Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-02-04
15:47:11 efried so that we can have one simple placement query for non-NUMA
15:47:39 sean-k-mooney yes although i think at some point we will want to have 1 code path
15:47:48 efried That's the 20
15:48:10 sean-k-mooney yes but it could also be a refinment of scope
15:48:20 efried a refinement of scope for Ussuri?
15:48:37 efried or adding restrictions in future releases?
15:48:46 sean-k-mooney no. if we say all vms are numa vms in the future we reduce fucntionality as we did with cpu pinning
15:48:49 sean-k-mooney but make this all simpler
15:49:14 sean-k-mooney efried: to model PCPUs in placment we reduced the funcatiolity of the thread policies
15:49:30 sean-k-mooney we could in a future relase consider the same here
15:49:42 stephenfin ralonsoh: One more question regarding this comment -> "The same patch also introduced an error when retrieving the network ID. The network ID is stored in a key named 'floating_network_id'"
15:50:05 sean-k-mooney every time we try to do that we end up makeing no progress at all
15:50:20 sean-k-mooney so im saying defer to V+ and take the incremental improvment in U
15:50:23 ralonsoh stephenfin, you don't have the network name, only the network ID in this key 'floating_network_id'"
15:51:12 stephenfin ralonsoh: Ah, so I don't think that's an issue since I'm building that field myself https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L2593-L2600
15:51:48 stephenfin ralonsoh: My question is would that make a good extension for neutron (adding 'network_details' to complement 'port_details')
15:52:09 ralonsoh stephenfin, ahhhhh ok. BTW, do you really need to make this call? This is expensive and the ID, IMO, is good enough
15:52:09 sean-k-mooney stephenfin: you should proably swap to using .get() for all those filed lookups by the way
15:52:17 stephenfin tbf, we only need that information for this one (deprecated) API, but maybe it would be useful for others
15:52:19 ralonsoh stephenfin, unless you specifically need the name
15:53:00 ralonsoh this could be an optimization, avoiding this "show_network" call
15:53:15 stephenfin ralonsoh: Unfortunately, yes. It's a deprecated API but we expect to return network names first
15:53:31 ralonsoh stephenfin, okidoki
15:53:44 stephenfin I could probably make it optional for this deprecated API. Let me investigate that
15:57:10 stephenfin ralonsoh: Wait, I lied. I've another question :) The 'alias' field will always be present in the 'GET /v2.0/extensions' response, right? https://docs.openstack.org/api-ref/network/v2/?expanded=list-extensions-detail#id5
15:57:37 ralonsoh stephenfin, let met check
15:58:15 stephenfin We're caching the extension name and I've no idea why, because the alias seems a lot better to use a reference constant https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L1254-L1255
16:05:36 ralonsoh stephenfin, sorry, I took my a while, this is not a regular DB call
16:05:59 ralonsoh stephenfin, the call returns a list of this
16:06:00 ralonsoh <class 'dict'>: {'name': 'Address scope', 'alias': 'address-scope', 'description': 'Address scopes extension.', 'updated': '2015-07-26T10:00:00-00:00', 'links': []}
16:06:11 ralonsoh (this is one element of the list)
16:06:22 stephenfin okay, so alias will always be there
16:06:30 stephenfin I'll rework that to use aliases so
16:06:35 stephenfin much clearer, IMO
16:06:36 ralonsoh yes and this is something static
16:06:46 ralonsoh sure, you can consider the alias as a constant
16:06:50 ralonsoh and it's in neutron-lib
16:06:57 stephenfin Bug fix done too. Just fixing up tests
16:20:39 huaqiang stephenfin: for the mixed vCPU instance spec https://review.opendev.org/#/c/668656/, do you have more comments?
16:20:58 huaqiang I know there is no concensus now
16:21:41 huaqiang should I raise a discussion in Thursday's team meeting?
16:21:49 huaqiang which way is better for you?
16:22:40 kashyap stephenfin: That rST thing on line-38 didn't work out, afraid; going to revert to using explicit references (https://review.opendev.org/#/c/693844/5/specs/ussuri/approved/allow-secure-boot-for-qemu-kvm-guests.rst)
16:41:26 huaqiang which way is better for you?
16:52:00 stephenfin huaqiang: Sorry, been working on a bug. I'll try look at that before the meeting but it would be good to bring up anyway
16:52:13 openstackgerrit Stephen Finucane proposed openstack/nova master: Handle neutron without the fip-port-details extension https://review.opendev.org/705760
16:52:15 stephenfin ralonsoh: ^
16:52:25 ralonsoh stephenfin, reviewing it
16:52:35 stephenfin efried, dansmith, bauzas: Apparently this is breaking neutron's gate so we should get this in once it's green
16:52:45 bauzas mmmm ok
16:52:52 stephenfin I ran/fixed a subset of tests that I though might break
16:52:57 stephenfin *thought
16:53:03 efried sounds like a review for gibi
16:53:13 stephenfin oh, how'd I forget gibi
16:54:13 gibi ack
16:54:28 gibi but in 5 minutes it is beertime here
16:54:50 stephenfin I bet you can get this done in 4 though
16:54:56 stephenfin ;)
16:54:56 efried heh
16:55:18 openstackgerrit Sasha Andonov proposed openstack/nova master: rbd_utils: increase _destroy_volume timeout https://review.opendev.org/705764
16:55:53 gibi working on it ...
16:58:41 gibi done.
16:58:44 gibi in 3
16:58:46 gibi :D
17:14:21 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844
17:35:05 gmann stephenfin: cmurphy melwitt alex_xu this is ready to re-review now. - https://review.opendev.org/#/c/701624/
17:35:29 cmurphy thanks gmann
17:38:00 openstackgerrit Stephen Finucane proposed openstack/nova master: Handle neutron without the fip-port-details extension https://review.opendev.org/705760
17:38:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Avoid calling neutron for N networks https://review.opendev.org/705784
17:38:03 stephenfin ralonsoh: ^
17:38:40 ralonsoh stephenfin, I'm on it now
18:09:43 openstackgerrit Vladyslav Drok proposed openstack/nova master: Minor improvements to cell commands https://review.opendev.org/698053
18:22:10 openstackgerrit Stephen Finucane proposed openstack/nova master: Use extension aliases, not names https://review.opendev.org/705792
18:34:32 gmann melwitt: this is ready from gate side to change your vote from +1 -> +2 - https://review.opendev.org/#/c/705135/4
18:35:10 gmann you can see the tests of other-projects-context working as expected in https://review.opendev.org/#/c/705126/7
18:49:35 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-attach-interfaces https://review.opendev.org/705799
20:24:59 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
21:38:06 openstackgerrit Michael Bayer proposed openstack/nova master: remove DISTINCT ON SQL instruction that does nothing on MySQL https://review.opendev.org/705850
22:07:01 gmann does anyone know way/hack to skip the deps installation while creating tox env
22:07:04 gmann this could have helpful for me to fix https://github.com/tox-dev/tox/issues/410
22:07:17 gmann stephenfin: ^^
22:42:50 openstackgerrit Merged openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154
22:48:15 efried gmann: Can't you just hack out the relevant lines of the tox.ini section?
22:48:32 efried or is this something you want to be able to do in a merged patch?
22:48:50 gmann efried: config value we can set via skip_install but i wanted to skip while we create tox at runtime
22:49:25 gmann on stable branch where i want to skip the master upper constraint dep hard coded in tempest.tox.ini master branch.
22:49:54 gmann anyways i did it via env var to use stable constraint - https://review.opendev.org/#/c/705089/4/lib/tempest@703
22:49:58 sean-k-mooney there is a hack where you can just touch i think the egg.info file locally or somehting
22:50:14 sean-k-mooney i know stephenfin had a way to work around it in the past
22:50:39 efried Yeah, I'm still confused as to whether you're talking about needing to do it locally or in "prod".
22:50:48 gmann ohk, that will be good to do instead of global env var at least for my local run on stable
22:51:35 gmann efried: locally as well as in stable branches jobs testing
22:52:52 sean-k-mooney im not sure if that will work in this case or not i just know he used to do something like that to skip instlaling deps
22:53:26 gmann at runtime ? and not via skip_install config value in tox.ini
22:54:02 gmann runtime i mean while running tox env not in tox.ini
22:55:14 sean-k-mooney yes i think he used to do touch <file> && tox -e ...
22:57:32 gmann ohk. if that happens before installing deps then that is something i am looking for.
23:06:23 efried dansmith: Sorry, I got started, but ran out of time. I'll try to get to that patch (cyborg request groups) early tomorrow.
23:07:34 efried I got to the point where I was starting to remember asking Sundar to make this look more like how we feed bandwidth requests into the RequestSpec, and this doesn't look like it's doing that (at least the way I expected). But I'll dig in more tomorrow.
23:13:17 dansmith efried: okay, well, glad I waited then but..yeah, would be good if we can get that feedback in the queue so he has some time to address it

Earlier   Later