| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-20 | |||
| 15:22:22 | kashyap | sean-k-mooney: ^ I reworded the commit message; and reworded the puropose more clearly. | |
| 15:22:42 | kashyap | sean-k-mooney: (And tweaked the driver.py; hop that looks OK.) | |
| 15:25:07 | sean-k-mooney | i would still delete the backgroud section to be honest. that should have beeen in the patch that chagne to use /dev/urandom by default not this chagne but i wont block on it | |
| 15:26:05 | sean-k-mooney | you could have just referencce the change id of that commit instead of providing the history again | |
| 15:30:29 | gibi | stephenfin: I have one question in https://review.opendev.org/#/c/697153/15/nova/network/neutron.py | |
| 15:37:06 | stephenfin | gibi: Replied (tl;dr: nothing has really changed, but we could probably improve it in a follow-up patch) | |
| 15:38:54 | gibi | stephenfin: ahh _setup_net_dict could raise a similar unhandled exception before. Then your change does not make it worse. thanks for the explanation | |
| 15:39:04 | stephenfin | yup, exactly | |
| 15:40:55 | gibi | stephenfin: do you have an estimate how much work still remains in the nova-net removal? | |
| 15:41:11 | stephenfin | gibi: I think the patches that are up there are it | |
| 15:41:43 | stephenfin | I'm sure I missed some stuff but that should have the bulk of the work (services, API, docs, tests) taken care of | |
| 15:41:44 | gibi | stephenfin: wow soo colse then I gather my brain and try to read through | |
| 15:41:59 | gibi | close | |
| 15:51:23 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: Block rebuild when NUMA topology changed https://review.opendev.org/702972 | |
| 15:51:23 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: Disable NUMATopologyFilter on rebuild https://review.opendev.org/702973 | |
| 15:51:24 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: FUP for in-place numa rebuild https://review.opendev.org/702974 | |
| 16:01:59 | gibi | stephenfin: thank you for your perseverance, it was an awesome job to remove all this logically dead code | |
| 16:22:47 | KeithMnemonic | elod: thank you for the review on https://review.opendev.org/#/c/683008/ any idea who else i can ask to get the "W"? | |
| 16:27:27 | elod | KeithMnemonic: no problem. well, I was a bit hesitant to give a +2+W, but decided to wait for other stable cores (list of stable cores: https://review.opendev.org/#/admin/groups/540,members ) | |
| 16:42:44 | KeithMnemonic | melwitt: can you please join the party here https://review.opendev.org/#/c/683008/ ;-) ? | |
| 16:43:22 | melwitt | KeithMnemonic: I can go through it later today. thanks for getting more people to review it, that helps | |
| 16:44:01 | KeithMnemonic | thank you and as i mentioned the customer with the issue confirmed those fixes correct the broken behavior | |
| 16:56:57 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Enhance service restart in functional env https://review.opendev.org/703103 | |
| 17:01:35 | kashyap | gibi: If you're looking a change of scenery, an "easy win", if I may say so myself :-) -- https://review.opendev.org/#/c/616603/ | |
| 17:02:01 | gibi | kashyap: I've saved it for tomorrow morning :) | |
| 17:02:26 | kashyap | gibi: Yep, it's EoD for us in CET anyway... | |
| 17:06:04 | gibi | yepp, I'm about to leave for today | |
| 17:31:56 | openstackgerrit | Ilya Etingof proposed openstack/nova master: Add JSON schema for network_data.json https://review.opendev.org/703133 | |
| 19:17:03 | openstackgerrit | Merged openstack/nova master: nova-net: Remove layer of indirection in 'nova.network' https://review.opendev.org/696745 | |
| 20:51:31 | openstackgerrit | Merged openstack/nova stable/stein: Remove global state from the FakeDriver https://review.opendev.org/703102 | |
| 20:51:43 | openstackgerrit | Merged openstack/nova stable/queens: Improve metadata server performance with large security groups https://review.opendev.org/697518 | |
| 21:02:47 | openstackgerrit | sean mooney proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed https://review.opendev.org/703116 | |
| 21:02:47 | openstackgerrit | sean mooney proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703117 | |
| 21:02:48 | openstackgerrit | sean mooney proposed openstack/nova stable/rocky: FUP for in-place numa rebuild https://review.opendev.org/703118 | |
| 21:29:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| 21:29:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | |
| #openstack-nova - 2020-01-21 | |||
| 02:50:24 | alex_xu | gibi: yea, I can be the liaison for that | |
| 02:51:05 | alex_xu | melwitt: i have few question for https://review.opendev.org/602201, still on the road to familar the spec | |
| 08:49:49 | gibi | alex_xu: thanks | |
| 09:51:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Stop setting Flavor.id https://review.opendev.org/703568 | |
| 09:51:01 | stephenfin | alex_xu, gibi, bauzas: Can you folks take a look at ^ since it's causing intermittent gate failures | |
| 09:54:35 | stephenfin | I also need someone to add me to nova-drivers again so I can triage bugs :/ | |
| 09:54:36 | stephenfin | https://launchpad.net/~nova-drivers | |
| 09:57:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | |
| 09:57:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| 09:59:16 | brinzhang | stephenfin: https://review.opendev.org/#/c/702790/ this I was fixed the functional test fails, and leave the failed reason, please review again, while you are free | |
| 10:00:24 | brinzhang | alex_xu: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ when you are free | |
| 10:00:43 | brinzhang | stephenfin, alex_xu: thanks :) | |
| 10:01:38 | stephenfin | brinzhang: Done. I want to get dansmith to hit that again when he's online | |
| 10:02:19 | brinzhang | stephenfin: yeah | |
| 10:03:35 | openstack | bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,In progress] https://launchpad.net/bugs/1663456 - Assigned to Brin Zhang (zhangbailin) | |
| 10:03:35 | brinzhang | dansmith: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ with bug 1663456 fix code, in your free time | |
| 10:04:57 | stephenfin | brinzhang: Does my comment on https://review.opendev.org/#/c/702790/ make sense? | |
| 10:05:45 | brinzhang | stephenfin: ack | |
| 10:09:05 | brinzhang | stephenfin: yeah, that's ture, your comment is makes sense. | |
| 10:23:37 | bauzas | stephenfin: sorry had some internal network issues since yesterday evening, but will add you | |
| 10:24:21 | bauzas | stephenfin: oh, actually it's the wrong team | |
| 10:24:43 | stephenfin | well, that would explain things :-D | |
| 10:25:25 | bauzas | stephenfin: you need to be in https://launchpad.net/~nova-bugs | |
| 10:26:57 | stephenfin | perfect. thanks | |
| 10:29:02 | bauzas | and +2 | |
| 10:29:22 | bauzas | stephenfin: but I said we should wait a little bit for the CI to return first | |
| 10:30:10 | stephenfin | Coolness | |
| 10:31:55 | kashyap | To those using Bash ... here's something useful (and fun): | |
| 10:32:11 | kashyap | To intelligently prepend an env. variable: | |
| 10:32:14 | kashyap | export LD_LIBRARY_PATH=/mypath${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} | |
| 10:32:25 | kashyap | [ Source: http://stackoverflow.com/a/9631350 ] | |
| 10:32:39 | kashyap | [And: https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Shell-Parameter-Expansion] | |
| 10:34:17 | kashyap | It's yet another obscure/magical-yet-useful combination of characters in Bash :D | |
| 11:27:01 | gibi | stephenfin: does the flavor ids in conflict within a test case or in between test cases running in the same test executor worker? | |
| 11:33:23 | stephenfin | gibi: It appears to be the latter, although I'm not sure if the DB fixture is supposed to prevent that or not | |
| 11:33:33 | stephenfin | i.e. if we tear down the DB after every test | |
| 11:33:53 | gibi | stephenfin: I think we should tear down the db after each step | |
| 11:34:10 | gibi | stephenfin: but there could be some global state that leaks | |
| 11:37:18 | gibi | stephenfin: your fix is still OK, I'm just wondering if we have a bigger problem somewhere deep | |
| 11:47:54 | stephenfin | gibi: I wonder where we'd start. Probably examine the SQLite DB after N tests | |
| 11:53:35 | gibi | yeah something like that | |
| 11:53:47 | gibi | but don't spend too much time on this | |
| 12:17:59 | openstackgerrit | sean mooney proposed openstack/nova master: Revert "Skip cpu comparison on AArch64" https://review.opendev.org/703596 | |
| 13:18:57 | sean-k-mooney | stephenfin: the db fixture should be createing and delete the sqlite db for each test | |
| 13:19:46 | sean-k-mooney | tox will execute the test in effectivly a random order so we cannot have an ordering depencies in how the tests are run so all the tests must use a clean copy | |
| 13:37:40 | stephenfin | sean-k-mooney: Yeah, that's what we're thinking. Just seems unlikely that you'd have a randint conflict in the scope of one test | |
| 13:37:49 | stephenfin | But I guess not | |
| 13:39:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for failed and aborted live migration https://review.opendev.org/699065 | |
| 13:41:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use common server create function for qos func tests https://review.opendev.org/701353 | |
| 13:41:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261 | |
| 13:45:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066 | |
| 14:11:55 | openstackgerrit | Alexandre arents proposed openstack/nova master: Avoid allocation leak when deleting instance stuck in BUILD https://review.opendev.org/702368 | |
| 14:56:00 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 14:56:09 | kashyap | gibi: Thanks for the review; hope the above looks better. | |
| 15:03:42 | efried_pto | stephenfin: I'm trying to find out who the admins of lp nova-drivers are... | |
| 15:04:48 | sean-k-mooney | its owned by openstack adminstrators | |
| 15:04:50 | sean-k-mooney | https://launchpad.net/~nova-drivers | |
| 15:05:12 | sean-k-mooney | efried_pto: https://launchpad.net/~nova-drivers/+members#active | |
| 15:05:25 | sean-k-mooney | but melwitt is an admin | |
| 15:05:35 | sean-k-mooney | so she can make you one if you need it | |
| 15:06:05 | efried | oh, why didn't I see that status column before? | |
| 15:06:27 | sean-k-mooney | the openstack amdinstartor group is https://launchpad.net/~openstack-admins/+members#active by the way | |
| 15:06:28 | efried | yeah, melwitt probably a good idea to give yourself a backup who's actually still on the core team. | |
| 15:06:35 | sean-k-mooney | in case you need them to change something | |