Earlier  
Posted Nick Remark
#openstack-nova - 2020-01-17
18:08:59 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.ironic' https://review.opendev.org/703152
18:08:59 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.xenapi' https://review.opendev.org/703151
18:09:00 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.cmd', 'nova.console', 'nova.db' https://review.opendev.org/703154
18:09:00 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve final issues with 'nova.virt' https://review.opendev.org/703153
18:23:28 efried <poke>
18:23:28 efried stephenfin: came across this: https://review.opendev.org/#/c/688603/
21:22:40 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
21:22:42 openstack bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms)
21:22:42 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404
22:31:49 gibi efried, dustinc|PTO : I've finished reviewing the provider config series.
22:32:34 gibi now I might dream about jsonschema in yaml files :D
#openstack-nova - 2020-01-18
17:55:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: experiment with ProviderConfig https://review.opendev.org/703249
#openstack-nova - 2020-01-19
01:26:35 openstackgerrit Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271
01:27:42 openstackgerrit Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790
02:26:56 gmann efried: stephenfin live migration job is still not happy after merging the devstack fix. I see consistent error - "Image is not raw format" added traceback and log in bug.
02:28:14 gmann This was occurring on nova test patch also.
02:38:25 openstack bug 1860021 in OpenStack Compute (nova) "nova-live-migration fails 100% with "mysql: command not found" on subnode" [Critical,New] https://launchpad.net/bugs/1860021
02:38:25 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Test fix for bug 1860021 https://review.opendev.org/702961
03:02:32 openstackgerrit Alex Xu proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656
03:38:01 openstackgerrit Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271
04:29:04 openstackgerrit Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271
06:59:50 openstackgerrit Alex Xu proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656
07:16:56 openstackgerrit Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790
08:56:44 openstackgerrit Alex Xu proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656
14:26:24 gmann efried: gate is green now.
14:35:01 gmann efried: nova-next is failing on multiple network now. approved this - https://review.opendev.org/#/c/702553/3
14:42:06 yoctozepto gmann: never green enough, huh? :D
14:44:17 gmann nova-next failure is due to race, one more patch to merge.
14:46:21 yoctozepto yeah, looks like it, high chance of failure
15:09:07 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.vmwareapi' https://review.opendev.org/703148
15:09:07 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.libvirt' https://review.opendev.org/703147
15:09:08 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.powervm' https://review.opendev.org/703150
15:09:08 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.hyperv' https://review.opendev.org/703149
15:09:09 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve final issues with 'nova.virt' https://review.opendev.org/703153
15:09:09 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.xenapi' https://review.opendev.org/703151
15:09:10 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.cmd', 'nova.console', 'nova.db' https://review.opendev.org/703154
19:58:21 openstackgerrit Merged openstack/nova master: Remove dict compat from populate_filter_properties https://review.opendev.org/697669
23:19:00 openstackgerrit Merged openstack/nova master: Add NovaEphemeralObject class for non-persistent objects https://review.opendev.org/702049
23:19:05 openstackgerrit Merged openstack/nova stable/pike: Error out interrupted builds https://review.opendev.org/687918
#openstack-nova - 2020-01-20
02:46:27 openstackgerrit Merged openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_FILE_BACKED_VERSION https://review.opendev.org/695942
08:44:55 openstackgerrit Lee Yarwood proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291
08:54:10 lyarwood sean-k-mooney: ack, will do.
08:55:09 lyarwood stephenfin: https://review.opendev.org/699291 - assuming this now passes CI can you +W again, I rebased by mistake.
09:12:01 shilpasd dansmith: hi, i want your opinion on my comment added https://review.opendev.org/#/c/694462/8/nova/db/sqlalchemy/api.py@2008
09:12:22 shilpasd dansmith: would like to hear from you on this
11:42:42 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: [OVS] VLAN tag should be set in the Port register https://review.opendev.org/703373
11:49:25 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.hyperv' https://review.opendev.org/703149
11:49:25 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.vmwareapi' https://review.opendev.org/703148
11:49:26 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.xenapi' https://review.opendev.org/703151
11:49:26 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.powervm' https://review.opendev.org/703150
11:49:27 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.cmd', 'nova.console', 'nova.db' https://review.opendev.org/703154
11:49:27 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve final issues with 'nova.virt' https://review.opendev.org/703153
12:21:49 openstackgerrit Ilya Etingof proposed openstack/nova master: Add JSON schema for network_data.json https://review.opendev.org/703133
12:38:25 openstackgerrit Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790
12:41:08 brinzhang__ stephenfin: hi, adding metadata to the creating aggregate, it does not populate the aggregate's 'updated_at' field, that's why the functional tests failed
12:41:49 brinzhang__ stephenfin: please review the latest patch https://review.opendev.org/#/c/702790/5/nova/objects/aggregate.py@191, thanks
12:42:11 openstackgerrit Merged openstack/nova master: functional: Add unified '_build_server' helper function https://review.opendev.org/697537
12:42:18 openstackgerrit Merged openstack/nova master: functional: Add unified '_(build|create)_flavor' helper functions https://review.opendev.org/697538
12:42:24 openstackgerrit Merged openstack/nova master: functional: Add '_delete_server' to 'InstanceHelperMixin' https://review.opendev.org/697539
13:39:04 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261
13:40:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use common server create function for qos func tests https://review.opendev.org/701353
13:42:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066
13:44:04 openstackgerrit Merged openstack/nova master: Make removal of host from aggregate consistent https://review.opendev.org/696392
13:45:54 gibi alex_xu: would you like to be a liaison for the api change https://review.opendev.org/#/c/701763 ?
13:46:30 gibi dansmith: replied in https://review.opendev.org/#/c/702261/
13:47:57 stephenfin gibi: Care to hit this now that others have looked at it? https://review.opendev.org/#/c/696745/
13:49:09 openstackgerrit Merged openstack/nova master: Set instance CPU policy to 'share' through image property https://review.opendev.org/688603
13:50:10 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Set instance CPU policy to 'share' through image property https://review.opendev.org/703393
13:51:06 gibi stephenfin: looking
14:08:22 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603
14:08:33 kashyap stephenfin: When you get a moment --^ does that look better?
14:09:57 kashyap stephenfin: Quick change-log: (a) we should keep the both extra spec properties (see comments); (b) modified the driver function to make (correct) use of the extra spec props; (c) added a rel-note for change in semantics
14:10:05 kashyap stephenfin: Thanks for the earlier review. That was useful
14:16:45 gibi stephenfin: +A, thanks
14:16:49 brinzhang__ gibi: https://review.opendev.org/#/c/701763/2 I leave some comment on
14:16:53 stephenfin gibi: Thanks
14:16:56 stephenfin kashyap: Will do
14:17:04 gibi brinzhang__: ack
14:20:09 gibi brinzhang__: replied
14:24:33 brinzhang__ Yeah, I think "rule:project_reader_api" role is good to me
14:24:42 brinzhang__ gibi
14:25:44 brinzhang__ gmann: are you around?
14:28:35 gmann stephenfin: one question on hacking cap - https://review.opendev.org/#/c/695733/4/test-requirements.txt@5
14:28:44 brinzhang__ gmann: 'rule:project_reader_api' and 'rule:project_member_api' which different from 'rule:system_admin_or_owner' and 'rule:system_or_project_reader'? I am not sure
14:29:14 gmann brinzhang__: did not get completely.
14:30:09 brinzhang__ gmann: which scope?
14:30:11 stephenfin gmann: Makes sense. Will submit a follow-up
14:30:24 gmann brinzhang__: 'system_*' rules are with system level scope and project only rules are project scopped.
14:30:29 gmann stephenfin: +1 thanks
14:30:56 gmann brinzhang__: 'rule:system_admin_or_owner' and 'rule:system_or_project_reader' are [system, project] both scoped.
14:33:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add '_create_server' helper https://review.opendev.org/697540
14:33:42 brinzhang__ gmann: other words, if we are *system_* role, we can get all projects resource. and if we are *project_* role, we just can get his own project's resource, right?
14:34:46 gmann brinzhang__: right.
14:35:10 brinzhang__ gmann: Thanks :)
14:35:57 gmann in addition to that, new default roles also considered like reader etc. so admin can get member,reader but not vice versa (on both scope case)
14:36:22 brinzhang__ gibi: so filter instances by az, I think use "rule:project_reader_api" is ok, what do you think?
14:37:04 openstackgerrit Stephen Finucane proposed openstack/nova master: requirements: Limit hacking to one minor version https://review.opendev.org/703405
14:37:46 brinzhang__ gmann: yeah, I reviewed your docs of this :P
14:38:28 stephenfin gmann: ^
14:38:53 gibi brinzhang__: based on you discussion with gmann it looks OK to me

Earlier   Later