| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-16 | |||
| 08:26:28 | openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | |
| 08:47:05 | gibi | dansmith: hi! stephenfin would like you to look at one of the qos patch https://review.opendev.org/#/c/702261/ and if you are there already the rest is also ready for review | |
| 09:14:47 | openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | |
| 09:22:14 | stephenfin | efried: Probably would have waited til https://review.opendev.org/#/c/702440/ was merged to mark that BP as complete, personally - I'd like to get the whole thing closed out | |
| 09:22:26 | stephenfin | but hey, the hardest work is done | |
| 09:31:26 | openstackgerrit | Riccardo Pittau proposed openstack/nova master: Fix typos for update_available_resource reference https://review.opendev.org/702602 | |
| 09:39:42 | stephenfin | yo, sean-k-mooney, looks like you added https://github.com/openstack/nova/blob/b44b540fc70504f3869ef23022642095de0ea99e/nova/virt/libvirt/vif.py#L299-L301 | |
| 09:41:41 | stephenfin | sean-k-mooney: but that function has existed since it was removed in commit 92323586b5d03b31c18657ad64646a8ce3b8a742 | |
| 09:42:02 | stephenfin | sean-k-mooney: so that means that code is not being called by anything yet. In either case, want to work on the fix or will I? | |
| 09:42:40 | stephenfin | sean-k-mooney: fwiw, I'm running pytype over the code base to see what it reveals. That's one of two actual issues it has found so far | |
| 09:42:51 | openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Enable REST quiescing https://review.opendev.org/702810 | |
| 10:00:46 | kashyap | stephenfin: Hey, any clue how to resolve this "duplicate label" thing?: | |
| 10:00:54 | kashyap | /home/zuul/src/opendev.org/openstack/nova-specs/doc/source/specs/ussuri/approved/allow-secure-boot-for-qemu-kvm-guests.rst:72:duplicate label proposed change, other instance in /home/zuul/src/opendev.org/openstack/nova-specs/doc/source/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst | |
| 10:00:54 | kashyap | Warning, treated as error: | |
| 10:01:00 | kashyap | --- | |
| 10:04:03 | stephenfin | kashyap: Use anonymous labels instead | |
| 10:04:10 | stephenfin | `foo`__ | |
| 10:04:17 | stephenfin | __ https://example.com/ | |
| 10:04:33 | stephenfin | (double underscore) | |
| 10:04:38 | kashyap | stephenfin: Ah-ha! you, sir, are the Main Man! | |
| 10:07:19 | kashyap | Okay, good to know: "... However, this feature [Anonymous Hyperlinks] is easily abused and can result in unreadable plaintext and/or unmaintainable documents. Caution is advised." | |
| 10:08:58 | kashyap | stephenfin: Oh, wait -- | |
| 10:09:11 | kashyap | stephenfin: I see that anonymous labels are only for URLs | |
| 10:09:23 | kashyap | stephenfin: I'm trying to refer to a section in the _same_ document; thus no URL here | |
| 10:11:46 | kashyap | Here is a small concrete example: http://paste.openstack.org/show/788455/ | |
| 10:20:27 | kashyap | Okay, that works. | |
| 10:20:52 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844 | |
| 12:29:07 | openstackgerrit | waleed mousa proposed openstack/os-vif master: Add delete_netdev field in VIFPortProfileOpenVSwitch profile https://review.opendev.org/702857 | |
| 12:38:15 | openstackgerrit | waleed mousa proposed openstack/os-vif master: Add delete_netdev field in VIFPortProfileOpenVSwitch profile https://review.opendev.org/702857 | |
| 12:53:25 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844 | |
| 13:00:31 | openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | |
| 13:36:43 | efried | stephenfin: I'm confused. Is https://review.opendev.org/#/c/702440/ related to mox somehow? | |
| 13:36:51 | efried | I marked the mox blueprint complete, not the nova-net one. | |
| 13:37:02 | efried | ...at least that's what I meant to do... | |
| 13:38:02 | efried | lyarwood: I don't think you missed anything; that other trait merged later. I just wanted to pick it up in the same release since the timing worked out. | |
| 13:54:43 | efried | stephenfin: tidy docs patch for the ironic virt driver, should be an easy +A for you: https://review.opendev.org/#/c/701998/ (Note that more is possible, but the information there is accurate afaict and it has nod from ironic cores) | |
| 14:08:38 | iurygregory | efried, thanks for the +2 =) | |
| 14:09:05 | efried | iurygregory: yahyoubetcha. Appreciate the patch. | |
| 14:09:54 | iurygregory | \o/ | |
| 14:14:57 | efried | dansmith: I started to look at https://review.opendev.org/#/c/580271/ and successor and they seem fine, but I don't have the confidence to approve. Would you please cast your discerning eye? Should be an easy +A for you, if it's right. | |
| 14:25:07 | dansmith | efried: so I've always been told we shouldn't mess with those fields from python land, so I'm not confident to +W that either | |
| 14:25:25 | dansmith | I would think we'd want someone from oslo db land to say they're comfortable with them | |
| 14:25:25 | efried | glad I asked | |
| 14:25:48 | dansmith | maybe stephenfin has already consulted the expert or is an expert himself since he's already +2? | |
| 14:26:27 | stephenfin | I was expecting SQLA to handle those fields for us, tbh, but I couldn't find anything that suggested it would | |
| 14:28:07 | stephenfin | I didn't think about looking in oslo.db though /o\ /me goes to investigate | |
| 14:30:43 | dansmith | the update *is* handled by SQLA fwiw | |
| 14:30:49 | sean-k-mooney | dansmith: efried it looks like there are some issues with the arq binding on the cyborg side http://paste.openstack.org/show/788470/ | |
| 14:31:18 | stephenfin | Yup, have spotted the use of 'TimestampMixin' in NovaBase | |
| 14:32:05 | efried | gibi: I'd like to queue up some review time from you for the provider config file bp if possible please. It's pretty straightforward stuff, kind of fun to look at IMO. It's very close to ready, if you want to preview: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/provider-config-file | |
| 14:32:30 | gibi | efried: ack, tomorrow I can start the day with that | |
| 14:32:35 | efried | great, thank you. | |
| 14:32:50 | dansmith | sean-k-mooney: ack | |
| 14:33:31 | belmoreira | Hi, we are hitting https://review.opendev.org/#/c/684375/3 can we get an agreement on how to proceed? kashyap stephenfin | |
| 14:33:49 | efried | sean-k-mooney: are other nova api comms working in that env? Could it just be a creds-in-config thing? | |
| 14:34:09 | sean-k-mooney | ill try booting a normal vm | |
| 14:34:17 | sean-k-mooney | that shoudl trigger the neutron events | |
| 14:35:51 | sean-k-mooney | ya that booted fine | |
| 14:35:52 | efried | sean-k-mooney: point would be cyborg.conf's creds to [nova] | |
| 14:35:55 | sean-k-mooney | so it could be | |
| 14:36:22 | sean-k-mooney | nova] | |
| 14:36:24 | sean-k-mooney | project_domain_name = Default | |
| 14:36:26 | sean-k-mooney | project_name = service | |
| 14:36:28 | sean-k-mooney | user_domain_name = Default | |
| 14:36:30 | sean-k-mooney | password = password | |
| 14:36:32 | sean-k-mooney | username = nova | |
| 14:36:34 | sean-k-mooney | auth_url = http://192.168.135.77/identity | |
| 14:36:36 | sean-k-mooney | auth_type = password | |
| 14:36:38 | sean-k-mooney | that looks fine to me | |
| 14:37:30 | sean-k-mooney | well fine for devstack | |
| 14:37:32 | stephenfin | belmoreira: Should have been more exact about that. I'm not happy with changing the default for everyone to work around a temporary blip with a buggy kernel (which is what that appears to be) | |
| 14:38:34 | sean-k-mooney | we should not proceed with that patch unless we really really reallly have too | |
| 14:38:49 | stephenfin | sean-k-mooney: are you referring to the hugepages one or something else? | |
| 14:39:10 | efried | stephenfin: would you be okay if we implemented the [workaround] opt as suggested? | |
| 14:39:13 | sean-k-mooney | the mempages mode=preferred change | |
| 14:40:07 | stephenfin | efried: That depends on when the bug was introduced and when it was fixed. Latter seems to be 4.19 but kashyap's notes don't appear to capture the former | |
| 14:40:19 | belmoreira | sean-k-mooney what's your main concern? | |
| 14:40:51 | stephenfin | not sean-k-mooney but I'm going to guess potentially huge performance penalties if you haven't correctly configured your host | |
| 14:42:20 | sean-k-mooney | so i originally suggested perfered to kashyap as a potentil solution but im more conserned about non hugepage guest that use hw:numa_nodes=* | |
| 14:42:34 | kashyap | belmoreira: Hi | |
| 14:42:45 | sean-k-mooney | for hugepage we pin the pages seperately so they will be allocated form the numa node we expect | |
| 14:43:29 | sean-k-mooney | however setting perfered by default means we can be sure that the memory of a gues that has a numa doploty but is not backed by hugepage will come form the numa node we expect | |
| 14:43:58 | sean-k-mooney | which will cause issue if we ever model numa in placment | |
| 14:45:01 | sean-k-mooney | i suspect that most of the time it would likely be fine but im not sure what all the sideeffect will be | |
| 14:45:17 | sean-k-mooney | belmoreira: have you tested the patch and conrimed that it fixes the issue? | |
| 14:45:41 | sean-k-mooney | belmoreira: we were not able to get our customer to do that and we did not have a plathform where we could repoduce the issue | |
| 14:45:59 | sean-k-mooney | belmoreira: so we dont acatully know that will fix it although we suspect it will | |
| 14:46:08 | kashyap | stephenfin: I don't know when exactly it was introduced; I need to do kernel commit message digging (if it's not there, then worse, do bisection myself or ask a KVM dev) | |
| 14:47:10 | sean-k-mooney | stephenfin: belmoreira i would be more ok with his as a workaround config option and keeping the default to strict with the expection we might remvoe it in the future. | |
| 14:48:07 | kashyap | stephenfin: On forcing distros to backport — normally, that would be my approach such kernel cases. But here, we need to bear in mind all the existing OpenStack deployments in the wild. | |
| 14:49:28 | sean-k-mooney | i think this issue is only going to show up on centos/rhel maybe suse | |
| 14:49:56 | kashyap | sean-k-mooney: I think they'd be the distros that are most likely to _backport_ those | |
| 14:50:06 | sean-k-mooney | if you are using the hwe kernel on ubunutu 18.04 you will be on 5.x | |
| 14:50:12 | kashyap | Right | |
| 14:50:55 | sean-k-mooney | i supose if you stuck with the orginal ubuntu 18.04 kernel that was 4.15 | |
| 14:52:06 | kashyap | belmoreira: I take it that rebooting the host kernel is not an option in your deployments? | |
| 14:52:27 | sean-k-mooney | belmoreira: o i see you noted that the patch did solve the problem | |
| 14:52:53 | kashyap | Yeah, he tested it | |
| 14:53:33 | kashyap | sean-k-mooney: And in general, 'preferred' is what we recommend _anyway_, no? | |
| 14:53:57 | sean-k-mooney | no | |