| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-10 | |||
| 18:23:28 | sean-k-mooney | dansmith: we should be construciton the os-vif objects from nova ones but neither should contain the other. and the should in theory be in there own namespace but maybe that is not done correctly | |
| 18:24:49 | dansmith | yeah the namespace stuff was added way late when we were spinning things out | |
| 18:24:58 | dansmith | it's working right now, there's just a wrinkle in this test | |
| 18:25:16 | dansmith | so I will work around that and then revisit the bigger picture, but yeah I think os-vif is doing the right thing now that I look | |
| 18:26:18 | sean-k-mooney | this is where we set the os-vif namespace by the way https://github.com/openstack/os-vif/blob/master/os_vif/objects/base.py#L18 | |
| 18:26:58 | dansmith | yep, I dug in | |
| 18:29:05 | dansmith | btw, when are we going to switch the functional tox target to be py37 by default? I hate having to type out functional-py37 each time | |
| 18:29:28 | sean-k-mooney | in nova you mean | |
| 18:29:42 | sean-k-mooney | we could do that now i guess | |
| 18:29:43 | dansmith | yes | |
| 18:29:46 | sean-k-mooney | its after m1 | |
| 18:30:33 | sean-k-mooney | dansmith: it looks like its already python3 | |
| 18:30:54 | sean-k-mooney | so tox -e functional will use your default system python 3 | |
| 18:30:57 | dansmith | is it? why do we have functional-py37 then? | |
| 18:31:03 | sean-k-mooney | that is proably 3.6 | |
| 18:31:28 | sean-k-mooney | well functional-py37 will be expressly 3.7 regardless of your system default | |
| 18:31:41 | dansmith | last I checked, which has been a while, functional would use whatever env says "python" resolves to, which is 2.7 for me | |
| 18:31:49 | sean-k-mooney | the fucntioal target is inheriting basepython = python3 | |
| 18:32:04 | dansmith | ah okay | |
| 18:32:18 | dansmith | hmm, from 2018 | |
| 18:32:21 | sean-k-mooney | os ya it will use whatever python3 point too | |
| 18:33:04 | sean-k-mooney | am no form https://github.com/openstack/nova/commit/14872caae1a51c7015dd7c509d0173df2e943ed4 | |
| 18:33:32 | sean-k-mooney | it had python 2.7 explcitly before https://github.com/openstack/nova/commit/14872caae1a51c7015dd7c509d0173df2e943ed4#diff-b91f3d5bd63fcd17221b267e851608e8L69 | |
| 18:33:50 | dansmith | oh good good, that explains it | |
| 18:34:34 | sean-k-mooney | i still kind of want to add a "unit" env so we can do the same thing with the unit tests | |
| 18:34:59 | sean-k-mooney | i.e. just run them with any python 3 and tell me if they pass | |
| 18:35:11 | dansmith | yeah that would be nice | |
| 18:35:32 | dansmith | hitting p-y-[2-3] is actually fairly error-prone for me | |
| 18:37:19 | sean-k-mooney | i use crtl-r to seach my history way to much but ya i dont mind it too much but it can be annoying at times | |
| 18:37:47 | dansmith | yeah, but c-r tox doesn't work always, and otherwise I have to type the py37 bit anyway | |
| 18:37:49 | sean-k-mooney | my most common mistate is ttyring to change form 27 to 36 and ending up with 26 | |
| 18:38:27 | dansmith | sean-k-mooney: no, your most common mistake is any english word ever, but I'll concede that py26 is probably in the list somewhere too :P | |
| 18:38:52 | sean-k-mooney | hehe :) ya i noticed that after i hit enter. | |
| 18:38:55 | dansmith | heh | |
| 18:39:33 | sean-k-mooney | i need to like bind enter to spell check and shift enter to send or somehting | |
| 18:40:16 | dansmith | pre-send hook requiring aspell==0 | |
| 18:40:46 | dansmith | pretty sure we'd never hear from you again though | |
| 18:40:54 | sean-k-mooney | actully i need to resinstall aspell i had it integreated but i broke it a while a go | |
| 18:41:55 | sean-k-mooney | anyway im going to try restacking with the latest cyborg change so ill be back in a while when that is done. im currently trying to test with the fake driver | |
| 18:42:06 | dansmith | scweet | |
| 18:42:12 | dansmith | er, schweet | |
| 19:29:27 | artom | yeah is pell liek a tads now | |
| 22:09:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects https://review.opendev.org/702049 | |
| 22:10:55 | efried | \o/ | |
| 22:14:14 | dansmith | oops, | |
| 22:14:19 | dansmith | I forgot to clean up your requestgroup thing | |
| 22:14:30 | dansmith | but, pretend this is you: https://review.opendev.org/#/c/702049/1/nova/objects/diagnostics.py | |
| 22:25:28 | openstackgerrit | Dan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects https://review.opendev.org/702049 | |
| 22:33:04 | mriedem | ooo did i provide the mixin idea? | |
| 22:33:49 | mriedem | f yeah i did https://review.opendev.org/#/c/699050/5/nova/objects/request_spec.py@1231 | |
| 22:41:29 | dansmith | mriedem: about 24 hours late :) | |
| 22:44:50 | mriedem | i'm going to say there was some precog stuff at work here | |
| 22:44:55 | mriedem | in order to still take credit | |
| 22:45:05 | dansmith | hmm, okay :) | |
| 23:27:12 | openstackgerrit | Merged openstack/nova master: Fix typos in nova doc https://review.opendev.org/701876 | |
| 23:29:22 | sean-k-mooney | dansmith: ill take a look at that patch a little more in deail but i left a comment for you on the pci_device __init__ | |
| #openstack-nova - 2020-01-11 | |||
| 00:48:29 | openstackgerrit | Merged openstack/nova stable/queens: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/700359 | |
| 00:50:21 | openstackgerrit | Luigi Toscano proposed openstack/nova stable/pike: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/702061 | |
| 03:58:27 | openstackgerrit | Brin Zhang proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info https://review.opendev.org/580271 | |
| 06:43:02 | openstackgerrit | Brin Zhang proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info https://review.opendev.org/580271 | |
| 09:52:35 | openstackgerrit | Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271 | |
| 10:23:05 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Populate 'updated_at' when aggregate metadata is updated https://review.opendev.org/702070 | |
| 14:24:46 | openstackgerrit | Victor Coutellier proposed openstack/nova master: Non-admin user can filter their instances by AZs https://review.opendev.org/701609 | |
| 14:37:21 | openstackgerrit | Victor Coutellier proposed openstack/nova-specs master: Non-admin user can filter their instances by AZs https://review.opendev.org/701763 | |
| 16:18:58 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: DNM Test https://review.opendev.org/#/c/702089/ on stable/rocky https://review.opendev.org/702090 | |
| #openstack-nova - 2020-01-13 | |||
| 03:09:56 | openstackgerrit | Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271 | |
| 05:12:05 | alex_xu | efried: sean-k-mooney, if we only support placement-ese, then we will get mixing case like, user specified the cpu_policy=dedicated or shared, also specified PCPU and VCPU in resources. | |
| 05:18:43 | alex_xu | efried: sean-k-mooney, huaqiang reminder me, we currently refuse both cpu_policy and PCPU/VPCU are specified, so it should be ok | |
| 05:19:47 | alex_xu | efried: sean-k-mooney i'm ok with that algo, I guess that algo will be done at API layer,not the virt layer. | |
| 05:51:10 | alex_xu | efried: sean-k-mooney and if the user specified PCPU and VCPU in resources, then the value of InstanceNUMACell.cpu_policy will be 'dedicated'. then we didn't introduce new policy 'mixed' anymore, does sounds make sense to you? | |
| 06:39:33 | openstackgerrit | Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271 | |
| 09:55:02 | openstackgerrit | Liang Fang proposed openstack/nova-specs master: Support volume local cache https://review.opendev.org/689070 | |
| 10:04:35 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Mask the token used to allow access to consoles https://review.opendev.org/702181 | |
| 10:25:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use EphemeralObject for non DB versioned objects https://review.opendev.org/702184 | |
| 12:41:46 | brinzhang_ | Hi all, https://review.opendev.org/#/c/580271/ this patch I was resolved the functional test and python test, but there are some errors I donot know why. | |
| 12:41:59 | brinzhang_ | is there need some dependency packges? | |
| 12:43:28 | brinzhang_ | any professional python expert can give some guide? thanks ^^ | |
| 12:44:37 | lyarwood | brinzhang_: https://storyboard.openstack.org/#!/story/2007084 | |
| 12:50:26 | lyarwood | brinzhang: I'm not sure if you saw this, https://storyboard.openstack.org/#!/story/2007084 | http://lists.openstack.org/pipermail/openstack-discuss/2020-January/011956.html | |
| 12:51:53 | brinzhang | lyarwood: Oh no, see it by your send | |
| 13:25:05 | brinzhang_ | gibi: hi, I am not very clear what did you mean, can you give me more details about this https://review.opendev.org/#/c/699669/2/specs/ussuri/approved/action-event-fault-details.rst@128 | |
| 13:25:08 | brinzhang_ | gibi: thanks :) | |
| 14:05:10 | efried | alex_xu: I don't fully have in my head all the combinations that would or would not make sense. | |
| 14:05:13 | efried | But somebody should | |
| 14:05:19 | efried | And then block the ones that don't make sense. | |
| 14:05:35 | efried | I don't know if cpu_policy=$anything makes sense in the mixed CPU case, because you're dedicating some and sharing some. | |
| 14:05:42 | efried | So perhaps those should be mutually exclusive. | |
| 14:06:07 | efried | but that ^ kind of decision just needs to be made, in a way that makes sense, for all the relevant options. | |
| 14:06:30 | efried | ...by someone who knows what makes sense, which ain't me :P | |
| 14:07:43 | efried | But tl;dr we're not going to freak out about combining placement-ese and other syntaxes, because dansmith beat me down. I'm now a husk of my former self. | |
| 14:40:09 | gibi | brinzhang_: extended my comment in https://review.opendev.org/#/c/699669/2/specs/ussuri/approved/action-event-fault-details.rst@128 | |
| 14:45:48 | sean-k-mooney | efried: we were going to use an expcitly cpu_policy=mixed for mixed cpus if you dont set that you cant use the feature | |
| 14:46:45 | efried | 'mixed' is a new value? | |
| 14:46:56 | sean-k-mooney | yes | |
| 14:47:00 | efried | And why do we need it? | |
| 14:47:12 | efried | Is cpu_policy a required field otherwise? | |
| 14:47:28 | sean-k-mooney | it how you enable pinning | |
| 14:47:30 | efried | I would expect we could infer 'mixed' based on the fact you specified both vcpu and pcpu | |
| 14:47:38 | sean-k-mooney | and it need to be set for realtime | |
| 14:47:52 | sean-k-mooney | and we do not want to use cpu_policy=dedicated with mixed cpus | |