| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-10 | |||
| 16:18:22 | dansmith | efried: I don't want to be the sole recipient of the told-you-so | |
| 16:18:43 | dansmith | if I'm the only one that prefers that method, then of course it doesn't make sense to go down a path everyone else doesn't want | |
| 16:19:04 | efried | I think it's just you & me in the cage dansmith. | |
| 16:19:06 | dansmith | it makes me sad, but I'm sad about a lot of things | |
| 16:19:40 | efried | As usual, you're probably right and I'm probably wrong anyway. | |
| 16:21:41 | dansmith | no, I'm sure you're right | |
| 16:29:43 | openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | |
| 16:51:42 | sean-k-mooney | well im not a fan of the group sysntax in the flavor or a direct mapping form flavor resource requets to placement query | |
| 16:52:00 | sean-k-mooney | so i do like the hw:* extra spec for that reason | |
| 16:52:31 | sean-k-mooney | but if you just use the unnumbered groups in the flavor and hw:* for tweeking then i could buy that | |
| 16:52:42 | sean-k-mooney | i think think there is a midel ground | |
| 16:56:13 | dansmith | efried: https://pastebin.com/zbHra4rr | |
| 16:57:09 | dansmith | service is the outlier there. we break the rules specifically because version should *always* be overridden always | |
| 16:57:27 | dansmith | so I'll have to figure out some way to copiously document why that is the case, if not already | |
| 17:12:03 | efried | dansmith: Am I looking at the result of the test that we talked about yesterday? | |
| 17:12:36 | efried | So after asserting that we should never ever overwrite the table cell, we found an example where we have to overwrite the table cell? | |
| 17:12:38 | dansmith | yeah, just fyi, that's the list of objects that do naughty things | |
| 17:13:42 | dansmith | service version is kinda special in that regard.. we want to overwrite it always and forever, kinda like how updated_at is always set outside of your control | |
| 17:14:31 | efried | yeah, updated_at was the example that came to mind yesterday, but I figured that was handled specially somehow. | |
| 17:14:45 | dansmith | it is handled below the object layer | |
| 17:15:10 | dansmith | since service version is *implemented* at the object layer it can't be done in the db layer | |
| 17:15:19 | efried | makes sense. | |
| 17:17:13 | dansmith | efried: hah, past me was on it: https://github.com/openstack/nova/blob/b0cae0750c3d9f9ebac33ee38cc1762fdd7fc138/nova/objects/service.py#L231-L235 | |
| 17:17:28 | sean-k-mooney | why am di not surprised that the numa and pci objects are on that list | |
| 17:17:40 | dansmith | sean-k-mooney: yeah they're *awful* unfortunately | |
| 17:17:55 | dansmith | sean-k-mooney: would really appreciate you reviewing this patch to see if I'm breaking anything by making the changes I'm making | |
| 17:17:58 | dansmith | when I post it that is | |
| 17:18:25 | sean-k-mooney | i was just going to ask which patch but sure add me to it and ill take a look | |
| 17:26:33 | dansmith | efried: Sundar: FYI, since I haven't seen much activity lately: I'm off in the wilderness week after next, completely unreachable most of the time | |
| 18:01:35 | dansmith | sean-k-mooney: hrm | |
| 18:02:36 | dansmith | looks like an os-vif object is leaking into nova's namespace | |
| 18:04:25 | dansmith | not sure how that's happening | |
| 18:05:58 | dansmith | ooh | |
| 18:06:23 | dansmith | I wonder if it's because you have a "Network" object and we do too, and get_nova_objects() is only checking the first in the list | |
| 18:09:38 | sean-k-mooney | maybe | |
| 18:10:23 | dansmith | but the repository is mixing the two, which seems, like bad.. but gawd I don't even want to think about that right now | |
| 18:20:33 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove VIR_DOMAIN_BLOCK_REBASE_RELATIVE check https://review.opendev.org/702021 | |
| 18:22:03 | sean-k-mooney | dansmith: sorry was on a call | |
| 18:22:25 | sean-k-mooney | am can you point me in the right direction and i can try an figure out how this is happenign. | |
| 18:23:09 | dansmith | I was thinking it was something in os-vif but now I don't think it is | |
| 18:23:16 | dansmith | so it'd be something for me to resolve if anything | |
| 18:23:28 | sean-k-mooney | dansmith: we should be construciton the os-vif objects from nova ones but neither should contain the other. and the should in theory be in there own namespace but maybe that is not done correctly | |
| 18:24:49 | dansmith | yeah the namespace stuff was added way late when we were spinning things out | |
| 18:24:58 | dansmith | it's working right now, there's just a wrinkle in this test | |
| 18:25:16 | dansmith | so I will work around that and then revisit the bigger picture, but yeah I think os-vif is doing the right thing now that I look | |
| 18:26:18 | sean-k-mooney | this is where we set the os-vif namespace by the way https://github.com/openstack/os-vif/blob/master/os_vif/objects/base.py#L18 | |
| 18:26:58 | dansmith | yep, I dug in | |
| 18:29:05 | dansmith | btw, when are we going to switch the functional tox target to be py37 by default? I hate having to type out functional-py37 each time | |
| 18:29:28 | sean-k-mooney | in nova you mean | |
| 18:29:42 | sean-k-mooney | we could do that now i guess | |
| 18:29:43 | dansmith | yes | |
| 18:29:46 | sean-k-mooney | its after m1 | |
| 18:30:33 | sean-k-mooney | dansmith: it looks like its already python3 | |
| 18:30:54 | sean-k-mooney | so tox -e functional will use your default system python 3 | |
| 18:30:57 | dansmith | is it? why do we have functional-py37 then? | |
| 18:31:03 | sean-k-mooney | that is proably 3.6 | |
| 18:31:28 | sean-k-mooney | well functional-py37 will be expressly 3.7 regardless of your system default | |
| 18:31:41 | dansmith | last I checked, which has been a while, functional would use whatever env says "python" resolves to, which is 2.7 for me | |
| 18:31:49 | sean-k-mooney | the fucntioal target is inheriting basepython = python3 | |
| 18:32:04 | dansmith | ah okay | |
| 18:32:18 | dansmith | hmm, from 2018 | |
| 18:32:21 | sean-k-mooney | os ya it will use whatever python3 point too | |
| 18:33:04 | sean-k-mooney | am no form https://github.com/openstack/nova/commit/14872caae1a51c7015dd7c509d0173df2e943ed4 | |
| 18:33:32 | sean-k-mooney | it had python 2.7 explcitly before https://github.com/openstack/nova/commit/14872caae1a51c7015dd7c509d0173df2e943ed4#diff-b91f3d5bd63fcd17221b267e851608e8L69 | |
| 18:33:50 | dansmith | oh good good, that explains it | |
| 18:34:34 | sean-k-mooney | i still kind of want to add a "unit" env so we can do the same thing with the unit tests | |
| 18:34:59 | sean-k-mooney | i.e. just run them with any python 3 and tell me if they pass | |
| 18:35:11 | dansmith | yeah that would be nice | |
| 18:35:32 | dansmith | hitting p-y-[2-3] is actually fairly error-prone for me | |
| 18:37:19 | sean-k-mooney | i use crtl-r to seach my history way to much but ya i dont mind it too much but it can be annoying at times | |
| 18:37:47 | dansmith | yeah, but c-r tox doesn't work always, and otherwise I have to type the py37 bit anyway | |
| 18:37:49 | sean-k-mooney | my most common mistate is ttyring to change form 27 to 36 and ending up with 26 | |
| 18:38:27 | dansmith | sean-k-mooney: no, your most common mistake is any english word ever, but I'll concede that py26 is probably in the list somewhere too :P | |
| 18:38:52 | sean-k-mooney | hehe :) ya i noticed that after i hit enter. | |
| 18:38:55 | dansmith | heh | |
| 18:39:33 | sean-k-mooney | i need to like bind enter to spell check and shift enter to send or somehting | |
| 18:40:16 | dansmith | pre-send hook requiring aspell==0 | |
| 18:40:46 | dansmith | pretty sure we'd never hear from you again though | |
| 18:40:54 | sean-k-mooney | actully i need to resinstall aspell i had it integreated but i broke it a while a go | |
| 18:41:55 | sean-k-mooney | anyway im going to try restacking with the latest cyborg change so ill be back in a while when that is done. im currently trying to test with the fake driver | |
| 18:42:06 | dansmith | scweet | |
| 18:42:12 | dansmith | er, schweet | |
| 19:29:27 | artom | yeah is pell liek a tads now | |
| 22:09:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects https://review.opendev.org/702049 | |
| 22:10:55 | efried | \o/ | |
| 22:14:14 | dansmith | oops, | |
| 22:14:19 | dansmith | I forgot to clean up your requestgroup thing | |
| 22:14:30 | dansmith | but, pretend this is you: https://review.opendev.org/#/c/702049/1/nova/objects/diagnostics.py | |
| 22:25:28 | openstackgerrit | Dan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects https://review.opendev.org/702049 | |
| 22:33:04 | mriedem | ooo did i provide the mixin idea? | |
| 22:33:49 | mriedem | f yeah i did https://review.opendev.org/#/c/699050/5/nova/objects/request_spec.py@1231 | |
| 22:41:29 | dansmith | mriedem: about 24 hours late :) | |
| 22:44:50 | mriedem | i'm going to say there was some precog stuff at work here | |
| 22:44:55 | mriedem | in order to still take credit | |
| 22:45:05 | dansmith | hmm, okay :) | |
| 23:27:12 | openstackgerrit | Merged openstack/nova master: Fix typos in nova doc https://review.opendev.org/701876 | |
| 23:29:22 | sean-k-mooney | dansmith: ill take a look at that patch a little more in deail but i left a comment for you on the pci_device __init__ | |
| #openstack-nova - 2020-01-11 | |||
| 00:48:29 | openstackgerrit | Merged openstack/nova stable/queens: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/700359 | |
| 00:50:21 | openstackgerrit | Luigi Toscano proposed openstack/nova stable/pike: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/702061 | |
| 03:58:27 | openstackgerrit | Brin Zhang proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info https://review.opendev.org/580271 | |