Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-09
22:17:37 dansmith there will be a base class in base.py which mixes in and then you'll inherit from that once
22:18:39 dansmith and that means we can always isinstance(thing, NovaEphemeral) to know its true nature
22:19:38 efried as opposed to self.EPHEMERAL. But yeah, the possibility of flipping back and forth in nested subclasses is a reasonable argument against that.
22:20:31 dansmith yeah I just mean you can't really fake your parentage easily
22:20:37 efried though this way you can still do that, but you can only flip *to* ephemeral, and you can only do it once.
22:21:33 efried unless we just don't define the mixin at all. Make NovaEphemeral a subclass of NovaObject.
22:21:36 efried anyway, details.
22:22:05 dansmith yeah, just being a class variable makes it changeable at runtime, vs an essential quality of the thing
22:22:31 dansmith what's the argument for it being a class variable?
22:22:50 dansmith less formality, maybe, but I'm going for formality here
22:22:59 efried "efried doesn't like mixins"?
22:23:36 dansmith oh I don't really either, but I think I was asked to make those qualities mixins because that's how python libraries do things like this without affecting interfaces as much
22:23:48 efried makes it tough to figure out what's happening
22:23:59 efried ye gods, have you seen the openstacksdk project?
22:24:13 dansmith yep, totally agree, which is why the one class that does the mixin in base and then you single-inherit from that, knowing its done right
22:24:20 dansmith mixin heaven?
22:24:32 efried every class has like a dozen mixins, and it's freaking impossible to understand where you go when you invoke a method
22:24:43 dansmith yeah, I'm totally with you on that
22:24:51 dansmith when this was all code in nova there was a lot less mixing going on
22:24:53 efried mixins, and proxy shims, and dynamic construction, and ...
22:25:01 dansmith but it's a library now, so..
#openstack-nova - 2020-01-10
01:16:08 openstackgerrit Merged openstack/nova master: Add missing parameter vdi_uuid in log message https://review.opendev.org/701004
01:29:59 alex_xu efried: sean-k-mooney sorry, I was too sleepy last night, I didn't follow the end of dicussion for placement-ese and flavor-ese, I saw there are some vision in the irc log, but what should we do for mix instance spec in this release?
01:45:06 openstackgerrit zhufl proposed openstack/nova master: Fix typos in nova doc https://review.opendev.org/701876
02:44:46 openstackgerrit Merged openstack/nova master: Use Placement 1.35 (root_required) https://review.opendev.org/699050
05:29:28 LiangFang dansmith: happy new year:) Could you please help to review again: https://review.opendev.org/#/c/689070/
05:31:41 LiangFang related code implemetation are also ready except UT: https://review.opendev.org/#/c/663542/
08:41:45 openstackgerrit Merged openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078
08:46:05 shilpasd Hi, thanks for review for DB patch for ignore root_gb
08:46:18 shilpasd brinzhang_: thanks for review for DB patch for ignore root_gb
08:46:33 shilpasd regarding comment related to release note, IMO since its code level changes, we shouldn't have
08:47:01 brinzhang_ shipasd: Yeah, I am ok.
08:47:27 shilpasd brinzhang_: thanks
08:48:05 brinzhang_ shilpasd: np :)
08:50:03 openstack Launchpad bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,Confirmed]
08:50:03 brinzhang_ alex_xu: I am reviewing this bug https://bugs.launchpad.net/nova/+bug/1663456, I think Vishakha Agarwal fix is available, can you restore https://review.opendev.org/#/c/580271/
08:51:12 brinzhang_ alex_xu: it's abandoned by matt because of the merge conflict, I will resolve the merge conflict, and let the bug continue
09:51:07 gibi dansmith: thanks for starting the discussion on the conflicting ovo usage. I appreciate your effort. I was alway too lazy to start up such a discussion. I will comment your patches soon
10:03:44 ralonsoh gibi, sorry, I updated the commit message at the same you +1 the patch https://review.opendev.org/#/c/701797/
11:28:44 gibi ralonsoh: no worries
11:28:50 gibi ralonsoh: thanks for fixing the gatae
11:28:52 gibi gate
11:41:59 openstackgerrit Luyao Zhong proposed openstack/nova-specs master: support live migration with virtual persistent memory https://review.opendev.org/695863
12:04:12 brinzhang gibi: sean-k-mooney: could you please review these specs? https://review.opendev.org/#/c/699669/ and https://review.opendev.org/#/c/682302/
12:05:00 brinzhang gibi, sean-k-moonkey: thanks~
12:16:01 sean-k-mooney efried: do you know if sundar has been testing his cyborg patches on centos 7 still. i have tried 3 different way to get python 3.6 running properly on centos and they all end up failing to stack with python errors so im swaping to ubunut just want to check if you know if he has tested ubuntu 18.04
12:19:23 sean-k-mooney i assume the tempest job proably used ubunut so it should work but just said i would ask
12:25:51 gibi brinzhang: added to my review queue
12:26:21 brinzhang gibi: thanks :)
12:31:31 gibi dansmith, efried: I commented both ovo improvement patch. I totally +2 on the EphemeralObject one, and I'm OK with the default_fn too but I don't see where I will use that in Nova
12:33:10 openstack Launchpad bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,Confirmed] - Assigned to Brin Zhang (zhangbailin)
12:33:10 brinzhang gibi: Today I was reviewed this bug https://bugs.launchpad.net/nova/+bug/1663456,and reviewed it's fixed patch, I think it's available, and it was abandoned by matt, could you please restore this patch?
12:33:58 brinzhang gibi: I will resolve that merge conflict, and continue work for it.
12:47:49 gibi brinzhang: restored the review https://review.opendev.org/#/c/580271/
12:48:52 lyarwood did someone track down a change in devstack-gate that's causing n-net to be dropped from stable/queens cells-v1 runs?
13:01:23 frickler lyarwood: that should be fixed by https://review.opendev.org/701404
13:01:38 frickler oh, n-net
13:02:09 frickler that isn't fixed afaict, need to do something similar to the above probably if that's really still needed
13:02:17 frickler the fix was for n-cauth
13:02:39 lyarwood yeah I think I'm confusing it with thast
13:03:31 lyarwood https://a2c2b9c0506b0b396571-e07636147bed59ede28bbdb888fbf884.ssl.cf1.rackcdn.com/700359/1/gate/nova-cells-v1/11412d4/logs/local.conf.txt.gz - n-net is missing from local.conf here on the nova-cells-v1 jobs that results in n-cpu trying to use neutron even when it isn't deployed. Trying to work out why now as this wasn't the case on the 23rd.
13:04:04 frickler lyarwood: this patch dropped it https://review.opendev.org/#/c/700217/
13:04:35 frickler so it's all mriedem's fault ;)
13:05:13 lyarwood \o/
13:05:19 lyarwood I'll add it back in for queens now
13:05:25 lyarwood thanks :)
13:06:23 sean-k-mooney lyarwood: queens is em now right
13:06:46 sean-k-mooney we will eventually drop it and the cells v1 job im assuming but i guess not for a while
13:07:19 lyarwood sean-k-mooney: yup, it was passing prior to this change and as it's just infra I'll fix it
13:08:12 sean-k-mooney ya im just not sure how many people are still running cellsv1 and queens
13:08:48 sean-k-mooney im sure there is some unfortunete that is but if it was an invovled fix rather then just enableing nova networks again i would question the merit more
13:09:16 lyarwood yup indeed
13:12:45 lyarwood frickler: FYI https://review.opendev.org/701957
13:15:18 frickler lyarwood: thx, added to my list, will review once the test results are in
13:17:25 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: DNM Test devstack-gate n-net fix https://review.opendev.org/701958
14:03:20 aarents Hi, kashyap: lyarwood I need your feedback from that: https://review.opendev.org/#/c/696084/ if you may have a look
14:03:30 kashyap aarents: Hi
14:05:01 kashyap aarents: Have queued it; once I flush my curent cache, will look.
14:05:51 lyarwood aarents: ack also looking
14:06:11 lyarwood hmm is gerrit dead for anyone else?
14:06:23 lyarwood nvm it's back
14:06:43 aarents kashyap: lyarwood great, thks
14:55:01 efried alex_xu: gimme a second and I'll try to summarize the discussion...
14:55:11 efried sean-k-mooney: I don't know where/how Sundar has been testing, let me ask him.
14:59:45 efried Sundar: sean-k-mooney was asking what OS you're using to test cyborg stuff...
15:00:10 efried Sundar: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-01-10.log.html#t2020-01-10T12:16:01
15:00:46 Sundar efried: sean-k-mooney: It is mostly Centos 7.6.
15:08:36 sean-k-mooney Sundar: so the issue i have with centos 7.6 was gettign a working version of python 3.6
15:09:04 sean-k-mooney you cant deploy nova under python 2 anymore and i was getting issue with python 3.6 from eple
15:09:44 Sundar sean-k-mooney: I have installed Python 3.6 with Centos 7.6, and I am testing exclusively with Py3.
15:09:45 sean-k-mooney i have stacked on ubuntu now but without the nova changes ill restack with that after the meeting im on finishes up
15:10:14 sean-k-mooney Sundar: ok i was getting some trace back although it was runrelated to cyborg
15:10:52 Sundar I understand it is not a first class citizen yet. There are a few wrinkles.
15:10:55 sean-k-mooney i tried installing python3.6 3 different way so maybe one of the first two caussed issue when i installed it from epel
15:11:29 sean-k-mooney Sundar: well centos 7 is not going to be offically supported for ussuri
15:11:48 sean-k-mooney peopel are workign to move devstack to centos 8
15:12:15 sean-k-mooney i used to be able to use py36 on centos fine but it broke for me back in august
15:13:01 Sundar sean-k-mooney: Totally understand. Many Centos packages still assume Python 2, such as yum etc. Had some issues with pip2 etc. My main constraint is, I often work with FPGAs and that stack is validated with Centos 7.6 and old Ubuntu.
15:13:48 Sundar Meanwhile, many 'real world' deployments of the stack are with Centos, so I kinda prioritize that
15:15:03 Sundar sean-k-mooney: "centos 7 is not going to be offically supported for ussuri" -- for devstack? Or more generally?

Earlier   Later