Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-09
17:09:34 efried sean-k-mooney: any idea when he's back?
17:18:13 sean-k-mooney am i belive tuesday so if gibi is +2 and you adresss his nits i think you can proceed without him
17:18:51 sean-k-mooney or bauzas could bug him to take a look they when he show up at his place
17:19:26 sean-k-mooney they are going skieing so if there is an acident we could be down two cores
17:20:38 sean-k-mooney i remember thing in the flight back to hetrown form the first vancouver ptg that there were at least 8 cores and sevel other active comunity member on that flight
18:12:38 gmann dansmith: melwitt efried yeah I agree that if we are changing the filters for admin/non-admin without policy it need microversion otherwise even it is restriction or extensions of allowed filters will cause interop issue.
18:12:51 dansmith ++
18:12:59 efried thanks gmann
18:13:21 gmann but i thought new policy 'os_compute_api:servers:allow_all_filters' solve the filtering issue for non-admin and operator can do that way.
18:14:55 gmann but if changing policy is not preferable then we can reiterate on non-admin filters and may be we may find some filters which we should allow for them. so +1 on spec to iterate on those not just AZ.
18:15:21 openstack bug 1844568 in tempest "[compute] "create_test_server" if networks is undefined and more than one network is present" [Medium,In progress] https://launchpad.net/bugs/1844568 - Assigned to Eric Fried (efried)
18:15:21 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Test granular tempest changes for bug 1844568 https://review.opendev.org/701794
18:15:33 efried ralonsoh: ^
18:15:55 efried gmann: that approach was problematic, see the patches
18:16:03 efried I think tldr it gave too much power
18:16:25 dansmith efried: gibi: I want to work on our marriage instead of just fight all the time: https://review.opendev.org/#/c/701796/
18:16:42 dansmith (see that and below)
18:17:08 efried dansmith: I read that as "f'ing default"
18:18:21 dansmith I think _fn is a fairly common suffix for function, but if you want something else that's fine
18:18:23 dansmith it's short
18:18:33 efried no, it's good, I was just joshing around.
18:18:36 dansmith default_callback or default_function are both long to specify in a class defintion
18:18:38 dansmith okay
18:19:00 dansmith remember the therapist said to be direct in our communication to avoid misunderstandings
18:19:04 dansmith especially in front of the children
18:20:00 dansmith anyway, this'll require an ovo release before we can use either of these, and I don't even know how that happens these days, but I think we'll be able to reparent things like your new request classes,
18:20:07 dansmith and get them the default behavior you want
18:21:29 efried dansmith: I'm not sure I understand how this differs from using the existing syntax, considering the deepcopy we've identified previously. It looks like it might let you do extra things during the initialization that a deepcopy wouldn't account for; but afaict nobody is asking for that?
18:21:53 dansmith efried: which are you talking about?
18:22:02 dansmith the default_fn one?
18:22:43 efried Oh, you said "below", I was waiting for another link in IRC. Looking at the other patch now....
18:22:43 efried default_fn, yes.
18:23:07 dansmith the reason I actually wrote that one is more so you can provide a class than a function
18:23:13 ralonsoh efried, ^^
18:23:13 openstack bug 1844568 in tempest "[compute] "create_test_server" if networks is undefined and more than one network is present" [Medium,In progress] https://launchpad.net/bugs/1844568 - Assigned to Rodolfo Alonso (rodolfo-alonso-hernandez)
18:23:13 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: DNM: Test global tempest changes for bug 1844568 https://review.opendev.org/701799
18:23:33 efried ralonsoh: ack
18:24:13 dansmith yes, it'll still get deepcopy'd for compat, but not knowing that detail, it's more intuitive for just providing a callable thing like a class and having it instantiated
18:24:36 dansmith you know, I actually might be able to eliminate the deepcopy if you provide a _fn,
18:24:48 dansmith if I make the default wrapper do the deepcopy
18:25:51 efried as long as that wouldn't break anyone already relying on the deepcopy...
18:26:12 dansmith yeah, that's what we need to avoid, so I was just going to punt on it
18:26:31 dansmith but I'm not sure it'd be legit to be relying on that subtle of a detail
18:26:43 sean-k-mooney ralonsoh: is that to deal with the fact that somethins there are multile network and in somecase we race there creation if we change concurancy > 2
18:26:56 ralonsoh sean-k-mooney, yes
18:27:44 efried sean-k-mooney: trying to tackle the "Multiple networks found" CI errors that are making 80% of our CI runs fail.
18:27:45 sean-k-mooney ok in some cases where you are using tempest without floating ip we still need to be able to specify a network for the tempset clietn to be abel to ssh in on
18:27:52 sean-k-mooney i assume that will still work
18:28:16 ralonsoh sean-k-mooney, yeah, from the neutron channel
18:28:17 ralonsoh http://paste.openstack.org/show/788211/
18:28:18 efried I think that's what we're trying to find out
18:28:31 efried possibly "can be made to work"
18:30:06 sean-k-mooney well its more we support using tempest on real clouds for interop testing in that case we suppro specify a public network where you vm can directly create ports instead of using fip
18:30:30 sean-k-mooney im jsut making sure that if we create network for the compute test we can still support that when we need too
18:30:46 sean-k-mooney i can move to the neuton channel by the way if that makes more sense
18:31:50 sean-k-mooney i dont in prinsipal see an issue with createing a network for each trest although i know that some clould like rackspace used to have neutron but not allow tenant to call the api
18:35:07 efried See, I don't understand any of that, and don't especially want to take the time to learn it. I just want to make our CI not fail for reasons unrelated to the code being tested.
18:35:21 sean-k-mooney https://github.com/openstack/tempest/blob/97052fae121174b9d6daa51684c03f730dc74683/tempest/config.py#L303-L309
18:35:32 sean-k-mooney im refering to this config option by the way
18:36:21 efried I like where this is going, thank you.
18:36:21 efried dansmith: added a comment in https://review.opendev.org/#/c/701795/
18:36:26 sean-k-mooney and there is also a seperate config for ssh verification
18:36:28 sean-k-mooney https://github.com/openstack/tempest/blob/97052fae121174b9d6daa51684c03f730dc74683/tempest/config.py#L831-L834
18:36:32 dansmith efried: yep, replying
18:37:51 efried sean-k-mooney: I did notice that we're doing this explicit network setup in a different method, prepare_instance_network, based on some other conf options.
18:38:38 efried but understanding what those conf options mean, and why certain tests would want to do that but others wouldn't... again, deeper than I want to go.
18:39:57 sean-k-mooney well to be clear i have not fully groked what ralonsoh is change yet
18:40:23 ralonsoh groked?
18:40:26 sean-k-mooney i just know that there are some case where always createing neutron network might be an issue
18:40:45 sean-k-mooney ralonsoh: formed a complete understanding of
18:40:58 sean-k-mooney https://en.wikipedia.org/wiki/Grok
18:42:19 ralonsoh sean-k-mooney, maybe we can do the opposite: in those cases where the network creation is an issue, we can disable it
18:43:37 sean-k-mooney well the idea fo the fixed network was so you could execute test in an enve where the network were precreated. in that case you wont have the multiple network isue anyway
18:43:56 sean-k-mooney so if that config is defiend you would be able to jsut not create teh network and use the one set in the config
18:44:14 ralonsoh agree
18:45:40 sean-k-mooney for the ssh verificaiton im also wondering if you need to create a router too? instead of an isolated network?
19:00:03 sean-k-mooney efried: ralonsoh i left a comment on the review. i think in general this would make sense just would need someone more familar to check this wont break things
19:01:10 sean-k-mooney another example of when you need to use fixed netowrkisn is usign tempest with ironic and flat netorkign. so its not just for rackspace.
19:01:43 sean-k-mooney that said you can deploy ironic with neutron netorks too but i still dont know how common that is
19:16:07 dustinc dansmith: Is there a chance that you can check this out and maybe wf+1? It is just a small update to the Provider Config File spec. https://review.opendev.org/#/c/693414/
20:14:37 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: Ensure source service is up before resizing/migrating https://review.opendev.org/701757
20:14:37 openstack bug 1855927 in OpenStack Compute (nova) "_poll_unconfirmed_resizes may not retry later if confirm_resize fails in API" [Low,In progress] https://launchpad.net/bugs/1855927 - Assigned to Matt Riedemann (mriedem)
20:14:37 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: Add recreate test for bug 1855927 https://review.opendev.org/701756
20:41:29 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-agents policies https://review.opendev.org/701648
20:42:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-agents policy https://review.opendev.org/701649
20:51:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-assisted_volume_snapshots policies https://review.opendev.org/701835
20:58:52 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-assisted_volume_snapshots policy https://review.opendev.org/701837
21:02:47 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-assisted_volume_snapshots policies https://review.opendev.org/701840
21:08:38 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-assisted_volume_snapshots policy https://review.opendev.org/701841
21:40:02 dansmith efried: still around?
21:40:07 efried yes
21:41:01 dansmith efried: I think you're missing my point on the defaulting stuff, and mashing together the default_fn thing with the object mix-in
21:41:24 dansmith they're not really related, as you'll note the mixin has nothing to do with the default_fn thing
21:41:51 efried yeah, I get that they could be separate. I'm just not sure there's a reason to do that.
21:41:54 dansmith the latter is just syntactic sugar in most cases, aside from the fact that the latest patch avoids copying everything all the time
21:42:09 dansmith they're wholly separate
21:42:29 dansmith default_fn has nothing to do with whether or not it's applied implicitly at init time
21:42:39 efried I understand that
21:43:00 dansmith okay
21:43:13 efried but still think there's value in smashing them together.

Earlier   Later