Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-20
17:33:03 johnthetubaguy maybe another question... what upgrade check should we when we want to make enforce_scope = true?
17:33:31 johnthetubaguy we could warn if they have any policy rules overriden that they need checking, but not sure what else we can do really
17:33:51 gmann we need deprecation at specific policy level when we do granularity where rule name change like- https://review.opendev.org/#/c/648480/23/nova/policies/services.py
17:33:53 johnthetubaguy this is more for "next" release, after we make the initial backwards compatible change
17:34:04 johnthetubaguy gmann: +1
17:34:11 johnthetubaguy that case we totally need that
17:34:58 johnthetubaguy but that is a sort of independent issue, its because we added more granularity
17:35:07 gmann yeah
17:35:11 johnthetubaguy and folks make have overriden the old rule
17:35:28 johnthetubaguy cool, does that mean we are all set?
17:36:33 gmann for upgrade check, i was thinking auto correction but it need more thought.
17:36:59 johnthetubaguy yeah, although I don't think it blocks this release's work a such
17:37:21 johnthetubaguy the simplest check is probably to see if the override is the old default
17:37:37 johnthetubaguy in case people haven't deleted their old policy files they always used to deploy
17:37:58 johnthetubaguy there is an ops meetup after christmas, I could ask around there if policy comes up
17:38:17 gmann +1, that will be great.
17:38:50 johnthetubaguy cool, happy holidays when that happens
17:38:52 gmann seems all set for now. thanks for discussion.
17:39:17 johnthetubaguy no problem, thanks for pushing this, so many of our customers are wanting to see this move forward
17:39:19 gmann you too. i will try to make other policy ready once you are back
17:39:29 johnthetubaguy cool
17:40:21 gmann also waiting for stephenfin to reply on this, i could not understand his query (if something interesting to care at initial level)- https://review.opendev.org/#/c/657698/14
17:43:30 johnthetubaguy gmann: I think stephenfin was meaning we could have left the unit tests where they were, under api, rather than "moving" to policy
17:44:12 gmann ohk
17:45:13 johnthetubaguy personally, I had assumed we were putting the unit tests under api/ before I saw your patches, but I wasn't against moving it
17:45:14 gmann i think doing under separate dir is more explicit and easy to check coverage. inside API it was very hidden kind of testing. but may be it just me ?
17:45:40 johnthetubaguy the other thing, is when you cut and paste all the tests when adding a new API, you might not see the policy tests
17:45:57 johnthetubaguy not that people do that, of course (cough)
17:45:58 gmann i actually went with the code structure. policies is not under API code
17:46:31 johnthetubaguy but we are testing the context.can call, and that is under the API code
17:46:59 johnthetubaguy I should be clear, my +2 stands, I don't mind the idea, for the reasons you just said
17:47:17 johnthetubaguy really just playing devils advocate to make sure we are sure
17:48:26 gmann ok. i can move as its not big deal. may be under ./nova/tests/unit/api or nova/tests/unit/api/openstack/compute ?
17:49:36 johnthetubaguy I think for that patch, basically it goes where those deleted tests are
17:50:13 johnthetubaguy but I would +2 either approach, until I hear a stronger argument for one or the other
17:50:37 gmann i think we should do under separate dir but under API dir or api/openstack/compute
17:50:53 johnthetubaguy oh... in some ways that is worse
17:51:06 gmann inside API test files it is very hidden honestly.
17:51:15 johnthetubaguy lets stick with what you have already, assuming stephenfin is OK with it after we tell him why
17:51:39 gmann in doc we can say 'any API change or policy, review can check the tests under this folder'
17:51:47 gmann ok
17:52:36 johnthetubaguy I think either we consider it testing the policy file or the api file, its basically testing both
17:53:04 johnthetubaguy hence I am OK with either next to all the API unit tests (like the old broken tests we delete) or in the new place you chose
17:53:50 johnthetubaguy its easy enough to move if we decide we made the wrong call
17:54:03 johnthetubaguy cool, I should run, was good to catch up
17:54:07 gmann ok. let's see what stephenfin say.
17:54:11 johnthetubaguy +1
17:54:13 gmann sure, thanks
18:49:15 openstackgerrit Merged openstack/nova stable/train: Block rebuild when NUMA topology changed https://review.opendev.org/698530
19:58:50 openstackgerrit Merged openstack/nova stable/stein: Cache security group driver https://review.opendev.org/697480
20:10:06 openstackgerrit Merged openstack/nova stable/stein: Improve metadata server performance with large security groups https://review.opendev.org/695925
21:18:09 openstackgerrit Merged openstack/nova master: FakeDriver: adding and removing instances on live migration. https://review.opendev.org/243613
21:24:00 mriedem stephenfin: some easy things to cleanup in the xvpvncproxy removal change https://review.opendev.org/#/c/687909/ - i'm sure i'll probably be poking around in gerrit next week to avoid my in-laws so if you get that updated i'm +2
21:48:15 openstackgerrit Merged openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480
21:55:50 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
21:55:50 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
21:55:51 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
21:55:51 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522
22:38:03 mriedem gmann: nova.tests.unit.test_policy.RealRolePolicyTestCase.test_all_rules_in_sample_file is dumping a lot to the console log
22:38:35 mriedem https://zuul.opendev.org/t/openstack/build/3a837b550b2344aca69eaf747dc5a0c2/log/job-output.txt#20581
#openstack-nova - 2019-12-21
05:47:31 openstackgerrit Merged openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268
06:24:25 openstackgerrit Merged openstack/nova stable/rocky: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/700121
21:33:42 openstackgerrit Merged openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650
#openstack-nova - 2019-12-22
21:26:29 openstackgerrit Merged openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
23:17:46 openstackgerrit Luigi Toscano proposed openstack/nova stable/queens: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/700359
23:38:28 openstackgerrit Merged openstack/nova master: Add test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec https://review.opendev.org/695336
#openstack-nova - 2019-12-23
02:27:16 openstackgerrit Chason Chan proposed openstack/nova master: [api-ref] Fix the incorrect link https://review.opendev.org/700362
05:45:18 openstackgerrit Merged openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
07:28:12 openstackgerrit chenker proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
09:24:40 ruffian_sheep Hi,does anyone know how can i change the api version of the compute?
09:26:04 ruffian_sheep I want to test the multiattach in the tempest.But It always show me that Multiattach volumes are only supported starting with compute API version 2.60.I dont know how to change it ,can anyone help me?
09:59:19 openstackgerrit Merged openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
11:32:13 openstackgerrit chenker proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
11:54:16 openstackgerrit Qiu Fossen proposed openstack/nova-specs master: specify mac for creating instance https://review.opendev.org/700429
12:07:45 brinzhang_ ruffian_sheep: you can specify "X-OpenStack-Nova-API-Version: <version>" to set the nova api to microversion 2.60.
12:08:06 brinzhang_ ruffian_sheep: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id1
12:53:37 openstackgerrit Merged openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698
14:21:31 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
14:31:16 openstackgerrit Merged openstack/nova master: libvirt: flatten rbd image during cross-cell move spawn at dest https://review.opendev.org/691991
15:11:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Flesh out docs for cross-cell resize/cold migrate https://review.opendev.org/696212
15:11:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
15:11:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
15:11:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add sequence diagrams for cross-cell-resize https://review.opendev.org/698051
15:11:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize tests for _poll_unconfirmed_resizes https://review.opendev.org/698322
15:11:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement cleanup_instance_network_on_host for neutron API https://review.opendev.org/697162
15:11:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Simplify FinishResizeAtDestTask event handling https://review.opendev.org/695337
15:11:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb graceful_exit through to EventReporter https://review.opendev.org/699237
15:11:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix accumulated non-docs nits for cross-cell-resize series https://review.opendev.org/698935
15:11:29 openstackgerrit Matt Riedemann proposed openstack/nova master: FUP for docs nits in cross-cell-resize series https://review.opendev.org/699259
15:11:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Use graceful_exit=True in ComputeTaskManager.revert_snapshot_based_resize https://review.opendev.org/699238
15:11:30 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832
15:11:30 openstackgerrit Matt Riedemann proposed openstack/nova master: FUP to Iff8194c868580facb1cc81b5567d66d4093c5274 https://review.opendev.org/700202
15:11:31 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213
15:41:39 openstackgerrit Merged openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905
15:41:45 openstackgerrit Merged openstack/nova master: nova-net: Convert remaining unit tests to neutron https://review.opendev.org/696510
16:07:14 openstackgerrit Merged openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function https://review.opendev.org/696511
16:08:30 openstackgerrit Merged openstack/nova master: nova-net: Remove nova-network security group driver https://review.opendev.org/696512
16:08:36 openstackgerrit Merged openstack/nova master: nova-net: Correct some broken VIF tests https://review.opendev.org/696513
16:25:05 openstackgerrit Merged openstack/nova master: Fix get_request_group_mapping doc https://review.opendev.org/699979
16:50:53 openstackgerrit Merged openstack/nova master: Func test for qos live migration reschedule https://review.opendev.org/699015

Earlier   Later