Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-16
14:56:47 tbachman pilots
14:57:34 mriedem it's all auto-pilot now
14:57:56 tbachman that’s the way I roll when developing
14:58:23 tbachman explains all the bugs
15:06:13 gibi mriedem: thanks
15:06:14 KeithMnemonic good day mriedem: i did an update to fix that issue with osc --marker --deleted. Would you mind giving me your thought on if this is the right direction to go in. Thank you. https://review.opendev.org/691045
15:06:49 KeithMnemonic it was what we discussed a few weeks ago, just for ID only when --deleted is also used
15:08:48 gibi mriedem: will you implement the fix for https://review.opendev.org/#/c/638047/56/nova/conductor/manager.py@1883 in a separate commit top of the series? if yes then I will +A the current patch to keep the series moving
15:10:14 mriedem gibi: yes i'm working on it now
15:10:20 gibi mriedem: cool.
15:10:58 aarents lyarwood: I commented out your reply if you may have a look ? https://review.opendev.org/#/c/696084
15:12:39 mriedem KeithMnemonic: done
15:13:13 mriedem gibi: i've also removed the cache from https://review.opendev.org/#/c/691991/ in the FUP patch at the end
15:13:20 mriedem just haven't pushed it yet
15:14:05 gibi mriedem: thanks. I see your comment about having the whole instance object cached. That seems even more dangerous but dansmith seemed to have a good reason for that cache https://github.com/openstack/nova/commit/7a9942c5924d7ccfe321c54d0b5e70cfb3aede57
15:14:59 mriedem i think that's probably safer since a Migration record is created with an instance.uuid always i think
15:15:03 mriedem so it's not going to change
15:15:15 mriedem gibi: also on the assertion to add in https://review.opendev.org/#/c/638268/56 - can i do that in a FUP as well to keep things moving?
15:15:26 mriedem you said you were out after today and most of the series is approved so i'd like to FUP what i can
15:15:33 gibi mriedem: sure, that can be a simple extension to the test
15:17:09 gibi mriedem: changed my vote there
15:17:35 gibi mriedem: yeah today is my last day in the office. I will try look at some of my patches during this week still
15:18:29 gibi mriedem: I think I'm +A now on all the patches that had +2 from stephenfin
15:25:13 mriedem awesome, thanks
15:25:21 mriedem i've got your live migration qos change in the tab queue as well
15:26:11 lyarwood aarents: ack yeah sorry will try to get to it today
15:27:54 aarents lyarwood: oky, thks
15:33:36 efried o/
15:33:43 efried I'm not here
15:33:49 efried but if I were, it would be only to ask for some reviews...
15:34:16 efried gibi: you're on vacation starting... tomorrow?
15:35:01 efried mriedem: would be neat to get your feedback on (esp the ovo parts of) https://review.opendev.org/#/c/699050/ before you disappear into a quantum paradox.
15:35:05 efried or whatever that is
15:35:32 efried it's what we talked about on Friday: RequestSpec.placement_shit
15:36:47 efried And in the spirit of throwing small, self-contained, but hopefully slightly interesting stuff at you for your last few days, this one should hopefully be an easy A: https://review.opendev.org/#/c/698803/
15:37:22 mriedem they are in the tab qeuue
15:37:24 mriedem *queue
15:37:38 efried thanks mriedem
15:37:42 efried stephenfin: If you could please have another look at the vTPM spec, I would love to get that merged before the new year. https://review.opendev.org/#/c/686804/
15:39:48 openstackgerrit Eric Fried proposed openstack/nova master: FUP: Remove noqa and tone down an exception https://review.opendev.org/698054
15:40:15 efried stephenfin: that's a trivial fup you requested, probably fast-approvable ^
15:44:45 gibi efried: this is my last day in the office
15:45:34 gibi efried: I will try to still look at my qos patches during this week
15:45:54 efried gibi: okay, cool. If you have time, I think you might find https://review.opendev.org/#/c/699050/ interesting. But no big deal if you don't get to it. (Uses placement 1.35 to do root_required, and puts a request-level params object next to RequestSpec.requested_resources)
15:46:12 gibi efried: ack, added to the queue
15:52:49 KeithMnemonic mriedem: do you mean a test here? https://github.com/openstack/python-openstackclient/tree/master/openstackclient/tests/functional/compute/v2 or unit? or both? this is new to me
15:54:27 mriedem KeithMnemonic: functional would be ideal since it's easy to have false positive unit tests in osc
15:55:05 KeithMnemonic thank you
15:55:37 mriedem i.e. a functional test that does something like, (1) creates a server and then deletes it, (2) tries to list using the marker being the server name with --deleted and assert it fails with server not found, and then (3) lists servers with marker being the server.id + --deleted and show it works
16:25:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832
16:25:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix accumulated non-docs nits for cross-cell-resize series https://review.opendev.org/698935
16:25:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb graceful_exit through to EventReporter https://review.opendev.org/699237
16:25:19 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213
16:25:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Use graceful_exit=True in ComputeTaskManager.revert_snapshot_based_resize https://review.opendev.org/699238
16:29:13 mriedem #success cross-cell resize/cold migrate is on its way to the gate
16:29:15 openstackstatus mriedem: Added success to Success page (https://wiki.openstack.org/wiki/Successes)
16:29:43 mriedem gibi: stephenfin: efried_pto: dansmith: et al ^ thanks for making it happen
16:34:38 gibi mriedem: wooot!
16:38:59 gibi mriedem: thanks for pushing the feauter forward
17:09:36 gibi_pto mriedem: I hope your ghost will linger around on IRC still in next year. But if not then good luck and hapy hacking!
17:09:55 gibi_pto and thanks for all the fish
17:14:09 mriedem gibi_pto: i'm sure i'll do some haunting, have a good break
17:53:26 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832
17:53:27 openstackgerrit Matt Riedemann proposed openstack/nova master: FUP for docs nits in cross-cell-resize series https://review.opendev.org/699259
17:53:27 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213
18:48:40 openstackgerrit Merged openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803
19:36:13 KeithMnemonic mriedem ok i addressed your comments please let me know what you think https://review.opendev.org/#/c/691045/
19:36:29 KeithMnemonic melwitt: if you care to review as well that would be great
21:18:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291
21:18:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add recreate test for bug 1855927 https://review.opendev.org/699045
21:18:45 openstack bug 1855927 in OpenStack Compute (nova) "_poll_unconfirmed_resizes may not retry later if confirm_resize fails in API" [Low,Confirmed] https://launchpad.net/bugs/1855927
22:01:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291
22:01:08 openstack bug 1855927 in OpenStack Compute (nova) "_poll_unconfirmed_resizes may not retry later if confirm_resize fails in API" [Low,In progress] https://launchpad.net/bugs/1855927 - Assigned to Matt Riedemann (mriedem)
22:01:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Add recreate test for bug 1855927 https://review.opendev.org/699045
22:03:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291
22:03:49 openstack bug 1855927 in OpenStack Compute (nova) "_poll_unconfirmed_resizes may not retry later if confirm_resize fails in API" [Low,In progress] https://launchpad.net/bugs/1855927 - Assigned to Matt Riedemann (mriedem)
22:03:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Add recreate test for bug 1855927 https://review.opendev.org/699045
#openstack-nova - 2019-12-17
07:11:43 openstack bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)
07:11:43 openstackgerrit Ning Yao proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294
08:09:00 openstackgerrit Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
08:29:05 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
14:28:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291
15:12:20 mriedem KeithMnemonic: a few things in your osc patch https://review.opendev.org/#/c/691045/
15:20:11 KeithMnemonic thanks mriedem, did you want that full context added to the commit message
15:21:28 mriedem up to you
15:22:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Use graceful_exit=True in ComputeTaskManager.revert_snapshot_based_resize https://review.opendev.org/699238
15:22:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb graceful_exit through to EventReporter https://review.opendev.org/699237
15:22:17 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832
15:22:17 openstackgerrit Matt Riedemann proposed openstack/nova master: FUP for docs nits in cross-cell-resize series https://review.opendev.org/699259
15:22:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213
15:29:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Use COMPUTE_SAME_HOST_COLD_MIGRATE trait during migrate https://review.opendev.org/695220
15:37:53 KeithMnemonic mriedem, i will make all of those. the only one i can not is line 81 in the test, it is as you said due to the order of how the instances are launched, the first one actually is the second one in the list once both are ACTIVE
15:38:14 KeithMnemonic i saw that in testing when i first tried id1
15:44:18 mriedem i wasn't asking for a change in the test, just making a note to myself
15:59:07 mriedem melwitt: i dumped thoughts in https://review.opendev.org/#/c/678100/ about splitting that up
16:11:38 stephenfin mriedem: You've probably seen this already, but it looks like grenade is properly broken. Ansible version mismatches
16:13:57 mriedem ERROR: ara 0.16.6 has requirement ansible>=2.6.0, but you'll have ansible 2.5.7 which is incompatible.
16:13:57 mriedem nope i hadn't noticed but now i see
16:15:17 stephenfin Yup. I'm not sure where it's coming from. Clearly not us
16:15:50 mriedem fungi: known issue ^?

Earlier   Later