Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-13
15:42:26 efried Yes, I agree with you.
15:42:52 efried Are you also agreeing that 1b makes 1a/2/3 unnecessary?
15:43:01 efried If we can agree on that, then I'll get fully behind 1b.
15:43:06 dansmith I'm asking for one of those four options
15:43:09 efried cool
15:43:18 dansmith I thought you didn't want 1b?
15:43:21 efried Sundar: I retract my objection to 1b.
15:43:27 efried I didn't, but now I do.
15:43:39 dansmith man I'm glad we're not local
15:43:57 efried What, you gonna put clorox in my coffee?
15:43:59 dansmith I'd smack you, you'd punch me, our lawyers would get boats
15:44:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Use COMPUTE_SAME_HOST_COLD_MIGRATE trait during migrate https://review.opendev.org/695220
15:44:11 efried I don't punch.
15:44:25 efried I thought you were asking for multiple redundant checks.
15:44:27 dansmith karate chop
15:44:42 efried now you're deliberately goading me
15:44:51 dansmith mriedem can cue up a youtube of the final scene of karate kid
15:45:27 dansmith efried: the only duplicity (which I don't consider duplicity) is us backing up the proper behavior of cyborg with a check, tht's all
15:45:45 mriedem https://www.youtube.com/watch?v=oomCIXGzsR0
15:46:32 dansmith mriedem: right, thanks
15:47:17 Sundar dansmith: efried: So, we are all agreed on 1b: Nova compute publishes a trait, Nova scheduler uses that in Placement query, we all party. Right?
15:47:36 dansmith I'm not partying with either of you, but yes, I'm fine with that
15:48:07 mriedem it occurs to me that daniel's secret is the same as defeating bald bull in punch out
15:48:25 Sundar unrequited? ;)
15:48:25 Sundar dansmith: efried: Re. the idea that Cyborg should not publish inventory till n-c
15:50:12 efried Sundar: ...till n-c advertises the trait. And yes, 1b.
15:51:25 Sundar efried: From an operator's POV, if the inventory gets published, she'd know at least that the devices are good and Cyborg is functioning, and they should look elsewhere to get the system functional.
15:53:24 efried I can live with that.
15:55:07 Sundar efried: dansmith: Ok I'll put in the trait definition. The changes for 1b presumably go in my current patch series.
15:55:16 efried yes
15:55:29 dansmith once the trait is there, it should be one line I'd think
15:55:30 efried so you'll need the os-traits chain
15:55:52 efried dansmith: I'm not actually sure where that line will go. But he also needs to bump the GET /a_c microversion.
15:55:58 efried ...which is like 12 lines.
15:56:11 efried (including test)
15:56:26 dansmith efried: why does he need a bump?
15:56:52 efried Because the trait needs to go into root_required. I'm not going to accept new code that hacks it into the unnumbered request group anymore.
15:57:17 dansmith oh, okay.. we have traits requested now of course, but I guess the point is this is a complicated request
15:57:34 dansmith well, service version check is pretty small and no external dependencies, but.. :)
15:57:42 efried the traits cyborg is requesting today are going into the device profile request groups, which isn't where this capability trait is.
15:58:12 efried And the place those request groups are being built from is kinda far from where the root_required will need to be put in.
15:58:21 efried which is why I said "not sure where that will go".
15:58:30 dansmith aight
15:58:43 efried but this is all very solvable, and moves the ball forward wrt using placement features for what we made them for.
15:58:51 dansmith ack
15:59:10 efried viz. string suffixes and rg/rp mappings
15:59:23 dansmith efried: could we do the microversion bump early in the series and get that merged so we don't add a piece to Sundar's puzzle?
15:59:31 efried for sure
15:59:42 efried I can probably work on that.
15:59:48 efried Sundar: ^
15:59:56 efried I'll try to hack it up this afternoon.
15:59:56 dansmith that would be good, and would be moving the ball a little instead of increasing the weight of the ball
16:00:04 Sundar efried: dansmith: Thanks
16:00:35 efried sean-k-mooney: Are you about today? If not, I can fix up that func test on the image props sync patch and get that moving forward.
16:01:17 sean-k-mooney im around for about an hour but i wont get to it before i head to a team dinner
16:01:53 efried okay. It'll be trivial 1c changes to half a dozen test cases, so I'll still feel good about +2ing.
16:03:39 sean-k-mooney oh i forgot to update the notification samples
16:04:31 sean-k-mooney the notifiction really are a pain
16:07:22 efried yeah, I'm sure they're not worth the trouble.
16:08:15 openstackgerrit Eric Fried proposed openstack/nova master: Sync ImageMetaPropsPayload fields https://review.opendev.org/698613
16:08:17 efried sean-k-mooney: ^
16:08:40 sean-k-mooney :) i was just trying to run them locally to reporduce but ill go back to backporting. thanks
16:11:17 openstackgerrit Eric Fried proposed openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803
16:11:22 efried sean-k-mooney: and ^
16:11:31 dansmith mriedem: are you about to push a change to this? https://review.opendev.org/#/c/638046/56/nova/conductor/tasks/cross_cell_migrate.py
16:11:42 efried gibi, dansmith: That should be an easy win if you could take a quick look
16:11:50 efried https://review.opendev.org/698803
16:11:53 mriedem dansmith: no those are fup'ed already https://review.opendev.org/#/c/698935/
16:11:59 dansmith ah okay
16:14:08 openstack Launchpad bug 1856312 in oslo.config "RuntimeError during calling log_opts_values" [Undecided,New]
16:14:08 mriedem stephenfin: this is probably in your wheelhouse https://bugs.launchpad.net/oslo.config/+bug/1856312
16:24:47 stephenfin mriedem: 1856312
16:24:53 stephenfin whoops. https://review.opendev.org/698954
16:25:04 stephenfin oh yeah
16:26:09 dansmith mriedem: check my comment here: https://review.opendev.org/#/c/638046/56
16:33:43 mriedem dansmith: replied
16:36:21 dansmith mriedem: ack
16:49:15 openstackgerrit Sundar Nadathur proposed openstack/os-traits master: Add a trait that compute manager can handle accelerator requests. https://review.opendev.org/698961
16:49:53 finucannot dansmith: I'm heading off, but can you make sure you're happy with https://review.opendev.org/698890 before you leave for the year?
16:50:18 finucannot gmann should probably look at it too, but I think the main concern about us breaking the DevStack default has been resolved now
16:50:34 dansmith finucannot: I skimmed it earlier, it's just reverting the stuff now that the devstack default is py3 yeah/
16:50:45 finucannot 'zactly
16:51:10 dansmith ack fine with me
16:51:14 finucannot ta
16:51:16 dansmith but yeah, gmann
16:51:19 mriedem we might want to consider taking the boot_index part of this spec and doing it on its own https://specs.openstack.org/openstack/nova-specs/specs/train/approved/detach-boot-volume.html#proposed-change since there is some confusion going on in -sdks about knowing when a server is volume-backed or not
16:51:23 finucannot agreed
16:51:30 mriedem and twould be helpful if we exposed the boot_index of the attached volumes
16:51:43 finucannot dansmith: have a good one 🎄
16:51:49 dansmith o/
16:52:08 gmann dansmith: stephenfin +1
16:53:07 gmann its m-1 also so is anyone is break its time foe them to merge the py2 drop patch.
16:53:21 mriedem dansmith: is there a standard way to check the type on a field?
16:53:33 dansmith mriedem: isinstance
16:53:55 mriedem heh yeah i was doing if isinstance(field, fields.ObjectField) but that didn't work
16:54:09 mriedem so i did value = getattr(target_obj, field) and if isinstance(value, fields.ObjectField): but that doens't work either
16:54:11 dansmith should work
16:54:48 dansmith mriedem: https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L773
16:54:53 mriedem ok i'll tinker, got a call with HR in 5 minutes
16:54:56 dansmith oh I see what you're doing

Earlier   Later