Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-12
18:33:27 mriedem there is a test below it which needed a simple mod, but the change linked there doesn't have merge conflicts so i don't think so
18:33:56 mriedem would have been nice for KeithMnemonic, who has been asking for reviews on these backports for weeks, to have actually reviewed them himself
18:34:15 mriedem dansmith: unrelated, but i'd like your 2nd opinion on https://review.opendev.org/#/c/696574/10/nova/objects/instance.py@1239
18:34:27 mriedem it's a refactor but i'm not sure i'm comfortable with where the method is moving *to*
18:38:18 mriedem note that "NeutronFixture sugar" is what i add to my xmas cookies to give them a little something extra
18:39:57 dansmith mriedem: commented
18:41:08 mriedem thanks
18:46:31 sean-k-mooney efried_afk: gibi stephenfin will ye be able to review https://review.opendev.org/#/c/674072/17 today or tomorrow. artom will likely take this over form me after that as ill be gone.
18:47:06 sean-k-mooney or ill pick it back up in the new year but it would be cool to wrap that up before i go on PTO
18:49:27 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in Admin Action API policies https://review.opendev.org/676682
18:52:08 gmann johnthetubaguy: ^^ trying without deprecating the rule which should fail the project admin token tests which is why i thought of deprecating the rule. I might not be understanding your comment clearly but I will read it again with fresh mind.
18:55:11 openstack Launchpad bug 1827489 in neutron "Wrong IPV6 address provided by openstack server create" [Low,In progress] - Assigned to Brian Haley (brian-haley)
18:55:11 mriedem haleyb: do you think there is anything for nova to do with this? https://bugs.launchpad.net/nova/+bug/1827489
18:59:47 openstackgerrit sean mooney proposed openstack/nova master: Sync ImageMetaPropsPayload fields https://review.opendev.org/698613
19:00:31 haleyb mriedem: no, it's really a config issue in the guest
19:00:58 sean-k-mooney mriedem: this seam ver config specific. when you enable ipv6 in neutron you have several option includign stateful dhcp6
19:01:58 sean-k-mooney i use dhcp6 for my home cluster and the ip that my vms get are not related to the back at all as far as i can see
19:02:07 mriedem ok, invalidated, thanks
19:03:33 sean-k-mooney *mac
19:07:16 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Drop tables for removed services, features https://review.opendev.org/698706
19:07:17 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: db: Remove placement tables https://review.opendev.org/698707
19:08:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Follow up to I5b9d41ef34385689d8da9b3962a1eac759eddf6a https://review.opendev.org/698028
19:08:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
19:08:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
19:08:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
19:08:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
19:08:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046
19:08:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
19:08:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
19:08:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Flesh out RevertResizeTask.rollback https://review.opendev.org/695334
19:08:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335
19:08:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
19:08:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650
19:08:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268
19:08:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec https://review.opendev.org/695336
19:08:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
19:08:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
19:08:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
19:08:31 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: flatten rbd image during cross-cell move spawn at dest https://review.opendev.org/691991
19:09:30 stephenfin Thanks for the reviews, dansmith
19:09:39 stephenfin sean-k-mooney: I can take a look tomorrow, sure (y)
19:09:41 dansmith stephenfin: -1ing the fsck out of that right now
19:10:00 stephenfin I was talking about the backports :D
19:10:04 stephenfin but do your worst
19:10:12 stephenfin I like the pain
19:10:36 dansmith ah, well, then, sure :)
19:10:49 mriedem that doesn't render for me but i hope it's a studded paddle
19:12:58 sean-k-mooney it is not :( its a boaring house
19:13:52 mriedem stephenfin: when you're back about, i had to rebase https://review.opendev.org/#/c/637316/ because of the great api-removeninig of 2019 in the functional tests so can you re-approve that when you get a chance
19:14:12 dansmith what is a boaring house?
19:14:21 mriedem something that elon musk created
19:14:22 dansmith some sort of pig farming facility?
19:14:50 sean-k-mooney :) you know what i ment
19:15:12 dansmith I don't, but I didn't see whatever he was referring to
19:15:44 sean-k-mooney stephens unicode house 🏠
19:16:17 sean-k-mooney which you proably didnt also see there because i just copy pasted it
19:16:49 dansmith I see the house, I just don't know what a boaring house is..or what a studded paddle has to do with it
19:16:53 dansmith but whatevs
19:17:02 mriedem stephen said he liked the pain,
19:17:08 mriedem i made an S&M joke
19:17:14 mriedem and now we're here
19:17:30 dansmith and a boaring house is like a S&M dungeon?
19:17:54 sean-k-mooney no its just me misspelling boring
19:18:23 dansmith oh
19:18:56 mriedem alternative to me waiting for stephen or the gib in the morning to re-approve, if someone else wants to eyeball PS56 to PS57 here and confirm that the only things i changed are what i called out https://review.opendev.org/#/c/637316/57 i'll re-approve and unblock the other 4 or so approved changes after that in the gate
19:19:21 mriedem since it takes a couple of days to merge code i'd like to start the recheck bus now
19:20:59 dansmith 57 was just changes due to rebase?
19:21:05 mriedem yes
19:21:17 sean-k-mooney im looking at it now so far it looks identical
19:21:43 mriedem caused by this https://review.opendev.org/#/c/697694/1
19:22:36 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.opendev.org/698531
19:22:36 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Add --instance option to heal_allocations https://review.opendev.org/698529
19:24:37 sean-k-mooney mriedem: ya so i dont see any change other then the ones you noted
19:24:57 mriedem ack thanks sean-k-mooney and dansmith
19:25:12 mriedem bottom 6 cross-cell changes are on their way which is nice
19:25:51 sean-k-mooney yep it is
19:27:07 sean-k-mooney ok im goign to get dinner and likely call it a day. o/
19:28:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Do not reschedule on ExternalNetworkAttachForbidden https://review.opendev.org/694179
19:30:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Create instance action when burying in cell0 https://review.opendev.org/694165
19:38:35 efried sean-k-mooney: I'll try to get to it in the next couple hours.
19:38:47 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add NodeOwnerFilter https://review.opendev.org/697331
19:44:14 mriedem dansmith: in order to avoid a compute service version check workaround thing, what do you think about just checking for vcenter here in U and remove in V? https://review.opendev.org/#/c/695220/3/nova/compute/api.py@3881
19:44:44 dansmith mriedem: seriously?
19:44:45 mriedem won't work for any out of tree cluster driver that supports same-host cold migration but....so what?
19:45:10 mriedem well, what's the alternative? get the compute service version and if old, fallback to existing behavior?
19:45:17 mriedem that was my original thought
19:45:32 dansmith I definitely don't want to start a trend of putting virt-specific hacks into upper layers
19:45:57 mriedem ok so do what i have documented there as the todo
19:46:07 mriedem check service versoin, if old fallback to use the config
19:46:10 mriedem remove that in V
19:46:15 dansmith yes
19:46:18 mriedem alright then
19:46:35 dansmith as you should
19:47:03 dansmith let it be remembered for all time, the last thing mriedem tried to do was an api-level hack for vmware
19:47:14 dansmith can you self paddle?
19:47:21 mriedem can a bear shit in the woods?
19:47:26 dansmith heh
19:47:26 dansmith nevermind, don't answer
20:00:33 sean-k-mooney hehe if only this was archive publicly for al time
20:00:44 sean-k-mooney *all

Earlier   Later