Posted	Nick	Remark
#openstack-nova - 2019-12-12
00:50:06	efried	o/
00:55:42	melwitt	TheJulia: around?
01:05:26	mriedem	efried: fwiw reading scrollback, the libvirt driver does check task_state to flatten rbd images while unshelving i think
01:06:18	mriedem	https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L9246
01:06:56	mriedem	efried: also btw, immediate shelve offload is the default behavior and there is a context
01:07:09	mriedem	the periodic or shelveOffload api only kick in if you've configured the computes to not immediately offload
01:07:21	mriedem	https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.shelved_poll_interval
01:07:57	openstackgerrit	Eric Xie proposed openstack/nova master: Report trait 'COMPUTE_IMAGE_TYPE_PLOOP' https://review.opendev.org/698132
01:08:05	mriedem	dansmith: btw, "because, for example, shelve is used under the covers for cross-cell-migration" is not true - it was for the original poc, but not what i have now
01:08:12	mriedem	parts are similar though
01:09:19	dansmith	mriedem: well, yeah, sorry I'm collapsing shelve-like snapshot behavior into it
01:09:50	dansmith	mriedem: and the task_state check down in the rbd stuff is just a total hack, I hope you'd agree
01:10:00	dansmith	because of the layers of plumbing that would be required
01:10:05	mriedem	it is
01:11:09	mriedem	we're the ones that approved it too :)
01:11:25	dansmith	mriedem: given that a snapshot for migration would be very shelve-like, but a task-state check for shelving to save the tpm would be the exact kind of guessing the virt driver shouldn't be doing because composite operations on top of the primitives can't rely on predictable behavior
01:12:20	mriedem	yup, case in point https://review.opendev.org/#/c/691991/
01:12:24	dansmith	very shelve-like, meaning it would *need* to store the tpm, but wouldn't if the task_state wasn't shelving, so migrations that happened to cross cells would end up with an empty tpm
01:12:28	dansmith	which is exactly my point
01:12:45	dansmith	ha yeah
01:13:57	dansmith	this marks my 12th hour behind the keyboard today
01:24:28	mriedem	dansmith: for tomorrow - a compute rpc api method that didn't return anything but now does - version bump? i would think so at least for the behavior change.
01:33:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: DNM: debug cross-cell resize https://review.opendev.org/698304
01:48:09	openstackgerrit	sean mooney proposed openstack/nova master: Sync ImageMetaPropsPayload fields https://review.opendev.org/698613
01:50:28	sean-k-mooney	gibi: efried ^ wanted to get that done before i went to sleep there are only 3 fields that were missing
01:50:44	sean-k-mooney	anyway night o/
02:30:22	pmatulis	when implementing a policy override does one need to place /etc/nova/policy.json on just a single compute node?
02:45:49	melwitt	pmatulis: not the compute node, the controller (where nova-api process is running)
02:46:05	melwitt	policies are an api thing
02:48:00	pmatulis	melwitt, ah ha right
02:54:13	pmatulis	melwitt, this works but do you see anything wrong with it?
02:54:17	pmatulis	https://paste.ubuntu.com/p/jcq7znKczd/
02:54:33	pmatulis	i left the default as a comment
02:56:09	melwitt	pmatulis: I think you can't have a comment in a json file (but you said it works?). the new entry looks fine to me
02:57:37	pmatulis	melwitt, yeah works :)
02:58:04	melwitt	kewl
03:15:42	pmatulis	melwitt, so this is odd. i removed /etc/nova/policy.json (it did not exist prior) and now i get error (log: "...stacktrace...cannot find policy.json). i put it back and error goes away
03:16:09	pmatulis	confirm i can just drop a file in w/o stopping the service?
03:16:57	melwitt	pmatulis: yeah, it shouldn't need it (all defaults are in the code). I would have thought you could drop it without restarting the service but I haven't tried it before. did you have to restart for it to notice it when you added it or no?
03:17:13	melwitt	when you added it the first time I mean
03:19:03	pmatulis	melwitt, no, i did not
03:19:16	pmatulis	i read that it wasn't necessary
03:20:56	melwitt	yeah, I do know it tries to read the file each policy check (if it is there) and you are meant to be able to change it on the fly
03:21:34	melwitt	I don't know why it would error when you remove it. if you pastebin the stacktrace we can at least see where in the code it fails
03:22:29	openstackgerrit	Guo Jingyu proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure https://review.opendev.org/661466
03:38:09	pmatulis	melwitt, http://paste.ubuntu.com/p/YBVThgRWDh/
03:46:17	melwitt	ah, built in caching in oslo.policy https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L548. guess we have a bug, need to handle that somehow in nova
03:46:34	melwitt	I didn't find a bug already open for this
03:53:53	openstack	Launchpad bug 1856119 in OpenStack Compute (nova) "FileNotFoundError: [Errno 2] No such file or directory: '/etc/nova/policy.json' when policy file removed" [Undecided,New]
03:53:53	melwitt	opened this https://bugs.launchpad.net/nova/+bug/1856119
03:54:12	pmatulis	sweet
08:10:59	gibi	sean-k-mooney: attaching ports with resource request is still not supported. https://docs.openstack.org/api-guide/compute/port_with_resource_request.html
08:12:35	gibi	sean-k-mooney: for ussuri on my todolist in priority order: live migration, unshelve, cross cell resize and saying something about heal port allocation CLI usage on Stein with train nova-manage in a venv
08:12:52	gibi	sean-k-mooney: so no, I don't have port attach on my ussuri TODO list
08:32:59	brinzhang_	gibi: hello, do you know this spec http://specs.openstack.org/openstack/nova-specs/specs/train/approved/numa-aware-live-migration.html
08:35:27	brinzhang_	gibi: I have a question, if the destination server's NUMA topology (e.g. nume_node=2) < source server's NUMA topology (e.g. numa_noed=4) in a instance. If I am living *this* instance, what will be happend?
08:36:57	brinzhang_	gibi: Context in "Proposed change" the "Third" aspect. "Third, information about the instance’s new NUMA characteristics needs to be generated on the destination (an InstanceNUMATopolgy object is not enough, more on that later)"
08:41:27	brinzhang_	And efried completed it's status in Train release. notartom works on it.
09:13:26	openstackgerrit	Lee Yarwood proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
09:40:13	stephenfin	gibi: Morning o/ I've a couple of functional test rework patches here you might be interested in, if you have some free time today https://review.opendev.org/#/c/689181/
09:48:38	openstackgerrit	Stephen Finucane proposed openstack/nova master: functional: Add unified '_(build|create)_flavor' helper functions https://review.opendev.org/697538
09:48:39	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP: functional: Add '_create_server' helper https://review.opendev.org/697540
09:48:39	openstackgerrit	Stephen Finucane proposed openstack/nova master: functional: Add '_delete_server' to 'InstanceHelperMixin' https://review.opendev.org/697539
10:13:27	openstackgerrit	Merged openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070
10:29:08	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused 'stub_out_db_network_api' https://review.opendev.org/697151
10:29:09	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining unit tests to neutron https://review.opendev.org/696510
10:29:09	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove db methods for ProviderMethod https://review.opendev.org/697150
10:29:10	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove nova-network security group driver https://review.opendev.org/696512
10:29:10	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function https://review.opendev.org/696511
10:29:11	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove firewall support https://review.opendev.org/696514
10:29:11	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Correct some broken VIF tests https://review.opendev.org/696513
10:29:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove final references to nova-network https://review.opendev.org/696516
10:29:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Copy shared utils from nova-net module https://review.opendev.org/696515
10:29:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs to remove security group-related objects https://review.opendev.org/696517
10:29:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove 'MetadataManager' https://review.opendev.org/696748
10:29:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Kill it https://review.opendev.org/696518
10:29:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove dependency on nova-net from fake cache https://review.opendev.org/696749
10:29:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776
10:29:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove unused exceptions https://review.opendev.org/697149
10:29:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Rename 'nova.network.neutronv2' -> 'nova.network' https://review.opendev.org/696745
10:29:17	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152
10:29:17	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746
10:29:18	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154
10:29:18	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153
11:16:39	gibi	stephenfin: ack, added to my queue
11:56:22	openstackgerrit	Stephen Finucane proposed openstack/nova master: trivial: Remove dead code https://review.opendev.org/698703
11:56:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: db: Drop snapshots table https://review.opendev.org/698705
11:56:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: db: Drop cells v1 tables https://review.opendev.org/698704
11:56:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: db: Remove placement tables https://review.opendev.org/698707
11:56:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: db: Drop tables that were moved to API DB https://review.opendev.org/698706
12:28:32	sean-k-mooney	gibi: ok good to know. i need to work on a bug with attch port for numa aware vswitchs
12:30:02	sean-k-mooney	gibi: being able to attach an sriov port has been a long standing desire, when i fix the numa awareness checking i might look into sriov and port request since they both would have to check and claim resouces although that will have to wait till febuary for me to figure out.
12:30:49	sean-k-mooney	im planning on spending january finishing the image metatdata prefilter and working on ci so i wont be starting anything new in january
12:36:05	gibi	sean-k-mooney: ack. if you happen to start port request part of the interface attach, then let me know and I will try to keep a close eye on that commit
12:36:38	sean-k-mooney	well i dont want anything i do to conflcit with your work
12:37:21	sean-k-mooney	but if im working on the attachment code anyway ill take a look and see how invovled it would be to do
12:43:07	gibi	sean-k-mooney: sthanks
13:11:31	openstackgerrit	Merged openstack/nova master: functional: Unify '_wait_until_deleted' implementations https://review.opendev.org/689181
13:11:37	openstackgerrit	Merged openstack/nova master: functional: Unify '_build_minimal_create_server_request' implementations https://review.opendev.org/695024
13:17:05	openstackgerrit	Merged openstack/nova master: functional: Remove 'get_invalid_image' https://review.opendev.org/697454

Earlier   Later