Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-09
17:24:54 kashyap efried: BTW, 'virtio-serial' is a not-so-stellar-but-works-alright thing that exposes a character dev for simple I/O between host and guest.
17:25:01 openstackgerrit Merged openstack/nova stable/stein: Do not update root_device_name during guest config https://review.opendev.org/696351
17:25:08 efried gmann, dansmith, mriedem, Sundar: I think that's ready now --^
17:25:08 kashyap efried: Nah, you're being your diligent self
17:25:16 efried kashyap: I was making table tennis jokes
17:25:31 kashyap efried: I'm being a dense potatoe
17:26:46 kashyap sean-k-mooney: Ah, I already see you made the correction of generic "virtio controller" --> "virtio serial controller"
17:27:19 sean-k-mooney yes since there are lots of virt controllers :)
17:28:06 kashyap s/going/is going/
17:32:22 kashyap efried: Yes, the reason for the change makse sense to me, FWIW. And I know the "IOMMU" driver being a requirement for SEV. (From its Nova spec)
17:32:59 kashyap (I'll let sean-k-mooney to take a deeper look, as he also was looking at it before.)
17:33:57 sean-k-mooney i have reviewd the bottm two patchs almost done with the final one
17:34:53 openstackgerrit Merged openstack/os-traits master: Add COMPUTE_SAME_HOST_COLD_MIGRATE trait https://review.opendev.org/666604
17:37:27 stephenfin artom: loads of comments left on that
17:38:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
17:38:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
17:38:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
17:38:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
17:38:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
17:38:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Flesh out RevertResizeTask.rollback https://review.opendev.org/695334
17:38:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046
17:38:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
17:38:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
17:38:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268
17:38:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335
17:38:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
17:38:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650
17:38:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
17:38:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec https://review.opendev.org/695336
17:38:42 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: flatten rbd image during cross-cell move spawn at dest https://review.opendev.org/691991
17:38:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
17:38:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
17:38:49 mriedem oh gdi that wasn't meant to be a full rebase
17:38:55 mriedem but now that it is, i might as well do a full rebase on master
17:40:27 sean-k-mooney efried: +1 on the qemu guest agent series
17:40:55 efried thanks sean-k-mooney. I'll send it to the gate.
17:41:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070
17:41:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
17:41:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Follow up to I5b9d41ef34385689d8da9b3962a1eac759eddf6a https://review.opendev.org/698028
17:41:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
17:41:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
17:41:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
17:41:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
17:41:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Flesh out RevertResizeTask.rollback https://review.opendev.org/695334
17:41:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046
17:41:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
17:41:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
17:41:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268
17:41:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335
17:41:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
17:41:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650
17:41:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
17:41:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec https://review.opendev.org/695336
17:41:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
17:46:53 artom stephenfin, thanks!
17:47:00 openstackgerrit Vladyslav Drok proposed openstack/nova master: Minor improvements to cell commands https://review.opendev.org/698053
17:52:53 openstackgerrit Eric Fried proposed openstack/nova master: Nix os-server-external-events 404 condition https://review.opendev.org/698037
17:53:19 efried gmann, mriedem: done ^
18:05:19 efried stephenfin: are you working your way up to https://review.opendev.org/#/c/696992/ eventually? (aka: "would you please, and thank you?")
18:09:17 openstackgerrit sean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild https://review.opendev.org/689861
18:09:34 openstackgerrit sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072
18:10:37 sean-k-mooney efried: do you have time this week to review https://review.opendev.org/#/c/687957/11 and the two patches that follow. i would like to get those merged before i go on PTO
18:10:53 efried is that the numa affinity thing?
18:11:30 sean-k-mooney the frist two are rebuild of numa instance and the last is the numa affinity policy thing
18:12:20 sean-k-mooney so those 3 patch fix 2 bugs and close two blueprints/specs
18:12:47 openstackgerrit Merged openstack/nova master: Fup for I63c1109dcdb9132cdbc41010654c5fdb31a4fe31 https://review.opendev.org/697678
18:13:20 sean-k-mooney efried: also i think you just missed stephenfin. he was just heading home for the day
18:13:32 openstackgerrit Eric Fried proposed openstack/nova master: FUP: Remove noqa and tone down an exception https://review.opendev.org/698054
18:14:17 efried ack.
18:14:23 efried I'll look at those now sean-k-mooney...
18:24:56 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
18:25:59 mnaser has anyone seen any race conditions in starting up instances in stein? :X
18:26:33 openstackgerrit Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040
18:27:19 mnaser https://www.irccloud.com/pastebin/8hYnM4Lx/
18:27:40 mnaser i mean this is a grep on the instance uuid but the instance destroyed successfully twice 15 seconds apart?
18:36:58 sean-k-mooney it could be an interaction with the periodic task and the actul instnace action that tried to showdown the instance
18:37:23 sean-k-mooney mnaser: but no i have not seen that specifically
18:37:53 mnaser sean-k-mooney: well instance destroyed successfully is called by `_wait_for_destroy`
18:38:02 mnaser https://github.com/openstack/nova/blob/stable/stein/nova/virt/libvirt/driver.py#L1023-L1025
18:38:23 mnaser which has the timer here https://github.com/openstack/nova/blob/stable/stein/nova/virt/libvirt/driver.py#L1038-L1039
18:38:55 mnaser which is `_destroy()`
18:39:45 mnaser hmm, we dont have a 'powering-off' state in nova do we
18:40:19 mnaser we do
18:41:27 mnaser task state gets updated inside nova.compute.api -- does that mean that technically there could be 2 concurrent api requests?
18:42:06 sean-k-mooney you can have two concurrent request to destroy yes at the api level
18:42:27 sean-k-mooney but the window would be quite short
18:42:27 mnaser so i guess in that case if two api requests came at the same time, we can end up with two requests in the compute level
18:42:52 sean-k-mooney yes
18:43:32 sean-k-mooney although we normaly do a check of the taskstate wehn ever we updat it so one would fail
18:49:57 mordred mriedem, efried: sdk release was cut including your ironic fix
18:51:05 efried ack, thx
18:51:08 mnaser sean-k-mooney: _record_action_start is called, ill check logs
18:54:09 efried sean-k-mooney: theoretically...
18:54:17 efried if a rebuild is done with the same image...
18:54:36 efried couldn't I have changed the metadata on that image since my instance was originally booted?
18:57:21 mnaser sean-k-mooney: sigh, i wonder if we call _destroy before starting up an instance which is why it says "Instance destroyed successfully."
18:58:02 mnaser sean-k-mooney: yes thats exactly what happens, we call destroy for power on because we call hard reboot
19:05:12 dustinc [1] https://blueprints.launchpad.net/nova/+spec/provider-config-file
19:05:12 dustinc disable the entire feature by default instead
19:05:12 dustinc dansmith: I was working on docs/etc for [1] and was thinking that it might be a good idea to have a master on/off switch for the feature with a default of off...the reason I was thinking that is because as it is specced right now, the directory is the only config option and a cautious operator would probably want to make sure the default directory is present with permissions set..it would maybe be easier to just

Earlier   Later