Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-05
07:08:40 eandersson Because the database is not yet updated to reflect the compute hosting the instance (or at least it's not easy, or obvious to find the compute without digging deep into the database)
07:09:16 eandersson I am still baffled on why so many RabbitMQ Clusters broke within a short period of time. Seems to be caused by some sort of memory leak on one of the RabbitMQ servers.
07:10:44 eandersson But we also saw it happen on one cluster after a network partition.
07:12:46 eandersson The only thing we could really find on RabbitMQ was messages stuck un'acked (even without consumers), but unsure if that was just a display issue.
08:11:14 openstackgerrit Luyao Zhong proposed openstack/nova-specs master: support live migration with virtual persistent memory https://review.opendev.org/695863
08:20:57 openstackgerrit Luyao Zhong proposed openstack/nova-specs master: support live migration with virtual persistent memory https://review.opendev.org/695863
10:08:54 stephenfin bauzas: Can you send this on its way? https://review.opendev.org/#/c/665518/
10:09:14 bauzas stephenfin: sure
10:10:13 stephenfin Thanks
10:14:29 bauzas stephenfin: any chance to add a new tox target that would wrap pre-commit ?
10:14:55 stephenfin I could, but it doesn't really make sense. They're really different tools
10:15:50 stephenfin pre-commit "installs" things by cloning git repos and creating its own venv. It wouldn't benefit from tox
10:16:05 zbr_ stephenfin: it makes a lot of sense, haptics being one of them
10:16:17 stephenfin haptics?
10:16:26 zbr_ yeah, or habbits
10:16:44 zbr_ most devs are used to call "tox -e linters", as most projects in opestack have them.
10:16:46 bauzas stephenfin: i have to admit I'm new to pre-commit, but I'll give it a try
10:17:09 stephenfin zbr_: to be clear, this doesn't replace that - you can still call that
10:17:12 bauzas stephenfin: that said, I'm maybe a bit torn about saying we *could* deprecate fast8
10:17:16 zbr_ mainly you change how we orchestrate linters without changing the user interface
10:17:17 stephenfin all that pre-commit adds is a way to call it automatically
10:17:27 zbr_ tox -> linters -> pre-commit -> ....
10:17:42 stephenfin no, it's more like
10:17:47 zbr_ mainly the only dependency listed in linters environment of tox would be "pre-commit"
10:17:49 stephenfin tox -> flake8 (hacking)
10:17:58 stephenfin pre-commit -> flake8 (hacking)
10:18:07 stephenfin it's two different ways to achieve the same end goal
10:18:13 bauzas stephenfin: anyway, sent to the gate
10:18:19 stephenfin bauzas: ta
10:18:28 zbr_ so you adopt the tool without changing how user is calling it, and more important without asking them to install a new tool.
10:18:39 zbr_ just having python and tox is usually enough
10:19:10 stephenfin I have flake8 integrated into my editor because it makes my life easier
10:19:16 stephenfin but I don't force people to do the same
10:19:19 stephenfin ditto for pre-commit
10:19:32 stephenfin so long as flake8 is passing, I don't care how people check things
10:19:45 stephenfin pre-commit is just another way to do that check
10:20:15 stephenfin on top of 'tox -e pep8', 'tox -e flake8', random editor integration, etc.
10:20:48 zbr_ stephenfin: yeah, another way. who said you would loose ability to use flake8 in your editor
10:21:17 stephenfin no one did
10:21:29 zbr_ huh.... :D
10:21:43 stephenfin I don't get the point?
10:22:21 zbr_ I was explaining why I find useful to call pre-commit from tox, also makes very easy to integrate with zuul, without gaving to add any extra configs.
10:24:07 zbr_ in fact tox itself is doing it, https://github.com/tox-dev/tox/blob/master/tox.ini#L68-L70
10:24:55 stephenfin could be one to do in the future so, once it's bedded in
10:25:13 stephenfin for now though, I've had a hard enough time getting _something_ in that I'll take the win I have and be happy with it :)
10:26:12 zbr_ stephenfin: i empathise with your pain... i know exactly what you mean.
10:29:53 openstackgerrit Eric Xie proposed openstack/nova master: Host CPU compatibility check does not make sense on AArch64; skip CPU comparison https://review.opendev.org/589769
10:48:29 openstackgerrit Eric Xie proposed openstack/nova master: Skip cpu comparison on AArch64 https://review.opendev.org/589769
11:07:29 sean-k-mooney zbr_: for what its worth i still dont know of any project that i have worked on that has tox -e linters
11:09:57 sean-k-mooney zbr_: i may have but if i did i was not aware of it. its not part of the pti https://github.com/openstack/governance/tree/master/reference/pti so its not require for project to implement and you are the first person who has raised it as a thing
11:10:33 sean-k-mooney most project i was aware of if they ran addtional linters added them to the pep8 tox enve
11:11:00 zbr_ sean-k-mooney: http://codesearch.openstack.org/?q=testenv%3Alinters&i=nope&files=tox.ini&repos= reports 201 repos, and is one of the few officially supported environments: https://docs.openstack.org/infra/openstack-zuul-jobs/jobs.html#job-openstack-tox-linters
11:11:01 sean-k-mooney i belive neutron still adds extra linters to there pep8 tox env
11:11:27 zbr_ mainly is seen as a replacement for the older pep8
11:11:58 zbr_ sean-k-mooney: that's a perfect alternative, mainly is the same, just a different name to avoid confusions.
11:12:10 zbr_ i used pep8 too in several places, for convenience.
11:12:29 zbr_ even if is wasn't really pep8, it was flake8 + 10 others inside.
11:13:42 sean-k-mooney looking at that is mainly openstack ansible and windmil + some test projects
11:13:57 zbr_ on at least one project I made an "alias" to point pep8 -> linters, just to keep it working for the user. i hate to force people to change habits, especially good ones.
11:14:02 sean-k-mooney non of the core project or service project actully use linters which is why im not familar with it
11:14:15 zigo eandersson: What package do you need to be updated in Debian?
11:14:52 zbr_ sean-k-mooney: if you have pep8, keep using it and just document its more broad goal.
11:14:57 sean-k-mooney zbr_: sure im not really against tox -e linters
11:17:02 zbr_ sean-k-mooney: in fact I was considering altering the zuul jobs to introspect tox file and to run whatever they find linters or pep8. If I do this it would be much easier to projects to migrate to the more generic one. Now is almost impossible to remove openstack-tox-pep8 job as is deep inside defaults.
11:17:44 sean-k-mooney its just 200 project repos which is about 50% openstack stack ansible does not mean its a common practice in openstack when we have thoasands of repos in opendev orgs
11:17:47 zbr_ i already talked with infra about this about but i did not had time to go into action yet.
11:17:59 zbr_ true
11:18:17 sean-k-mooney zbr_: to do that you would need to modify the project testing interface
11:18:23 sean-k-mooney which require a tc vote
11:18:55 zbr_ that is why i was considering the smart linter idea, because it could allow people to adopt newer method without breaking existing users.
11:19:03 sean-k-mooney zbr_: no
11:19:14 sean-k-mooney that would be still a violation of the testing interface
11:19:33 sean-k-mooney if you want to change it then you shoudl propose a governace motion via a patch
11:20:05 zbr_ i know, but before working on such a change i wanted to get some feedback.
11:20:43 sean-k-mooney min would be we should keep pep8 and have an optional seperate linters target
11:20:49 sean-k-mooney *mine
11:21:07 zbr_ we already have this, probably is more than an year old
11:21:11 sean-k-mooney exitsting project that run addtionall linters in pep8 shoudl move them
11:21:16 sean-k-mooney to the linter target
11:53:13 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations https://review.opendev.org/689181
11:53:14 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Make '_IntegratedTestBase' subclass 'InstanceHelperMixin' https://review.opendev.org/689182
11:53:14 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Unify '_build_minimal_create_server_request' implementations https://review.opendev.org/695024
11:58:48 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Remove 'get_invalid_image' https://review.opendev.org/697454
12:00:04 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Unify '_build_minimal_create_server_request' implementations https://review.opendev.org/695024
12:00:04 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations https://review.opendev.org/689181
12:00:05 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Remove 'get_invalid_image' https://review.opendev.org/697454
12:00:05 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Make '_IntegratedTestBase' subclass 'InstanceHelperMixin' https://review.opendev.org/689182
12:26:59 openstackgerrit Merged openstack/nova master: Integrate 'pre-commit' https://review.opendev.org/665518
14:02:55 openstackgerrit Matt Riedemann proposed openstack/nova stable/train: Cache security group driver https://review.opendev.org/697475
14:09:05 shilpasd mriedem: requesting to review 'https://review.opendev.org/#/c/612626/
14:09:48 openstackgerrit sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072
14:10:03 shilpasd bauzas: requesting you to review 'https://review.opendev.org/#/c/650188/8 Allow compute nodes to use DISK_GB from shared storage RP' as per your priorities
14:10:13 bauzas shilpasd: ack
14:10:26 shilpasd bauzas: thank you
14:11:09 shilpasd @nova core: please review 'https://review.opendev.org/#/c/650188/8 Allow compute nodes to use DISK_GB from shared storage RP'
14:17:22 stephenfin Is anyone else seeing this message when running 'tox -e py36 ' http://paste.openstack.org/show/787167/ ?
14:19:46 mnaser eandersson: im just about ready to give up on rabbit clusters
14:24:29 mriedem shilpasd: comments on https://review.opendev.org/#/c/694462/
14:25:15 shilpasd mriedem: thank you for review, will work on them
14:25:36 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Cache security group driver https://review.opendev.org/697480

Earlier   Later