| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-30 | |||
| 16:57:10 | openstackgerrit | Merged openstack/nova master: nova-net: Remove references to nova-net service from tests https://review.opendev.org/686818 | |
| 16:57:15 | openstackgerrit | Merged openstack/nova master: docs: Blast final references to nova-network https://review.opendev.org/696498 | |
| 16:57:23 | openstackgerrit | Merged openstack/nova master: nova-net: Remove final references to nova-net from functional tests https://review.opendev.org/696499 | |
| 18:13:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Rename 'nova.network.security_group.neutron_driver' -> 'nova.network.security_group' https://review.opendev.org/696746 | |
| 18:13:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776 | |
| 19:16:46 | openstackgerrit | Merged openstack/nova stable/stein: Add --instance option to heal_allocations https://review.opendev.org/693200 | |
| 19:16:52 | openstackgerrit | Merged openstack/nova stable/stein: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.opendev.org/693201 | |
| 19:16:58 | openstackgerrit | Merged openstack/nova stable/rocky: Nova compute: add in log exception to help debug failures https://review.opendev.org/693009 | |
| 20:13:58 | openstackgerrit | Merged openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | |
| 20:14:05 | openstackgerrit | Merged openstack/nova master: libvirt: Remove 'enable_hairpin' https://review.opendev.org/696500 | |
| 22:30:09 | openstackgerrit | Merged openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | |
| #openstack-nova - 2019-12-01 | |||
| 00:51:52 | openstackgerrit | Merged openstack/nova master: libvirt: Remove vestigial nova-network support https://review.opendev.org/696501 | |
| 00:51:58 | openstackgerrit | Merged openstack/nova master: hyperv: Remove vestigial nova-network support https://review.opendev.org/696502 | |
| 02:04:57 | eandersson | mriedem https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2075 | |
| 02:05:15 | eandersson | This code path can also raise an Eventlet Timeout exception | |
| 02:05:29 | eandersson | Which wouldn't be caught and leads to a UnboundLocalError | |
| 02:06:22 | eandersson | Since eventlet.Timeout is based on BaseException and not Exception. | |
| 02:07:00 | eandersson | http://paste.openstack.org/show/786939/ | |
| 02:08:59 | eandersson | Probably almost impossible to hit that timeout, but still :p | |
| 06:17:55 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717 | |
| 07:50:08 | openstackgerrit | Adit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found https://review.opendev.org/679247 | |
| #openstack-nova - 2019-12-02 | |||
| 09:10:02 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Use virDomainBlockCopy to swap volumes with >= 5.10.0 https://review.opendev.org/696834 | |
| 09:59:06 | openstackgerrit | Dirk Mueller proposed openstack/nova master: Remove rootwrap filters for nova network https://review.opendev.org/696844 | |
| 10:11:41 | openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP:Drop unreliable host_aggregate_map https://review.opendev.org/696851 | |
| 10:36:16 | openstackgerrit | Guo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120 | |
| 11:12:56 | stephenfin | sean-k-mooney: Hit https://review.opendev.org/#/c/689861/ and it's predecessor, FYI. Sorry for the delay | |
| 11:46:27 | sean-k-mooney | ah cool ill address the comments on that today | |
| 11:46:31 | sean-k-mooney | thanks | |
| 11:48:39 | sean-k-mooney | stephenfin: by the way you realise that i did the test refactor before you started yours right. and that i cant depend you your refactor because i need to backport this which is why i orginally asked you to base your refactor on top of that series | |
| 11:49:26 | sean-k-mooney | i can drop the new base class and go back to the other _wait_for_state_chage but i can use any of your refactoring or ill have to undo all of it when i backport | |
| 12:00:00 | sean-k-mooney | * i can't use | |
| 12:31:23 | stephenfin | sean-k-mooney: Yup, but I don't think it's a massive deal that '_wait_for_state_change' behaves oddly on stable branches, given that there's plenty of tests using it | |
| 12:33:47 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/682523 | |
| 12:33:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Rename _is_storage_shared_with to _is_path_shared_with https://review.opendev.org/693337 | |
| 12:39:44 | sean-k-mooney | stephenfin: ya im using the fake notifier too so i can also use the notifer to wait for the completeion events too so its fine ill rework them later today | |
| 12:49:34 | sean-k-mooney | gibi: johnthetubaguy do either of ye feel comfrotable reviewing pci code | |
| 12:59:45 | stephenfin | sean-k-mooney: Can I say no to that? ^ :P | |
| 13:07:31 | sean-k-mooney | you can but you already reviewed the patch and said yes :) | |
| 13:07:50 | sean-k-mooney | also i said comfortabley not do you like reviewing pci stuff :) | |
| 13:11:03 | sean-k-mooney | i also feel like i missed a chance to use "no take backsies" but that might date me a little | |
| 13:14:38 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Add 'TYPE_PLOOP' image type. https://review.opendev.org/696435 | |
| 13:15:17 | efried | stephenfin: I fixed that link ^ -- do you want to confirm real quick before I send it? | |
| 13:24:21 | sean-k-mooney | the ploop image type is only used by parallel/openvz containers rights | |
| 13:25:10 | efried | No idea, but it's on the list, so we should have a trait for it. | |
| 13:25:41 | efried | (and by "no idea", I mean your sentence has at least three words I don't know) | |
| 13:25:42 | sean-k-mooney | ya it is https://wiki.openvz.org/Ploop/format | |
| 13:26:04 | sean-k-mooney | and yes we should have a trait for it | |
| 13:26:18 | efried | sounds like a euphemism for a particular type of turd to me <shrug> | |
| 13:28:07 | openstackgerrit | Eric Fried proposed openstack/nova master: Reusable RequestGroup.add_{resource|trait} https://review.opendev.org/696380 | |
| 13:28:07 | openstackgerrit | Eric Fried proposed openstack/nova master: Process requested_resources in ResourceRequest init https://review.opendev.org/696354 | |
| 13:28:08 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use string suffixes and provider mappings https://review.opendev.org/696418 | |
| 13:28:16 | efried | stephenfin, gibi: fixed the unit test on the bottom one ^ | |
| 13:34:26 | openstackgerrit | Merged openstack/os-traits master: Add 'TYPE_PLOOP' image type. https://review.opendev.org/696435 | |
| 14:23:17 | gibi | efried: I'm +2 on the bottom patch | |
| 14:23:25 | efried | thanks gibi | |
| 14:23:34 | gibi | thanks for starting this work | |
| 14:23:42 | gibi | you are solving some of my todos :) | |
| 14:23:47 | efried | does the strategy seem sane to you wrt the requester_id <=> group ID? | |
| 14:24:12 | gibi | efried: yeah, that step is what I had in my mind | |
| 14:24:17 | efried | great | |
| 14:25:30 | gibi | efried: I'm a bit affraid the replacement of fill_provider_mapping with the mapping from the a_c response. Theortically it should work I just hope there will not be too much complication | |
| 14:25:42 | efried | we'll see :) | |
| 14:26:03 | efried | gibi: I think the most complicated bit might be revert_resize | |
| 14:26:12 | gibi | yes, that is the type of surgery that better do that plan | |
| 14:26:19 | efried | By that time the original mappings might be long gone | |
| 14:26:33 | efried | ...unless we persist them in the RequestSpec...? | |
| 14:26:49 | gibi | efried: in case of revert_resize we can either start using multiple port binding for resize which is hard but nice, or persist the mapping somewhere | |
| 14:27:01 | gibi | if we go to the later then I would persist it to the Migration object | |
| 14:27:29 | gibi | as the migration object has the proper lifecycle for this type of data | |
| 14:27:37 | gibi | the RequestSpec lives longer | |
| 14:41:25 | sean-k-mooney | gibi: i would like to move to useing multiple port bindings for resize for what its worth | |
| 14:41:38 | sean-k-mooney | gibi: we will be using it for cross cell resize | |
| 14:41:58 | sean-k-mooney | so i think it makes sense to just use it always for resize/cold migrate | |
| 14:46:02 | sean-k-mooney | efried: gibi when ye have time could yet take a look at https://review.opendev.org/#/c/674072/ and maybe https://review.opendev.org/#/c/695118/ | |
| 14:47:31 | sean-k-mooney | ill be going on vacation in 2 weeks but i have a 4 patches i really want to get merged if i can before i do those are two of them and im resping the other two now | |
| 14:49:56 | efried | stephenfin, lyarwood: thoughts on bug tagging here? https://review.opendev.org/#/c/682594/ | |
| 14:51:41 | efried | sean-k-mooney: that might be a bit out of my bailiwick, but I'll give it a try. | |
| 14:53:01 | stephenfin | looking | |
| 14:53:32 | lyarwood | efried: yeah that's fair, I can also address the nits before we merge this afternoon | |
| 14:53:41 | efried | okay | |
| 14:53:48 | lyarwood | efried: I think I was trying to avoid any suggestion that this was the only fix required here | |
| 14:53:58 | stephenfin | Your call. I could go either way. I'm guessing it was left that way since mriedem has a better albeit not backportable fix | |
| 14:54:04 | stephenfin | yup | |
| 14:54:28 | efried | right, I'm looking at it from the perspective of stable, where if we don't Closes-Bug on this patch, there will never be a "fix". | |
| 14:54:58 | efried | I guess if you really want, we could keep this one Related-Bug and switch it to Closes-Bug on the backports | |
| 14:55:07 | efried | can't believe there's not a precedent for something like this. | |
| 14:56:03 | lyarwood | Yeah not that I recall but I'd be okay with that from a stable point of view | |
| 14:56:15 | lyarwood | related on master, closes on stable that is | |
| 14:56:23 | sean-k-mooney | well does it actully fix the bug | |
| 14:56:30 | sean-k-mooney | or just make it less bad | |
| 14:56:58 | openstack | Launchpad bug 1844296 in OpenStack Compute (nova) "Stale BDM records remain in the DB after n-api to n-cpu RPC timeouts during reserve_block_device_name" [Undecided,In progress] - Assigned to Lee Yarwood (lyarwood) | |
| 14:56:58 | sean-k-mooney | ye are talking about https://bugs.launchpad.net/nova/+bug/1844296 right | |
| 14:57:15 | sean-k-mooney | and this patch https://review.opendev.org/#/c/682594/ | |
| 14:57:25 | lyarwood | sean-k-mooney: yeah, it cleans up after one type of failure, it doesn't stop the failure from happening. | |
| 14:57:38 | sean-k-mooney | ah i see | |
| 14:57:51 | sean-k-mooney | so its treating the symtoms not the cause | |
| 14:58:11 | lyarwood | sean-k-mooney: yeah and very specific symptoms at that. | |
| 14:58:47 | sean-k-mooney | you could make it partial-bug if you plan to try and fix it someother way on master in a follow up patch | |
| 14:59:19 | lyarwood | ah yeah I forgot about partial | |
| 14:59:21 | lyarwood | that might do | |