Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-11-29
17:20:41 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove SG tests that don't apply to neutron https://review.opendev.org/696507
17:20:42 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining unit tests to neutron https://review.opendev.org/696510
17:20:42 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining API tests to use neutron https://review.opendev.org/696509
17:20:43 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove nova-network security group driver https://review.opendev.org/696512
17:20:43 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function https://review.opendev.org/696511
17:20:44 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove firewall support https://review.opendev.org/696514
17:20:44 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Correct some broken VIF tests https://review.opendev.org/696513
17:20:56 stephenfin there we go
17:21:21 stephenfin sean-k-mooney: https://review.opendev.org/#/c/696518/ :)
17:21:43 stephenfin There's something cathartic about those stats: +112, -15960
17:22:20 sean-k-mooney was the title orogint nova-net: kill it :)
17:22:31 sean-k-mooney *orgininally
17:22:35 stephenfin there was also a celebration emoji
17:22:40 sean-k-mooney ah ok
17:22:55 stephenfin damn you, Gerrit
17:23:31 sean-k-mooney so we will still have the neutron code in the nova/network/neutronv2 folder right
17:23:39 sean-k-mooney and some interface files in the folder above
17:23:44 stephenfin https://review.opendev.org/#/c/696745/
17:23:52 stephenfin I'm hoping not
17:24:06 stephenfin but that's way off. It'll be weeks before the CI lets us get that far
17:24:10 sean-k-mooney ok because i would like to move those to os-vif i think
17:24:19 sean-k-mooney but i wanted to see what was left after you were done
17:24:29 stephenfin yeah, we can probably kill nova.network.models next
17:24:34 stephenfin in favour of os-vif stuff
17:24:49 sean-k-mooney maybe but im not sure
17:24:54 sean-k-mooney we put those in teh network info cache
17:24:54 stephenfin but I need to move offices again, so I best go
17:25:01 stephenfin have a good weekend o/
17:25:16 sean-k-mooney we can serailise os-vif object but it would require an db migration
17:25:21 sean-k-mooney enjoy o/
18:28:20 openstackgerrit Merged openstack/nova stable/rocky: Fix false ERROR message at compute restart https://review.opendev.org/694581
18:28:26 openstackgerrit Merged openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181
18:50:13 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-services https://review.opendev.org/645427
19:41:09 openstackgerrit Vlad Gusev proposed openstack/nova stable/queens: Fix false ERROR message at compute restart https://review.opendev.org/696733
20:56:19 openstackgerrit Merged openstack/nova master: Follow up I18d73212f9d98bc75974a024cf6fd872fdfb1ca4 https://review.opendev.org/696740
23:11:28 openstackgerrit Merged openstack/nova stable/train: Reset instance to current vm_state if rolling back in resize_instance https://review.opendev.org/696085
#openstack-nova - 2019-11-30
01:39:32 eandersson When using the openstacksdk why to get a server. Why would flavor_id ever be None?
03:22:46 openstackgerrit Merged openstack/nova stable/queens: Fix false ERROR message at compute restart https://review.opendev.org/696733
04:24:47 openstackgerrit Brin Zhang proposed openstack/nova master: PoC: Support re-configure the delete_on_termination in server https://review.opendev.org/693828
04:47:55 eandersson Do I really need to do this starting with nova 2.47? https://review.opendev.org/#/c/696767/1/senlin/profiles/os/nova/server.py
04:57:37 eandersson I wonder if this has been broken in senlin for 2 years, or if micro version was always set lower or something
06:22:34 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717
11:41:50 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove final references to nova-network https://review.opendev.org/696516
11:41:51 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs to remove security group-related objects https://review.opendev.org/696517
11:41:51 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'MetadataManager' https://review.opendev.org/696748
11:41:52 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Kill it https://review.opendev.org/696518
11:41:52 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove dependency on nova-net from fake cache https://review.opendev.org/696749
11:41:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename 'nova.network.security_group.neutron_driver' -> 'nova.network.security_group' https://review.opendev.org/696746
11:41:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename 'nova.network.neutronv2' -> 'nova.network' https://review.opendev.org/696745
16:04:17 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename 'nova.network.security_group.neutron_driver' -> 'nova.network.security_group' https://review.opendev.org/696746
16:04:17 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename 'nova.network.neutronv2' -> 'nova.network' https://review.opendev.org/696745
16:04:18 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776
16:57:10 openstackgerrit Merged openstack/nova master: nova-net: Remove references to nova-net service from tests https://review.opendev.org/686818
16:57:15 openstackgerrit Merged openstack/nova master: docs: Blast final references to nova-network https://review.opendev.org/696498
16:57:23 openstackgerrit Merged openstack/nova master: nova-net: Remove final references to nova-net from functional tests https://review.opendev.org/696499
18:13:11 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename 'nova.network.security_group.neutron_driver' -> 'nova.network.security_group' https://review.opendev.org/696746
18:13:12 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776
19:16:46 openstackgerrit Merged openstack/nova stable/stein: Add --instance option to heal_allocations https://review.opendev.org/693200
19:16:52 openstackgerrit Merged openstack/nova stable/stein: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.opendev.org/693201
19:16:58 openstackgerrit Merged openstack/nova stable/rocky: Nova compute: add in log exception to help debug failures https://review.opendev.org/693009
20:13:58 openstackgerrit Merged openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
20:14:05 openstackgerrit Merged openstack/nova master: libvirt: Remove 'enable_hairpin' https://review.opendev.org/696500
22:30:09 openstackgerrit Merged openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
#openstack-nova - 2019-12-01
00:51:52 openstackgerrit Merged openstack/nova master: libvirt: Remove vestigial nova-network support https://review.opendev.org/696501
00:51:58 openstackgerrit Merged openstack/nova master: hyperv: Remove vestigial nova-network support https://review.opendev.org/696502
02:04:57 eandersson mriedem https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2075
02:05:15 eandersson This code path can also raise an Eventlet Timeout exception
02:05:29 eandersson Which wouldn't be caught and leads to a UnboundLocalError
02:06:22 eandersson Since eventlet.Timeout is based on BaseException and not Exception.
02:07:00 eandersson http://paste.openstack.org/show/786939/
02:08:59 eandersson Probably almost impossible to hit that timeout, but still :p
06:17:55 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717
07:50:08 openstackgerrit Adit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found https://review.opendev.org/679247
#openstack-nova - 2019-12-02
09:10:02 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP libvirt: Use virDomainBlockCopy to swap volumes with >= 5.10.0 https://review.opendev.org/696834
09:59:06 openstackgerrit Dirk Mueller proposed openstack/nova master: Remove rootwrap filters for nova network https://review.opendev.org/696844
10:11:41 openstackgerrit Guo Jingyu proposed openstack/nova master: WIP:Drop unreliable host_aggregate_map https://review.opendev.org/696851
10:36:16 openstackgerrit Guo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120
11:12:56 stephenfin sean-k-mooney: Hit https://review.opendev.org/#/c/689861/ and it's predecessor, FYI. Sorry for the delay
11:46:27 sean-k-mooney ah cool ill address the comments on that today
11:46:31 sean-k-mooney thanks
11:48:39 sean-k-mooney stephenfin: by the way you realise that i did the test refactor before you started yours right. and that i cant depend you your refactor because i need to backport this which is why i orginally asked you to base your refactor on top of that series
11:49:26 sean-k-mooney i can drop the new base class and go back to the other _wait_for_state_chage but i can use any of your refactoring or ill have to undo all of it when i backport
12:00:00 sean-k-mooney * i can't use
12:31:23 stephenfin sean-k-mooney: Yup, but I don't think it's a massive deal that '_wait_for_state_change' behaves oddly on stable branches, given that there's plenty of tests using it
12:33:47 openstackgerrit Lee Yarwood proposed openstack/nova master: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/682523
12:33:55 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Rename _is_storage_shared_with to _is_path_shared_with https://review.opendev.org/693337
12:39:44 sean-k-mooney stephenfin: ya im using the fake notifier too so i can also use the notifer to wait for the completeion events too so its fine ill rework them later today
12:49:34 sean-k-mooney gibi: johnthetubaguy do either of ye feel comfrotable reviewing pci code
12:59:45 stephenfin sean-k-mooney: Can I say no to that? ^ :P
13:07:31 sean-k-mooney you can but you already reviewed the patch and said yes :)
13:07:50 sean-k-mooney also i said comfortabley not do you like reviewing pci stuff :)
13:11:03 sean-k-mooney i also feel like i missed a chance to use "no take backsies" but that might date me a little
13:14:38 openstackgerrit Eric Fried proposed openstack/os-traits master: Add 'TYPE_PLOOP' image type. https://review.opendev.org/696435
13:15:17 efried stephenfin: I fixed that link ^ -- do you want to confirm real quick before I send it?
13:24:21 sean-k-mooney the ploop image type is only used by parallel/openvz containers rights
13:25:10 efried No idea, but it's on the list, so we should have a trait for it.
13:25:41 efried (and by "no idea", I mean your sentence has at least three words I don't know)
13:25:42 sean-k-mooney ya it is https://wiki.openvz.org/Ploop/format
13:26:04 sean-k-mooney and yes we should have a trait for it
13:26:18 efried sounds like a euphemism for a particular type of turd to me <shrug>

Earlier   Later