Earlier  
Posted Nick Remark
#openstack-nova - 2019-11-28
11:02:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining API tests to use neutron https://review.opendev.org/696509
11:02:13 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove nova-network security group driver https://review.opendev.org/696512
11:02:13 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function https://review.opendev.org/696511
11:02:14 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove firewall support https://review.opendev.org/696514
11:02:14 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Correct some broken VIF tests https://review.opendev.org/696513
11:02:15 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Copy shared utils from nova-net module https://review.opendev.org/696515
11:12:18 Liraz Hi all! I'm trying to implement a custom filter based on instance name for the nova-scheduler and it seems RequestSpec class does not contain any reference to the requested name. Any pointers on getting that name?
11:50:06 sean-k-mooney stephenfin: are we allowed to use the python 3 type info stuff now?
11:50:39 sean-k-mooney e.g. the optional static typing annotations
11:51:22 sean-k-mooney so this https://docs.python.org/3/library/typing.html
11:57:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture https://review.opendev.org/696247
11:57:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings https://review.opendev.org/696246
11:57:31 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make the binding:profile handling consistent in NeutronFixture https://review.opendev.org/696526
11:58:48 gibi stephenfin: there is a small change to fix an old bug https://review.opendev.org/#/c/220622/
11:58:54 gibi stephenfin: melwitt is +@
11:58:56 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905
11:58:57 gibi +2
11:59:12 openstackgerrit Brin Zhang proposed openstack/nova master: WIP: Support re-configure the delete_on_termination in server https://review.opendev.org/693828
12:09:40 stephenfin gibi: yup, done
12:09:46 gibi stephenfin: thanks
12:09:59 stephenfin sean-k-mooney: no, we're gonna give it until M1 at least
12:10:04 stephenfin I think that was the plan, anyway
12:10:15 stephenfin gmann posted to the ML about it
12:10:29 sean-k-mooney oh right but we can start using it in ussuri right
12:10:34 stephenfin yup
12:10:37 sean-k-mooney we dont need to wait to next cycle
12:10:39 sean-k-mooney cool
12:11:26 sean-k-mooney personaly i think that is a better feature then fstrings to start using python 3 only features
12:16:12 openstackgerrit Merged openstack/nova stable/stein: Added openssh-client into bindep https://review.opendev.org/691809
12:24:58 stephenfin git rebase -i master --exec 'tox -e fast8'
12:25:01 stephenfin TIL ^
12:27:00 gibi stephenfin: you might want --reschedule-failed-exec as well
12:27:37 gibi so if you fixed something durin the rebase the command will be re-run before git move to the next change
12:28:39 stephenfin ooh, nifty
12:29:37 gibi rebase.rescheduleFailedExec
12:29:38 gibi :)
12:39:48 openstackgerrit Stephen Finucane proposed openstack/nova master: zvm: Remove vestigial nova-network support https://review.opendev.org/696504
12:39:48 openstackgerrit Stephen Finucane proposed openstack/nova master: vmware: Remove vestigial nova-network support https://review.opendev.org/696503
12:39:49 openstackgerrit Stephen Finucane proposed openstack/nova master: xenapi: Remove vestigial nova-network support https://review.opendev.org/696505
12:39:50 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Drop nova-network-base security group tests https://review.opendev.org/696508
12:39:50 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove SG tests that don't apply to neutron https://review.opendev.org/696507
12:39:50 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Flatten class hierarchy for neutron SG tests https://review.opendev.org/696506
12:39:51 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining unit tests to neutron https://review.opendev.org/696510
12:39:51 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining API tests to use neutron https://review.opendev.org/696509
12:39:52 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove nova-network security group driver https://review.opendev.org/696512
12:39:52 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function https://review.opendev.org/696511
12:39:53 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove firewall support https://review.opendev.org/696514
12:39:53 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Correct some broken VIF tests https://review.opendev.org/696513
12:39:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove final references to nova-network https://review.opendev.org/696516
12:39:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Copy shared utils from nova-net module https://review.opendev.org/696515
12:39:55 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Remove 'nova-network' https://review.opendev.org/696518
12:39:55 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add TODOs to remove security group-related objects https://review.opendev.org/696517
12:47:52 openstackgerrit Stephen Finucane proposed openstack/nova master: Keep pre-commit inline with hacking and fix whitespace https://review.opendev.org/674057
12:47:52 openstackgerrit Stephen Finucane proposed openstack/nova master: Integrate 'pre-commit' https://review.opendev.org/665518
13:15:05 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move _get_request_group_mapping() to RequestSpec https://review.opendev.org/696541
13:33:14 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Join migration_context and flavor in Migration.instance https://review.opendev.org/696572
13:40:32 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove vestigial nova-network support https://review.opendev.org/696501
13:40:32 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove 'enable_hairpin' https://review.opendev.org/696500
13:40:33 openstackgerrit Stephen Finucane proposed openstack/nova master: vmware: Remove vestigial nova-network support https://review.opendev.org/696503
13:40:33 openstackgerrit Stephen Finucane proposed openstack/nova master: hyperv: Remove vestigial nova-network support https://review.opendev.org/696502
13:40:34 openstackgerrit Stephen Finucane proposed openstack/nova master: xenapi: Remove vestigial nova-network support https://review.opendev.org/696505
13:40:34 openstackgerrit Stephen Finucane proposed openstack/nova master: zvm: Remove vestigial nova-network support https://review.opendev.org/696504
13:40:35 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove SG tests that don't apply to neutron https://review.opendev.org/696507
13:40:35 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Flatten class hierarchy for neutron SG tests https://review.opendev.org/696506
13:40:36 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining API tests to use neutron https://review.opendev.org/696509
13:40:36 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Drop nova-network-base security group tests https://review.opendev.org/696508
13:40:37 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function https://review.opendev.org/696511
13:40:37 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining unit tests to neutron https://review.opendev.org/696510
13:40:38 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Correct some broken VIF tests https://review.opendev.org/696513
13:40:38 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove nova-network security group driver https://review.opendev.org/696512
13:40:39 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Copy shared utils from nova-net module https://review.opendev.org/696515
13:40:39 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove firewall support https://review.opendev.org/696514
13:40:40 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add TODOs to remove security group-related objects https://review.opendev.org/696517
13:40:40 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove final references to nova-network https://review.opendev.org/696516
13:41:00 stephenfin gibi: I had to fix a tiny pep8 issue in that base hairpin patch. Mind quickly re +2ing?
13:41:04 stephenfin https://review.opendev.org/696500
13:41:59 gibi stephenfin: done
13:42:04 stephenfin Thank you
13:44:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move _update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/696574
13:48:26 gibi nova team meeting starts in 11 minutes on #openstack-meeting
13:49:36 shilpasd Gibi: okay
13:49:42 gibi :)
14:08:02 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905
14:19:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Add resource provider allocation unset example to troubleshooting doc https://review.opendev.org/696582
17:04:14 stephenfin sean-k-mooney: one test change requested on https://review.opendev.org/#/c/674072/ along with a few nits
17:04:30 stephenfin if you can get those done for tomorrow, I'll happily +2
17:06:01 sean-k-mooney i would have to look at how we generate the fake nodes but yes we proably coudl use the cpu_dedicated_set flags to restict it to just one numa node
17:06:20 sean-k-mooney im going to adress the other nits this evening. ill give that a try too
17:06:53 sean-k-mooney stephenfin: this is the test change right https://review.opendev.org/#/c/674072/8/nova/tests/functional/libvirt/test_pci_sriov_servers.py@533
17:09:24 stephenfin correct
17:09:38 stephenfin I don't think we consider the flags when generating the fake nodes
17:10:41 sean-k-mooney ill give it a try for the node generation we should not have too
17:11:06 sean-k-mooney but we should be looking at it for cpu pinning so provided i enable pinning in the flaovr or image it might work
17:12:08 sean-k-mooney i would need to look at how we do the cpu numbering too. to work out the correct mask/range but ya ill fix the other issues then ill give it a try
17:18:32 sean-k-mooney stephenfin: cool so jsut finished reviewing the comments they make sense so ill work on that this evening
19:16:11 openstackgerrit Merged openstack/nova stable/pike: Changing scheduler sync event from INFO to DEBUG https://review.opendev.org/669127
19:16:18 openstackgerrit Merged openstack/nova master: Mask the token used to allow access to consoles https://review.opendev.org/220622
23:21:36 openstackgerrit Merged openstack/nova master: block_device: Copy original volume_type when missing for snapshot based volumes https://review.opendev.org/694497
23:25:36 openstackgerrit Merged openstack/nova master: Sanity check instance mapping during scheduling https://review.opendev.org/683730
#openstack-nova - 2019-11-29
01:38:28 openstackgerrit Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043

Earlier   Later