| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-26 | |||
| 02:38:48 | openstackgerrit | Eric Xie proposed openstack/nova master: Fix incorrect command examples https://review.opendev.org/695832 | |
| 04:39:56 | openstackgerrit | Merged openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | |
| 04:40:03 | openstackgerrit | Merged openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | |
| 04:40:11 | openstackgerrit | Merged openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | |
| 05:52:59 | openstackgerrit | Merged openstack/nova stable/train: Join migration_context and flavor in Migration.instance https://review.opendev.org/694408 | |
| 07:00:52 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717 | |
| 08:50:34 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Use long_rpc_timeout in reserve_block_device_name https://review.opendev.org/693537 | |
| 09:02:14 | kashyap | efried: Noted on your "meh"; can squash...could've squashed (but it's already merged). Thx! | |
| 09:04:18 | kashyap | (And also thanks to stephenfin for the reviews, as usual.) | |
| 09:07:00 | kashyap | stephenfin: Oops, good catch on "test_min_version_file_backed_ok"! | |
| 09:50:12 | stephenfin | bauzas: If you're bored, three dead simple patches here for you https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:drop-python2-support | |
| 09:50:22 | bauzas | stephenfin: lol | |
| 09:50:44 | bauzas | stephenfin: I'm bored by an internal customer issue, fer sur | |
| 10:11:08 | johnthetubaguy | stephenfin: just went back to the nova-net removal, can't we delete all of that nova/network/api.py as its the class we use to talk to the binary you removed in the patch before? | |
| 10:12:51 | stephenfin | johnthetubaguy: Maybe? I'm not really sure. The RPC client/server divide constantly trips me up | |
| 10:13:06 | stephenfin | I have been trying to avoid huge patches though because no one will review them. That feels like one such patch | |
| 10:13:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Filter hypervisors by service host https://review.opendev.org/695716 | |
| 10:13:15 | stephenfin | assuming I have to remove references from elsewhere while I'm at it | |
| 10:13:16 | johnthetubaguy | understood | |
| 10:13:28 | johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/network/__init__.py | |
| 10:13:28 | johnthetubaguy | I just wonder if you remove this bit: | |
| 10:13:46 | johnthetubaguy | that might mean a bunch of stuff just gets deleted, as its no longer used | |
| 10:14:26 | johnthetubaguy | a large set of just red, with zuul +1 might get a quick ish review | |
| 10:14:43 | stephenfin | let me try | |
| 10:14:54 | stephenfin | I think I have that done _somewhere_, but who knows where | |
| 10:14:59 | johnthetubaguy | heh, OK | |
| 10:15:17 | stephenfin | thank God for cherry-pick | |
| 10:15:21 | johnthetubaguy | if doing it results in a silly change, that is all good | |
| 10:15:23 | johnthetubaguy | heh | |
| 10:49:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove references to nova-net service from tests https://review.opendev.org/686818 | |
| 10:50:38 | kashyap | sean-k-mooney: Hey, can you remind again: upstream supports multique virtio-net, yes? | |
| 10:50:43 | kashyap | s/que/queue/ | |
| 11:08:46 | johnthetubaguy | kashyap: I have used that with a customer, with some success | |
| 11:09:14 | kashyap | johnthetubaguy: I see | |
| 11:09:16 | kashyap | Good to hear | |
| 11:09:19 | johnthetubaguy | good when you have lots of small packets | |
| 11:09:56 | kashyap | johnthetubaguy: I ask because, a QEMU dev was just mentioning an OOM bug for a Windows guest w/ multiqueue enabled | |
| 11:10:04 | kashyap | (Recently fixed, /me goes to check) | |
| 11:10:20 | johnthetubaguy | heh, thank goodness they doing run windows then :) | |
| 11:10:26 | johnthetubaguy | oops | |
| 11:10:28 | kashyap | :D | |
| 11:10:30 | johnthetubaguy | don't^ | |
| 11:10:39 | johnthetubaguy | I forget the negative :) | |
| 11:11:52 | kashyap | johnthetubaguy: Yeah, it's a guest-crash ... trying to find the upstream commit/release, if you're curious | |
| 12:04:59 | openstackgerrit | Merged openstack/nova master: Reset instance to current vm_state if rolling back in resize_instance https://review.opendev.org/691908 | |
| 12:08:24 | openstackgerrit | Merged openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Ussuri" https://review.opendev.org/695056 | |
| 12:08:29 | openstackgerrit | Merged openstack/nova master: doc: remove admin/manage-users https://review.opendev.org/695779 | |
| 12:23:21 | openstackgerrit | Merged openstack/nova master: Drop neutron-grenade-multinode job https://review.opendev.org/694789 | |
| 12:39:20 | tssurya | @nova-api experts like alex_xu, gmann: Is this a bug or a feature ? : https://github.com/openstack/nova/blob/d621914442855ce67ce0b99003f7e69e8ee515e6/nova/api/openstack/identity.py#L61 | |
| 12:39:37 | tssurya | shouldn't we be blocking this action if we know its wrong ? | |
| 13:38:30 | mriedem | gibi: if you have some time, https://review.opendev.org/#/c/643451/46 and the one after it are negative functional tests for cross-cell resize and have +2s already | |
| 13:38:46 | gibi | mriedem: ack. I will try. | |
| 13:39:04 | mriedem | thanks | |
| 13:39:21 | mriedem | aarents: were you going to propose backports for this? https://review.opendev.org/#/c/670000/ | |
| 13:40:44 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Join migration_context and flavor in Migration.instance https://review.opendev.org/696083 | |
| 13:40:44 | aarents | yes why not | |
| 13:41:52 | openstackgerrit | Alexandre arents proposed openstack/nova master: Flatten qcow2 images when unshelving an instance https://review.opendev.org/696084 | |
| 13:42:09 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Reset instance to current vm_state if rolling back in resize_instance https://review.opendev.org/696085 | |
| 13:44:35 | aarents | mriedem: thanks about you reply on ml about "unshelved bug", when you will have time can you review https://review.opendev.org/696084 it is about flatten also qcow2 disk during unshelve | |
| 13:45:35 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | |
| 13:51:37 | mriedem | aarents: i've added mdbooth to that since he's going to be more of an authority on that change than me | |
| 13:52:15 | aarents | mriedem: ok thks | |
| 13:52:36 | mriedem | though it should be pretty easy to recreate in tempest right? make sure devstack is configured to use the qcow2 image backend (it might be by default?) and write a tempest test that shelve/unshelves an instance and then resizes it - without your fix that should fail correct? | |
| 13:58:14 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696088 | |
| 14:03:35 | aarents | mriedem: Hum, I'm not sure this bug can be always detected during a resize, for exemple issue is typically detected when instance is unbootable, it shoud depends of the data diff between shelved image and original image, but we can imagine in tempest scenario something reproducible 100% by checking generated data or something like that. | |
| 14:23:21 | dpawlik | stephenfin: can I add nova-core group for this review? https://review.opendev.org/#/c/687909/ | |
| 14:23:59 | stephenfin | dpawlik: you can, but I don't know how much it'll help | |
| 14:24:14 | stephenfin | is there a rush on merging it? | |
| 15:00:20 | dpawlik | stephenfin: not so big :) | |
| 15:19:30 | mriedem | dpawlik: adding the entire core team to a review is generally discouraged as bad behavior | |
| 15:21:51 | efried | that's perhaps a culture we should seek to amend in light of falling numbers. | |
| 15:22:56 | efried | What's your alternative? Hang out in IRC and pounce on someone? Or just wait and pray? | |
| 15:23:08 | mriedem | adding the entire core team to lots of reviews isn't going to make people start reviewing things | |
| 15:23:19 | efried | I've always thought that was kind of a crappy expectation for casual contributors. | |
| 15:23:20 | mriedem | if it's important, yes, ask in irc or in the meeting | |
| 15:23:32 | mriedem | you can post things on the meeting for awareness without actually attending | |
| 15:23:57 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | |
| 15:24:00 | mriedem | we've said multiple times that most if not all cores are ok with people asking for reviews in here (within reason) | |
| 15:24:01 | efried | "lots of reviews" principle applies regardless of the method | |
| 15:24:24 | efried | anyway, sorry, /me crawls back into hole | |
| 15:31:40 | mriedem | stephenfin: another way to get eyes on that series is putting it in runways - which has basically been empty all of ussuri | |
| 15:31:47 | mriedem | so i'm not sure why we're even doing runways anymore | |
| 15:32:20 | artom | mriedem, playing devil's advocate for a bit, a new contributor might now even know runways are a thing | |
| 15:32:25 | artom | *not even | |
| 15:32:38 | mriedem | i was going to tell dpawlik but they left | |
| 15:32:52 | mriedem | is dpawlik red hat? | |
| 15:33:16 | artom | mriedem, not to my knowledge | |
| 15:33:53 | artom | If they are, they're not Nova | |
| 15:34:02 | mriedem | at least they are documented https://docs.openstack.org/nova/latest/contributor/process.html#runways | |
| 15:36:16 | mriedem | ok dpawlik is ovh https://www.stackalytics.com/?user_id=daniel-pawlik | |
| 15:36:25 | mriedem | ovh devs aren't new to openstack or nova | |
| 15:36:26 | artom | mriedem, so, putting myself in the shoes of a new contributor, that link doesn't tell me "put your series in this etherpad and monitor it. When it hits a runway, be available to respond to feedback quickly and iterate fast." | |
| 15:36:33 | mriedem | so i'd hope that within their dev team they can explain how things work | |
| 15:36:47 | mriedem | artom: so write up some contributor docs | |
| 15:36:48 | sean-k-mooney | i added https://review.opendev.org/#/c/674072/ to the runway queue for what its worth. i thought i already had but i guess not | |
| 15:36:55 | artom | mriedem, can't argue with that :) | |
| 15:37:14 | mriedem | writing up stuff like this is near impossible, because it's either too much or not enough content | |
| 15:37:27 | mriedem | i'm pretty sure there are summit videos on this topic but people would have to find and watch them | |
| 15:37:40 | mriedem | within an organization of decent size with multiple developers there should also be mentoring | |
| 15:37:46 | mriedem | that's what we had at ibm when i was new to openstack | |