Posted	Nick	Remark
#openstack-nova - 2019-11-22
21:05:48	melwitt	KeithMnemonic: if I were you I'd make it work with ID only and forget about name for now. the name requires a further change to python-novaclient (AFAIK) and it's already standard operating procedure that some APIs or options only work with ID. not ideal perhaps but it is what it is. just MHO
21:06:23	KeithMnemonic	ok so my patch does that ;-)
21:06:31	melwitt	yeah, you need to update it no?
21:06:41	KeithMnemonic	i can
21:06:54	melwitt	update the doc and everything mriedem pointed out on the patch
21:07:11	KeithMnemonic	as long as it seems everyone here is ok with the concept
21:07:14	melwitt	to make sure marker referenced by ID is consistent
21:07:21	KeithMnemonic	thanks for the help
21:07:55	melwitt	yeah I think so, unless I'm totally missing something, which I might be. people letting me know lately that I've missed a lot ;)
21:08:17	melwitt	I don't see why doing it ID only would not be ok
21:10:38	KeithMnemonic	ok thanks again, any chance i can get some movement on that other patch by mriedem for rocky that fixes the marker? he made a ton of progress before the summit but it seems to have stalled
21:10:57	KeithMnemonic	it is merged through stein now
21:11:40	melwitt	yeah. my head's spinning with all the stuff I'm trying to do but I'll try to get those. they're not 100% easy bc there's differences and conflicts to look at
21:15:51	melwitt	KeithMnemonic: I guess the sticking point on the osc one is that it's a change in behavior? does that mean that marker by name works with non-deleted servers?
21:16:48	KeithMnemonic	yes it does
21:17:07	melwitt	ahhhh dammit
21:17:16	KeithMnemonic	so maybe some logic needs to go around the change to only do it if -deleted is passed
21:18:06	melwitt	yeah like, do some extra stuff (client gymnastics) to get the server by name first then call with marker if --deleted is passed
21:18:14	KeithMnemonic	that way it does not break anything but makes -deleted work in once case at least
21:18:23	melwitt	*with marker as ID if --deleted is passed
21:18:27	KeithMnemonic	yup
21:18:39	melwitt	yeah ok. I get it now
21:19:32	KeithMnemonic	let me spin up a fresh devstack and start hacking on it again
21:19:47	melwitt	yeah so I rewind from what I said earlier and I'd do the extra step if --deleted is passed. grab the server id and then pass marker as id under the covers
21:21:07	openstackgerrit	Merged openstack/nova master: Remove 'os-consoles' API https://review.opendev.org/687907
21:26:34	mriedem	heh, this is a bit old https://docs.openstack.org/nova/latest/reference/vm-states.html#create-instance-states
21:26:42	mriedem	api -> compute done!
21:37:05	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-guide: flesh out BUILD and ACTIVE server create transitions https://review.opendev.org/695771
21:43:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-guide: fix the file injection considerations drift https://review.opendev.org/695773
21:48:42	openstackgerrit	Merged openstack/nova master: Avoid raise InstanceNotRunning exception https://review.opendev.org/541152
21:48:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-guide: remove empty sections about inter-service interactions https://review.opendev.org/695774
21:48:51	openstackgerrit	Merged openstack/nova master: Start README.rst with a better title https://review.opendev.org/695025
22:16:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-guide: flesh out flavor extra specs and image properties https://review.opendev.org/695776
22:33:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-guide: flesh out networking concepts https://review.opendev.org/695777
22:33:44	melwitt	efried: question on test cleanup https://review.opendev.org/685399
22:33:52	efried	...
22:35:01	efried	I think you're probably right. Lemme check one thing quick...
22:36:05	melwitt	ok. I wasn't sure how this is supposed to be
22:37:10	efried	Yup, I think that was just a miss melwitt, good spot, will remove.
22:38:24	openstackgerrit	Eric Fried proposed openstack/nova master: test cleanup: Make base TestCase subclass oslotest https://review.opendev.org/685399
22:38:30	efried	melwitt: done, thanks.
22:38:46	melwitt	kewl
22:39:30	efried	thanks for those reviews melwitt
22:39:54	efried	a day when my dashboard shrinks is a good day :)
22:40:32	efried	and johnthetubaguy ^
22:41:14	melwitt	np, nice cleanups
22:43:01	openstackgerrit	Merged openstack/nova master: Remove 'nova-console' service, 'console' RPC API https://review.opendev.org/687908
22:44:10	openstackgerrit	Merged openstack/nova master: nova-net: Remove 'networks' quota https://review.opendev.org/686812
22:47:12	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-guide: flesh out todos in user doc https://review.opendev.org/695778
22:59:04	openstackgerrit	Matt Riedemann proposed openstack/nova master: doc: remove admin/manage-users https://review.opendev.org/695779
23:13:26	efried	dansmith: you said something about hard reboot being admin-only by default, but I can't find how that's the case in the code, where it looks like soft/hard are under the same umbrella. Did I misunderstand?
23:17:24	openstackgerrit	Merged openstack/nova master: test cleanup: Use oslotest's Timeout fixture https://review.opendev.org/685389
23:17:30	openstackgerrit	Merged openstack/nova master: test cleanup: Use oslotest's CaptureOutput fixture https://review.opendev.org/685392
23:37:09	dansmith	efried: that wasn't me
23:38:14	dansmith	at least, not the hard reboot nova action
23:38:21	dansmith	I talked a lot about *host* reboot...
23:38:33	efried	dammit, that's probably where I got confused.
23:38:41	efried	thanks.
#openstack-nova - 2019-11-23
00:08:59	openstackgerrit	Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
00:09:00	openstackgerrit	Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
00:09:00	openstackgerrit	Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522
02:40:20	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP https://review.opendev.org/686818
05:31:46	openstackgerrit	Merged openstack/nova master: test cleanup: Make base TestCase subclass oslotest https://review.opendev.org/685399
06:28:19	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717
13:03:49	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165
13:08:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove nova-manage network, floating commands https://review.opendev.org/686813
13:08:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815
13:08:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814
13:08:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817
13:08:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary https://review.opendev.org/686816
13:08:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP https://review.opendev.org/686818
14:05:32	openstackgerrit	Merged openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165
15:55:28	openstackgerrit	Merged openstack/nova master: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event https://review.opendev.org/594527
#openstack-nova - 2019-11-24
00:31:50	openstackgerrit	Merged openstack/nova master: Remove nova-manage network, floating commands https://review.opendev.org/686813
06:46:00	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717
#openstack-nova - 2019-11-25
00:45:33	openstackgerrit	Eric Xie proposed openstack/nova master: Fix incorrect command examples https://review.opendev.org/695832
05:12:16	openstackgerrit	Merged openstack/nova master: api-guide: flesh out BUILD and ACTIVE server create transitions https://review.opendev.org/695771
05:13:28	openstackgerrit	Merged openstack/nova master: api-guide: fix the file injection considerations drift https://review.opendev.org/695773
06:30:41	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717
08:19:04	bauzas	good morning Nova
08:44:35	openstackgerrit	Lee Yarwood proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
08:45:03	lyarwood	stephenfin: ^ hope you don't mind, thought I'd sort out the last few failures as the removal came up in RDO over the weekend.
08:53:29	stephenfin	lyarwood: fine by me, but I think it needs to be rebased again
08:53:35	stephenfin	"This change depends on a change that failed to merge."
08:53:55	lyarwood	stephenfin: ah it's the tempest change?
08:54:22	lyarwood	stephenfin: hmm no that's also up to date
08:54:23	lyarwood	weird
09:07:07	lyarwood	stephenfin: oh that was my bad, I pushed another PS to the tempest change after pushing the nova change, apologies!
09:07:16	lyarwood	recheked
09:07:22	lyarwood	rechecked*
09:38:43	openstackgerrit	Luyao Zhong proposed openstack/nova-specs master: support live migration with virtual persistent memory https://review.opendev.org/695863
09:51:14	tssurya	dansmith: whenever you are awake and have some time, review appreciated on this https://review.opendev.org/#/c/689422/ thanks in advance
09:52:48	openstackgerrit	Luyao Zhong proposed openstack/nova-specs master: spec update: virtual persistent memory https://review.opendev.org/695868
10:15:06	openstackgerrit	Elod Illes proposed openstack/nova stable/stein: Use admin neutron client to see if instance has qos ports https://review.opendev.org/694668
10:19:04	stephenfin	dansmith: Could I get some input on RPC versioning issues here, when you're online? https://review.opendev.org/#/c/686814/11
10:59:35	stephenfin	johnthetubaguy: Could you weigh in on https://review.opendev.org/#/c/686814/11/nova/network/rpcapi.py@a211, assuming you know RPC better than I do?
11:11:53	kashyap	stephenfin: Hi, when you get a moment, want to ACK/NACK these? -- https://review.opendev.org/#/c/694821/3
11:12:28	kashyap	stephenfin: I'd prefer to keep them seperate, although I know they _could_ be squashed. But if that's the "bone of contention" and you insist, can squash :-)
12:32:03	sean-k-mooney	stephenfin: can you take a look at https://review.opendev.org/#/c/674072/ today if you get a chance
12:51:23	gibi	sean-k-mooney, mriedem: hi! do we have live migration functional tests where the server has at least on neutron port? did we added such functional test when the bp neutron-new-port-binding-api has been implemented?

Earlier   Later