Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-11-22
15:42:29 bauzas and we don't want the change to merge now
15:42:33 bauzas https://review.opendev.org/#/c/686810/7
15:43:06 mriedem the GETs were not removed
15:43:12 stephenfin ah, I see now
15:43:15 mriedem but you removed them in docs, policy and tests
15:44:27 stephenfin Go me \o/
15:47:55 mriedem if you're going to rebase, might as well fix that release note later in the series,
15:48:00 mriedem and also a question here https://review.opendev.org/#/c/686813/8/nova/cmd/manage.py@a2673
15:49:30 melwitt why do we want to keep the GETs?
15:49:37 mriedem they are proxies for neutron and work
15:49:45 mriedem i mean, they'll work once nova-network is gone
15:50:06 melwitt oh ok. I thought we didn't want to keep proxies
15:50:25 mriedem the GETs are capped at 2.35
15:50:55 mriedem iow, proxies have already been deprecated for a long time
15:50:59 mriedem newton i think
15:52:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove '/os-tenant-networks' REST API https://review.opendev.org/686810
15:52:20 mriedem pulled from the gate ^
15:52:37 melwitt oh right... but that wouldn't mean that all get/post/put stay and return http gone? I guess I never knew the detail behind how that was implemented
15:53:43 stephenfin okay, think I know why I removed that - there's no functional test for it
15:54:03 stephenfin so it didn't exist as far as I, in functional test fixup mode, was concerned
15:54:27 mriedem melwitt: can you rephrase?
15:54:47 mriedem if a thing works after nova-net is gone but was just deprecated b/c it's a proxy, no we won't remove it, because it still works
15:55:03 mriedem we're not removing our glance or volume proxies here either
15:55:16 melwitt sorry, like in the 2.35 deprecation, were all apis except GET removed? or did all apis stay and change to return http gone, in version 2.35
15:55:29 mriedem they return 404
15:55:39 mriedem deprecation = 404 for us, gone = 410
15:55:51 mriedem but you can still hit the proxies at 2.1
15:55:51 melwitt and GET does not return 404?
15:56:24 mriedem not below the deprecation microversion it shouldn't - not b/c of deprecation i mean; sure you could get 404 for trying to show details on a neutron network that doesn't exist
15:56:44 melwitt just trying to parse why removing POST is ok but not GET
15:56:52 melwitt should they all stay?
15:57:12 melwitt *shouldn't
15:57:32 mriedem POST is only implemented for nova-net
15:57:36 mriedem nova-net is going to be gone
15:57:38 mriedem so it's a 410
15:57:38 melwitt ohhhh
15:57:49 mriedem if an API is only implemented for nova-net, it will be 410
15:57:50 melwitt yeah, ok. I see
15:58:28 melwitt it all makes now
15:58:38 melwitt make sense now, aaarrrggghh
15:58:49 stephenfin mriedem: question on https://review.opendev.org/#/c/686810/7/api-ref/source/os-tenant-network.inc@2
15:59:07 stephenfin ?
15:59:07 stephenfin does that actually make sense, since some of the APIs have been removed but others have not
16:05:54 openstackgerrit Balazs Gibizer proposed openstack/nova-specs master: Filter hypervisors by service host https://review.opendev.org/695716
16:07:43 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'USE_NEUTRON' from functional tests https://review.opendev.org/686811
16:07:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove '/os-tenant-networks' REST API https://review.opendev.org/686810
16:07:44 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'networks' quota https://review.opendev.org/686812
16:07:45 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814
16:07:45 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova-manage network, floating commands https://review.opendev.org/686813
16:07:46 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary https://review.opendev.org/686816
16:07:46 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815
16:07:47 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP https://review.opendev.org/686818
16:07:47 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817
16:08:13 stephenfin melwitt, gibi: fixed that silly typo in the reno if you want to re +2 https://review.opendev.org/686812
16:08:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support service_host filtering for os-hypervisor API https://review.opendev.org/695708
16:09:55 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'os-consoles' API https://review.opendev.org/687907
16:09:56 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
16:09:56 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-console' service, 'console' RPC API https://review.opendev.org/687908
16:10:40 openstackgerrit Balazs Gibizer proposed openstack/nova-specs master: Filter hypervisors by service host https://review.opendev.org/695716
16:10:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support service_host filtering for os-hypervisor API https://review.opendev.org/695708
16:13:01 bauzas stephenfin: ask others for your series, sorry
16:13:14 stephenfin have a good weekend o/
16:13:36 melwitt stephenfin: why did you update to say "which has been removed"? it's not going to removed until the end of the series right? I guess it makes sense to write it as thought it's already happened though since it will be by the time anyone reads that
16:13:43 melwitt *though
16:14:13 stephenfin yeah, I'm writing from the perspective of the end of the series
16:14:43 melwitt yeah, ok that makes sense
16:14:49 stephenfin and in reality, we removed nova-network support when we dropped cells v1 support https://github.com/openstack/nova/blob/master/nova/cmd/network.py#L46
16:15:14 melwitt oh yeah, I didn't think about that
16:15:15 gibi stephenfin: sorry, I have to take that next week
16:15:36 stephenfin gibi: 'sall good (y)
16:16:05 gibi have a nice weekend folks!
16:16:26 melwitt bye, happy weekend o/
16:27:28 mriedem stephenfin: a couple of thoughts/questions in the bottom change https://review.opendev.org/#/c/686810/
16:27:37 stephenfin looking
16:27:42 mriedem i don't know if we have precedent for 410ing some methods in a route but not all
16:28:25 stephenfin why would it be 500?
16:29:09 mriedem i was thinking if you hit something that's not neutron, but i guess if you upgrade and the nova-network binary is literally gone, then yeah i guess that's not possible
16:29:15 mriedem b/c you can only have neutron or you can't upgrade
16:29:48 stephenfin yeah, the nova-network service literally can't be started since we dropped the cells v1 code
16:30:27 stephenfin so people have to be using neutron in Train, never mind Ussuri
16:42:20 mriedem should update the reno here https://review.opendev.org/#/c/686812/8/releasenotes/notes/remove-nova-network-c02953ba72a1795d.yaml
16:44:12 stephenfin damn it
16:44:17 stephenfin yup
16:44:56 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'networks' quota https://review.opendev.org/686812
16:45:02 stephenfin done
16:48:19 mriedem sorry one more in there - you forgot os-quota-class-sets in the reno
16:48:28 mriedem the quota apis are super fun!
16:48:34 mriedem because there are 100 of them
16:49:50 melwitt this patch is a stats machine
16:49:56 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove 'networks' quota https://review.opendev.org/686812
16:50:06 stephenfin Do I get a prize if I win?
16:50:15 stephenfin Can someone "win"?
16:50:31 stephenfin I want the plush tiger
16:50:35 melwitt haha
16:51:32 melwitt I think we're all winning cause we're talking about quotas
16:51:34 melwitt right??
16:52:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove nova-manage network, floating commands https://review.opendev.org/686813
16:52:31 stephenfin so long as you don't get more "winning" than you're paying for
16:53:09 openstackgerrit Matt Riedemann proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814
16:53:17 openstackgerrit Matt Riedemann proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815

Earlier   Later