| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-19 | |||
| 14:12:40 | kashyap | (On RPM-based distros, DevStack generally "works for me" on Fedora. Never tried on CentOS, though.) | |
| 14:12:40 | stephenfin | sean-k-mooney: we can, but we can also do it on CentOS 8. Both involve some work, and it seems obvious to me that the effort should spent on the latter option | |
| 14:13:02 | mriedem | corvus: removing the WIP doesn't make it work, as you can see from the job results | |
| 14:13:03 | sean-k-mooney | stephenfin: we can do both | |
| 14:13:12 | kashyap | stephenfin: Just chiming in randomly, why can't one just stick to a Fedora-only job? (IIRC, there was one; need to check if it's still maintained, or is rotting) | |
| 14:13:16 | mriedem | as sean pointed out there are a series of changes so someone has to align that stuff | |
| 14:13:22 | mriedem | the one under my WIP has been sitting since april | |
| 14:13:29 | mriedem | so clearly not a community priority | |
| 14:14:10 | mriedem | kashyap: as far as i can recall the fedora jobs in openstack have been a garbage dump since forever | |
| 14:14:36 | mriedem | i don't know of any projects in openstack that gate on fedora, maybe tripleo or some deployment projects | |
| 14:14:38 | kashyap | mriedem: Right, need bodies. | |
| 14:14:39 | stephenfin | kashyap: Fedora is too much of a moving target for CI, I'm afraid | |
| 14:14:41 | tosky | mriedem: maybe devstack jobs - tripleo was able to have f28 jobs | |
| 14:14:43 | sean-k-mooney | mriedem: well that because fedora and ci is basically an anti pattern. it chagne too much and keeps breaking | |
| 14:14:47 | stephenfin | Ask sean-k-mooney - they know all about it | |
| 14:14:50 | stephenfin | jinx :D | |
| 14:14:50 | kashyap | The only one I know who worked on Fedora jobs was/is ianw | |
| 14:15:00 | stephenfin | anyway, that's a different discussion | |
| 14:16:03 | kashyap | Yeah, agreed on Fedora being a "moving target"; if CentOS-8 is more manageable, by all means. | |
| 14:16:42 | kashyap | sean-k-mooney: "Anti-pattern" for a cloud software probably; libvirt and QEMU upstream test on Fedora jobs just fine. | |
| 14:16:49 | sean-k-mooney | kashyap: i think the main issue with centos 8 will be a lack of packages | |
| 14:16:58 | sean-k-mooney | kashyap: libvirt and qemu are too of the main issues | |
| 14:17:33 | sean-k-mooney | we hit temproy brakages or chagnes in the output of things like qemu-img | |
| 14:17:38 | kashyap | (Also, bear in mind -- most / all upstream kernel / Virt issues are fixed on Fedora first -- as most kernel / Virt upstream devs use it.) | |
| 14:18:24 | sean-k-mooney | ya the kernel and gcc kept causing issues for compiling dpdk and ovs too | |
| 14:18:36 | sean-k-mooney | anyway thats a different topic | |
| 14:18:38 | stephenfin | corvus, tosky: Can we combine https://review.opendev.org/#/c/649097/ and https://review.opendev.org/#/c/694967/ and just merge that? | |
| 14:18:54 | kashyap | Anyway, this is all largely about having enough warm bodies that are incentivized to care. | |
| 14:19:06 | stephenfin | So switch DevStack to Python 3 and drop the CentOS 7 job, which will no longer work | |
| 14:19:48 | mriedem | stephenfin: those non-ubuntu jobs aren't voting anyway so they don't matter | |
| 14:19:54 | stephenfin | True | |
| 14:20:09 | mriedem | if a job isn't voting it's not enough of a priority for people to care about it | |
| 14:20:09 | tosky | stephenfin: maybe, I don't know; I'd wait for gmann too, even though I have some objections to his comment in https://review.opendev.org/#/c/649097/ as I wrote there | |
| 14:20:46 | stephenfin | I don't want to inflict pain on people, but as mriedem notes someone needs to start driving this and if I'm doing that from nova's side, then a straight up revert is what I want | |
| 14:20:48 | stephenfin | It sounds like we'd be kicking a can down the road. I'd rather help people pick up the pieces than do that | |
| 14:21:14 | sean-k-mooney | mind if i just rebase the 3 devstack patch into the right order | |
| 14:21:25 | stephenfin | sean-k-mooney: before you do, what are the three? | |
| 14:21:33 | tosky | stephenfin: it's too big right now - if you don't want to fully revert https://review.opendev.org/#/c/694891/, are you going to accept at least a revert of setup.cfg (the condition) and *requirements.txt ? | |
| 14:21:57 | sean-k-mooney | Handle uninstalled python3 -> Handle localrc early enough in stackrc -> Change USE_PYTHON3=True by default | |
| 14:22:25 | sean-k-mooney | that fixes centos 7 then enable python 3 early then set it to the defaul | |
| 14:22:29 | stephenfin | sean-k-mooney: again, I don't think we need "Handle uninstalled python3". Let's use CentOS 8 instead | |
| 14:22:38 | sean-k-mooney | we can do both | |
| 14:22:51 | stephenfin | we can, but it doesn't mean we should | |
| 14:23:16 | stephenfin | tosky: We can, but that means we'll no longer test against Python 2.7 | |
| 14:23:36 | sean-k-mooney | if we want to drop all centos testing until centos 7 works we could but why when its a trivial patch | |
| 14:23:54 | stephenfin | so there's an implicit countdown before nova on py2.7 breaks anyway | |
| 14:23:56 | tosky | stephenfin: no, not directly - but it is really likely that you are going to break py2 with a commit in the next 3 weeks? | |
| 14:24:12 | stephenfin | no, it's not, in fairness | |
| 14:24:48 | stephenfin | sean-k-mooney: for the reasons ianw has pointed out: no one has actually tested that it works | |
| 14:24:55 | stephenfin | and it's not reflective of real-world use cases | |
| 14:25:14 | stephenfin | better to disable the tests and focus on switching to centos8, imo | |
| 14:25:27 | sean-k-mooney | i used to used centos 7 with python 3 as my dev env untill like july | |
| 14:25:42 | mriedem | as i've said earlier, i would put the bare minimum effort into making nova work with py27, i.e. let it install but after that all bets are off | |
| 14:25:54 | mriedem | if it doesn't work with py27 it's a bug until we can really say we no longer care | |
| 14:26:01 | stephenfin | mriedem: I also like that approach | |
| 14:26:07 | sean-k-mooney | ya same | |
| 14:26:19 | sean-k-mooney | which means remove 1 line in setup.cfg | |
| 14:26:20 | stephenfin | tosky: yeah, if you want to just revert the setup.cfg changes, I'll be happy with that | |
| 14:26:28 | mriedem | stephenfin: and likely the requirements stuff | |
| 14:26:34 | stephenfin | also that, yes | |
| 14:26:46 | sean-k-mooney | the requirement chagne for contextlib2 is only half needed | |
| 14:26:53 | mriedem | there should probably be a TODO in the setup.cfg line saying to remove python-requires once devstack uses py3 by default | |
| 14:27:05 | sean-k-mooney | the way devstack works it will get installed by other projects but sure | |
| 14:27:15 | stephenfin | and that, yup yup yup | |
| 14:27:22 | mriedem | sean-k-mooney: but kolla! | |
| 14:27:26 | mriedem | osa, etc | |
| 14:27:31 | mriedem | anything running nova in a container or venv | |
| 14:27:34 | tosky | stephenfin: but don't you think that also reverting requirements.txt is needed? There is at least one condition which affects py2, and that may break as well | |
| 14:27:44 | mriedem | tosky: we just said yes | |
| 14:27:52 | tosky | mriedem: sorry, missed in the stream | |
| 14:27:56 | stephenfin | tosky: it is. I missed that. Fortunately mriedem caught it (y) | |
| 14:28:03 | sean-k-mooney | kolla is python3 by default alredy but yes fair point | |
| 14:30:32 | KeithMnemonic | lyarwood do you think you may have time to review this patch this week? https://review.opendev.org/683008 | |
| 14:30:32 | mriedem | stephenfin: technically tosky brought up the requirements thing first so credit goes to him for that | |
| 14:32:31 | efried | so is someone going to modify ianw's patch or propose a new one? Probably the latter is better. | |
| 14:33:26 | sean-k-mooney | maybe we should send an update too the list too whith what our plan is | |
| 14:34:18 | openstackgerrit | Luigi Toscano proposed openstack/nova master: (Temporarily) readd bare support for py27 https://review.opendev.org/695007 | |
| 14:34:28 | tosky | let's see if it works ^^ | |
| 14:34:52 | corvus | tosky: test results will not be helpful here -- there is no testing of py27 | |
| 14:35:08 | tosky | corvus: one monent | |
| 14:35:27 | sean-k-mooney | i dont think we should add the py 27 calssifier back | |
| 14:35:35 | sean-k-mooney | but otherwise it looks fine | |
| 14:35:52 | stephenfin | sean-k-mooney: just left a comment to that effect | |
| 14:36:09 | sean-k-mooney | so did i :) | |
| 14:36:42 | openstackgerrit | Luigi Toscano proposed openstack/nova master: (Temporarily) readd bare support for py27 https://review.opendev.org/695007 | |
| 14:37:15 | tosky | I'm using this: https://review.opendev.org/694949 | |
| 14:37:17 | tosky | to test it | |
| 14:37:57 | stephenfin | tosky: one more comment, sorry /o\ (the Python 3 Only classifier still makes sense) | |
| 14:38:07 | tosky | stephenfin: oh | |
| 14:38:16 | stephenfin | it's just metadata so you can keep it | |
| 14:38:19 | sean-k-mooney | as does the cpython on | |
| 14:38:22 | stephenfin | yup | |
| 14:38:40 | stephenfin | after that, I'm +2 pending https://review.opendev.org/694949 | |
| 14:38:46 | openstackgerrit | Luigi Toscano proposed openstack/nova master: (Temporarily) readd bare support for py27 https://review.opendev.org/695007 | |
| 14:40:25 | corvus | i'd really love for there to be a job which tests py2.7. can we not just add one until the default switches? | |
| 14:41:13 | corvus | testing with depends-on changes seems error-prone | |
| 14:41:37 | tosky | a non-voting one? A voting one? | |
| 14:41:44 | tosky | I'd defer that to nova cores | |
| 14:42:38 | sean-k-mooney | the whole point of the orginal change was nova wanted to drop all python 2 support and therefor the testing | |
| 14:42:45 | sean-k-mooney | but yes we could | |