| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-15 | |||
| 16:29:21 | gibi | bauzas: then something is wrong with the placement fixture we use in the functional test | |
| 16:29:45 | bauzas | and, with using the 'version' keyword : | |
| 16:29:52 | bauzas | 2019-11-15 17:29:16,087 INFO [placement.requestlog] 127.0.0.1 "GET /placement/resource_providers" status: 200 len: 1684 microversion: 1.14 | |
| 16:30:05 | bauzas | we probably kwargs | |
| 16:30:07 | mriedem | def get(self, url, **kwargs): is your problem | |
| 16:30:08 | bauzas | gibi: ^ | |
| 16:30:13 | mriedem | like gibi said it's a bug in the fixture | |
| 16:30:13 | bauzas | heh, this | |
| 16:30:41 | mriedem | SchedulerReportClient.get won't let you pass microversion= | |
| 16:30:42 | mriedem | def get(self, url, version=None, global_request_id=None): | |
| 16:30:43 | gibi | then it is a good time to fix the fixture | |
| 16:30:51 | gibi | :) | |
| 16:31:42 | bauzas | aaaaand I love to see a bug about some code with a few TODO(sbauza) around it... | |
| 16:33:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Change order of two classes https://review.opendev.org/689178 | |
| 16:33:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Make '_wait_for_state_change' behave consistently https://review.opendev.org/689180 | |
| 16:33:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Rework '_delete_server' https://review.opendev.org/689179 | |
| 16:33:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Make 'ServerTestBase' subclass 'InstanceHelperMixin' https://review.opendev.org/689182 | |
| 16:33:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations https://review.opendev.org/689181 | |
| 16:33:36 | mriedem | should just remove those todos in the placement fixture about passing a token, that's never going to happen if it hasn't happened by now | |
| 16:33:48 | mriedem | we should like, put a 3 year timer on todos in the code | |
| 16:34:05 | mriedem | "TODO(vishy): do this in grizzly" | |
| 16:34:28 | gibi | :) | |
| 16:36:06 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | |
| 16:38:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Replacing underscores with dashes https://review.opendev.org/685929 | |
| 16:38:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove 'adv-config', 'system-admin' subdocs https://review.opendev.org/684402 | |
| 16:38:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Strip '.rst' suffix https://review.opendev.org/687264 | |
| 16:42:43 | stephenfin | melwitt: If you have time before the end of the day, think you could hit this quotas doc patch? https://review.opendev.org/#/c/667165/ | |
| 16:42:53 | stephenfin | It's been around for a few months. Would be nice to close it out | |
| 16:43:09 | KeithMnemonic1 | hello all any chance to get some more reviews and a possible WF+1 on this one ? https://review.opendev.org/#/c/683008/ | |
| 16:43:30 | melwitt | stephenfin: that's a biggun. I'll try to get to it | |
| 16:44:06 | stephenfin | melwitt: Sure thing. tbh, I'd just forget whatever was there previously and read it like a new doc. If nothing stands out as totally wrong, it's gonna be better than what we have | |
| 16:44:09 | stephenfin | IMO, obv | |
| 16:44:51 | sean-k-mooney | KeithMnemonic1: i think lyarwood should proably review that | |
| 16:45:07 | melwitt | stephenfin: ok, I'll approach it with that in mind | |
| 16:47:45 | stephenfin | ta | |
| 16:48:12 | stephenfin | Have a good weekend, all o/ | |
| 16:49:02 | melwitt | happy weekend | |
| 16:51:26 | gibi | bauzas: another bug in https://review.opendev.org/#/c/670112/9/nova/cmd/manage.py@2695 this is also not caught by any functional test as that is green for me on PS9 | |
| 16:52:10 | bauzas | gibi: thanks | |
| 16:52:34 | gibi | bauzas: don't be confused by the line numbers in my stack trace. I had to cherry-pick your patch top of the nova master in my devstack | |
| 16:52:36 | melwitt | gibi: I dunno if you saw this but I attempted to do a TODO you mentioned in the NeutronFixture for fun https://review.opendev.org/693453 | |
| 16:52:47 | bauzas | gibi: ack no worries | |
| 16:53:29 | gibi | melwitt: yeah I think I saw it during the PTG but then I got distracted. Looking at it now. Thanks for picking that TODO up | |
| 16:53:53 | melwitt | gibi: don't thank me yet haha, I hope I didn't misunderstand | |
| 16:56:25 | bauzas | gibi: and I get why you catched the error and not my tests | |
| 16:56:53 | bauzas | gibi: that's because when I use the cache, I forget to use the cell mapping | |
| 16:57:13 | bauzas | so, unless you have more than one instance for the same compute, you don't have the problem | |
| 16:57:29 | bauzas | (and I only verify one instance... :) ) | |
| 16:59:00 | KeithMnemonic1 | thanks sean-k-mooney, lyarwood would you have time in the next few business days to look at it? | |
| 17:00:11 | KeithMnemonic1 | can someone please continue the reviews on mriedem patches for the "openstack list marker hang" https://review.opendev.org/#/c/690721/4 | |
| 17:01:46 | sean-k-mooney | KeithMnemonic1: lyarwood for what its worth im +0.5 on it. i dont know htat part of the code well enought to tell if all of the change form queens make sense but the conflcits are called out in the commit and it looks more or less correct | |
| 17:03:35 | gibi | bauzas: I have one instance in shutoff state on the compute | |
| 17:03:51 | bauzas | no worries, I'm just fixing the bug | |
| 17:03:55 | gibi | bauzas: sure | |
| 17:04:02 | bauzas | and thanks, I should actually test it | |
| 17:04:35 | bauzas | it's 6.04pm tho, so I'll just fix the bug and add a TODO in the commit msg for saying I need to add a new func test for it :) | |
| 17:04:39 | bauzas | ie. two instances :-) | |
| 17:04:49 | bauzas | s/add/modify | |
| 17:05:01 | gibi | bauzas: yeah, I will time out soon as well | |
| 17:05:13 | bauzas | actually, you know what ? I'm just gonna amend the test now | |
| 17:05:17 | bauzas | and see whether it's seen | |
| 17:17:35 | openstackgerrit | Merged openstack/nova stable/queens: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693239 | |
| 17:26:15 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | |
| 17:30:24 | gibi | melwitt: two small cleanup suggestion in https://review.opendev.org/#/c/693453/3 then I'm +A | |
| 17:31:25 | melwitt | gibi: thanks, will update | |
| 17:31:46 | gibi | melwitt: I thank you :) | |
| 17:35:48 | melwitt | gibi: thank you for review :) | |
| 17:42:45 | openstackgerrit | Archit Modi proposed openstack/nova stable/pike: doc: fix and clarify --block-device usage in user docs https://review.opendev.org/694450 | |
| 18:02:43 | openstackgerrit | melanie witt proposed openstack/nova master: Use wrapper class for NeutronFixture get_client https://review.opendev.org/693453 | |
| 18:04:17 | melwitt | gibi: updated ^ | |
| 18:18:47 | openstackgerrit | Dustin Cowles proposed openstack/nova-specs master: Update provider config spec for identification conflicts https://review.opendev.org/693414 | |
| 18:18:56 | eandersson | gibi thanks a lot for fixing that bug | |
| 18:19:02 | eandersson | I completely forgot to open a bug for it. | |
| 18:26:41 | gibi | melwitt: +2 thank you! | |
| 18:26:49 | gibi | eandersson: no worries | |
| 18:26:57 | melwitt | thanks! | |
| 19:21:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: mention that rescuing a volume-backed server is not supported https://review.opendev.org/694584 | |
| 20:29:01 | efried | melwitt: aren't you doing something with host status UNKNOWN? http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010887.html | |
| 20:29:23 | efried | ah https://blueprints.launchpad.net/nova/+spec/policy-rule-for-host-status-unknown | |
| 21:27:56 | mriedem | s/doing/done/! | |
| 22:07:14 | efried | yeah, once I saw I had even approved it, it all came back to me. | |
| 23:01:34 | openstackgerrit | Merged openstack/nova master: Always trait the compute node RP with COMPUTE_NODE https://review.opendev.org/688979 | |
| 23:01:39 | openstackgerrit | Merged openstack/nova master: docs: Extract rescue from reboot https://review.opendev.org/694529 | |
| 23:11:09 | openstackgerrit | Merged openstack/nova master: Remove fixed sqlalchemy-migrate deprecation warning filters https://review.opendev.org/690704 | |
| 23:13:06 | efried | mriedem: quick ack on https://review.opendev.org/#/c/689823/ if you can please | |
| 23:17:43 | mriedem | i thought you thought set commands should be a full overwrite? | |
| 23:22:24 | efried | mriedem: Didn't we agree earlier that adding --amend to a `set` would mean "add on"? | |
| 23:22:41 | efried | And there's no way to do partial removals with --amend, you have to implement an `unset`? | |
| 23:23:15 | efried | I don't love it, but it's simple(r than the alternatives) | |
| 23:24:42 | mriedem | i left some comments | |
| 23:24:54 | mriedem | we have some docs to update | |
| 23:40:54 | efried | Thanks mriedem. I actually tried `set` with no ``-trait`` before I posted my comments, it does indeed wipe out all the traits on the provider. | |
| 23:41:01 | efried | With that, I'm out o/ | |
| 23:41:12 | mriedem | \o | |
| 23:48:48 | mriedem | just played the clean version of big poppa by notorious big to my kid and had to explain what "macking" means | |
| 23:48:54 | mriedem | harder than you'd think | |
| 23:49:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047 | |
| 23:49:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046 | |
| 23:49:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268 | |
| 23:49:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048 | |