Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-11-13
15:06:01 efried I may be choppy today, going to be trying to work remotely (like, more remotely than usual).
15:09:00 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'os-consoles' API https://review.opendev.org/687907
15:09:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
15:09:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-console' service, 'os-consoles' API https://review.opendev.org/687908
15:15:06 openstackgerrit Merged openstack/nova master: Remove TODOs around claim_resources_on_destination https://review.opendev.org/693635
15:15:41 openstack Launchpad bug 1852446 in OpenStack Compute (nova) "Hypervisors in nova - no subpage details for ironic" [Undecided,New]
15:15:41 mriedem bauzas: https://bugs.launchpad.net/nova/+bug/1852446
15:16:09 bauzas ack, good point
15:18:07 stephenfin mriedem: It's not urgent, but if you can rebase https://review.opendev.org/#/c/693425/ today I'm happy to push it through
15:19:29 mriedem ack, let me rebase the entire cross-cell series first quick so i can destroy the gate
15:21:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
15:21:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Make API always RPC cast to conductor for resize/migrate https://review.opendev.org/693937
15:21:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
15:21:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
15:21:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
15:21:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
15:21:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
15:21:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
15:21:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070
15:21:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058
15:21:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
15:21:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
15:21:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
15:21:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
15:21:51 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.opendev.org/638046
15:21:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
15:21:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
15:21:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
15:22:11 mriedem dansmith: gibi_off: https://review.opendev.org/#/c/693937/ is fixed now
15:22:15 mriedem py2 vs py3 weirdness
15:27:09 openstackgerrit Merged openstack/nova master: Remove now invalid TODO from ComputeManager._confirm_resize https://review.opendev.org/693427
15:27:21 openstackgerrit Merged openstack/nova master: Use ListOfUUIDField from oslo.versionedobjects https://review.opendev.org/693258
15:27:37 openstackgerrit Merged openstack/nova master: Add known limitation about resize not resizing ephemeral disks https://review.opendev.org/691915
15:27:46 openstackgerrit Merged openstack/nova master: api-ref: re-work resize action post-conditions https://review.opendev.org/691918
15:27:56 openstackgerrit Merged openstack/nova master: Provide a better error when _verify_response hits a TypeError https://review.opendev.org/693042
15:30:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Use named kwargs in compute.API.resize https://review.opendev.org/693425
15:30:26 mriedem stephenfin: done ^
15:36:05 openstackgerrit Elod Illes proposed openstack/nova stable/pike: cleanup evacuated instances not on hypervisor https://review.opendev.org/687912
15:36:27 mdbooth lyarwood: Re https://review.opendev.org/#/c/694033/ What did you think about combining these 2 traits?
15:37:00 mdbooth IIUC their window of usefulness is limited to the period between stable disks and BFV rescue landing, right?
15:37:24 mdbooth COMPUTE_RESCUE_BFV implies COMPUTE_RESCUE_STABLE_DEVICES
15:39:02 lyarwood mdbooth: for the libvirt driver implementation yeah
15:40:48 sean-k-mooney i think having two traits is fine
15:41:01 mdbooth lyarwood: As I said in the spec, though, if this discussion gets in the way of getting this done, it's not worth it.
15:41:01 sean-k-mooney glad to see you put them under compute :)
15:41:32 mdbooth But I think 1 trait would be better.
15:42:07 sean-k-mooney its only better if we support rescue for BFV in the same step
15:42:21 sean-k-mooney or release
15:42:44 mdbooth sean-k-mooney: Right, but the change from stable disks to rescue BFV is trivial.
15:42:58 mdbooth IIRC it's just removing a check in the api which prevents it.
15:43:23 sean-k-mooney sure although one point. you cant assume that just using a usb device will mean it wont reorder the disk in all cases
15:43:37 sean-k-mooney its going to be true 99% of the time
15:43:43 mdbooth sean-k-mooney: That's unrelated.
15:44:00 mdbooth (True, but unrelated)
15:44:02 sean-k-mooney well its part of the premisis of the stable_device resuce spec
15:44:06 sean-k-mooney ya
15:44:39 lyarwood it's not going to reorder the physical layout, that's all we can guarantee
15:44:50 sean-k-mooney just said i would mention it since you can use hw_disk_bus to usb already https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L39
15:44:54 lyarwood everything else within the guestOS is out of our control
15:45:00 mdbooth Right. It's definitey way better than what we do now in all cases.
15:45:16 mdbooth lyarwood: Don't suppose you still have a link to the old patches kicking about, do you?
15:45:28 lyarwood yeah I'm working through a rebase now
15:45:54 lyarwood mdbooth: https://review.opendev.org/#/q/topic:bp/virt-rescue-stable-disk-devices
15:46:07 lyarwood mdbooth: hope to have it posted later this evening
15:47:02 mdbooth lyarwood: Cool. Did we discuss switching it on unconditionally in a new microversion, btw?
15:47:22 mdbooth IIRC there's a new microversion involved anyway.
15:48:31 lyarwood mdbooth: that's what I'm suggesting in the follow up spec at the moment
15:48:47 lyarwood mdbooth: well, with the trait
15:48:54 lyarwood mdbooth: so it's not unconditional
15:53:49 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: re-work migrate action post-conditions https://review.opendev.org/694103
15:54:54 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix review link. https://review.opendev.org/689612
15:59:05 openstackgerrit Elod Illes proposed openstack/nova stable/pike: Add functional test for resize crash compute restart revert https://review.opendev.org/687913
16:04:07 openstackgerrit Merged openstack/nova master: ItemsMatcher: mock call list arg in any order https://review.opendev.org/689487
16:04:11 artom sean-k-mooney, I know you're respinning https://review.opendev.org/#/c/674072/4 soon, but there are a couple more typos I found
16:04:57 mriedem melwitt: dansmith: this might have come up before and i'm just not remembering, but an instance that fails initial scheduling and is buried in cell0 doesn't have a 'create' instance action because we apparently don't create that in cell0
16:05:19 dansmith mriedem: not sure it has come up before
16:05:30 dansmith mriedem: did it have one prior to the bury-in-cell0 behavior?
16:05:46 melwitt I don't recall talking about this before either
16:07:53 mriedem looking back at mitaka, the api would create the 'create' action in the 'nova' cell db https://github.com/openstack/nova/blob/mitaka-eol/nova/compute/api.py#L1180 before casting off to conductor
16:08:53 mriedem i don't see anything in conductor which would "complete" that action with a fail even if scheduling failed https://github.com/openstack/nova/blob/mitaka-eol/nova/conductor/manager.py#L374
16:08:56 mriedem but at least the action would exist
16:09:05 dansmith ack
16:09:10 dansmith well, makes sense
16:11:22 openstackgerrit Elod Illes proposed openstack/nova stable/pike: Prevent init_host test to interfere with other tests https://review.opendev.org/687916
16:13:04 mriedem makes sense that we wouldn't create the instance action in cell0?
16:13:53 sean-k-mooney artom: cool i ran a spell check on it since i figured out how to do that with emacs
16:14:21 sean-k-mooney artom: im just running the tests currently
16:14:37 artom sean-k-mooney, it was just capitalization and "use case" into 2 words
16:15:24 openstackgerrit Merged openstack/nova master: Fix ItemMatcher to avoid false positives https://review.opendev.org/689690
16:15:59 mriedem sean-k-mooney: are you planning on writing functional tests for https://review.opendev.org/#/c/674072/ ?
16:17:06 dansmith mriedem: no makes sense that we missed doing that when we created bury-in-cell0, and makes sense that we should fix that
16:17:13 mriedem dansmith: ah ok
16:17:25 mriedem i'll open a bug in a bit
16:20:51 sean-k-mooney am i can if you would like them
16:21:23 mriedem ?
16:21:23 mriedem anything involving image meta / flavor extra specs + pci + affinity + scheduling + compute likely means unit tests aren't sufficient, yeah
16:21:29 mriedem maybe that's just me
16:21:48 openstackgerrit Alexandre arents proposed openstack/nova master: Abort live-migration during instance_init https://review.opendev.org/678016
16:23:26 sean-k-mooney mriedem: the code change is just reuseing the existing support for numa policies
16:23:44 sean-k-mooney so im jsut passing that policy via the flavor instead of the alisa

Earlier   Later