Earlier  
Posted Nick Remark
#openstack-nova - 2019-11-13
14:50:05 mriedem see ComputeManager.update_available_resource
14:50:47 mriedem or you're trying to do something outside of nova to try to expose a vulnerability?
14:51:09 bauzas efried: yeah, you need to know the (host, node) tuple
14:51:44 bauzas mriedem: and no, AFAICR, for some virt drivers, node != host
14:52:04 mriedem bauzas: yeah, ironic
14:52:05 mriedem i said that
14:52:13 bauzas mriedem: not only for ironic
14:52:17 mriedem which ones?
14:52:25 mriedem if you're thinking vcenter, you're thinking of kilo era
14:52:29 bauzas I don't remember, lemme look
14:53:29 efried I think I can work with this, thanks.
14:53:30 bauzas I do wonder for HyperV
14:53:41 mriedem hyperv has only 1 node per host
14:54:39 mriedem http://cloudbase-ci.com/nova/693937/1/windows/logs/n-h2-693937-1/nova-compute.log.gz
14:54:43 mriedem 2019-11-13 05:46:51.769 5012 103574784 GreenThread-1 INFO nova.compute.resource_tracker [req-320b7c3d-8917-4c50-b48e-18dd405c7877 - - - - -] Compute node record created for n-h2-693937-1:n-h2-693937-1 with uuid: 77e9e8d8-bba6-4aba-81f9-5e9f69ca1db9
14:55:15 mriedem ironic is the only weirdo
14:56:12 bauzas anyway, looks you're right
14:57:08 bauzas https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L9189
14:59:33 usr2033 Hi, can i pxe boot nova/kvm instances?
14:59:43 mriedem note that https://docs.openstack.org/nova/latest/admin/configuration/hypervisors.html doesn't have a subpage for ironic as a compute driver in nova - that's probably a decent sized gap given all of the edge cases we could describe with ironic in nova as a compute driver
14:59:47 openstackgerrit Merged openstack/python-novaclient master: Add minor version [21] to the test_versions https://review.opendev.org/688599
15:00:08 mriedem not to mention scaling issues when using the ironic driver to manage lots of nodes from a single compute service, re the ML threads on RT perf issues
15:02:10 mriedem usr2033: not natively no
15:02:13 mriedem see https://serverfault.com/questions/469479/does-nova-support-pxe-boot
15:03:38 mriedem usr2033: you may be interested in https://openstack-virtual-baremetal.readthedocs.io/en/latest/index.html
15:06:01 efried I may be choppy today, going to be trying to work remotely (like, more remotely than usual).
15:09:00 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'os-consoles' API https://review.opendev.org/687907
15:09:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
15:09:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-console' service, 'os-consoles' API https://review.opendev.org/687908
15:15:06 openstackgerrit Merged openstack/nova master: Remove TODOs around claim_resources_on_destination https://review.opendev.org/693635
15:15:41 openstack Launchpad bug 1852446 in OpenStack Compute (nova) "Hypervisors in nova - no subpage details for ironic" [Undecided,New]
15:15:41 mriedem bauzas: https://bugs.launchpad.net/nova/+bug/1852446
15:16:09 bauzas ack, good point
15:18:07 stephenfin mriedem: It's not urgent, but if you can rebase https://review.opendev.org/#/c/693425/ today I'm happy to push it through
15:19:29 mriedem ack, let me rebase the entire cross-cell series first quick so i can destroy the gate
15:21:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
15:21:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Make API always RPC cast to conductor for resize/migrate https://review.opendev.org/693937
15:21:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
15:21:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
15:21:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
15:21:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
15:21:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
15:21:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
15:21:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070
15:21:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058
15:21:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
15:21:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
15:21:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
15:21:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
15:21:51 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.opendev.org/638046
15:21:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
15:21:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
15:21:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
15:22:11 mriedem dansmith: gibi_off: https://review.opendev.org/#/c/693937/ is fixed now
15:22:15 mriedem py2 vs py3 weirdness
15:27:09 openstackgerrit Merged openstack/nova master: Remove now invalid TODO from ComputeManager._confirm_resize https://review.opendev.org/693427
15:27:21 openstackgerrit Merged openstack/nova master: Use ListOfUUIDField from oslo.versionedobjects https://review.opendev.org/693258
15:27:37 openstackgerrit Merged openstack/nova master: Add known limitation about resize not resizing ephemeral disks https://review.opendev.org/691915
15:27:46 openstackgerrit Merged openstack/nova master: api-ref: re-work resize action post-conditions https://review.opendev.org/691918
15:27:56 openstackgerrit Merged openstack/nova master: Provide a better error when _verify_response hits a TypeError https://review.opendev.org/693042
15:30:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Use named kwargs in compute.API.resize https://review.opendev.org/693425
15:30:26 mriedem stephenfin: done ^
15:36:05 openstackgerrit Elod Illes proposed openstack/nova stable/pike: cleanup evacuated instances not on hypervisor https://review.opendev.org/687912
15:36:27 mdbooth lyarwood: Re https://review.opendev.org/#/c/694033/ What did you think about combining these 2 traits?
15:37:00 mdbooth IIUC their window of usefulness is limited to the period between stable disks and BFV rescue landing, right?
15:37:24 mdbooth COMPUTE_RESCUE_BFV implies COMPUTE_RESCUE_STABLE_DEVICES
15:39:02 lyarwood mdbooth: for the libvirt driver implementation yeah
15:40:48 sean-k-mooney i think having two traits is fine
15:41:01 mdbooth lyarwood: As I said in the spec, though, if this discussion gets in the way of getting this done, it's not worth it.
15:41:01 sean-k-mooney glad to see you put them under compute :)
15:41:32 mdbooth But I think 1 trait would be better.
15:42:07 sean-k-mooney its only better if we support rescue for BFV in the same step
15:42:21 sean-k-mooney or release
15:42:44 mdbooth sean-k-mooney: Right, but the change from stable disks to rescue BFV is trivial.
15:42:58 mdbooth IIRC it's just removing a check in the api which prevents it.
15:43:23 sean-k-mooney sure although one point. you cant assume that just using a usb device will mean it wont reorder the disk in all cases
15:43:37 sean-k-mooney its going to be true 99% of the time
15:43:43 mdbooth sean-k-mooney: That's unrelated.
15:44:00 mdbooth (True, but unrelated)
15:44:02 sean-k-mooney well its part of the premisis of the stable_device resuce spec
15:44:06 sean-k-mooney ya
15:44:39 lyarwood it's not going to reorder the physical layout, that's all we can guarantee
15:44:50 sean-k-mooney just said i would mention it since you can use hw_disk_bus to usb already https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L39
15:44:54 lyarwood everything else within the guestOS is out of our control
15:45:00 mdbooth Right. It's definitey way better than what we do now in all cases.
15:45:16 mdbooth lyarwood: Don't suppose you still have a link to the old patches kicking about, do you?
15:45:28 lyarwood yeah I'm working through a rebase now
15:45:54 lyarwood mdbooth: https://review.opendev.org/#/q/topic:bp/virt-rescue-stable-disk-devices
15:46:07 lyarwood mdbooth: hope to have it posted later this evening
15:47:02 mdbooth lyarwood: Cool. Did we discuss switching it on unconditionally in a new microversion, btw?
15:47:22 mdbooth IIRC there's a new microversion involved anyway.
15:48:31 lyarwood mdbooth: that's what I'm suggesting in the follow up spec at the moment
15:48:47 lyarwood mdbooth: well, with the trait
15:48:54 lyarwood mdbooth: so it's not unconditional
15:53:49 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: re-work migrate action post-conditions https://review.opendev.org/694103
15:54:54 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix review link. https://review.opendev.org/689612
15:59:05 openstackgerrit Elod Illes proposed openstack/nova stable/pike: Add functional test for resize crash compute restart revert https://review.opendev.org/687913
16:04:07 openstackgerrit Merged openstack/nova master: ItemsMatcher: mock call list arg in any order https://review.opendev.org/689487
16:04:11 artom sean-k-mooney, I know you're respinning https://review.opendev.org/#/c/674072/4 soon, but there are a couple more typos I found
16:04:57 mriedem melwitt: dansmith: this might have come up before and i'm just not remembering, but an instance that fails initial scheduling and is buried in cell0 doesn't have a 'create' instance action because we apparently don't create that in cell0

Earlier   Later