| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-07 | |||
| 15:15:28 | efried | I've seen it done, I know it's true. This is closer than usual, but there's no sense putting up a review with a hundred typo comments. | |
| 15:15:49 | dansmith | a hundred typos is closer than usual? ouch :D | |
| 15:23:48 | mriedem | people must be working b/c the gate is load failing a bit again today | |
| 15:25:52 | openstackgerrit | ya.wang proposed openstack/nova-specs master: Re-propose expose-auto-converge-post-copy spec for Ussuri https://review.opendev.org/687199 | |
| 15:27:41 | mriedem | lyarwood: the long term solution to crap like https://review.opendev.org/682523 is i think https://review.opendev.org/#/c/650188/ | |
| 15:27:58 | mriedem | the imagebackend tells us about shared or not for the root disk storage, | |
| 15:28:05 | mriedem | placement tells us if the local host disk is on shared storage | |
| 15:28:17 | mriedem | no more trying to guess based on imagebackend (wrongly), | |
| 15:28:33 | mriedem | no more trying to create temp files to see if we can on the remote host | |
| 15:28:55 | mriedem | no more shared ssh keys if you're using shared storage, | |
| 15:29:10 | mriedem | and we could schedule within a shared storage pool for things like live migration if you don't use shared ssh keys | |
| 15:29:26 | mriedem | god everybody wins! | |
| 15:31:30 | lyarwood | mriedem: ack yeah agreed, the question about a refactor was actually to mdbooth but yeah ultimatley that spec is going to solve alot of this. | |
| 15:35:11 | mriedem | oh, the *other* matt | |
| 15:36:52 | lyarwood | yup my bad sorry | |
| 15:37:14 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add spec for VM-scoped SR-IOV NUMA affinity https://review.opendev.org/683174 | |
| 15:37:22 | efried | sean-k-mooney: done ^ | |
| 15:38:02 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Rename _is_storage_shared_with to _is_path_shared_with https://review.opendev.org/693337 | |
| 15:39:00 | openstackgerrit | Merged openstack/nova stable/stein: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693242 | |
| 15:41:22 | mriedem | easy cross-cell-resize change here at the bottom of the stack to keep the series moving https://review.opendev.org/#/c/669012/ | |
| 15:53:57 | efried | mriedem: question there, but generally makes sense to me. | |
| 15:56:30 | sean-k-mooney | efried: thanks are you generally ok with it? | |
| 15:57:14 | efried | sean-k-mooney: I didn't actually read it; I'm doing that now. Note that I'm pretty weak on things involving NUMA, SR-IOV, and PCI so I probably won't be able to do more than +1 anyway. | |
| 15:58:06 | jamesdenton | sean-k-mooney I have some hardware here to kick the tires on that, but it may be next week before i have a chance | |
| 15:58:08 | efried | yeah, sorry, when I said "done" I just ment the copy edit | |
| 15:58:34 | dansmith | efried: gave you my answer on mriedem's patch at least (and +2d) | |
| 15:58:41 | efried | ack | |
| 15:58:46 | sean-k-mooney | jamesdenton: cool, 99% is just using code that was already there | |
| 15:58:52 | dansmith | actually had a tab open with a +2 on that from yesterday that I never hit go on | |
| 15:59:47 | efried | dansmith: +A, thanks for confirming. | |
| 16:00:07 | efried | jamesdenton: are you in operator-land? Is sean-k-mooney's use case a thing you care about? | |
| 16:02:30 | mriedem | efried: replied with the big details | |
| 16:03:19 | jamesdenton | i am in operator-land. The use-case doesn't directly impact me, but i try to stay tuned to what's happening with SRIOV for our customers that do use it | |
| 16:04:19 | mriedem | efried: dansmith: thanks | |
| 16:04:42 | mriedem | tell me when my asking for reviews on this series gets too annoying | |
| 16:05:34 | mriedem | also, my wife and daughter just left for disney world (meeting up with my mother in law), you know what that means! | |
| 16:05:52 | efried | mriedem: squeaky wheel and all that. Keep spoonfeeding me the easy ones and I'll keep reviewing them. Still haven't made it all the way through the review guide to hit the heavier ones | |
| 16:05:58 | dansmith | mriedem: eating raw brownie batter shirtless over the sink time! | |
| 16:06:07 | mriedem | close! | |
| 16:06:20 | mriedem | let's just say i still haven't showered or put contacts in yet today | |
| 16:06:38 | efried | I can smell you from here | |
| 16:06:39 | dansmith | get some brownie batter and you've got a party! | |
| 16:06:47 | mriedem | efried: yeah i've been trying to front-load as much of the simpler mechanical and test-only things for that reason | |
| 16:06:53 | mriedem | pants of dance off! | |
| 16:06:56 | mriedem | *off | |
| 16:08:14 | efried | dansmith: I'll take my slice of humble pie from you, but you've got some nerve disagreeing with jacky06 on https://review.opendev.org/#/c/688122/ | |
| 16:11:14 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add spec for VM-scoped SR-IOV NUMA affinity https://review.opendev.org/683174 | |
| 16:11:26 | efried | d'oh, forgot to save my last batch of edits sean-k-mooney ^ | |
| 16:24:08 | dansmith | efried: my finger quivered with nerves as I hit the submit button on that one for sure | |
| 16:54:36 | efried | sean-k-mooney: reviewed, +2 | |
| 16:56:13 | sean-k-mooney | efried: thanks. | |
| 17:07:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert nova-live-migration job to zuulv3 https://review.opendev.org/693364 | |
| 17:45:30 | openstackgerrit | Eric Fried proposed openstack/nova master: Add emulated TPM support to Nova https://review.opendev.org/631363 | |
| 17:45:31 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: vTPM request_filter https://review.opendev.org/678325 | |
| 17:45:31 | openstackgerrit | Eric Fried proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 18:00:16 | sean-k-mooney | efried: by the way are you taking over teh vTPM stuff in general this cycle | |
| 18:02:06 | sean-k-mooney | i have added them to my review list in anycase | |
| 18:03:02 | efried | sean-k-mooney: yes. It's actually the whole reason I'm trying to get a devstack with modern libvirt/qemu. It's a nontrivial delta from the previously approved spec as it has to include the encryption bits. | |
| 18:03:07 | efried | and I still don't know wtf that means yet. | |
| 18:03:11 | efried | so, experimenting. | |
| 18:03:41 | sean-k-mooney | oh so the vTPM will actully encrypt its contence on the hsot | |
| 18:03:45 | sean-k-mooney | *host | |
| 18:04:04 | efried | yes, via a virsh "secret" | |
| 18:04:12 | sean-k-mooney | ya that would be a good improvment. | |
| 18:04:20 | efried | but I don't know how the "secret" gets to nova, and I don't know how the VM unlocks it. | |
| 18:04:35 | efried | the docs are pretty sparse | |
| 18:04:40 | efried | so, experimenting. | |
| 18:05:04 | efried | nice | |
| 18:05:16 | efried_afk | dansmith: local buffering fail --^ | |
| 18:05:42 | dansmith | efried_afk: boo local buffering | |
| 18:35:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use openstack server create --boot-from-volume in test_evacuate.sh https://review.opendev.org/693406 | |
| 18:48:04 | artom | mriedem, maybe a stupid question on ^^ | |
| 18:48:53 | mriedem | sob | |
| 18:51:18 | mriedem | get your downvote in while it's hot | |
| 18:51:52 | artom | OK :) | |
| 18:52:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use openstack server create --boot-from-volume in test_evacuate.sh https://review.opendev.org/693406 | |
| 18:56:03 | artom | mriedem, did we also not change the devstack default disk size to be 2 to help with the gate? | |
| 18:56:47 | artom | I suppose size was 1 before, it can stay 1 | |
| 18:57:28 | mriedem | this? https://review.opendev.org/#/c/690991/ | |
| 18:57:57 | artom | Yeah | |
| 18:58:29 | mriedem | i don't think that's going anywhere anytime soon | |
| 18:58:54 | artom | Fair enough | |
| 18:59:22 | openstackgerrit | Merged openstack/nova master: Use admin neutron client to query ports for binding https://review.opendev.org/690999 | |
| 18:59:30 | openstackgerrit | Merged openstack/nova master: Use admin neutron client to gather port resource requests https://review.opendev.org/691005 | |
| 19:05:29 | artom | \o/ | |
| 19:05:53 | artom | Actually had some of the tests in https://review.opendev.org/#/c/691062/ pass | |
| 19:06:02 | artom | Meaning the basics for a whitebox Zuul job are in place | |
| 19:06:58 | artom | sean-k-mooney's probably the only one who groked that, but hopefully whitebox will become more of a thing with time | |
| 19:08:37 | sean-k-mooney | i should proably add that to my review list | |
| 19:09:10 | sean-k-mooney | also how is that on ps34 already | |
| 19:09:11 | artom | I was going to ask anyways | |
| 19:09:17 | artom | I suck at Zuul | |
| 19:09:22 | artom | And Devstack | |
| 19:09:27 | artom | And... in general :( | |
| 19:09:44 | sean-k-mooney | there is a joke there :) | |
| 19:10:12 | artom | There are jokes everywhere | |
| 19:10:31 | artom | The question is. Who's laughing. | |
| 19:10:41 | artom | *dun dun dun* | |
| 19:11:32 | artom | Wrong channel, but sure | |
| 19:13:59 | sean-k-mooney | im sure i can find upstream ones | |