| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-05 | |||
| 18:17:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.opendev.org/638046 | |
| 18:25:21 | dansmith | mriedem: I'm missing something | |
| 18:27:48 | dansmith | okay I think I see, but I feel like now the flow is more confusing than it was before | |
| 18:28:12 | dansmith | all the nested conditions make it hard for me to tell what states you can end up in after your fall out of all of it | |
| 18:28:35 | dansmith | and having the two "restricting" cases is not helping | |
| 18:29:08 | dansmith | I feel like that is a lot more complicated just because we're trying to log a message there about something that will happen later based on a flag we're not even concerned with | |
| 18:30:15 | dansmith | maybe it's more complicated because of the later change you commented about but... it's pretty confusing | |
| 18:30:42 | dansmith | ....which adds another level of nested conditional | |
| 18:30:50 | dansmith | and more logs | |
| 18:31:27 | dansmith | maybe it's just me, and sorry if so, but I think that end state tripley-nested conditional thing is just a total nightmare | |
| 18:39:10 | openstackgerrit | Archit Modi proposed openstack/nova master: Fix block-device-mapping parameter naming https://review.opendev.org/693065 | |
| 18:40:33 | dansmith | mriedem: totally untested, but I think this rearrangement of the final code works the same and is easier to follow? https://pastebin.com/Hq61MM2V | |
| 18:57:41 | mriedem | that paste could work, it's fine with me. it's after the targeted host thing so https://review.opendev.org/#/c/635668/ would be different | |
| 18:58:55 | mriedem | unless you're suggesting munging those changes together | |
| 19:00:26 | dansmith | mriedem: no, I'm not suggesting muging, I just chose the final state to demonstrate what I think it needs to look like | |
| 19:03:53 | mriedem | i'm tinkering | |
| 19:04:09 | melwitt | mriedem: I added you to what's turning out to be a hairy review for a bfv docs fix https://review.opendev.org/693065 | |
| 19:05:06 | melwitt | I think it probably just needs to be updated to use --boot-from-volume (new in 4.0.0 added by you) because it's a confusing mix of wrong osc commands and correct nova boot commands | |
| 19:05:27 | melwitt | but you know best | |
| 19:05:41 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 19:05:41 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 19:05:42 | openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Merge provider configs to provider tree https://review.opendev.org/676522 | |
| 19:06:27 | mriedem | melwitt: ok so this was likely a case of a doc being straight up changed from nova boot to just openstack server create with no thought to the implications of the actual option names or what was supported at the time | |
| 19:06:28 | mriedem | fun | |
| 19:06:36 | melwitt | exactly | |
| 19:12:06 | mriedem | melwitt: left some thoughts on how to maybe break that down into more manageable chunks | |
| 19:12:15 | mriedem | b/c i really hate fixing lots of random shit like this in the docs in the same patch | |
| 19:12:19 | mriedem | easy to get something wrong | |
| 19:12:40 | artom | alias 'openstack server create' 'nova boot' amirite | |
| 19:12:41 | melwitt | cool thanks | |
| 19:13:45 | mriedem | dansmith: ok so this would be pass 1 http://paste.openstack.org/show/785820/ | |
| 19:13:53 | mriedem | for https://review.opendev.org/#/c/635668/ | |
| 19:14:50 | mriedem | which i'd build on with the targeted host stuff in https://review.opendev.org/#/c/642591/ later | |
| 19:14:55 | mriedem | to be more like your final paste | |
| 19:18:32 | melwitt | mriedem: so first step is just replace 'openstack server create' with 'nova boot' to make everything work correctly, backport that. then next step is just convert everything to osc commands properly. I don't think I understand the middle step you described | |
| 19:18:47 | melwitt | or rather I'm seeing 2 steps instead of 3 | |
| 19:20:34 | mriedem | no there is still a nova boot example in there https://review.opendev.org/#/c/693065/1/doc/source/user/launch-instance-from-volume.rst@224 | |
| 19:20:37 | mriedem | so i was saying: | |
| 19:20:44 | mriedem | 1. revert to using nova boot everywhere | |
| 19:20:48 | mriedem | which is backportable | |
| 19:21:03 | dansmith | mriedem: did I miss that requested_destination can be set and None? | |
| 19:21:08 | mriedem | 2. fix the non nova boot (so not https://review.opendev.org/#/c/693065/1/doc/source/user/launch-instance-from-volume.rst@224) openstack server create usage | |
| 19:21:28 | mriedem | 3. replace the remaining nova boot example with openstack server create and mention --boot-from-volume since osc 4.0.0 | |
| 19:21:46 | mriedem | dansmith: that was the existing logic and is what we do elsewhere for setting the cell when moving the server | |
| 19:22:19 | dansmith | aight | |
| 19:22:31 | mriedem | melwitt: that's just how i'd tackle that to try and keep it small and sane for each thing getting fixed | |
| 19:22:50 | mriedem | rather than do it all in a single change stephen style :P and wait for 8 months for someone to review the doc fix | |
| 19:23:19 | melwitt | mriedem: yeah, sorry. I'm just thinking after we revert to nova boot everywhere, there won't be any non nova boot for step 2 | |
| 19:23:22 | mriedem | dansmith: this is my end product http://paste.openstack.org/show/785821/ | |
| 19:23:31 | mriedem | no test changes | |
| 19:23:47 | dansmith | mriedem: hundy times better, IMHO | |
| 19:23:47 | mriedem | melwitt: oh yeah you're right | |
| 19:23:54 | mriedem | dansmith: ok pushing | |
| 19:25:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | |
| 19:25:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | |
| 19:25:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | |
| 19:25:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | |
| 19:25:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | |
| 19:25:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | |
| 19:25:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | |
| 19:25:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | |
| 19:25:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | |
| 19:25:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | |
| 19:25:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070 | |
| 19:25:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058 | |
| 19:25:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316 | |
| 19:25:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075 | |
| 19:25:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453 | |
| 19:25:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630 | |
| 19:25:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.opendev.org/638046 | |
| 19:25:23 | mriedem | melwitt: i guess the alternative is just (1) fix the existing busted osc usage in there, and (2) convert the remaining nova boot to osc and also mention --boot-from-volume | |
| 19:25:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647 | |
| 19:25:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048 | |
| 19:25:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047 | |
| 19:25:51 | mriedem | the change right now just seems like it's trying to do too much and getting some of what it's trying to fix wrong - or incomplete | |
| 19:26:11 | melwitt | mriedem: yeah, I feel like reverting to nova boot and backport is the right first step | |
| 19:26:30 | mriedem | that works for me. | |
| 19:26:31 | melwitt | because actually making it correct for osc is not straightforward | |
| 19:26:37 | mriedem | btw, i thought rhosp had it's own docs and didn't use upstream? | |
| 19:26:43 | melwitt | and would be better off as a separate change | |
| 19:27:36 | amodi | mriedem: melwitt sure, updting the patch to use nova boot | |
| 19:28:08 | amodi | yes, we dont use upstream, except when we do :) | |
| 19:28:18 | mriedem | btw, this was the breaking change in the manuals repo https://review.opendev.org/#/c/404623/ | |
| 19:29:14 | melwitt | yeah, that was part of the big sweep that did some find/replaces. other docs of ours became wrong in that sweep, can't remember which atm | |
| 19:29:25 | melwitt | oh, the quota stuf | |
| 19:29:30 | melwitt | stuff | |
| 19:30:39 | mriedem | yup the quota one was annoying | |
| 19:30:49 | mriedem | i left an updated comment on amodi's change hopefully clearing it up | |
| 19:31:05 | mriedem | amodi: btw, you should create a doc bug for this since we'll backport the fix | |
| 19:31:41 | mriedem | and now i'm off to vote on raising my taxes for schools because i love the children | |
| 19:32:09 | amodi | mriedem: ack, will do, and im just updating this doc | |
| 19:32:32 | amodi | or if u want me to update all the other ones in the referenced changed, lmk | |
| 19:33:06 | mriedem | amodi: just that doc. i didn't look through https://review.opendev.org/#/c/404623/ to see if it broke other stuf | |
| 19:33:07 | mriedem | *stuff | |
| 19:33:38 | melwitt | it broke the boot from ISO image too (still looking) | |
| 19:33:43 | amodi | https://review.opendev.org/#/c/404623/8/doc/user-guide/source/cli-nova-launch-instance-using-ISO-image.rst this has the --block-device used with osc command | |
| 19:34:26 | melwitt | the other stuff is probably ok | |
| 19:34:31 | mriedem | ah yeah that is wrong, osc before 4.0 didn't have a way to boot with an image and create a blank volume | |
| 19:34:37 | mriedem | yeah the rest looked ok | |
| 19:35:15 | amodi | cool, will update thanks! | |