| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-04 | |||
| 16:53:11 | efried | so if you wouldn't mind reading my latest comments (when you get a chance) and if you agree with what I'm saying, go ahead and -2 and I'll follow suit. | |
| 16:53:21 | dansmith | sure | |
| 16:53:22 | efried | thx | |
| 16:53:46 | mriedem | i have run into "I don't want the author to take our -1s as a message that he should go try to fill it in." on a couple of specs for ussuri even though i've said a few times, "i don't think we need to do this, the existing alternatives or sufficient or this doesn't fit with the project IMO" but the specs continue to be updated | |
| 16:54:07 | mriedem | *are sufficient | |
| 16:54:29 | mriedem | i probably haven't -2ed because they are mostly trivial things to do, just plumbing, | |
| 16:54:40 | mriedem | not anywhere near the complexity of this flavor groups tihng | |
| 16:54:42 | mriedem | *thing | |
| 16:56:10 | cdent | Explicit words might be the way to go. | |
| 16:57:27 | dansmith | cdent: my words were explicit, but I hedged on the vote | |
| 16:57:44 | dansmith | because people sometimes accuse me of closing the door to further reviews with a -2 or even a -1 | |
| 16:58:02 | cdent | well closing the door is what's wanted here, yeah? | |
| 16:58:22 | dansmith | well, | |
| 16:58:38 | dansmith | yes, but I want to do that in concert with other reviewers, like efried and I just did | |
| 16:59:20 | dansmith | so which do I need to kill? there is public, private, and shared | |
| 16:59:25 | dansmith | oops, wrong window | |
| 16:59:42 | cdent | all three /me is all for early kills | |
| 16:59:45 | cdent | ! | |
| 17:02:48 | mriedem | https://review.opendev.org/#/c/682302/ and https://review.opendev.org/#/c/580336/ are the ones i'm struggling with fwiw | |
| 17:02:54 | mriedem | the latter has been coming up since berlin | |
| 17:03:17 | mriedem | and we have decent alternatives already available, though like i said the change itself would probably be pretty minimal | |
| 17:06:21 | dansmith | efried: done | |
| 17:06:28 | efried | thanks dansmith, following | |
| 17:09:50 | dansmith | huh, devstack defaults to configuring us for unversioned notifications apparently? | |
| 17:10:40 | mriedem | yeah, because downstream projects don't all use versioned | |
| 17:10:50 | mriedem | i seem to remember this coming up recently(ish) too when debugging something for watcher | |
| 17:11:08 | mriedem | i think b/c we (nova) changed our default | |
| 17:11:33 | mriedem | yup https://review.opendev.org/#/q/Ied9d50b07c368d5c2be658c744f340a8d1ee41e0 | |
| 17:21:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Follow up to I3e28c0163dc14dacf847c5a69730ba2e29650370 https://review.opendev.org/692856 | |
| 17:23:54 | mriedem | heh that long_rpc_timeout change just merge conflicted most of the cross-cell-resize series, yay | |
| 17:25:12 | dansmith | red pill or blue pill... | |
| 17:26:02 | mriedem | oh well, needed to work on adding unit tests to https://review.opendev.org/#/c/637630/47 anyway so might as well rebsae | |
| 17:26:04 | mriedem | *rebase | |
| 17:27:49 | mriedem | the gate is empty due to the summit so it's actually the best time | |
| 17:31:45 | mriedem | that reminds me, | |
| 17:31:55 | mriedem | efried: https://review.opendev.org/#/q/topic:bp/support-move-ops-with-qos-ports-ussuri+status:open if you have some time - i can probably answer questions | |
| 17:32:15 | mriedem | the bottom one is mostly only big b/c of tests | |
| 17:33:53 | efried | mriedem: oh, yeah, lost on my list... | |
| 18:10:32 | openstackgerrit | Merged openstack/nova stable/stein: Avoid error 500 on shelve task_state race https://review.opendev.org/692630 | |
| 18:10:37 | openstackgerrit | Merged openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | |
| 18:35:10 | dansmith | teehee | |
| 18:35:46 | dansmith | starting up 100 fake compute services on one machine... load of over 40 as they all slam the ever-loving crap out of conductor trying to create their db entries | |
| 18:36:15 | openstackgerrit | Merged openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | |
| 18:49:46 | mriedem | dansmith: how big is the host? | |
| 18:49:57 | dansmith | how big? | |
| 18:50:07 | dansmith | about yay big | |
| 18:50:09 | mriedem | i do the fake compute thing in a 8vcpu/8gb ram vm sometimes and can't really go over 30 computes | |
| 18:50:10 | dansmith | about 19" wide | |
| 18:50:30 | mriedem | cpu/ram | |
| 18:50:44 | dansmith | oh, 32G memory, 8 cores if that's what you mean | |
| 18:50:54 | mriedem | yeah | |
| 18:51:10 | mriedem | did you adjust API_WORKERS or let it do ncpu/2? | |
| 18:51:31 | dansmith | just defaults | |
| 18:52:25 | mriedem | ah. fake computes huh. so all that time trying to figure out which network to delete and you found out you can't create a fake driver vm with networking anyway right? | |
| 18:52:48 | mriedem | i always forget that when i do a devstack with the fake driver | |
| 18:53:36 | mriedem | i had written up some of that here at one point https://docs.openstack.org/devstack/latest/guides/nova.html#fake-virt-driver | |
| 18:53:37 | dansmith | one real compute and then a bunch of extra fakes on the same machine | |
| 18:53:41 | mriedem | ah ok | |
| 18:53:49 | mriedem | smells like someone is playing with aggregates | |
| 19:17:58 | mriedem | wonder if we can nuke this yet, nothing in or out of tree returns True for it that i can find https://opendev.org/openstack/nova/src/branch/master/nova/virt/driver.py#L1740 | |
| 19:18:53 | mriedem | oh nvm i guess it defaults to True in the ComputeDriver parent class and zvm doesn't override it... | |
| 19:18:58 | mriedem | or xenapi | |
| 20:07:57 | mriedem | artom: https://review.opendev.org/#/c/594139/ - am i misunderstanding your comment? | |
| 20:08:28 | artom | mriedem, lemme reload context | |
| 20:09:49 | artom | o_O | |
| 20:10:00 | artom | I am apparently retarded. | |
| 20:10:08 | mriedem | did your brain fart on how if/elif works? | |
| 20:10:14 | artom | Clearly | |
| 20:10:18 | artom | I remember double-checking myself as well | |
| 20:10:23 | artom | Thinking "no way Matt did that" | |
| 20:10:46 | mriedem | s'ok | |
| 20:11:10 | mriedem | that rollback code is all gorpy | |
| 20:12:45 | artom | mriedem, fixed | |
| 20:12:53 | artom | mriedem, lemme look it over once again, then +1 | |
| 20:13:04 | mriedem | sure, thanks | |
| 20:13:39 | artom | I was busy shitting all over https://review.opendev.org/#/c/512815/8 | |
| 20:13:42 | artom | Politely | |
| 20:18:10 | openstackgerrit | Merged openstack/nova stable/rocky: Avoid error 500 on shelve task_state race https://review.opendev.org/692631 | |
| 20:21:12 | eandersson | btw anyone got any experience with the keep alive issue and openstack services? I noticed a bug or two reported for nova and failures | |
| 20:21:58 | eandersson | > 'Connection aborted.', BadStatusLine("''",) | |
| 20:22:13 | eandersson | A few of the bug reports indicates that disabling keepalive would resolve some of these. | |
| 20:26:00 | efried | mriedem: One question on the qos patches (I'm on the bottom one rn): It looks like some of the code is being hit for both evacuate and rebuild. It wouldn't do any harm for the latter, since it's just populating the rg/rp mappings. But just wanted to confirm that's what I'm seeing? | |
| 20:26:05 | mriedem | artom: oh wow that's fun, smells like starlingx | |
| 20:26:29 | artom | mriedem, yeah eh? | |
| 20:26:32 | mriedem | starlingx did a lot of hacks with libvirt channels | |
| 20:26:37 | efried | mriedem: specifically these changes? https://review.opendev.org/#/c/688387/8/nova/conductor/manager.py | |
| 20:27:45 | mriedem | artom: good comments on that patch btw | |
| 20:27:46 | mriedem | all valid poitns | |
| 20:27:48 | mriedem | *points | |
| 20:27:53 | artom | I'm useful! | |
| 20:28:04 | mriedem | makes up for your lack of if/elif knowledge :) | |
| 20:28:08 | artom | Hahaha | |
| 20:28:38 | mriedem | efried: hmm, weird | |
| 20:28:42 | mriedem | s/weird/where/? | |
| 20:28:51 | mriedem | https://review.opendev.org/#/c/688387/8/nova/compute/manager.py only does the port mapping stuff if evacuate | |
| 20:29:05 | mriedem | same in https://review.opendev.org/#/c/688387/8/nova/conductor/manager.py | |
| 20:29:20 | mriedem | or are you asking, why do we only do that for evacuate? | |
| 20:29:26 | efried | No | |
| 20:29:56 | efried | in one file the bool is called 'evacuate', so I can buy that it's only happening for evacuate. In the other it's called 'recreate' and the comments imply we're hitting the path for both evacuate and rebuild. | |
| 20:30:11 | mriedem | in compute manager that evacuate variable used to be called recreate as well, | |