| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-31 | |||
| 13:47:05 | mriedem | it's not on pypi, | |
| 13:47:12 | efried | that neiter | |
| 13:47:13 | mriedem | it's a python lib built from the rbd binary | |
| 13:47:14 | mriedem | i think | |
| 13:47:14 | efried | neither | |
| 13:47:44 | efried | that error is only showing up on the "stop testing with py2" patch and the one above it, per logstash. But I don't see how that patch could have affected that job. | |
| 13:48:07 | mriedem | efried: we should do https://review.opendev.org/#/c/691765/ first then | |
| 13:48:10 | mriedem | in case it's related | |
| 13:48:38 | mriedem | though, | |
| 13:48:44 | mriedem | that's not the job that's failing in the drop py2 change right? | |
| 13:49:15 | mriedem | the nova-live-migration and nova-grenade-multinode jobs have a post-test hook script that sets up ceph | |
| 13:49:22 | efried | correct, but I'll approve that change anyway. | |
| 13:49:25 | mriedem | and those likely aren't setting USE_PYTHON3 | |
| 13:50:18 | mriedem | i can wip something up quick to try to move those to py3 | |
| 13:50:20 | efried | the other one is failing with a weird PyYAML dep | |
| 13:50:34 | efried | mriedem: stuff it in the pile underneath 'remove py2'? | |
| 13:50:38 | mriedem | yes | |
| 13:50:54 | mriedem | does this call for a "back to the pile" south park reference?! | |
| 13:51:14 | efried | It wasn't intentional. My South Park knowledge is slim | |
| 13:51:25 | mriedem | it's nsfw anyway | |
| 13:51:36 | efried | when have you ever cared about that? | |
| 13:51:48 | mriedem | ... | |
| 13:51:59 | mriedem | i've gotten better after being burned a few times over the years | |
| 13:52:10 | mriedem | despite artom still leaving traps for me | |
| 13:52:16 | efried | The PyYAML thing would be happening earlier than the rbd fail, so it's possible it would have hit the same thing later anyway. | |
| 13:52:57 | artom | mriedem, hey man, I've always had plausible deniability for everything, those traps are in your head | |
| 13:53:00 | efried | but again, I don't see how the 'stop testing py2' patch would have changed anything that would make the hook setup change. | |
| 13:53:18 | efried | the straight man in the comedy duo | |
| 13:53:59 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3 https://review.opendev.org/692374 | |
| 13:54:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3 https://review.opendev.org/692374 | |
| 13:54:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | |
| 13:55:00 | mriedem | let's see how that works | |
| 13:55:11 | mriedem | mels, then mine, then stephens | |
| 13:55:20 | efried | zuul kicked it | |
| 13:55:27 | efried | nm | |
| 13:55:32 | efried | nova meeting in five minutes | |
| 13:57:31 | sean-k-mooney | efried: that reminds me i need to recheck your os-vif job change. | |
| 13:57:40 | sean-k-mooney | i think the devstack patch should now be merged | |
| 13:58:51 | sean-k-mooney | actully no it faild to merge and is being rechecked so ill wait | |
| 14:00:17 | efried | thanks for keeping track of that sean-k-mooney | |
| 14:02:22 | sean-k-mooney | we should wait until after m1 to merge the os-vif change in anycase but ill keep an eye on it till then | |
| 14:09:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API https://review.opendev.org/469675 | |
| 14:09:07 | mriedem | dansmith: updated ^ with a test and fix for a thing alex_xu found (thanks alex) | |
| 14:09:19 | dansmith | I saw | |
| 14:10:21 | openstack | Launchpad bug 1850736 in OpenStack Compute (nova) " MemoryPageSizeInvalid: Invalid memory page size" [Undecided,New] | |
| 14:10:21 | mriedem | sean-k-mooney: i want to say this is a duplicate of an existing bug but haven't dug for it, maybe you know? https://bugs.launchpad.net/nova/+bug/1850736 | |
| 14:11:35 | sean-k-mooney | mriedem: i have not looked at that but ill do it now and update it | |
| 14:11:58 | sean-k-mooney | also til packstack is still used... | |
| 14:29:42 | dansmith | oh jeez, today is halloween | |
| 14:29:48 | dansmith | totes forgot | |
| 14:43:18 | mdbooth | not impact the backportability of this patch at all. | |
| 14:43:18 | mdbooth | sean-k-mooney: My concern with the 'Don't clean anything up because we want to backport it' philosophy is that it means nothing ever gets cleaned up, which means we just end up accumulating duplicated crap. You could move the generic parts of NUMAServersTestNew to a reusable location and it would | |
| 14:43:55 | mriedem | dansmith: i don't want to alarm you, but you should probably get to your panic room in the basement soon | |
| 14:43:59 | mriedem | the kids start earlier and earlier | |
| 14:44:01 | mdbooth | At some point you have to clean stuff up. That impacts backports. The alternative is never clean anything up. | |
| 14:44:25 | mriedem | mdbooth: it's not that black and white, | |
| 14:44:51 | mriedem | if you've got 3 refactors leading up to a bug fix that is going to be backported, try to minimize change to make the fix backportable, and stack the refactors on top | |
| 14:44:53 | dansmith | mriedem: remember, my house automatically shuts off all front-facing illumination on 10/31 | |
| 14:44:58 | dansmith | it remembered, I didn't | |
| 14:45:17 | mdbooth | dansmith: Nice :) | |
| 14:45:56 | mriedem | the cirros image we're using in the gate (0.4.0) is ~2 years old... | |
| 14:46:01 | mriedem | but there isn't anything newer | |
| 14:46:27 | efried | mriedem: here's that rbd thing http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22RuntimeError%3A%20rbd%20python%20libraries%20not%20found%5C%22 | |
| 14:46:35 | sean-k-mooney | mdbooth: halloween is an irish holiday | |
| 14:46:53 | sean-k-mooney | we exported it to the us and they may have exported it to the uk | |
| 14:46:54 | mdbooth | sean-k-mooney: What are you doing at work, then? | |
| 14:47:06 | efried | mriedem: am I reading that correctly, 80 hits in like 12 minutes? | |
| 14:47:20 | sean-k-mooney | we had the bankholiday on monday | |
| 14:47:20 | mdbooth | Ok, I may have claimed to have no beef with Ireland in the past, but now I'm mad. | |
| 14:47:43 | sean-k-mooney | trick or treating was not part of the irish holiday by the way | |
| 14:48:04 | sean-k-mooney | that was added in the us | |
| 14:48:19 | mdbooth | mriedem: Sure, but in the case of sean-k-mooney's patch the 'refactor' is just putting the generic stuff somewhere else. | |
| 14:48:24 | sean-k-mooney | it orgially was a pagan festival with games and music and stuff | |
| 14:49:01 | mdbooth | And if you invert the order, it's still going to hit the backportability of the next thing | |
| 14:49:14 | sean-k-mooney | mdbooth: mriedem i have no issue with wriing another patch to refactor my test on top of mdbooth refactor by the way | |
| 14:49:14 | mdbooth | So if the cost is low, meh | |
| 14:49:28 | mdbooth | sean-k-mooney: My thing is gone | |
| 14:49:39 | mdbooth | sean-k-mooney: I'm not using libvirt for that functional test any more | |
| 14:49:41 | sean-k-mooney | oh ok did not know that | |
| 14:49:56 | sean-k-mooney | well i dont need libvirt in this case either | |
| 14:50:07 | sean-k-mooney | its just the only numa test we currently have | |
| 14:50:38 | mdbooth | sean-k-mooney: I was just advocating that rather than essentially rewriting a new libvirt functional base class for 1 test, you could actually write one and then use it | |
| 14:50:54 | mdbooth | Do it in the same patch if required. | |
| 14:51:10 | mdbooth | mriedem: How strongly do you feel about the CastAsCall thing, btw? | |
| 14:51:30 | mdbooth | mriedem: That was a significant change when I rewrote my test. I see the benefit, though. | |
| 14:51:31 | sean-k-mooney | well i coudl write a generic numa functional base class and use that | |
| 14:51:49 | sean-k-mooney | and then later refactor the libvir one to inherit form it | |
| 14:52:31 | mdbooth | sean-k-mooney: If you went down the route of doing something like mriedem's new base class, but adding libvirtiness, you'd be losing CastAsCall. | |
| 14:52:55 | sean-k-mooney | we dont want the castAsCall stuff right? | |
| 14:52:56 | mdbooth | Which I agree with in principal, especially if we're writing a new base class, as it's quite different. | |
| 14:53:10 | mdbooth | sean-k-mooney: Right, but your base class here will be using it. | |
| 14:53:20 | mdbooth | So I'm wondering what the strength of feeling is there. | |
| 14:53:22 | sean-k-mooney | yes but may tests does not care | |
| 14:54:11 | mdbooth | sean-k-mooney: Ah, crap. I forgot to get coffee before your meeting ;) | |
| 14:54:29 | sean-k-mooney | i need the messaging to work so the service can comunicate but i dont depend on the castascall behavior | |
| 14:54:38 | sean-k-mooney | yep im about to do the same | |
| 14:55:33 | mriedem | efried: logstash isn't showing me hits for that | |
| 14:55:36 | mriedem | in 15 minutes anyway | |
| 14:55:56 | mriedem | efried: it's also only a couple of changes in the last 2 days | |
| 14:56:12 | mriedem | mdbooth: i don't know what sean-k-mooney patch you're referring to | |