| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-29 | |||
| 15:15:45 | sean-k-mooney | e.g. add 'minLenght':1 | |
| 15:15:56 | sean-k-mooney | mriedem: nope | |
| 15:16:02 | efried | mriedem: sorry, where in https://review.opendev.org/#/c/35625/ is a nonempty password enforced? | |
| 15:16:04 | sean-k-mooney | i assume it does that or something similar | |
| 15:16:24 | sean-k-mooney | https://review.opendev.org/#/c/691880/ | |
| 15:16:25 | mriedem | efried: https://review.opendev.org/#/c/35625/10/nova/api/openstack/compute/plugins/v3/admin_password.py@61 | |
| 15:16:45 | mriedem | efried: oh well i guess that would be True | |
| 15:16:48 | mriedem | "" is a basestring | |
| 15:16:49 | efried | mriedem: that enforces ... yeah | |
| 15:17:13 | efried | so empty string has always been allowed | |
| 15:18:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Log some stats for image pre-cache https://review.opendev.org/688173 | |
| 15:18:43 | sean-k-mooney | the admin password requires the qemu guest agent to work too right. | |
| 15:18:43 | openstackgerrit | Dan Smith proposed openstack/nova master: Add Aggregate image caching progress notifications https://review.opendev.org/691390 | |
| 15:19:05 | sean-k-mooney | e.g. by defualt it wont work unless you enable it and install it in your guest image at least for libvirt | |
| 15:19:16 | efried | Which is kinda okay imo, I'm not convinced it's always wrong to use "". | |
| 15:19:47 | mriedem | looks like that was originally this https://github.com/openstack/nova/blob/icehouse-eol/nova/api/openstack/compute/servers.py#L1490 | |
| 15:19:48 | dansmith | gibi: mriedem: are either of you aware of any example notification-consuming code out there? thinking I might write up an example tool that caches images and watches for completion via notifications | |
| 15:19:51 | sean-k-mooney | efried: well at least on the linux side it can be locked down via ssh/pam setting in the guest | |
| 15:20:00 | mriedem | and this is where the generate password stuff happened https://github.com/openstack/nova/blob/icehouse-eol/nova/api/openstack/compute/servers.py#L1484 | |
| 15:20:15 | gibi | dansmith: no I don't know about such tool | |
| 15:20:23 | mriedem | so the regression was actually that you could specify adminPass=None and it would generate a password for you, which is probably how that got down into the compute manager code | |
| 15:20:56 | dansmith | gibi: bummer, okay | |
| 15:21:02 | mriedem | gibi: your versioned notifications talk had a project on github you wip'ed up for consuming notifications didn't you? | |
| 15:21:03 | mriedem | in devstack | |
| 15:21:13 | gibi | mriedem: yeah that was an example tool | |
| 15:21:19 | gibi | mriedem: nothing production ready | |
| 15:21:29 | dansmith | gibi: not looking for production, looking for example :) | |
| 15:21:43 | gibi | https://github.com/gibizer/nova-notification-demo | |
| 15:21:51 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass RequestContext to oslo_policy https://review.opendev.org/674038 | |
| 15:22:04 | gibi | dansmith: sorry I skipped the 'example' word in your question | |
| 15:22:12 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698 | |
| 15:22:29 | dansmith | gibi: thanks, I'll see if I can steal enough out of that to get something working | |
| 15:23:06 | gibi | dansmith: I'm happy to help | |
| 15:23:41 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | |
| 15:24:59 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-services https://review.opendev.org/645427 | |
| 15:42:17 | openstack | Launchpad bug 1558880 in OpenStack Compute (nova) "instance can not resize ephemeral from mitaka to stein and master" [Medium,Confirmed] | |
| 15:42:17 | mriedem | is anyone against just putting something in the API reference about https://bugs.launchpad.net/nova/+bug/1558880 being a known limitation? there are at least 3 known duplicates of that bug now and i don't see it being fixed anytime soon. | |
| 15:54:35 | gibi | mriedem: I agree to document it as a known limitation | |
| 16:02:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use admin neutron client to gather port resource requests https://review.opendev.org/691005 | |
| 16:04:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use admin neutron client to see if instance has qos ports https://review.opendev.org/691900 | |
| 16:08:18 | efried | mriedem: This looks weird https://docs.openstack.org/api-ref/compute/?expanded=list-hypervisors-detail#list-hypervisors | |
| 16:08:50 | mriedem | caller, can you be more specific? | |
| 16:08:53 | efried | 'marker' is listed twice, once as integer, once as string. In the former it says it's available until 2.52 and also new in 2.53 | |
| 16:09:21 | mriedem | it's because marker and id changed from an int id to a uuid in 2.53 | |
| 16:09:24 | mriedem | for multi-cell listing | |
| 16:09:38 | efried | oh, sorry, I misread 2.33 as 2.53. | |
| 16:09:40 | efried | This looks fine. | |
| 16:09:40 | mriedem | iow, the int id is not unique across cells | |
| 16:10:28 | efried | mriedem: but while I have your attention... adding support for new qparams into SDK, who's responsible for that? | |
| 16:10:45 | efried | do we have like a known "we have SDK support up to XXX microversion" somewhere? | |
| 16:11:54 | mriedem | nope | |
| 16:11:56 | efried | e.g. with_servers in that same API doesn't seem to exist in the SDK compute proxy's `hypervisors()` method. | |
| 16:11:57 | mriedem | i did that for osc | |
| 16:12:05 | mriedem | https://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc | |
| 16:12:13 | efried | ack | |
| 16:12:28 | efried | but you're not surprised that `with_servers` isn't in the SDK yet? | |
| 16:12:28 | mriedem | getting anyone to care about that is also pretty non-starty | |
| 16:12:33 | mriedem | hell no | |
| 16:12:36 | efried | okay. | |
| 16:12:59 | mriedem | as i've said before, the only thing that surprises me in openstack anymore is when things work | |
| 16:17:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Reset instance to current vm_state if rolling back in resize_instance https://review.opendev.org/691908 | |
| 16:19:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use admin neutron client to gather port resource requests https://review.opendev.org/691005 | |
| 16:20:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use admin neutron client to see if instance has qos ports https://review.opendev.org/691900 | |
| 16:51:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add known limitation about resize not resizing ephemeral disks https://review.opendev.org/691915 | |
| 16:52:23 | AJaeger | nova team, could I get a second +2 on https://review.opendev.org/#/c/689020/ to update the openSUSE Zuul job, please? Once that is in, I'll backport as well - these are needed to move forward on the infra side. | |
| 16:56:23 | AJaeger | thanks, dansmith ! | |
| 16:56:31 | dansmith | AJaeger: np | |
| 17:00:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: re-work resize action post-conditions https://review.opendev.org/691918 | |
| 17:18:56 | gmann | johnthetubaguy melwitt: replied on unified limit spec added comment of hangout call. this lgtm now. I think it is all you have captured in spec but it will be good if you can explain the plan per cycle (what we discussed in hangout, i wrote it in comment). also you need to change the cycle name in spec -https://review.opendev.org/#/c/602201/15/specs/ussuri/approved/unified-limits-nova.rst@523 | |
| 17:30:35 | sean-k-mooney | gmann: "- at some cycle in future - remove the APIs." | |
| 17:31:15 | sean-k-mooney | gmann_afk: have we ever actully got around to removeing an api since we adopted micorverions | |
| 17:31:36 | sean-k-mooney | e.g. you can always fall back to 2.0 and get them | |
| 17:32:29 | dansmith | sean-k-mooney: we have removed the network stuff, AFAIK | |
| 17:32:35 | dansmith | returning 409 Gone for those | |
| 17:32:44 | sean-k-mooney | the nova net apis? | |
| 17:33:00 | sean-k-mooney | ya i guess | |
| 17:33:11 | sean-k-mooney | we just usually keep them for quite a long time | |
| 17:36:20 | gmann | sean-k-mooney: removing API i mean 410 and keep the endpoints. | |
| 17:36:54 | gmann | like nova-net, cloudpipe, nova-cert APIs. but yes when it will happen do not know | |
| 17:37:34 | sean-k-mooney | i guess there have been a few | |
| 17:37:45 | sean-k-mooney | ya that is what i assumed you ment | |
| 17:38:53 | gmann | i clarified in comment. | |
| 18:05:39 | openstack | Launchpad bug 1850514 in OpenStack Compute (nova) "ReshapeForPCPUsTest.test_vcpu_to_pcpu_reshape intermittently fails with "Cannot 'migrate' instance while it is in vm_state building"" [Medium,Confirmed] | |
| 18:05:39 | mriedem | dansmith: you're going to have to recheck your top notification patch on https://bugs.launchpad.net/nova/+bug/1850514 | |
| 18:05:45 | dansmith | yeah I know | |
| 18:11:49 | mriedem | ok, posting a fix for that bug | |
| 18:11:57 | mriedem | it's using the _wait_for_state_change i hate | |
| 18:12:02 | mriedem | but all of the libvirt functional tests use | |
| 18:33:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix race in test_vcpu_to_pcpu_reshape https://review.opendev.org/691941 | |
| 18:33:06 | mriedem | dansmith: efried: ^ fixes that gate bug | |
| 18:48:28 | dansmith | mriedem: I haven't looked, but why does that fix it? because it might catch the ACTIVE before the transition or something? | |
| 18:51:46 | efried | dansmith: yes, that's how I understand it. | |
| 18:52:00 | efried | because it catches "not ACTIVE" immediately, rather. | |
| 18:52:43 | efried | mriedem: +2 | |
| 18:56:58 | dansmith | yeah okay | |
| 18:57:11 | dansmith | oh I should read the damn commit message :P | |
| 19:00:27 | mriedem | always start with the commit message... | |
| 19:00:30 | mriedem | at least on my patches | |
| 19:00:53 | dansmith | well, I like to look at code first, but sometimes forget to go back | |
| 19:01:00 | dansmith | mriedem: thanks for recheckin' mah thing | |