| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-23 | |||
| 18:29:52 | openstackgerrit | Merged openstack/nova master: Add functional regression test for bug 1849409 https://review.opendev.org/690428 | |
| 18:30:10 | efried | should we consider pushing the pre-precaching parts of what dansmith just wrote in an independent patch that can be backported, and then tacking the precaching bits on top in a separate master-only patch? | |
| 18:30:10 | efried | Leading to... | |
| 18:32:33 | mriedem | efried: we haven't ever had docs about the image cache so i don't think anyone is chomping at the bit to have those in stable | |
| 18:32:40 | dansmith | I guess I'm not opposed to that, but we have had image caching since forever, no docs since forever, | |
| 18:32:48 | mriedem | we finish each other's | |
| 18:32:51 | dansmith | and the master docs (minus precaching) will be live in google and applicable | |
| 18:32:53 | dansmith | so kinda meh | |
| 18:32:56 | dansmith | mriedem: sentences! | |
| 18:33:00 | dansmith | mriedem: <3 | |
| 18:33:01 | mriedem | teehee! | |
| 18:33:41 | efried | not sure I agree with the philosophy of "nobody ever bitched about it so it must not be worth doing" but okay. | |
| 18:34:12 | mriedem | well, it's docs | |
| 18:34:21 | mriedem | and this is already ready to go | |
| 18:34:54 | dansmith | just doesn't seem that important to have the docs back there.. people will google for this, and find this doc regardless | |
| 18:34:54 | efried | is gerrit slow for anyone else rn? | |
| 18:35:03 | dansmith | it's not like stable gets burned to a cd and shipped to people | |
| 18:35:58 | efried | okay. +W. I'm going to work up the patch to move those conf opts. | |
| 18:36:16 | efried | unless someone is already doing thot. | |
| 18:36:17 | efried | that | |
| 18:36:21 | mriedem | it's all yours | |
| 18:36:56 | mriedem | but first, https://www.youtube.com/watch?v=az8ht2-U0Q0 | |
| 18:37:25 | dustinc | efried: gerrit page loads are fine for me right now | |
| 18:37:38 | efried | thanks. I'll bounce my router then. | |
| 18:38:48 | efried | I don't get it mriedem. You're weird. | |
| 18:39:59 | dansmith | efried: messing with conf options is a fool's errand, is his point | |
| 18:40:07 | dansmith | efried: and stephenfin is the boogieman in this case | |
| 18:40:16 | dansmith | mriedem: did I get that right? | |
| 18:41:20 | mriedem | you're both wrong | |
| 18:41:23 | mriedem | i was just thinking of it | |
| 18:41:28 | dansmith | dammit | |
| 18:41:40 | mriedem | watched that episode the other night with my daughter | |
| 18:41:43 | mriedem | one of my favorites | |
| 18:49:51 | mriedem | lyarwood: probably too late for you today but a couple of small things in your fix https://review.opendev.org/#/c/682622/ | |
| 18:52:02 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Fix listing deleted servers with a marker https://review.opendev.org/690711 | |
| 18:52:02 | openstack | bug 1849409 in OpenStack Compute (nova) "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 18:52:02 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Add functional regression test for bug 1849409 https://review.opendev.org/690710 | |
| 19:03:49 | efried | dansmith, mriedem: ugh, what about [libvirt]remove_unused_resized_minimum_age_seconds? Should it be a) mentioned in the docs, b) moved to [image_cache]? | |
| 19:04:10 | dansmith | is that imagecache related? | |
| 19:04:36 | dansmith | hmm, guess so | |
| 19:04:37 | dansmith | however, | |
| 19:04:44 | dansmith | that looks to be libvirt-specific | |
| 19:04:55 | efried | right | |
| 19:04:58 | efried | ...now | |
| 19:04:59 | dansmith | so I dunno that I'd put that in imagecache | |
| 19:05:57 | dansmith | you wouldn't move libvirt-only things out to DEFAULT just because someone else could implement them in the future, would you? | |
| 19:06:19 | efried | no. But it's definitely related to image cache; and it's weird that there's remove_unused_original_minimum_age_seconds in a *different* place (whether that's [DEFAULT] or [image_cache]) | |
| 19:06:33 | efried | and | |
| 19:06:43 | efried | I wouldn't put up a patch to just do that move | |
| 19:06:54 | efried | but since I'm moving the rest, this seems like the right thing to do in concert. | |
| 19:07:30 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix listing deleted servers with a marker https://review.opendev.org/690716 | |
| 19:07:30 | openstack | bug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 19:07:30 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional regression test for bug 1849409 https://review.opendev.org/690715 | |
| 19:09:31 | dansmith | efried: but DEFAULT is related to everything, so the same argument for other things would seem to apply | |
| 19:09:48 | mriedem | dansmith: he's moving the image cache stuff from [DEFAULT] to a new [image_cache] group | |
| 19:09:51 | mriedem | to group those like options | |
| 19:10:09 | dansmith | mriedem: the remove_unused is already in the libvirt group | |
| 19:10:17 | mriedem | yeah i know, that's the only one (besides your new one) | |
| 19:10:26 | mriedem | i don't have a strong opinion on moving this one to the new group | |
| 19:10:35 | efried | remove_unused_*original* is in [DEFAULT]; remove_unused_*resized* is in libvirt | |
| 19:11:07 | dansmith | efried: that one is used by others | |
| 19:11:08 | mriedem | oh i didn't realize there were two | |
| 19:11:21 | dansmith | the libvirt-only one should stay in the libvirt group until it's used elsewhere, IMHO | |
| 19:11:22 | efried | which like I said I wouldn't bother to "fix" if it was just that, but IMO makes sense to move, despite being currently libvirt-only, since we're making a special group for image_cache. | |
| 19:11:45 | mriedem | fun that we don't even test remove_unused_resized_minimum_age_seconds | |
| 19:16:55 | mriedem | split the baby in half | |
| 19:18:40 | mriedem | dansmith: i've been thinking about taking a crack at that notification sample thing for your aggregate pre-cache stuff, do you mind if i do or are you already working on it? | |
| 19:19:11 | dansmith | mriedem: I've been meaning to try to corner gibi, but I've been busy in the mornings.. however, I have *no* idea where to start, so please, by all means | |
| 19:19:28 | mriedem | he's all greased up by then, hard to atch | |
| 19:19:29 | mriedem | *catch | |
| 19:19:52 | mriedem | ok i'll see if i can wip something up to start it | |
| 19:30:17 | mriedem | melwitt: fyi there is runway slot room for your host_status patch once that is ready for re-review https://etherpad.openstack.org/p/nova-runways-ussuri | |
| 19:30:36 | melwitt | mriedem: oh cool, thanks | |
| 19:33:08 | mriedem | sean-k-mooney: is https://review.opendev.org/#/q/topic:bp/image-metadata-prefiltering+status:open ready for runways? | |
| 19:34:18 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Fix listing deleted servers with a marker https://review.opendev.org/690721 | |
| 19:34:18 | openstack | bug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 19:34:18 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression test for bug 1849409 https://review.opendev.org/690720 | |
| 19:46:10 | openstackgerrit | Eric Fried proposed openstack/nova master: Consolidate [image_cache] conf options https://review.opendev.org/690723 | |
| 19:46:27 | efried | (the baby is mine) | |
| 19:46:27 | efried | mriedem, dansmith: ^ | |
| 19:50:16 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix listing deleted servers with a marker https://review.opendev.org/690725 | |
| 19:50:16 | openstack | bug 1849409 in OpenStack Compute (nova) train "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 19:50:16 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add functional regression test for bug 1849409 https://review.opendev.org/690724 | |
| 19:57:45 | openstackgerrit | Elod Illes proposed openstack/nova stable/rocky: cleanup evacuated instances not on hypervisor https://review.opendev.org/687550 | |
| 20:02:15 | elod | mriedem: I've updated the commit message ^^^ (forgot to put me '_off', as today is national holiday here, but tomorrow gibi will be back) | |
| 20:02:29 | mriedem | elod: i saw that, thanks | |
| 20:10:04 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: cleanup evacuated instances not on hypervisor https://review.opendev.org/687550 | |
| 20:10:46 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional test for resize crash compute restart revert https://review.opendev.org/687563 | |
| 20:10:53 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Prevent init_host test to interfere with other tests https://review.opendev.org/687862 | |
| 20:11:14 | openstack | bug 1833581 in OpenStack Compute (nova) rocky "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 20:11:14 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Functional reproduce for bug 1833581 https://review.opendev.org/687564 | |
| 20:11:21 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Error out interrupted builds https://review.opendev.org/687565 | |
| 20:11:53 | openstackgerrit | Eric Fried proposed openstack/nova master: Consolidate [image_cache] conf options https://review.opendev.org/690723 | |
| 20:16:07 | efried | dansmith: support matrix, you want just one section for image caching (where maybe without precaching the support is "partial") or two? | |
| 20:16:44 | dansmith | doesn't matter to me | |
| 20:16:51 | mriedem | i vote for one | |
| 20:17:36 | efried | ack. dansmith, I haven't looked, which drivers does precaching work for today? | |
| 20:17:46 | dansmith | libvirt | |
| 20:18:14 | efried | ight | |
| 20:23:13 | KeithMnemonic | mriedem , melwitt if you use the nova cli --deleted --marker work as expected ;-) | |