Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-10-22
08:15:57 openstackgerrit Adrian Chiris proposed openstack/nova master: Revert "vif: Resolve a TODO and update another" https://review.opendev.org/675776
08:16:00 bauzas didn't know OpenStack was running as airline :)
08:16:18 gibi Austrian Airlines
08:16:20 gibi :)
08:16:28 gibi but the ticker fits well :)
08:16:31 bauzas :p
08:16:58 bauzas I arrive a bit later, around 9:10am
08:17:14 bauzas so I mostly expect some visits during the afternoon hopefully
08:22:36 openstackgerrit do3meli proposed openstack/nova master: [Trivial] Add missing ws between words https://review.opendev.org/689921
08:23:16 bauzas alex_xu: could you please make me a favor and tell me whether https://www.sosh.fr works in China ? I just wanna make sure I can reach my phone provider just in case
08:25:46 alex_xu bauzas: just thinking how to ensure that, asking the local telco provider?
08:27:17 bauzas alex_xu: yeah, for example
08:27:27 bauzas I'm pretty sure it works
08:27:36 bauzas but I'm not sure
08:28:32 alex_xu bauzas: hah, let me try to call china mobile client service
08:31:12 openstack bug 1849165 in OpenStack Compute (nova) "_populate_assigned_resources raises "TypeError: argument of type 'NoneType' is not iterable" during active migration" [High,In progress] https://launchpad.net/bugs/1849165 - Assigned to Eric Fried (efried)
08:31:12 openstackgerrit Merged openstack/nova master: Func: bug 1849165: mig race with _populate_assigned_resources https://review.opendev.org/689866
08:32:08 alex_xu bauzas: china mobile tell me you should ask SOSH :)
08:34:08 bauzas alex_xu: heh, no worries
08:34:13 bauzas thanks for the call
08:34:30 bauzas I just meant accessing the website
08:34:38 bauzas sorry for the confusion
08:34:38 alex_xu hah
08:34:44 alex_xu no worries
08:35:01 bauzas but I definitely appreciate you called your service provider !
08:35:05 bauzas appreciated*
08:35:13 bauzas looks we both misunderstood :)
08:35:52 alex_xu no, I understand you :)
08:36:42 bauzas alex_xu: FWIW, I can reach the customer service by some internal chat app, that's why I just wanted to make sure it could work
08:37:18 alex_xu oh, so you need network first to reach the service
08:38:16 alex_xu bauzas: but remember don't depend on google maps for travel, that may not works in china ;)
08:41:08 bauzas alex_xu: yup, I know, hence my wonders about whether Sosh.fr works there
08:41:13 bauzas anyway
08:41:50 bauzas alex_xu: which application do you use for maps and directions in Shanghai, including routes and public transportation ?
08:42:00 bauzas do you s/use/recommend
08:42:02 bauzas my bad
08:42:58 bauzas apparently this time, the Foundation doesn't provide some tips&tricks for navigating around Shanghai
08:43:26 alex_xu I use local internet commpany apps, like baidu, alibaba, I'm not sure they have multiple language, but the Apple maps and bing maps should works.
08:44:29 alex_xu bauzas: but you can try Baidu Maps, see if they works for franch or english, if not, bing maps or apple maps(if you use iphone) is safe choice I think
08:50:34 bauzas alex_xu: I have an Android-based phone (Huawei)
08:50:44 bauzas but I'll figure that out then
08:51:31 bauzas my point is, I won't be able to use the Play Store while in China for downloading the apps that I want :D
08:51:51 bauzas hence some bits of preparation
08:52:32 alex_xu yea, good to download the apps first
08:52:59 alex_xu when I travel to US, the app store is connecting back to china server, that is crazy slow...
08:54:12 bauzas anyway, a good opportunity for de-googling myself :)
09:05:18 openstackgerrit kangyufei proposed openstack/python-novaclient master: Switch to Ussuri jobs https://review.opendev.org/690013
10:44:12 SonPham Hi. I want response data from nova (server.py) to nova-pythonclient after nova-pythonclient request to nova
10:44:20 SonPham How can i do it
10:44:46 SonPham Hi. I want response data from nova (server.py) to novaclient after novaclient request to nova
10:47:01 sean-k-mooney bauzas: hi can you review this quickly, i tried to get this in to the train RCs but i think if fell through the cracks so it would be nice to land and backport it quickly https://review.opendev.org/#/c/675776/7
12:05:14 efried gibi: can I get a quick +A on https://review.opendev.org/#/c/688979/ please?
12:05:43 gibi efried: looking...
12:07:05 efried you were +2 before the reno
12:07:23 efried Oh, I guess the predecessor still needs reviews
12:08:15 gibi I'm +A on the trait applying patch
12:09:33 efried gibi: +2 on the ItemsMatcher fup. If you want to +2 the bottom one, maybe we can convince bauzas to +A both and all three of these will merge.
12:16:49 gibi efried: I can add some unit tests for that fup. But as you are happy with the fup I'm happy with your original patch.
12:18:55 efried gibi: like I said, I think we can live without test-for-test-util; when we use it in tests we'll uncover any bugs and fix them then. And it won't impact prod.
12:19:11 efried but if you're losing sleep over it, I'll happily review tests :)
12:22:28 gibi efried: sure, I got your comment. I would like to add test cases
12:23:07 gibi efried: if the patch merges before I can add test cases then I will add those in a separate patch
12:23:20 efried now we need to get that spy stuff merged
12:23:30 gibi efried: that will be harder I think
12:23:32 efried been at least three or four cases that could have made use of it.
12:23:51 efried since it was proposed
12:26:32 gibi efried: I think I saw two of those cases. It think not everybody sees the same value we thing the spy adds
12:27:21 efried gibi: I'm almost convinced it should be added to the mock library itself. If we did that, we could probably iron out those last pesky wrinkles that are annoying us...
12:40:37 openstackgerrit Alex Xu proposed openstack/nova master: Add test for the race between post live migration and update available resource https://review.opendev.org/690066
12:41:16 alex_xu efried: ^ I feel the race is case due to the post live migration, not the pre live migration
12:41:39 efried alex_xu: ack, I was about to get around to trying to grok your comment :)
12:42:12 efried Did you see the repro though? That triggers the race by running the periodic before the dest claim.
12:42:53 alex_xu efried: yes, but I think that is due to the no numa instance without migration context, I feel it isn't race problem
12:43:32 alex_xu efried: we assign migration.dest and instance.migration_context under the same lock, so it shouldn't happen race
12:43:46 efried Only on cold migration
12:44:01 efried on live migration the former happens on the conductor, the latter on the compute.
12:44:02 alex_xu oh, I only see LM, didn't look at cold one
12:44:43 alex_xu but it should be same, since both cold migration and LM using same move claim
12:46:34 alex_xu efried: here is https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L306 and https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L370
12:49:54 efried alex_xu: cold migration uses _claim_existing_migration but live migration uses _create_migration -- or the other way around, now I can't remember :(
12:50:32 alex_xu really...i will hate that
12:51:47 alex_xu efried: quick grep the code, both cold and live using _claim_existing_migration
12:51:59 alex_xu they create the migration obj in conductor
12:52:09 efried alex_xu: If you can, probably best to wait for mriedem -- he understands these paths way better than I do.
12:52:39 alex_xu efried: yea, no hurry, whatever the fix is right
12:52:47 efried I put together these patches to further my understanding, but he was leading the way
12:53:40 efried Like, mission accomplished, I understand things a little bit better than I did before, but it's still like |...me..................mriedem..|
12:55:22 efried btw, I ran into the same COMPUTE_RESOURCE_SEMAPHORE deadlock while I was experimenting yesterday, and considered working around it by manually calling _populate_assigned_resources -- but I didn't think that was a realistic test.
12:56:41 alex_xu yea...that deadlock spend hours for me, totally not worth...
12:59:33 efried originally I was using a cold migration and injecting update_available_resource before _prep_resize, but that didn't trigger the problem. So I tried to inject it lower down, after _claim_existing_migration, and ran into the deadlock.
13:00:05 efried That's when mriedem suggested I instead use a live migration and inject before pre_live_migration instead.
13:00:14 efried That reproduced the race
13:00:24 efried or... *a* race, anyway :)
13:13:12 bauzas sean-k-mooney: ah sorry, was at the gym, will review it ASAP
13:16:19 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix policy doc for host_status and extended servers attribute https://review.opendev.org/689833
13:16:56 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix policy doc for host_status and extended servers attribute https://review.opendev.org/689833
13:16:57 mriedem hear ye hear ye we need stable/stein reviews https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/stein
13:17:11 bauzas mriedem: ack
13:17:19 bauzas sean-k-mooney: urgent revert, I guess ?
13:17:28 bauzas sean-k-mooney: I can fast-approve it as per our policy

Earlier   Later