| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-19 | |||
| 11:44:35 | openstackgerrit | Matthew Booth proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | |
| 11:44:35 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix incorrect vm and task state after build failure race https://review.opendev.org/689388 | |
| 17:48:53 | openstackgerrit | Merged openstack/python-novaclient master: Add images.GlanceManager.find_images() bulk query https://review.opendev.org/689537 | |
| 17:48:54 | openstackgerrit | Merged openstack/python-novaclient master: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | |
| 17:48:55 | openstackgerrit | Merged openstack/python-novaclient master: Add functional test for migration-list in v2.80 https://review.opendev.org/688635 | |
| #openstack-nova - 2019-10-20 | |||
| 00:12:24 | openstackgerrit | Merged openstack/nova master: Add support for cloud-init on LXC instances https://review.opendev.org/667976 | |
| 00:38:26 | openstackgerrit | Merged openstack/nova master: Remove dead reserve_volume compat code in _validate_bdm https://review.opendev.org/687427 | |
| 11:05:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | |
| 11:05:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix incorrect vm and task state after build failure race https://review.opendev.org/689388 | |
| #openstack-nova - 2019-10-21 | |||
| 00:08:10 | openstackgerrit | Merged openstack/nova master: Remove Stein compute compat checks for volume type support https://review.opendev.org/687428 | |
| 06:58:10 | bauzas | good morning Nova | |
| 07:11:07 | gibi | bauzas: good morning! | |
| 07:11:21 | bauzas | :) | |
| 08:18:24 | lyarwood | remote: amqps://messaging-devops-broker02.web.prod.ext.phx2.redhat.com:5671: proton:io: recv: Connection refused | |
| 08:18:27 | lyarwood | argh sorry | |
| 08:23:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix ItemMatcher to avoid false positives https://review.opendev.org/689690 | |
| 08:33:58 | mdbooth | sean-k-mooney: You around, yet? Mind taking a look at Stephen's unplug vif patch and the functional test I wrote for it? Head: https://review.opendev.org/#/c/663382/12 Base: https://review.opendev.org/#/c/689186/2 | |
| 08:34:09 | mdbooth | 4 patches in total | |
| 08:34:29 | mdbooth | 2 bugs, unfortunately, as the functional test uncovered another one | |
| 11:18:59 | openstackgerrit | Merged openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | |
| 11:19:06 | openstackgerrit | Merged openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | |
| 11:31:34 | openstackgerrit | Merged openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | |
| 14:08:43 | dansmith | stephenfin: so, I got a novaclient change merged, what is the magic I need to be able to use that api from osc? a release and requirements bump? | |
| 14:09:14 | efried | dansmith: I think stephenfin is on vacay until the ptg. | |
| 14:09:21 | dansmith | oh right | |
| 14:09:25 | efried | dtroyer: --^ | |
| 14:10:13 | dansmith | I could go bug other people (like dtroyer) I just was going to keep it in the family since we have experienced people here | |
| 14:10:22 | dansmith | I'm sure mriedem knows too, were he around | |
| 14:20:58 | mriedem | happy monday everyone! | |
| 14:21:49 | dansmith | um. | |
| 14:22:25 | dansmith | mriedem: so, I got a novaclient change merged, what is the magic I need to be able to use that api from osc? a release and requirements bump? | |
| 14:22:40 | mriedem | dansmith: yeah, brinzhang has a novaclient release patch i was holding for you | |
| 14:22:42 | mriedem | just update the git hash | |
| 14:22:58 | mriedem | https://review.opendev.org/#/c/688638/ | |
| 14:23:10 | mriedem | looks like he already updated it to include your stuff | |
| 14:23:15 | dansmith | yeah | |
| 14:23:17 | dansmith | just found that | |
| 14:24:59 | bauzas | mriedem: happy end of monday for me ! | |
| 15:00:15 | lyarwood | mriedem: https://review.opendev.org/#/q/topic:bug/1835400+status:open - would you mind hitting these? | |
| 15:02:13 | mriedem | sure | |
| 15:03:52 | lyarwood | thanks | |
| 15:05:00 | mriedem | lyarwood: btw i'm assuming you've seen the emails about getting queens released sometimes this week before EM yeah? | |
| 15:06:47 | lyarwood | mriedem: no sorry, just catching up after yet more time out at the tail end of last week, I'll take a look after this meeting. | |
| 15:08:39 | mriedem | ok, tl;dr unfortunately a lot of what's sitting in queens is waiting to merge on newer branches, so kind of need to flush from there but you know how that goes. would be helpful to start with these in train: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/train | |
| 15:16:09 | lyarwood | mriedem: ack I'll make a start tonight | |
| 15:28:10 | mriedem | gibi: are you ready for https://blueprints.launchpad.net/nova/+spec/support-move-ops-with-qos-ports-ussuri to go into an open runway slot? | |
| 15:28:20 | gibi | mriedem: yes, I'm | |
| 15:29:35 | gibi | mriedem: zuul hate https://review.opendev.org/#/c/688387/ as it always fail with a different reason | |
| 15:48:40 | dansmith | mriedem: can probably remove mine from a slot now.. just client and docs stuff remaining, and then some notification stuff with gibi's help | |
| 15:49:31 | gibi | dansmith: do you need my help writing the notificaiton patch or just my eyes to review it? | |
| 15:49:37 | dansmith | gibi: yes :D | |
| 15:49:48 | gibi | :D | |
| 15:50:35 | mriedem | gibi: i'd be wary of nova-live-migration job failures on that patch since it's the only job that also runs evacuate | |
| 15:51:05 | mriedem | sean-k-mooney: mdbooth: i don't see why we need to tie this regression test https://review.opendev.org/#/c/689278/ to the libvirt functional test base or the refactors you're doing in that libvirt func test tree | |
| 15:51:12 | gibi | mriedem: I will double check that but it does not fail constantly | |
| 15:51:15 | mriedem | that means unnecessary backports | |
| 15:51:35 | mriedem | and the plug/unplug thing is driver agnostic | |
| 15:52:24 | mriedem | gibi: https://zuul.opendev.org/t/openstack/build/2b10b4a240b84245bcee3366db93951d/log/job-output.txt#8630 | |
| 15:52:35 | mriedem | gibi: that might be http://status.openstack.org/elastic-recheck/#1813789 | |
| 15:52:37 | mriedem | but would have to check | |
| 15:52:46 | gibi | mriedem: will do | |
| 15:55:30 | gmann | mriedem: melwitt replied on host_status policy patch. that is only doc bug for 2.75. let me know if ok to fix in same patch otherwise i can push enw one - https://review.opendev.org/#/c/679181/1/nova/policies/servers.py@120 | |
| 15:55:35 | mriedem | dansmith: done, removed from queue | |
| 15:55:54 | dansmith | cool | |
| 15:56:10 | mriedem | gmann: maybe push a separate fix and melwitt can rebase on top of it | |
| 15:57:41 | gmann | mriedem: ok, even same for extended-server-attributes. https://github.com/openstack/nova/blob/964d7dc87989b5765fcc60d34f734963ab8e03e7/nova/policies/extended_server_attributes.py | |
| 16:00:13 | melwitt | gmann: yeah if you upload a fix I'll rebase my patch on top of it | |
| 16:00:28 | gmann | melwitt: ok, doing.. | |
| 16:00:38 | mriedem | gibi: something occurs to me - what if _update_pci_request_spec_with_allocated_interface_name runs and updates the instance pci_requests, then we fail later in whatever operation (resize, cold migrate, evacuate), we don't roll that back right? so instance.pci_requests would be wrong after that and might cause issues, but i'm not sure what kind - maybe hard reboot would fail? | |
| 16:04:20 | gibi | mriedem: good point. The InstancePciRequest change is not rolled back. | |
| 16:04:39 | gibi | mriedem: it could cause the failure of the pci_claim in the rt | |
| 16:04:58 | gibi | mriedem: do we re-claim resource at hard reboot? I don't think | |
| 16:05:01 | mriedem | no | |
| 16:05:16 | gibi | mriedem: if the instance is migrated forward then the migration will update the pci request again | |
| 16:06:04 | gibi | so the pci_claim at the second migration will see consitent data | |
| 16:07:36 | gibi | mriedem: now I think not rolling back this is not causing problems. but I agree that it is not nice to have wrong data in the PCI request after rollback | |
| 16:08:55 | mriedem | so could we have a case like, | |
| 16:09:10 | mriedem | 1. create server using port request and it gets parent_ifname foo, | |
| 16:09:25 | mriedem | 2. try to migrate the server and we update the instance pci_request to point at parent_ifname bar, | |
| 16:09:39 | mriedem | 3. migrate fails and we don't rollback the instance pci_request | |
| 16:09:54 | mriedem | 4. another server is created - it can't use parent_ifname bar even though nothing is using it right? | |
| 16:10:14 | mriedem | iow it's "claimed" by the failed first server | |
| 16:10:25 | gibi | this is not part of the claim | |
| 16:10:41 | gibi | it drivers the claim to select the good PF | |
| 16:10:52 | gibi | but the whole PF never claimed | |
| 16:11:07 | mriedem | ok, then how about if we hard reboot the failed server, will it try to use parent_ifname bar and fail if another guest on the same host is already using that? | |
| 16:11:42 | gibi | mriedem: if we hard reboot then nobody will check the parent_ifname. It is only the VF pci address that matters | |
| 16:12:14 | mriedem | ok i don't know how any of this stuff is actually used in the driver | |
| 16:12:21 | mriedem | just thinking about fallout scenarios | |
| 16:12:24 | gibi | parent_finame is not a consumable, it is like a trait | |
| 16:12:58 | gibi | it helps selecting the proper pool of VFs during the pci_claom | |
| 16:13:45 | mriedem | efried: alex_xu: looks like we have a fun TypeError for the resources stuff added late in Train https://zuul.opendev.org/t/openstack/build/2b10b4a240b84245bcee3366db93951d/log/logs/screen-n-cpu.txt.gz?severity=4#2675 | |
| 16:15:01 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix policy doc for host_status and extended servers attribute https://review.opendev.org/689833 | |
| 16:15:07 | gibi | mriedem: made a TODO to look into how hard to roll back the parent_ifname during rollback or revert | |
| 16:17:25 | mriedem | gibi: ack, not a huge deal | |
| 16:17:35 | mriedem | i know you like to pull these types of threads in your spare time :) | |
| 16:17:44 | gibi | :) | |
| 16:18:09 | openstack | Launchpad bug 1849165 in OpenStack Compute (nova) "_populate_assigned_resources raises TypeError: argument of type 'NoneType' is not iterable" [High,New] | |
| 16:18:09 | mriedem | efried: alex_xu: https://bugs.launchpad.net/nova/+bug/1849165 seems there is a race in that resources code in the RT during migrations | |
| 16:22:08 | mriedem | this is where i say even things that touch the RT which aren't used still have side effects... | |