| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-18 | |||
| 12:23:05 | ygk_12345 | oh | |
| 12:25:18 | sean-k-mooney | ygk_12345: cdent know more about this then i but we moved to testing with extrenal wsgi server implemenation a few release ago | |
| 12:25:43 | ygk_12345 | oh ok | |
| 13:42:28 | KeithMnemonic | mriedem Good day, what is the best was to get some reviews on the patch you submitted for me ? https://review.opendev.org/#/c/683008/ | |
| 13:43:29 | mriedem | KeithMnemonic: umm | |
| 13:43:45 | mriedem | you know we won't release that right? | |
| 13:43:58 | mriedem | since pike is in extended maintenance mode. we can merge stuff to pike but it won't be released. | |
| 13:44:08 | mriedem | so if you really need it you could probably just cherry pick it downstream | |
| 13:46:36 | KeithMnemonic | ok, i can do that, i was hoping it would get merged at least , is that not an option anymore even it if it is not released | |
| 13:47:13 | mriedem | it could be merged upstream but finding people to care about pike at this point upstream is hard, and that patch isn't exactly trivial | |
| 13:47:16 | mriedem | with all of the conflicts | |
| 13:48:16 | KeithMnemonic | ok let me try and cherry pick it locally | |
| 13:48:16 | dansmith | mriedem: api patch landed, can you kick this in? https://review.opendev.org/#/c/687141/ | |
| 13:49:42 | mriedem | dansmith: were you going to reply to andrey again before doing so? | |
| 13:50:16 | mriedem | he is a core so i feel sort of bad if i just overrule him without a reply | |
| 13:51:03 | dansmith | okay | |
| 13:54:16 | mdbooth | Oh, that's evil | |
| 13:54:52 | mdbooth | In python2, if your module is in nova.tests.functional and you 'import fixtures', you get nova.tests.functional.fixtures. In python3 you get 'fixtures'. | |
| 13:55:13 | mdbooth | Apart from renaming nova.tests.functional.fixtures, I'm not immediately sure wtf to do about that. | |
| 13:57:55 | mdbooth | Fun fact 2: emojis in review comments elicit a 500 from gerrit. | |
| 13:58:01 | sean-k-mooney | mdbooth: that to do with relitive imports and what happens if you have a module in the local director that alisas a module in your path | |
| 13:58:23 | mdbooth | sean-k-mooney: Any idea how to disable in py2 in a manner which doesn't break py3? | |
| 13:58:50 | sean-k-mooney | there might be a futre thing for this. absolute import or something like htat | |
| 13:59:21 | melwitt | KeithMnemonic, mriedem: I started reviewing that patch yesterday but not done yet. it's taking forever bc of all the conflicts. I'll finish reviewing today | |
| 13:59:36 | KeithMnemonic | thanks! | |
| 13:59:38 | sean-k-mooney | https://www.python.org/dev/peps/pep-0328/ | |
| 13:59:45 | sean-k-mooney | from __future__ import absolute_import | |
| 14:00:10 | sean-k-mooney | but that shoudl be enabled by default in py 2.7 | |
| 14:00:28 | mdbooth | Apparently not | |
| 14:05:36 | bauzas | mdbooth: to make it clear, nobody should just import any module like "import <module>" but rather doing "from <where> import <module>" | |
| 14:06:08 | bauzas | if I'm reviewing any change like this, I'd -1 it | |
| 14:09:00 | melwitt | mdbooth: there shouldn't be a module nova.tests.functional.fixtures module, there's one in nova.tests.fixtures though | |
| 14:09:11 | melwitt | I think that's how this hasn't come up before | |
| 14:11:38 | efried_afk | from __future__ import absolute_import | |
| 14:11:38 | efried_afk | mdbooth: you need | |
| 14:12:03 | efried | oh, I'm late to the party. | |
| 14:12:25 | efried | if we could just merge the "kill py2" patch, we could stop doing this ick | |
| 14:14:20 | sean-k-mooney | yes | |
| 14:14:35 | sean-k-mooney | although we shoudl still keep it in mind if we backport things | |
| 14:27:28 | melwitt | bauzas: well, if you need to import the base fixtures module (https://pypi.org/project/fixtures/) there's no other way than 'import fixtures', right? | |
| 14:34:55 | mriedem | melwitt: nova.tests.functional.fixtures is where the placement fixture is | |
| 14:35:22 | mriedem | it got moved there after ripping placement out of nova | |
| 14:36:02 | melwitt | oh, I see. I forgot it was just 'fixtures' there | |
| 14:36:09 | melwitt | mah bad | |
| 14:43:44 | openstackgerrit | Eric Fried proposed openstack/nova master: Always trait the compute node RP with COMPUTE_NODE https://review.opendev.org/688979 | |
| 14:43:45 | openstackgerrit | Eric Fried proposed openstack/nova master: ItemsMatcher: mock call list arg in any order https://review.opendev.org/689487 | |
| 14:44:14 | efried | gibi: You'll like ^ :) | |
| 14:52:46 | bauzas | melwitt: sorry was afk, I meant to not import any module by relative | |
| 14:53:34 | bauzas | any import should be absolute | |
| 14:53:46 | bauzas | that's it | |
| 14:53:48 | melwitt | bauzas: np. I know, I'm saying how do you do the "from |
|
| 14:54:15 | bauzas | melwitt: "import fixtures" is absolute for it :) | |
| 14:54:24 | bauzas | I meant for packages | |
| 14:54:44 | bauzas | fixtures is both the package and the module you wanna import | |
| 14:54:53 | bauzas | nova.tests.unit.fixtures isn't | |
| 14:55:15 | bauzas | http://sametmax.com/les-imports-en-python/ | |
| 14:56:16 | melwitt | right, but if your test is in nova/tests/functional/my_test.py and you need 'import fixtures' and there is a nova/tests/functional/fixtures.py it would pick up the latter, we now know | |
| 14:56:50 | melwitt | anyway, just saying I don't see a way to avoid the problem other than using 'from __future__ import absolute_import' as has been mentioned earlier | |
| 14:58:33 | mdbooth | Thanks, all! I'll update the test. | |
| 14:59:06 | mdbooth | import fixtures as fucking_fixtures | |
| 15:00:19 | mdbooth | __future__ works :) | |
| 15:02:03 | openstackgerrit | Matthew Booth proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | |
| 15:03:53 | mdbooth | efried: I split out the regression test from the new bugfix, btw. Turned it into a double regression test with 2 separate fixes: https://review.opendev.org/#/c/689278/ | |
| 15:04:57 | efried | mdbooth: I was thinking that might be appropriate, but I was too fried to make a stink about it yesterday. Thanks. | |
| 15:05:14 | mdbooth | efried: Yeah, np. Thanks for looking. | |
| 15:06:31 | efried | cdent, gibi, bauzas, mriedem: I think all the ducks are lined up for: Always trait the compute node RP with COMPUTE_NODE https://review.opendev.org/688979 | |
| 15:06:39 | mdbooth | efried: I was also fried, and extremely annoyed at finding a new bug I wasn't looking for. | |
| 15:06:55 | efried | and btw, "if you build it, they will come" -- I came across another use case for it yesterday https://review.opendev.org/#/c/676522/21/nova/compute/resource_tracker.py@1823 | |
| 15:08:10 | bauzas | efried: cool, I'll just honestly leave it for monday | |
| 15:08:39 | bauzas | (and with no kids at home, my productivity will dramatically increase) | |
| 15:09:48 | efried | bauzas: are they "not at home" like moved out, or just on vacation? | |
| 15:10:05 | bauzas | both, grand-parents care | |
| 15:10:13 | bauzas | for the week \o/ | |
| 15:10:21 | efried | woot | |
| 15:10:25 | bauzas | indeed | |
| 15:10:28 | mdbooth | bauzas: Party at your house :) | |
| 15:11:02 | bauzas | technically, our friends and us have no kids at same time | |
| 15:11:18 | bauzas | I don't wanna rush into details about the fact we already planned the whole week | |
| 15:11:58 | mdbooth | bauzas: Why haven't you taken the week off? | |
| 15:12:36 | bauzas | because I still love my job and despite the fact it looks like, I'm not on perpetual PTO (c) mriedem | |
| 15:13:12 | mdbooth | He's just jealous | |
| 15:14:21 | bauzas | I'm pretty sure France still provides work permits for people who'd like to :p | |
| 15:14:37 | bauzas | there is one drawback tho | |
| 15:14:50 | bauzas | you have to leave in France | |
| 15:17:21 | cdent | "normal tea" | |
| 15:17:26 | cdent | such a british thing to say :P | |
| 15:17:33 | bauzas | mdbooth: it exists, it's called Courchevel | |
| 15:17:44 | bauzas | well, you also have to speak russian too | |
| 15:19:13 | mdbooth | cdent: You know, tea that's just normal. Like PG Tips or Yorkshire Tea. Not fancy. Just... normal. | |
| 15:19:23 | bauzas | mdbooth: do you think British MPs would be more inclined to accept the deal if we would add a clause for selling Courchevel ? Honestly, it's not like we miss anything | |
| 15:19:54 | bauzas | (sorry, Friday here) | |
| 15:20:23 | mdbooth | bauzas: I tried to put myself in the mind of a British MP once. I awoke from a coma 2 months later. Haven't tried again. | |
| 15:23:19 | cdent | only 2 months? | |
| 15:24:26 | sean-k-mooney | cdent: my mother refers to barrys or lyons tea as normal tea | |
| 15:24:35 | sean-k-mooney | cdent: so it translate to ireland too | |
| 15:46:11 | mriedem | efried: i'm going to have to take a different approach on https://review.opendev.org/#/c/689049/ where the caller has the context, like this: http://paste.openstack.org/show/784726/ | |
| 15:46:20 | mriedem | and pretty much leave move_allocations as-is | |
| 15:46:53 | mriedem | if we had consumer types i could determine from move_allocations if the instance still exists or not... | |
| 15:47:13 | mriedem | or just pass the types into move_allocations but that kind of sucks | |
| 15:48:12 | efried | mriedem: don't we still have a race in that situation? | |