Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-10-14
16:45:08 openstackgerrit Eric Fried proposed openstack/nova master: Stop using NoAuthMiddleware in tests https://review.opendev.org/687416
16:45:10 openstackgerrit Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181
16:45:10 openstack bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Undecided,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried)
16:45:10 openstackgerrit Eric Fried proposed openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180
16:45:13 efried mriedem: ^
16:48:23 openstackgerrit Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140
16:52:16 openstackgerrit Eric Fried proposed openstack/nova-specs master: Add spec for vm scoped sriov numa affinity https://review.opendev.org/683174
16:52:16 openstackgerrit Eric Fried proposed openstack/nova-specs master: Add 'Feature Liaison' spec process https://review.opendev.org/685857
16:52:49 efried bauzas, gmann: Had to respin to fix the title on gibi's s/Core/Feature/ Liaison section ^
16:53:07 efried (gibi thanks for adding that section preemptively :)
16:55:27 gmann efried: +1
16:55:33 efried thanks gmann
17:26:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
17:26:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
17:26:11 openstackgerrit Matt Riedemann proposed openstack/nova master: FUP for I66d8f06f19c5c631e33208580428aa843abb38d2 https://review.opendev.org/678951
17:26:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
17:26:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
17:26:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
17:26:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
17:26:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
17:26:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
17:26:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
17:26:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
17:26:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
17:26:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
17:26:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
17:26:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
17:26:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
17:26:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012
17:26:19 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058
17:51:00 openstackgerrit Son Pham proposed openstack/nova-specs master: [WIP]Add blueprint snapshot-vms-with-state of-processes https://review.opendev.org/688522
18:00:37 openstackgerrit Son Pham proposed openstack/nova-specs master: [WIP]Add blueprint snapshot-vms-with-state-of-processes https://review.opendev.org/686948
18:01:31 mriedem bauzas: here are a set of queens changes that are good to go: https://review.opendev.org/#/c/676285/ https://review.opendev.org/#/c/675355/ https://review.opendev.org/#/c/682722/ https://review.opendev.org/680873 https://review.opendev.org/#/c/676500/
18:11:21 dansmith mriedem: I guess you didn't squash that fixup patch into your second patch when you rebased just now eh/
18:12:10 dansmith doesn't look like anything is running yet, so you could do that without losing much still I think
18:12:36 mriedem https://review.opendev.org/#/c/678951/ you mean?
18:13:27 mriedem at some point the thing it was FUP'ing ( https://review.opendev.org/#/c/627890/ ) had +2s on it a couple of times so i figured it was easier to not squash for those +2s to come back as a diff check
18:14:30 mriedem i can if you want, i'm sure at this point a diff isn't trivial for gibi or stephenfin anymore anyway
18:14:32 dansmith mriedem: yeah, but rebased on master now so there's a ton of churn in the patches from there now
18:14:41 dansmith yeah
18:14:49 mriedem none of this code is impacted much from master...
18:14:58 dansmith I think it makes sense to just do it now
18:14:58 mriedem well, this conductor task code
18:15:14 dansmith oh, fair I guess. I just eye-diffed the bottom one and there was a lot of churn, but true about this one
18:15:35 mriedem https://review.opendev.org/#/c/627890/53..59 it's not really trivial anyway
18:15:37 dansmith anyway, whatever, the reason for doing it was a +2 on there in August, so seems safe to squash now but whatever
18:15:49 mriedem yeah i will
18:16:13 mriedem i'll take most any excuse to take a break from reviewing these queens backports...
18:22:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
18:22:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
18:22:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
18:22:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
18:22:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
18:22:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
18:22:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
18:22:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
18:22:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591
18:22:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253
18:22:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450
18:22:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592
18:22:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012
18:22:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
18:22:21 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058
18:22:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
18:22:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
18:22:22 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.opendev.org/637070
18:33:23 dansmith mriedem: so that filter patch that added 2.80,
18:33:34 dansmith can I rebased that on master real quick since it needs a recheck anyway?
18:33:46 dansmith otherwise I can't run tests easily because it doesn't have the rpc changes
18:33:51 dansmith (which are in master already)
18:34:20 dansmith rebasing it will only take ten minutes away from its queue time and it's behind your massive set anyway
18:34:37 mriedem sure
18:34:42 mriedem i'll re-approve
18:35:32 openstackgerrit Dan Smith proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
18:35:33 openstackgerrit Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140
18:35:33 openstackgerrit Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139
18:35:48 dansmith done
18:49:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix legacy issues in filter migrations by user_id/project_id https://review.opendev.org/682198
18:54:35 openstackgerrit Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140
19:07:35 openstackgerrit melanie witt proposed openstack/nova master: Remove redundant call to get/create default security group https://review.opendev.org/688206
19:35:33 dansmith mriedem: question for you here: https://review.opendev.org/#/c/627890/60/nova/conductor/tasks/cross_cell_migrate.py@495
19:36:04 dansmith I didn't -1 in case you had a good reason or excuse, but figured it was worth pointing out if you hadn't thought about it
19:49:08 mriedem replied
19:49:28 mriedem i've got some negative tests for things failing higher in the stack but not the scenario you're asking about
19:49:31 mriedem it wouldn't be hard to add though
19:53:03 sean-k-mooney mriedem: while that would be good i think its also i higher bar of testing then we have of similarly hairy failure modes.
19:54:01 sean-k-mooney i have wondered in the past if we should have a delete --force and change delete to raise a error with --force when the vm is in task state that are potentially hard to clean up
19:55:29 sean-k-mooney the issue with that is force deleteion is somehting i proably woudl want only my admin to do sicne they are the ones that woudl have to clean it up but as a use if i dont want a thing any more i should be able to say that
19:55:40 sean-k-mooney espcially since im being billed for it in most cases
20:00:17 sean-k-mooney which reminds me we shoud get around to merging this so we dont leak vifs when we delete the vm while its spwaning https://review.opendev.org/#/c/663382/
20:06:50 sean-k-mooney dansmith: melwitt could one of ye review ^ efried since you looked at that ages ago if you get a chance that would be cool too
20:07:47 efried sean-k-mooney: are you +1 at this point?
20:08:11 sean-k-mooney im rereviewing it now to determind what matt changed
20:08:24 sean-k-mooney but it think it ws just the unit tests
20:08:53 mriedem trying to catch up, was on a call
20:08:55 sean-k-mooney but it was rebased so doing eye ball diff manually
20:09:45 mriedem so (1) sean-k-mooney you're saying fault injection testing per dansmith's request is a higher bar of testing than we usually have, right? if so i agree but i also agree we should do that kind of testing while it's fresh in our minds so i don't have a problem adding it
20:10:22 mriedem and (2) https://review.opendev.org/#/c/663382/ the last time i looked at that there were questions about how you can even get into that situation - did anyone (stephen?) sort that out?
20:10:27 sean-k-mooney mriedem: yes im not saying we should not do it just we normally have not been that proactive
20:11:12 sean-k-mooney i just notice that mdbooth updated it and so maybe that is a ping to early

Earlier   Later