| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-14 | |||
| 10:24:48 | SonPham | how this code work? | |
| 10:24:52 | SonPham | def reboot_instance(self, ctxt, instance, block_device_info, | |
| 10:24:53 | SonPham | block_device_info=block_device_info, | |
| 10:28:33 | SonPham | hi . i just traced nova-compute code | |
| 10:29:12 | SonPham | from nova-compute (api.py) call to rpcapi.py | |
| 10:29:40 | SonPham | but i can;t trace how it call to manager.py | |
| 10:32:37 | gibi | SonPham: ComputeManager.reboot_instance() is called via RPC from ComputeAPI.reboot_instance() | |
| 10:33:18 | SonPham | gibi can i add more RPCapi? | |
| 10:33:41 | SonPham | i'm finding docs about this | |
| 10:34:06 | gibi | SonPham: there is some documentation here https://docs.openstack.org/nova/latest/reference/rpc.html | |
| 10:34:44 | jkulik | Hi, what's the expected outcome if I create a server with imageRef and a boot-from-volume block_device_mapping_v2 entry in the same request? I know some code checks for instance.image_ref for bfv. But it looks like in this case image_ref is still set even though the bfv disk is kept. | |
| 10:35:38 | gibi | SonPham: but this is even better from dansmith http://www.danplanet.com/blog/2015/10/05/upgrades-in-nova-rpc-apis/ | |
| 10:36:56 | kashyap | gibi: I wouldn't normally randomly spam, but mind taking this no-risk (can explain) backport for Queens? -- https://review.opendev.org/#/c/668111/ | |
| 10:37:23 | gibi | kashyap: I can read it but note that I don't have +2 on stable branches | |
| 10:37:29 | kashyap | gibi: It already has +2, FWIW. I'd have asked Eric, as he ACKed the change before, but he's on PTO | |
| 10:37:40 | kashyap | Aargh. Who is awak that can ACK it now? | |
| 10:37:45 | kashyap | s/awak/awake/ | |
| 10:39:36 | gibi | kashyap: https://review.opendev.org/#/admin/groups/540,members maybe bauzas can help | |
| 10:40:01 | kashyap | Thank you, yeah | |
| 10:40:36 | kashyap | bauzas: Mind having a look? It is largely a procedural ACK. It was discussed here a week or so ago to be safe: https://review.opendev.org/#/c/668111/ | |
| 10:46:31 | SonPham | i have push a nova-specs rts file and tag nova core-reviewer but no want review it. what must i do | |
| 10:48:16 | gibi | SonPham: be patient :) | |
| 10:51:43 | SonPham | my boss not patient with me ;( | |
| 10:52:36 | openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | |
| 10:55:39 | gibi | SonPham: then you have to explain to your boss how the openstack upstream community works. | |
| 10:56:36 | SonPham | (y) nice. good ideal | |
| 10:57:56 | gibi | SonPham: you got questions from Eric in your spec https://review.opendev.org/#/c/686948/ | |
| 10:58:24 | gibi | SonPham: so the next step would be to answer them | |
| 11:00:05 | SonPham | gibi yep . i uploaded new patch set | |
| 11:01:05 | gibi | SonPham: cool Eric (efried) is on PTO (vacation) when he returns I suggest that you ping him telling him that you answered his questions in the spec reviw | |
| 11:01:08 | gibi | review | |
| 11:04:25 | SonPham | gibi how to ping him? | |
| 11:04:55 | cdent | blargh: launchpad is timing out on write for me | |
| 11:05:39 | gibi | SonPham: his nick is efried (now efried_pto as he is on vacation) if you mention his nick his IRC client will notify him | |
| 11:11:17 | openstackgerrit | Merged openstack/nova master: setup.cfg: Cleanup https://review.opendev.org/677969 | |
| 11:15:00 | SonPham | gibi what is his nick's name in IRC chat? | |
| 11:15:24 | gibi | SonPham: 'efried_pto' now, 'efried' when he is not on vacation | |
| 11:16:16 | SonPham | ok thanks | |
| 11:25:57 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | |
| 11:34:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | |
| 11:35:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | |
| 11:35:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused 'nova-dsvm-base' job https://review.opendev.org/688389 | |
| 11:37:51 | sean-k-mooney | stephenfin: i think your topic is incorrect on https://review.opendev.org/#/c/687954/5 | |
| 11:38:11 | stephenfin | Yes. Yes it is :D | |
| 11:38:37 | stephenfin | fixed | |
| 11:38:46 | sean-k-mooney | you need to fix the follow up patch too | |
| 11:38:59 | sean-k-mooney | but cool | |
| 11:40:13 | bauzas | kashyap: /me clicks on the stable change | |
| 11:41:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused 'nova-dsvm-base' job https://review.opendev.org/688389 | |
| 11:41:21 | bauzas | hah, queens backport | |
| 11:44:09 | bauzas | https://releases.openstack.org/ | |
| 11:44:09 | bauzas | kashyap: FWIW, the queens branch will become on Extended Maintenance in around 3 weeks :) | |
| 11:44:26 | bauzas | Queens Maintained 2018-02-28 Extended Maintenance estimated 2019-10-25 | |
| 11:47:57 | openstackgerrit | Arthur Dayne proposed openstack/nova master: libvirt:volume:Disallow AIO=native when no 'O_DIRECT' is available https://review.opendev.org/682772 | |
| 11:55:50 | kashyap | bauzas: Yeah, I'm aware of that. And thank you! :-) | |
| 12:49:05 | alex_xu | stephenfin: gibi efried_pto, just try to kick off the work https://etherpad.openstack.org/p/nova-train-release-project-update | |
| 12:50:37 | gibi | alex_xu: good initiative! I will check the etherpad out | |
| 12:50:46 | alex_xu | gibi: thanks | |
| 13:32:51 | openstackgerrit | Sundar Nadathur proposed openstack/nova-specs master: Updated Nova-Cyborg interaction spec. https://review.opendev.org/684151 | |
| 13:38:40 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | |
| 14:06:38 | openstackgerrit | Merged openstack/nova stable/queens: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/668111 | |
| 14:09:09 | dansmith | mriedem: https://review.opendev.org/#/c/633293 needs a rebase and compute rpc bump because of me... sorry :( | |
| 14:09:49 | mriedem | just replied on that one and noticed | |
| 14:10:04 | mriedem | don't worry, not my first rodeo chasing compute rpc version bumps on that series | |
| 14:10:21 | mriedem | you also have to rebase your api change and address some stuff in it :) | |
| 14:11:46 | mriedem | i misunderstood your question about the long rpc call | |
| 14:11:55 | mriedem | thought you were asking why it was a call and not a cast | |
| 14:12:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove compute compat checks for aborting queued live migrations https://review.opendev.org/688409 | |
| 14:12:55 | dansmith | mriedem: no, I was asking why a long call and not a regular call | |
| 14:13:02 | mriedem | yeah i realized | |
| 14:13:15 | mriedem | i don't have a good answer except it's what i did in all the new compute methods in this series | |
| 14:13:51 | dansmith | heh okay, like I said, I'm not sure there's a reason *not* to do it really, other than just signaling that some of them are expected to run *really* long | |
| 14:14:01 | dansmith | well, and I guess there's a teensy bit of messaging overhead | |
| 14:14:23 | bauzas | mriedem: just saw this morning that Queens will be on Extended Maintenance in 3 weeks, so maybe we should look at https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens ? | |
| 14:15:09 | dansmith | mriedem: I guess I thought the point of the schema was so we didn't have to test for things that the schema would reject for us | |
| 14:15:15 | dansmith | well, one of the points of the schema | |
| 14:15:37 | mriedem | we still have to test that we defined the schema correctly | |
| 14:15:38 | dansmith | isn't that like kinda like silly tests that are actually only testing that mock is working? | |
| 14:15:46 | dansmith | okay | |
| 14:16:03 | mriedem | and i'd say to prevent regressions in later microversions on the same api | |
| 14:16:53 | dansmith | okay, that's fine it just seems inconsistent with what we do elsewhere, like we don't check that when you define an object field as int that a string will blow it up :) | |
| 14:17:54 | mriedem | i've seen and i'm pretty used invalid schema before adding tests to validate it so it's a more complicated thing than type checking | |
| 14:17:59 | mriedem | *pretty sure | |
| 14:18:06 | dansmith | ah dammit, I really wanted 2.80 | |
| 14:18:44 | dansmith | also, I haven't had to write one of these in a long time, but it really sucks to have to do so much work if you miss your microversion | |
| 14:18:45 | mriedem | bauzas: join the party i guess, it's usually a party of 1 | |
| 14:19:12 | dansmith | I wish we could do something better there | |
| 14:20:10 | mriedem | i don't thinking the microversion stuff can be reasonably automated | |
| 14:20:12 | mriedem | *think | |
| 14:20:23 | mriedem | coffee hasn't kicked into my brain yet | |
| 14:20:34 | dansmith | well, it would take some changes in our workflow I think | |
| 14:20:39 | dansmith | I know it's not trivial | |
| 14:29:21 | efried | o/ nova | |
| 14:30:12 | efried | alex_xu, stephenfin, gibi: I copied the Denver proj update to a new google slide thingy. PM me whatever email address you have a google account for and I'll add you to editors. | |
| 14:35:22 | dansmith | gmann: can you help me decipher mriedem's request here? or point me at what something new looks like that I can copy? https://review.opendev.org/#/c/687140/5/nova/tests/unit/test_policy.py@312 | |
| 14:39:03 | gmann | dansmith: yeah, we can use the new naming standard for new policy. EX -https://github.com/openstack/nova/blob/master/nova/policies/server_topology.py#L19 | |
| 14:39:45 | dansmith | gmann: oh meaning just s/os-// ? | |
| 14:40:13 | mriedem | decipher :/ | |
| 14:40:26 | mriedem | i said "compute:aggregates:images" or "compute:aggregates:images:cache" | |
| 14:40:37 | dansmith | okay, I dunno what I was thinking last week, but reading it this morning he *did* tell me what to type | |