| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-09 | |||
| 14:03:12 | mriedem | since it avoids that tightly coupled plumbing | |
| 14:03:24 | dansmith | yep, well, that's what I was looking for | |
| 14:03:45 | mriedem | ack, it's also the alternative i tihnk i thought of on the original patch a long time ago but hadn't yet worked up a patch to see it in action | |
| 14:03:54 | mriedem | the functional recreate tests helped to make sure it was all working | |
| 14:03:58 | mriedem | i'm just fixing unit tests now | |
| 14:04:20 | mriedem | if you have suggestions on the patch, like if you're annoyed at the size with the docstrings and stuff, i could split that stuff out | |
| 14:05:59 | dansmith | not particularly.. I just kinda skimmed it but seems good | |
| 14:10:27 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/queens: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/668111 | |
| 14:10:42 | gibi | eandersson: rocky backport is up https://review.opendev.org/#/c/687565/ It is not a clean one | |
| 14:11:23 | kashyap | mriedem: You've in the past asked about the above stable/queens backport; I've got multiple bug reports for it, downstream, FWIW. I think it's worth it for Queens, too; Cc: lyarwood | |
| 14:12:09 | kashyap | (I fixed the legit test failure you pointed out.) | |
| 14:14:30 | mriedem | gibi: -1 on the bottom of your stein series of backports | |
| 14:14:44 | mriedem | missing a fix for a bug in the functional test i added which you fixed in train | |
| 14:15:40 | gibi | mriedem: thanks for checking. This is not at all a clean backport series unfortunately | |
| 14:15:48 | mriedem | kashyap: i'm not sure i want to be involved in that, it feels very rhel specific and especially with the rhel focus/pressure on queens stuff | |
| 14:15:54 | mriedem | kashyap: maybe if dansmith blesses it first | |
| 14:16:03 | mriedem | gibi: yeah i'm not surprised | |
| 14:16:13 | kashyap | mriedem: I knew you might say something like that :-) There's no "pressure" per se - as you can see the timeline of the backport | |
| 14:16:59 | kashyap | mriedem: I'd apprecaite if you were more charitable in your interpretation of intentions. I take "upstream first" damn seriously. | |
| 14:17:03 | openstackgerrit | Eric Fried proposed openstack/nova master: Stop using NoAuthMiddleware in tests https://review.opendev.org/687416 | |
| 14:17:41 | efried | mriedem: That might be ready to go ^ | |
| 14:19:26 | mriedem | kashyap: sorry? | |
| 14:19:53 | kashyap | mriedem: Nothing; my tired brain maybe read too much into what you said. | |
| 14:20:01 | mriedem | i'm not the only stable core so i'd appreciate if you didn't lay it on me | |
| 14:20:28 | kashyap | Sure. I explicitly pinged you because you had a question - otherwise, like any good citizen I'd ask it to the channel. | |
| 14:23:42 | kashyap | mriedem: Also, it is not "RHEL-specific" (whatever you mean by that) | |
| 14:25:00 | dansmith | mriedem: doesn't seem terrible to me. anyone running queens that is tracking later libvirt would care about this (like metacloud used to be famous for) | |
| 14:25:36 | dansmith | realistically today we're probably the ones that most care | |
| 14:25:59 | dansmith | we'll backport it internally of course, but it's cleaner for the accounting if it's in upstream queens | |
| 14:26:20 | dansmith | unless we mark a maximum version of libvirt that is acceptable for a given release, then this just seems like maintenance to me | |
| 14:27:50 | mriedem | maybe my mistake is originally reading it as "if you've got libvirt 4.7.0+ in queens do x" which is true but not probably for the reason i thought, which was like opt into some new behavior, and i thought "who is going to be running that new a version of libvirt except rhelosp customers" | |
| 14:28:34 | mriedem | so the point is if you're running libvirt 4.7.0+ let it do the retry/timeout stuff rather than nova, otherwise you get what - a super long timeout (or too short?) retry/timeout loop? | |
| 14:29:15 | dansmith | mriedem: right, but also apparently it changes the timeout counter for older versions, which should have been a different patch | |
| 14:29:30 | dansmith | so in that sense, it improves things for the more normal-for-queens versions too (supposedly) | |
| 14:29:57 | dansmith | tbh, it needed a refactor to make that clearer because it took me a while to realize it wasn't doing something much dumber | |
| 14:30:19 | dansmith | it looked to me like it was increasing the timout for 4.7 and actually removing that code for the older versions, but it's the opposite | |
| 14:30:29 | dansmith | but, have to kick that to the original reviewers | |
| 14:30:38 | mriedem | so wait longer for older libvirt versions, for newer libvirt let it handle it (assuming libvirt 4.7.0+ wait doesn't have bugs...) | |
| 14:30:40 | dansmith | (whoever that was, not me) | |
| 14:30:44 | dansmith | yes | |
| 14:37:45 | bauzas | gibi: http://paste.openstack.org/show/782109/ at line 17 and below looks weirdo | |
| 14:42:37 | kashyap | dansmith: Yes, your view is correct in: "largely maintenance". | |
| 14:42:44 | kashyap | mriedem: Your "so the point" is indeed correct | |
| 14:44:55 | gibi | bauzas: what do you mean by weirdo? | |
| 14:45:10 | kashyap | dansmith: Maintenance, and also improves things for normal-for-Queens version, too. FWIW, I've seen several occurences of it upstream and on IRC, too. | |
| 14:45:49 | bauzas | gibi: because I don't understand why it's not getting the compute node | |
| 14:45:54 | dansmith | kashyap: I think I said that, almost word-for-word :) | |
| 14:46:01 | bauzas | gibi: at least for the first RP | |
| 14:46:13 | kashyap | dansmith: I _was_ reinforcing your point, if it wasn't obvious :-) | |
| 14:46:20 | bauzas | (for the others, well it should find the root RP) | |
| 14:46:29 | bauzas | anyway, will try to find the problem | |
| 14:46:32 | gibi | bauzas: could this be some noise from the scatter gather? trying to get the compute from cell0? | |
| 14:47:16 | kashyap | dansmith: So in your copious free time, ACK / NACK / etc :-) (Also on refactor - that whole _method_ needs refactoring, you saw how long & convoluted that already is) | |
| 14:47:17 | bauzas | I don't think because I used the method not verifying the cell0 | |
| 14:47:25 | bauzas | gibi: anyway, thanks | |
| 14:50:06 | gibi | bauzas: true, your code skips cell0. | |
| 14:51:20 | bauzas | gibi: you know what ? I'll add some debug log | |
| 14:51:35 | gibi | bauzas: good idea | |
| 14:52:09 | bauzas | gibi: because https://review.opendev.org/#/c/670112/7/nova/cmd/manage.py@2772 should give you the root provider UUID | |
| 14:52:24 | bauzas | gibi: so we should have the same UUID for the 4 calls | |
| 14:54:34 | gibi | bauzas: do you use the proper microversion for the placement calls? | |
| 14:54:50 | bauzas | gibi: that's something I think it could be the root cause | |
| 14:55:32 | bauzas | gibi: I just don't ask for a specific microversion https://review.opendev.org/#/c/670112/7/nova/cmd/manage.py@2865 | |
| 14:55:43 | bauzas | but .get() does IIRC | |
| 15:00:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Prevent init_host test to interfere with other tests https://review.opendev.org/687579 | |
| 15:01:00 | gibi | bauzas: I think you need to pass the version to placement.get(.., version=1.14) | |
| 15:01:22 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Error out interrupted builds https://review.opendev.org/687535 | |
| 15:01:22 | openstack | bug 1833581 in OpenStack Compute (nova) train "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 15:01:22 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Functional reproduce for bug 1833581 https://review.opendev.org/687534 | |
| 15:01:34 | gibi | mriedem: ^^ restacked with the extra fix | |
| 15:02:04 | bauzas | gibi: probably, I need to look at more | |
| 15:02:22 | gibi | bauzas: https://github.com/openstack/nova/blob/b96b385a3468e91fa544bffa51832513feb4f383/nova/scheduler/client/report.py#L235 | |
| 15:03:20 | bauzas | gibi: sure, but I need to see whether we autodiscover the latest or we use the first microversion when None | |
| 15:05:39 | mriedem | gibi: you missed the cherry-picked-from line | |
| 15:08:04 | gibi | mriedem: indeed. | |
| 15:11:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Prevent init_host test to interfere with other tests https://review.opendev.org/687579 | |
| 15:11:57 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Error out interrupted builds https://review.opendev.org/687535 | |
| 15:11:57 | openstack | bug 1833581 in OpenStack Compute (nova) train "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 15:11:57 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Functional reproduce for bug 1833581 https://review.opendev.org/687534 | |
| 15:12:04 | gibi | mriedem: fixed ^^ | |
| 15:25:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | |
| 15:25:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fixtures: Add support for security groups https://review.opendev.org/686802 | |
| 15:25:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'os-security-group-default-rules' REST API https://review.opendev.org/686807 | |
| 15:25:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | |
| 15:25:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove (most) '/os-networks' REST APIs https://review.opendev.org/686809 | |
| 15:25:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused '*_default_rules' security group DB APIs https://review.opendev.org/686808 | |
| 15:25:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'USE_NEUTRON' from functional tests https://review.opendev.org/686811 | |
| 15:25:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove '/os-tenant-networks' REST API https://review.opendev.org/686810 | |
| 15:25:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova-manage network, floating commands https://review.opendev.org/686813 | |
| 15:25:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'networks' quota https://review.opendev.org/686812 | |
| 15:25:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815 | |
| 15:25:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814 | |
| 15:26:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817 | |
| 15:26:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary https://review.opendev.org/686816 | |
| 15:26:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP https://review.opendev.org/686818 | |
| 15:43:59 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Privatize and reorganize base package methods https://review.opendev.org/687378 | |
| 15:45:51 | stephenfin | bauzas: Got another fairly trivial doc patch for you, if you're in the mood https://review.opendev.org/#/c/684402/ | |
| 15:46:36 | bauzas | stephenfin: I'm always in the mood for docs | |
| 15:49:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API https://review.opendev.org/469675 | |
| 15:56:09 | openstackgerrit | Merged openstack/os-traits master: Add method to visualize the os-traits tree https://review.opendev.org/686464 | |