| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-07 | |||
| 14:04:28 | mriedem | lyarwood: i think https://review.opendev.org/#/c/679449/ is probably about the only thing worth getting into the next stable/rocky release if you want to push that through and then i'll queue up the release | |
| 14:05:36 | lyarwood | mriedem: ack I'll take a look now | |
| 14:09:11 | tellesnobrega | mriedem, hi, quick question nova reset-state command. I'm wondering if the command delete all ghost vms on the db? In case we do a backup of the DB and restore that later and the vms are gone, how can we clean up the DB | |
| 14:10:47 | mriedem | it does not | |
| 14:10:58 | mriedem | all reset-state does is change the vm_state on the instance and set task_state to None | |
| 14:11:11 | mriedem | it has no interaction with the compute service | |
| 14:11:34 | mriedem | to clean up the db you use the nova-manage db archive_deleted_rows command | |
| 14:11:48 | tellesnobrega | mriedem, awesome | |
| 14:11:50 | mriedem | with the --purge option if you really want to delete the data and not just move it to shadow tables | |
| 14:11:51 | tellesnobrega | thanks, I will take a look | |
| 14:12:01 | mriedem | info is here https://docs.openstack.org/nova/latest/cli/nova-manage.html | |
| 14:12:10 | tellesnobrega | mriedem, thanks | |
| 14:14:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Prevent using blank volume as boot device https://review.opendev.org/171984 | |
| 14:25:52 | gibi | stephenfin: I have one question in https://review.opendev.org/#/c/686795/2/nova/tests/fixtures.py@1255 | |
| 14:27:26 | gshippey | Instance wont migrate to a newly provisioned compute host, this is the error in the nova-compute log: During detach_volume, instance disappeared.: InstanceNotFound: Instance 2b5cdc09-e451-4e1d-9044-4d85ffd29b51 could not be found. Has anyone seen anything similar before? | |
| 14:28:02 | stephenfin | looking | |
| 14:28:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove fstype param from ploop init https://review.opendev.org/444970 | |
| 14:29:02 | stephenfin | gibi: Replied | |
| 14:30:04 | openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | |
| 14:30:08 | efried | alex_xu: ^ | |
| 14:30:14 | efried | thanks for the review. | |
| 14:30:28 | mriedem | stephenfin: kind of hard to care about any ploop/vz patches when their ci hasn't worked in probably over a year | |
| 14:31:25 | stephenfin | That one was fairly trivial so it shouldn't matter, hopefully, but yeah, agreed | |
| 14:31:58 | gibi | stephenfin: thanks | |
| 14:32:16 | mriedem | stephenfin: so...remove your +2 until their CI passes on it? | |
| 14:32:28 | mriedem | it's just code cleanup, not really fixing a bug | |
| 14:32:31 | mriedem | as far as i can tell | |
| 14:32:56 | stephenfin | kewl | |
| 14:32:57 | stephenfin | yeah | |
| 14:32:59 | stephenfin | it is | |
| 14:34:46 | openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | |
| 14:34:46 | openstack | bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Undecided,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried) | |
| 14:34:46 | openstackgerrit | Eric Fried proposed openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180 | |
| 14:34:53 | efried | resolved merge conflict ^ | |
| 14:40:51 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: [WIP] Move Nova Quobyte driver to LibvirtMountedFileSystemVolumeDriver https://review.opendev.org/687066 | |
| 14:47:48 | openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | |
| 14:47:48 | openstack | bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Undecided,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried) | |
| 14:47:48 | openstackgerrit | Eric Fried proposed openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180 | |
| 14:48:05 | efried | mriedem: clarified those comments in the test case -^ | |
| 14:49:57 | mriedem | stephenfin: remember when you abandon a patch linked to a bug, e.g. https://review.opendev.org/#/c/585978/ - you should probably update the bug to say it's not in progress and remove the owner | |
| 14:53:55 | mriedem | ack | |
| 14:54:29 | mriedem | stephenfin: i know you're busy with cleaning up old patches, but now that you've got my attention on this giant docs rewrite https://review.opendev.org/#/c/667133/ it'd be nice to close that out | |
| 14:55:04 | stephenfin | I can do both of those shortly, yup (y) | |
| 15:03:42 | mriedem | thanks | |
| 15:04:18 | mriedem_afk | gibi: dansmith: how are you feeling about this now? https://review.opendev.org/#/c/633293/ | |
| 15:04:34 | dansmith | will look in a biot | |
| 15:05:12 | gibi | mriedem_afk: I have to get back to that tomorrow | |
| 15:14:19 | donnyd | with the understand I know everyone is busy, is there anything I can do to move the ball forward on LXC | |
| 15:21:19 | efried | sean-k-mooney: ^ ? | |
| 15:25:04 | sean-k-mooney | donnyd: specificaly are you refering to https://review.opendev.org/#/c/667976/ or to hardeingin the lxc support in general | |
| 15:25:57 | sean-k-mooney | i tested ^ locally and it does indeed work so i think we shoudl merge it | |
| 15:25:57 | donnyd | sean-k-mooney: I am speaking more generally in terms of what can we do to | |
| 15:26:01 | donnyd | but yes that too | |
| 15:27:05 | sean-k-mooney | donnyd: mriedem_afk has a WIP lxc job i belive. feature wise the next thing i would like to see fixed is automaic resize of the disk to match the flavor for lxc | |
| 15:27:14 | sean-k-mooney | or rather the filesystem. | |
| 15:28:12 | sean-k-mooney | i think the block device is resized my nova already but i dont think you can resize the filesystme using growpart/resize2fs inside the lxc contiaer itself | |
| 15:28:41 | sean-k-mooney | once that was working my next wishlist item would be to fix the console. | |
| 15:29:22 | sean-k-mooney | neither of these i suspect would be terible hard to fix but we just have not spent the time to do it. | |
| 15:29:46 | donnyd | Isn't that a cloud-init function anyways | |
| 15:30:12 | sean-k-mooney | it is but i have tried to resize the filesystm from inside the lxc contianer manually and you cant | |
| 15:30:24 | sean-k-mooney | clould init works in teh lxc continer at startup | |
| 15:30:34 | sean-k-mooney | so i wont be able to do it either | |
| 15:30:51 | donnyd | Is that because of privileges to the underlying block device? | |
| 15:30:57 | sean-k-mooney | yep | |
| 15:31:18 | sean-k-mooney | we dont allow you to acess the block deivec in /dev directly with the permission to adjust the filesystem | |
| 15:31:52 | donnyd | So would it be possible to say start the container privileged, let cloud-init do its thing, and then restart unpriv | |
| 15:32:08 | donnyd | should all happen pretty quickly | |
| 15:32:25 | donnyd | With the understanding that right now, this is just kinda where its at | |
| 15:32:36 | sean-k-mooney | maybe but it might be cleaner to just have nova invoke resize2fs on the blockdevice before starting the container | |
| 15:32:51 | donnyd | sure, that would work too | |
| 15:33:07 | sean-k-mooney | i mean nova already grows the backing image to match the flavor root_disk | |
| 15:33:18 | donnyd | does nova blast a filesystem down onto the block device is makes now? | |
| 15:33:49 | sean-k-mooney | it effectly just uses qemu-image to DD the glance iamge but the resizes the image to the flavor size | |
| 15:35:03 | sean-k-mooney | how this actully works depends on your image backend in nova but the glance image basicaly has a partion table and filesystm | |
| 15:35:45 | sean-k-mooney | and we just donwlaod it and resize it. there are optimisation of copy on write formats liek qcow or backend like ceph | |
| 15:36:03 | donnyd | Ok, so we would have to inspect that filesystem or require meta-datas to tell nova whats in the box. Correct? | |
| 15:37:19 | sean-k-mooney | am im not sure we would. the qemu tools or libguestfs likely can do this for us | |
| 15:37:32 | sean-k-mooney | we would jsut need to call them. | |
| 15:38:42 | donnyd | Is libguestfs required for all distros or just RH ones? | |
| 15:39:16 | donnyd | Its about the slickest tool in the world for these types of things, but not sure its a req for the .debs | |
| 15:57:46 | efried | stephenfin: If you still have time today, wanna polish up the "SEV is busted" patch? aspiers has been MIA, so unless something drastic happens, I want to be able to merge that tomorrow so we have a bit of breathing room for the RC. | |
| 15:58:45 | stephenfin | Can do | |
| 16:10:22 | sean-k-mooney | donnyd: libguestfs is currently used for only 1 thing in nova and that thing is kind of broken | |
| 16:10:26 | efried | thanks stephenfin | |
| 16:11:08 | sean-k-mooney | donnyd: it is used to determin the default vaules of some option like disk_bus in th elibvirt dirver based on metadata on the image and i think it can do some interspection | |
| 16:11:49 | sean-k-mooney | so if i could remove the depency for that i would however if we had a valid usecase of it other then that i could see keeping it as a depency | |
| 16:13:13 | sean-k-mooney | donnyd: part of the reason i would like to remove libguestfs is currenlty it pulls in the kernel so it makes contianer image 10s-100s of megabytes bigger as it has a full kernel in the image | |
| 16:18:23 | ricolin | Hi, Nova team please help to review https://review.opendev.org/#/c/686996/ that error now frequently shows on grenade-heat job | |
| 16:26:49 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133 | |
| 16:32:37 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: docs: Highlight the current broken state of SEV https://review.opendev.org/686414 | |
| 16:32:49 | stephenfin | efried: mriedem_afk: ^ | |
| 16:33:10 | openstackgerrit | Merged openstack/nova stable/rocky: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/679449 | |
| 16:33:17 | openstackgerrit | Merged openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | |
| 16:33:24 | openstack | bug 1709118 in OpenStack Compute (nova) "_ContextAuthPlugin needs a refresh" [Low,Invalid] https://launchpad.net/bugs/1709118 | |
| 16:33:24 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove workaround for bug #1709118 https://review.opendev.org/524316 | |
| 16:33:27 | openstackgerrit | Merged openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | |
| 16:33:31 | efried | stephenfin: fixed pep ---^ | |
| 16:33:34 | openstackgerrit | Merged openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | |
| 16:34:08 | efried | mriedem_afk: easy ksa-ish fix: Remove workaround for bug #1709118 https://review.opendev.org/524316 | |
| 16:36:17 | sean-k-mooney | stephenfin: im sure ill find an example quickly but we can trivaly rename config vaules while both deprecteint the old name and still supporting it right. | |