| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-04 | |||
| 14:52:00 | mriedem | stephenfin: ugh....can we just do that in a follow up? | |
| 14:52:07 | mriedem | b/c that's going to slow things down quite a bit | |
| 14:52:43 | stephenfin | mriedem: We can. Want me to just fix that commit message comment and merge as-is so? | |
| 14:53:10 | bauzas | efried: honestly, I'm not opinionated, I just wanted to explain it would look a bit weirdo if the same name would be for both the owner and the liaison | |
| 14:53:28 | bauzas | efried: something either "None" or "Not needed" is cool with me | |
| 14:53:33 | efried | bauzas: I agree, I tried to explain it in the FAQ | |
| 14:53:40 | mriedem | stephenfin: if you're going to rev the commit message, i think you could also the thing i asked for in the stub which is only return a default security group for an instance that has a non-empty info_cache | |
| 14:53:44 | mriedem | stephenfin: i think that's as easy as: | |
| 14:53:48 | efried | bauzas: and yes, latest PS has "or None" in the template | |
| 14:53:57 | bauzas | ok, will look at it then | |
| 14:54:02 | efried | thx | |
| 14:54:16 | mriedem | if instance.get_network_info() | |
| 14:55:46 | stephenfin | I'm not sure if can rely on that since I think we mock a lot of it. See https://github.com/stephenfin/nova/commit/afb4698e8f7e39154e90dfe775d2d0e3e1f20dbc#diff-c731e6017d325067e73f0124f4ade91c | |
| 14:55:58 | stephenfin | Is that something else though? | |
| 14:56:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add boot from volume functional test with a huge request https://review.opendev.org/686734 | |
| 14:56:18 | mriedem | dansmith: so ^ proves my point about the server create case, mayhap i should open a bug for that | |
| 14:56:28 | dansmith | mriedem: ack | |
| 15:00:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add boot from volume functional test with a huge request https://review.opendev.org/686734 | |
| 15:02:54 | mriedem | stephenfin: ok so i guess for the current patch, how about just (1) fix the commit message and (2) leave a TODO in the new stub method that it should be smarter about instances that don't have networks/ports and thus won't have security groups | |
| 15:12:57 | stephenfin | mriedem: Yup, I can do that | |
| 15:13:00 | stephenfin | Will respin now | |
| 15:22:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334 | |
| 15:27:09 | mriedem | gibi: could i ask you to hit the bottom 2 FUPs in the cross-cell resize series https://review.opendev.org/#/c/676228/ since i think you're familiar with the changes they are...FUPing (aleady have a +2 on them) | |
| 15:27:58 | gibi | mriedem: sure, looking... | |
| 15:29:42 | mriedem | dansmith: what do you think about getting this CellTimeout logging traceback change in to debug the gate failure? https://review.opendev.org/#/c/684118/ - i'm unable to recreate on that change itself after many rechecks but it's one of the top gate failures: http://status.openstack.org/elastic-recheck/#1844929 | |
| 15:30:59 | dansmith | mriedem: sure | |
| 15:33:09 | gibi | efried: so https://blueprints.launchpad.net/nova/+spec/support-move-ops-with-qos-ports is in Implemented state. So I think I need to open a new bp for U about the rest of the move operations (live migrate, evacuate, unshelve) and then propose a spec that is a slimmed down version of the original spec https://review.opendev.org/#/c/652608/ Do you agree? | |
| 15:33:25 | mriedem | i did get the mysqld logs published for these failing grenade jobs and it looks like we do start mysqld at least 3 times during the grenade run which i didn't expect | |
| 15:33:37 | mriedem | we can see things really start to go south about the time that we hit the cell timeout failures | |
| 15:33:38 | mriedem | https://zuul.opendev.org/t/openstack/build/4085120e390f4f1e971c6ff61304a596/log/logs/mysql/error.txt.gz#213 | |
| 15:33:54 | dansmith | mriedem: yeah that seems weird | |
| 15:34:02 | efried | gibi: That would be fine. If you prefer I can un-implement the train bp and you can reuse it. I don't really care too much. But I think the old process hounds have a preference for creating a new bp (-ussuri suffix). | |
| 15:34:03 | dansmith | mriedem: are we actually upgrading mysql packages? | |
| 15:34:08 | mriedem | so i guess 2 starts would mean...old devstack and new devstack | |
| 15:34:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Correctly mock out security groups in NeutronFixture https://review.opendev.org/685927 | |
| 15:34:15 | stephenfin | mriedem: ^ | |
| 15:34:25 | stephenfin | think that's what you were looking for | |
| 15:36:18 | gibi | efried: OK, I will go with a new one. thanks | |
| 15:37:50 | mriedem | dansmith: we're not upgrading packages, same version for all 3 starts: | |
| 15:37:51 | mriedem | mysqld (mysqld 5.7.27-0ubuntu0.18.04.1) starting as process | |
| 15:38:06 | dansmith | mriedem: so why are we restarting it at all? | |
| 15:38:41 | mriedem | for one old and new devstack will just blindly try to restart the service i think | |
| 15:38:47 | mriedem | i need to dig into the grenade log | |
| 15:38:49 | dansmith | odd | |
| 15:39:15 | sean-k-mooney | dansmith: we also could be tweaking the mysql config between release | |
| 15:39:25 | dansmith | mriedem: unrelated, remind me.. are we not supposed to 404 for things like specifying a missing image id in my request? | |
| 15:39:35 | sean-k-mooney | although i dont think we actully do set much in grenade | |
| 15:39:36 | dansmith | sean-k-mooney: possible, but not sure what that would be | |
| 15:39:51 | dansmith | sean-k-mooney: but maybe some implicit restart in case it has changed or something | |
| 15:39:51 | mriedem | dansmith: 400 | |
| 15:39:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Correctly mock out security groups in NeutronFixture https://review.opendev.org/685927 | |
| 15:39:55 | dansmith | mriedem: okay | |
| 15:40:02 | mriedem | dansmith: 404 is if the resouce in the path is missing i think | |
| 15:40:06 | mriedem | 400 if a thing in the body is | |
| 15:40:12 | dansmith | mriedem: okay | |
| 15:40:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | |
| 15:40:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | |
| 15:41:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339 | |
| 15:42:19 | mriedem | stephenfin: +2 | |
| 15:42:24 | mriedem | gibi: i'm +2 on https://review.opendev.org/#/c/685927/ if you want to re-+2 | |
| 15:42:34 | stephenfin | ta | |
| 15:42:37 | gibi | mriedem: going... | |
| 15:42:47 | dansmith | mriedem: sean-k-mooney: in grenade's resource phase, mysql has to be up because we validate some things without the api, but we might then stop it between the upgrade steps I guess, but wouldn't expect to restart it more than that one time | |
| 15:42:59 | stephenfin | mriedem: Fixed you commit message nit on https://review.opendev.org/#/c/684335/ if you want to blast that through too | |
| 15:44:02 | mriedem | dansmith: yeah it's the more than once i'm confused about, so grenade log digging i go | |
| 15:44:19 | dansmith | yeah | |
| 15:44:23 | sean-k-mooney | dansmith: i think devstack would restart it twice becasue it will try to install mysql for both new and old and then explcitly restart it | |
| 15:44:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | |
| 15:44:38 | mriedem | blasted | |
| 15:44:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | |
| 15:44:49 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339 | |
| 15:44:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | |
| 15:45:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | |
| 15:45:07 | dansmith | sean-k-mooney: well, that's why I was saying I wonder if we're upgrading packages, which would be one of those restarts.. but yeah, maybe it's all expected, I dunno | |
| 15:45:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | |
| 15:46:02 | sean-k-mooney | well devstack will do an apt-get update on each run and i think that will result in 2 mysql restart on on the old code and one on the new | |
| 15:46:20 | dansmith | sean-k-mooney: only if we actually changed the mysql package right? | |
| 15:46:24 | sean-k-mooney | i dont know of a reason to require a third restart but im looking | |
| 15:46:29 | dansmith | sean-k-mooney: if we're going from xenial to xenial it won't, I wouldn't think | |
| 15:46:34 | sean-k-mooney | dansmith: im not sure if it was conditional | |
| 15:47:45 | mriedem | i doubt the devstack code is conditional | |
| 15:47:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | |
| 15:47:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | |
| 15:47:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | |
| 15:47:52 | mriedem | devstack is pretty biased to just assume fresh install | |
| 15:48:11 | mriedem | so maybe a newer mysqld package triggers a restart on any update | |
| 15:48:11 | dansmith | mriedem: but we're not changing OS releases or pinning OS packages right? so the apt upgrade between grenade phases shouldn't change the packages for that right? | |
| 15:48:24 | mriedem | the version isn't changing | |
| 15:48:25 | sean-k-mooney | ya its not https://github.com/openstack/devstack/blob/master/lib/databases/mysql#L129 | |
| 15:48:26 | dansmith | a newer mysql package will definitely do a restart | |
| 15:48:42 | dansmith | I just expect no package change | |
| 15:48:54 | mriedem | devstack is just outright restarting as sean pointed out | |
| 15:49:17 | dansmith | oh I see | |
| 15:49:20 | dansmith | so that's one | |
| 15:49:20 | sean-k-mooney | to be fair it does also regenrate teh mysql config before it does that | |
| 15:49:38 | sean-k-mooney | so it need to do the restart to make sure that is applied | |
| 15:49:45 | dansmith | yeah | |
| 15:49:59 | dansmith | okay so you found 33% of them :D | |
| 15:50:30 | sean-k-mooney | well taht shoudl accound for 2 restart right | |
| 15:50:34 | sean-k-mooney | the old run and new run | |