| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-03 | |||
| 19:22:39 | sean-k-mooney | sorry yes i ment to say we do not | |
| 19:24:16 | dansmith | it doesn't really matter if the osp images are flat or not, I think we don't support it for overcloud | |
| 19:24:21 | sean-k-mooney | the lvm backed performs better the qcow2 for write intensive workloads which is why imt thinking of using it | |
| 19:24:27 | dansmith | we used to I think, but dropped it probably because lyarwood threatened to quit :) | |
| 19:24:33 | mriedem | dansmith: btw, unrelated to image caching, question for you on the prep resize patch at the bottom of the cross-cell series https://review.opendev.org/#/c/633293/ | |
| 19:24:34 | dansmith | sure | |
| 19:24:51 | mriedem | dansmith: while it's fresh in your head, earlier i had posted a diff of what it might look like to re-use the existing prep_resize | |
| 19:25:12 | mriedem | it's not terrible...but i'd need to freshen that diff up to see what it looks like now after the vpmem stuff changed how normal prep_resize works | |
| 19:25:25 | dansmith | mriedem: I though we discussed that in here | |
| 19:25:42 | gmann | mriedem: yeah, i was thinking to mock the get_all or multi cell function or something in DownCellFixture and not return the down cell instances. but did not check yet. | |
| 19:25:45 | mriedem | i think we did a bit before i wrote the code to see what the diff would actually look like | |
| 19:26:01 | dansmith | mriedem: I think I said I wish we could make them more the same, but I'm probably just being too idealistic, and then the numa LM came along with a similar requirement | |
| 19:26:04 | mriedem | gmann: tl;dr you're right and we'll return security groups and proxy to neutron even for down cell responses | |
| 19:26:28 | mriedem | gmann: that was hidden in functional tests b/c of the bad fixture | |
| 19:28:24 | mriedem | dansmith: ok for prep_resize (of the 5 compute resize related methods) it's not terrible to munge support into the existing thing if we want to do that, | |
| 19:28:48 | mriedem | but it's not really tenable for the others imo | |
| 19:29:23 | dansmith | mriedem: ack, well, do whatever you think is best for all of them and I won't complain again either way | |
| 19:29:34 | mriedem | the only worry i have is eventually having something like rebuild_instance where it's double duty based on conditional and is hairy as hell | |
| 19:29:41 | gmann | mriedem: you mean only in func tests ? GET /server/detail would not return any down cell instances and so does not include the sec grp right ? | |
| 19:29:51 | dansmith | yeah, that was the outcome of our original discussion I think | |
| 19:29:55 | mriedem | gmann: incorrect | |
| 19:30:21 | mriedem | gmann: with the down cell stuff, we return a partial set of information about an instance based on the api db | |
| 19:30:29 | mriedem | https://docs.openstack.org/api-guide/compute/down_cells.html | |
| 19:30:57 | gmann | yeah which is from show method. so true for GET /servers/<server-id> | |
| 19:31:14 | mriedem | the down cell func tests were not using a fixture that returned security groups properly | |
| 19:31:20 | mriedem | stephen's patch exposes that | |
| 19:31:36 | mriedem | anyway, as i said in https://review.opendev.org/#/c/685927/2/nova/tests/functional/test_servers.py@1264 i think it's just a matter of a docs fix for down cell | |
| 19:31:39 | mriedem | tssurya: ^ | |
| 19:32:19 | mriedem | gmann: fwiw it's also possible to test this stuff in devstack, here is a guide https://docs.openstack.org/nova/latest/contributor/testing/down-cell.html | |
| 19:32:49 | gmann | but Show never return sec grp so my point was inconsistent response between SHow and detail | |
| 19:33:09 | mriedem | ah yeah | |
| 19:33:11 | mriedem | fair point | |
| 19:33:23 | mriedem | well, changing that now would be a new microversion | |
| 19:33:47 | gmann | yeah, same i was thinking whether it is worth to fix or just doc update work fine. | |
| 19:33:58 | gmann | doc update works fine i think | |
| 19:34:02 | mriedem | fix it with a new microversion? i don't think it's worth it | |
| 19:34:07 | mriedem | agree | |
| 19:34:26 | mriedem | if you want to know security groups for a server in a down cell, you can get them from neutron directly | |
| 19:34:57 | gmann | true. | |
| 19:34:58 | efried | dansmith: Does the db migrationy thingy get backported? | |
| 19:35:07 | efried | ...is it for train or ussuri | |
| 19:35:10 | efried | I'm confused... | |
| 19:35:14 | mriedem | ussuri, | |
| 19:35:19 | mriedem | it's in case we backport a db migratoin to train | |
| 19:35:22 | dansmith | efried: it's for U | |
| 19:35:23 | dansmith | backporting it would defeat the purpose | |
| 19:35:26 | mriedem | rare, but it's happened | |
| 19:35:53 | efried | k, just confused by the stein one that was proposed in train and its message says stein. | |
| 19:36:11 | dansmith | proposed in train for stein backports | |
| 19:36:17 | dansmith | like this is proposed in u for train backports | |
| 19:36:30 | efried | rite. | |
| 19:36:36 | efried | thanks | |
| 19:42:20 | mriedem | gmann: 1846559 | |
| 19:42:23 | openstack | bug 1846559 in OpenStack Compute (nova) "Handling Down Cells in nova - security_groups can be in the response for GET /servers/detail" [Medium,Confirmed] https://launchpad.net/bugs/1846559 | |
| 19:42:23 | mriedem | oops, bug 1846559 | |
| 19:42:52 | gmann | thanks | |
| 19:43:46 | sean-k-mooney | if you use nova network instead of neutron you will get the security grous too | |
| 19:44:45 | openstackgerrit | Merged openstack/nova master: nova-net: Remove explicit 'USE_NEUTRON = True' https://review.opendev.org/685937 | |
| 19:44:53 | openstackgerrit | Merged openstack/nova master: docs: Document how to revert, confirm a cold migration https://review.opendev.org/664396 | |
| 19:45:00 | openstackgerrit | Merged openstack/nova master: docs: Update resize doc https://review.opendev.org/665412 | |
| 19:45:13 | mriedem | sean-k-mooney: no you wont | |
| 19:45:36 | sean-k-mooney | there is a delta in the beahviro for server show that stephenfin found | |
| 19:45:40 | mriedem | because in a down cell case, the security groups for nova net are in the cell db, which is down, so this is at best going to have None as a value https://github.com/openstack/nova/blob/867401e575d2b27b9bc63ceda41cd85233545cd5/nova/api/openstack/compute/views/servers.py#L607 | |
| 19:45:58 | mriedem | sean-k-mooney: you mean the thing that gmann and i were just talking about for 10 minutes above? | |
| 19:46:23 | sean-k-mooney | i need to scoll back but it was not related to down cells | |
| 19:46:56 | sean-k-mooney | aparent show will retrun the security group with nova networks | |
| 19:47:26 | sean-k-mooney | that is what stephenfin told me he found when remvoing the nova networks code | |
| 19:48:07 | mriedem | and it will with neutron too | |
| 19:48:19 | mriedem | if the instance isn't in a down cell | |
| 19:48:45 | gmann | sean-k-mooney: you mean this one - https://review.opendev.org/#/c/684335/2//COMMIT_MSG@10 | |
| 19:48:58 | gmann | that was missing in Fixture | |
| 19:49:04 | sean-k-mooney | oh no it was the neutron fixture https://review.opendev.org/#/c/685927/ | |
| 19:49:10 | gmann | yeah | |
| 19:49:18 | sean-k-mooney | ok never mind then | |
| 19:49:25 | mriedem | sean-k-mooney: and that's specifically because of the 2.69 down cell test | |
| 19:49:29 | mriedem | which is the wrinkle | |
| 19:50:09 | sean-k-mooney | ok so the fixture emulated the down cell behavior uncondtionally | |
| 19:51:15 | sean-k-mooney | ok im going to grab something to eat o/ back in a while | |
| 21:04:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | |
| 21:04:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333 | |
| 21:19:00 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Core Liaison' spec process https://review.opendev.org/685857 | |
| 21:19:19 | efried | dansmith, mriedem, gmann_afk, sean-k-mooney, stephenfin: etc etc ^ | |
| 21:24:20 | mriedem | make way | |
| 21:25:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to I4d181b44494f3b0b04537d5798537831c8fdf400 https://review.opendev.org/676231 | |
| 21:25:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to I30916d8d10d70ce25523fa4961007cedbdfe8ad7 https://review.opendev.org/676228 | |
| 21:25:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | |
| 21:25:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | |
| 21:25:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | |
| 21:25:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP for I66d8f06f19c5c631e33208580428aa843abb38d2 https://review.opendev.org/678951 | |
| 21:25:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | |
| 21:25:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | |
| 21:25:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | |
| 21:25:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | |
| 21:25:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | |
| 21:25:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | |
| 21:25:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | |
| 21:25:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | |
| 21:25:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | |
| 21:25:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | |
| 21:25:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | |