Earlier  
Posted Nick Remark
#openstack-nova - 2019-10-01
16:50:21 aspiers no but it is anyway
16:50:46 sean-k-mooney ya it is type https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L1859
16:50:46 aspiers which IMHO is a bad choice because type is kind of reserved, but whatever
16:51:05 sean-k-mooney well its self.type
16:51:21 sean-k-mooney type as a variable would alisa the type fucntion which would be bad
16:51:25 aspiers sure
16:51:38 sean-k-mooney in class scope its kindo fo ok
16:51:43 aspiers emacs Python mode is too stupid to realise the difference
16:52:32 sean-k-mooney ya i can see that messing with alot of regex based syntax highlighting
16:53:12 sean-k-mooney so ya the guest agent is defulting to a virtio channel
16:53:14 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L2135-L2152
16:54:13 aspiers sean-k-mooney: vvvvvvv
16:54:20 openstackgerrit Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers and video in libvirt https://review.opendev.org/684825
16:54:44 aspiers It may need another PS for virtio channels, waiting to see what Brijesh says
16:54:56 sean-k-mooney ya i would keep that seperate
16:55:09 aspiers OK
16:55:28 sean-k-mooney although you proably could jsut try enableing the qemu guest agent too and see if it works
16:55:37 aspiers how do I do that?
16:55:54 sean-k-mooney you need to install it in the guest image and set an image property let me get it
16:56:06 aspiers urgh
16:56:21 aspiers by install, do you mean at build-time not post launch?
16:56:45 sean-k-mooney you can do it post launch i think
16:57:01 sean-k-mooney you set hw_qemu_guest_agent=yes in the image metadata
16:57:23 sean-k-mooney that will be enough to triger the generation of the qemu channel
16:57:38 aspiers ok I'll try that thanks
16:57:47 sean-k-mooney then you should be able to ssh in and install it
16:57:48 aspiers I wonder what the package will be called
16:58:01 sean-k-mooney on suse i have no idea
16:58:08 aspiers what is it on RH?
16:58:09 sean-k-mooney proably qemu-somthing
16:58:13 aspiers haha no shit :)
16:58:18 sean-k-mooney i dont know
16:58:28 sean-k-mooney i have only ever installed it on ubunutu
16:58:54 sean-k-mooney yum install qemu-guest-agent
16:59:10 sean-k-mooney https://wiki.libvirt.org/page/Qemu_guest_agent
17:03:10 mnaser mriedem: did the cross-cell resizes end up finishing in train?
17:03:24 aspiers sean-k-mooney: it's the same on SUSE
17:03:27 mnaser looks like it just all still needs review and probably isnt landing in train, from what i see?
17:03:40 sean-k-mooney aspiers: its a pretty good name for it
17:03:54 aspiers sean-k-mooney: very catchy ;-)
17:04:25 sean-k-mooney aspiers: the main reason it exists is to provide a way to quiesce the diesk when doing an online snapshot
17:04:43 sean-k-mooney it has other uses too
17:04:58 aspiers sean-k-mooney: does it do more than just a sync? since stuff could still be writing
17:05:39 sean-k-mooney i think it does a flush then prevents any addtional wirtes untill the snapshot completes
17:05:55 aspiers ah ok
17:06:04 aspiers how does it prevent? some kernel voodoo?
17:06:22 sean-k-mooney aspiers: dansmith told me it was important to not currupt things and i took him at his word
17:07:31 sean-k-mooney i havent really looked in to how it does it but i assume its acting as a broker between qemu and the guest kernel block deice layer in some way
17:12:26 sean-k-mooney this covers part of it https://www.sebastien-han.fr/blog/2015/02/09/openstack-perform-consistent-snapshots-with-qemu-guest-agent/
17:13:38 openstackgerrit Merged openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506
17:15:16 mriedem mnaser: not done in train no
17:15:26 sean-k-mooney aspiers: apparently you have to write your own freeze hooks
17:15:26 mriedem mnaser: do you have multiple cells yet?
17:30:21 mnaser mriedem: nope not yet
17:33:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle get_host_availability_zone error during reschedule https://review.opendev.org/685997
17:33:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional regression test for migrate part of bug 1781286 https://review.opendev.org/686017
17:33:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807
17:33:50 openstack bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,In progress] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem)
17:33:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional regression test for build part of bug 1781286 https://review.opendev.org/685998
17:41:36 mriedem hemna: fyi that https://review.opendev.org/#/c/683008/ nor anything on stable/pike will pass tempest jobs until https://review.opendev.org/#/c/684769/ or an alternative fix is merged
17:46:07 mriedem melwitt: when you get a chance can you hit these stable/stein backports? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/stein+topic:bug/1843090
17:46:21 mriedem those are an upgrade regression in stein so i'd like to get those into the next point release
17:50:33 openstackgerrit Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181
17:52:11 efried mriedem, stephenfin, mordred: The response headers were indeed different, fixed ^
17:52:18 efried ready for your enthusiastic +2s now.
17:58:18 aspiers OK here's a really dumb question - why am I getting this after updating my devstack? Unknown column 'migrations.user_id' in 'field list
17:58:33 aspiers I did a db sync and restarted services
17:59:43 mriedem you likely didn't sync cell1
17:59:49 aspiers ah thanks
18:00:09 mriedem nova-manage db sync --config-file /etc/nova/nova.conf --config-file /etc/nova/nova-cond_cell1.conf
18:00:10 mriedem something like that
18:00:20 aspiers trying ...
18:00:26 mriedem former only syncs cell0, latter syncs cell1
18:05:07 aspiers mriedem: nova-manage --config-file /etc/nova/nova.conf --config-file /etc/nova/nova_cell1.conf db sync was the winning combo, thanks!
18:07:35 mriedem \o/
18:10:56 melwitt mriedem: sure
18:13:27 openstackgerrit Merged openstack/nova stable/train: make virtual pmem feature compatible with python3 https://review.opendev.org/685742
18:25:05 openstack Launchpad bug 1715374 in OpenStack Compute (nova) "Reloading compute with SIGHUP prevents instances from booting" [High,In progress] - Assigned to Ralf Haferkamp (rhafer)
18:25:05 sean-k-mooney efried: can i mark this as fix released https://bugs.launchpad.net/nova/+bug/1715374
18:25:35 sean-k-mooney it should be in rc1 right as of https://github.com/openstack/nova/commit/73f1fda7e93325d3ca2b2c62afb17fe011d650f3
18:26:30 efried sean-k-mooney: Yeah, that makes sense, please do.
18:29:51 sean-k-mooney cool im doing some downstream bug traige and linking them to the upstream ones
18:34:12 mnaser hmm
18:34:16 mnaser how nova-friendly is https://docs.openstack.org/releasenotes/zun/train.html#upgrade-notes ?
18:34:22 mnaser [compute]/host_shared_with_nova = true
18:35:44 mnaser so looks like its integrated with placement and gets the rp that nova uses and makes claims against it
18:35:51 sean-k-mooney i assume that is in the zun.conf
18:35:55 sean-k-mooney not the nova.conf
18:36:07 mnaser which i (thinking out loud) don't think that it can do bad things(tm)
18:36:14 mnaser because placement would just not return that compute host as a likely candidate at that point
18:36:42 sean-k-mooney am it depends
18:37:05 sean-k-mooney it could do bad things if you are using cpu pinning or hugepages
18:37:26 mnaser true, i guess its mostly focusing around ram and cpu claims (blindly)
18:38:01 sean-k-mooney well if they claim VCPU not PCUP then they woudl be required to enusre that the contaiern swapen on the cpu_shared_set
18:38:18 sean-k-mooney if they do not then thants a problemn
18:39:55 mnaser looks like its claiming VCPU
18:40:09 mnaser but i think it might not know to pin workloads
18:40:16 mnaser dont even think thats possible with docker
18:40:21 sean-k-mooney it is
18:40:27 sean-k-mooney you can pass a cpuset

Earlier   Later