Posted	Nick	Remark
#openstack-nova - 2019-10-01
10:51:28	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
10:51:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
10:51:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
10:51:30	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
10:51:30	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
10:56:23	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova stable/train: Imported Translations from Zanata https://review.opendev.org/685534
11:13:11	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326
11:13:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333
11:13:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332
11:13:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: tests: Correctly mock out security groups in NeutronFixture https://review.opendev.org/685927
11:13:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334
11:13:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
11:13:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335
11:13:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339
11:13:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
11:13:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
11:13:16	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
11:13:17	openstackgerrit	Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
11:13:17	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
11:13:18	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
11:13:18	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
11:13:19	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Remove explicit 'USE_NEUTRON = True' https://review.opendev.org/685937
11:25:54	lyarwood	stephenfin: https://github.com/lyarwood/nova/blob/a51921fe195ba6d8ccf60941b12c07ed304496da/nova/tests/functional/libvirt/base.py#L102-L105 - I don't understand what you're suggesting here
11:26:24	lyarwood	stephenfin: AssertionError: 16 not greater than 16 : Host.get_online_cpus is only accounting for 16 CPUs but you're requesting 16; change the mock or your test currently showing up in https://review.opendev.org/#/c/682621/2 as a result
11:27:39	lyarwood	stephenfin: https://review.opendev.org/#/c/682621/2/nova/tests/functional/regressions/test_bug_1843639.py@57 - should I be setting some additional things in the HostInfo I'm providing?
11:39:54	lyarwood	stephenfin: I don't see why this has to be greater
11:56:40	openstackgerrit	Lee Yarwood proposed openstack/nova master: DNM libvirt: extract _start_heterogeneous_computes https://review.opendev.org/682620
11:56:41	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622
11:56:41	openstack	bug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,In progress] https://launchpad.net/bugs/1843639 - Assigned to Lee Yarwood (lyarwood)
11:56:41	openstackgerrit	Lee Yarwood proposed openstack/nova master: Add regression test for bug #1843639 https://review.opendev.org/682621
12:13:33	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/685949
12:14:57	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/685950
12:34:08	stephenfin	lyarwood: That should be assertGreaterEqual
12:34:52	stephenfin	lyarwood: It exists because of this https://github.com/lyarwood/nova/blob/a51921fe195ba6d8ccf60941b12c07ed304496da/nova/tests/functional/libvirt/base.py#L67-L69
12:35:03	stephenfin	That's saying cores 0-15 (so 16 cores) are online
12:35:52	lyarwood	stephenfin: yeah understood, couldn't see why it was just greater tbh.
12:35:54	lyarwood	stephenfin: thanks
12:43:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339
12:43:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
12:43:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
12:43:08	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
12:43:09	openstackgerrit	Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
12:43:09	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
12:43:09	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
12:43:10	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
12:43:10	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
12:44:35	stephenfin	gibi: Could you push this through, please? https://review.opendev.org/#/c/662505/4
12:50:05	gibi	stephenfin: donstedone
12:50:25	stephenfin	:D
12:50:32	stephenfin	thanks
13:42:20	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133
13:42:27	stephenfin	bauzas: Can you review that today, pretty please? ^ It keeps going into merge conflict and I'm sick of it \o/
13:43:28	bauzas	stephenfin: I can try, rushing to provide a new patch for the audit command
13:43:48	stephenfin	bauzas: Nah, if you've something higher priority do that
13:46:10	bauzas	customers, customers, customers
13:52:27	mriedem	dansmith: for versioned objects tests, you know how we have a local and remote version with a mixin that usually holds the actual tests run by both? if the method being tested isn't remotable but is just some classmethod, is there any value in having it part of the mixin that gets run by the remote test since it's not remotable? seems like duplication for no gain.
13:52:40	mriedem	iow, is it fine to just put it in the local test version (not the mixin)?
13:52:49	dansmith	mriedem: correct
13:56:02	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807
14:01:44	bauzas	gibi: thanks for your comments on https://review.opendev.org/#/c/670112/5/nova/cmd/manage.py
14:02:10	bauzas	gibi: I see you tested on your devstack, cool
14:02:30	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807
14:02:47	bauzas	gibi: if you don't disagree, I'll make some modifications for your comments and try to see the cell-targeted issue
14:34:10	stephenfin	mriedem, lyarwood: Can one of you merge the stable/stein tox/gitreview patches for novaclient, please https://review.opendev.org/#/c/683626/ https://review.opendev.org/#/c/683625/
14:34:56	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Add 'Core Liaison' section to spec template https://review.opendev.org/685857
14:35:25	lyarwood	stephenfin: can do
14:35:56	lyarwood	stephenfin: done
14:36:08	stephenfin	thanks (y)
14:36:11	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/train: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685980
14:37:15	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/stein: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685981
14:38:13	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/rocky: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685983
14:39:10	mriedem	stephenfin: i have an itch saying we should have a release note for that if you're going to backport it
14:39:30	mriedem	it's proper hardening but also changes something from silently pass to outright fail
14:40:24	stephenfin	Yeah, good call. I can put one together for master now, but should I squash the release notes into the backport or keep them separate?
14:40:33	mriedem	i'm fine with squashing in the backports
14:40:38	stephenfin	ack
14:45:13	openstack	bug 1845322 in python-novaclient train "'--hint' argument to 'nova boot ' should be a key-value pair" [Low,In progress] https://launchpad.net/bugs/1845322 - Assigned to Stephen Finucane (stephenfinucane)
14:45:13	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient master: Add release note for bug 1845322 https://review.opendev.org/685986
14:48:43	gibi	bauzas: sure, go ahead
14:49:39	gibi	bauzas: if you push a new PS I can try to run that in my devstack with bandwidth
14:49:46	stephenfin	mriedem: 'upgrade' or 'fixes' reno? I've gone with the former but could go with the latter
14:54:45	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/train: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685980
14:55:30	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/stein: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685981
14:55:51	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/rocky: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685983
14:57:26	mriedem	stephenfin: i initially thought 'fixes' but could see 'upgrade' as well
14:57:45	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/685949
14:59:01	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/685950
14:59:02	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/train: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685980
14:59:32	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/stein: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685981
15:00:10	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient stable/rocky: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685983
15:25:59	openstackgerrit	Merged openstack/nova master: ec2: Move ec2utils functions to their callers https://review.opendev.org/662505
15:32:42	stephenfin	gibi: Since you looked at the functional change, care to send this reno on its way, please? https://review.opendev.org/685986
15:33:49	gibi	stephenfin: sure, looking
15:33:56	stephenfin	Thanks
15:34:36	artom	gibi, a couple of -1s on your spy stack, but they're really more for visibility/discussion
15:34:37	gibi	stephenfin: that was an easy one :)
15:35:09	stephenfin	gibi: hang on, pretty sure I've a 1kloc patch sitting around here somewhere ;)
15:35:27	gibi	artom: yeah, that is basically an experiment, so any discussion starter is warmly welcome. I will check back to that patch later
15:35:44	gibi	stephenfin: I'm sure you have one :)
15:35:54	stephenfin	I probably do :(

Earlier   Later