Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-10-01
10:20:10 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
10:20:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
10:20:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
10:20:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
10:20:13 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
10:20:13 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
10:20:14 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Correctly mock out security groups in NeutronFixture https://review.opendev.org/685927
10:20:14 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
10:21:51 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/685391
10:25:22 gibi stephenfin: do I understand the situation that the nova net base sample tests was not covered the sec group case and now that you add neutron based sample tests which has sec group you discovered a bug in the api behavior?
10:25:36 stephenfin that seems to be my understanding
10:25:43 stephenfin *that is my understanding :)
10:26:06 stephenfin gibi: Basically, I'm not sure if https://review.opendev.org/685927 is correct or not
10:26:23 stephenfin I mean, the addition of that field to two APIs
10:26:58 stephenfin I guess I will need to look at a real cloud with a down cell to see what actually comes back
10:27:07 stephenfin Or spend ages trying to trace stuff :(
10:28:59 gibi your fixture is coded with the assumption that neutron returns at least the default security group for every instance. If this assumption correct then what I think what you see in the test is the actual nova behavior
10:29:33 gibi if that leads to unexpecte API response then that is a bug
10:29:57 stephenfin Sort. I think it's more like I'm assuming an instance has at least one security group regardless of its state
10:30:41 gibi stephenfin: yeah your view is more precies you would need to validate that assumption first
10:30:58 gibi I think neutron behavior should not be cell dependent
10:31:06 stephenfin Yeah, neither do I
10:31:19 stephenfin I've no idea where to start on validating that assumption though so ima wait til sean-k-mooney or mriedem are about :)
10:31:25 gibi :)
10:34:09 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Remove 'adv-config', 'system-admin' subdocs https://review.opendev.org/684402
10:34:10 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Replacing underscores with dashes https://review.opendev.org/685929
10:34:57 gibi in devstack if I do nothing special I get the default sec group
10:35:15 stephenfin Yeah, that's what I was seeing too
10:36:33 stephenfin gibi: https://docs.openstack.org/nova/pike/admin/security-groups.html
10:36:41 stephenfin "All projects have a default security group which is applied to any instance that has no other defined security group. Unless you change the default, this security group denies all incoming traffic and allows only outgoing traffic to your instance."
10:37:33 gibi after I stop the n-cond-cell1 service in my devstack I still see the default sec group returned by nova
10:38:02 gibi stephenfin: based on that doc your assumption is valid
10:45:37 stephenfin gibi: Just discussed with slaweq on #openstack-neutron. While it's possible to create ports with no security, that's not the default and none of our tests are checking for that, so expecting the default security group seems sane
10:45:45 stephenfin Left comments on https://review.opendev.org/#/c/685927/ to that effect
10:46:26 stephenfin I think we still have a bug though, in as far as there are times where the security_groups key is omitted rather than being set to an empty list or null. I need to discuss with gmann or mriedem later
10:47:20 gibi OK, cool
10:51:27 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
10:51:27 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
10:51:28 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
10:51:28 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
10:51:29 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
10:51:29 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
10:51:30 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
10:51:30 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
10:56:23 openstackgerrit OpenStack Proposal Bot proposed openstack/nova stable/train: Imported Translations from Zanata https://review.opendev.org/685534
11:13:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326
11:13:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333
11:13:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332
11:13:13 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Correctly mock out security groups in NeutronFixture https://review.opendev.org/685927
11:13:13 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334
11:13:14 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
11:13:14 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335
11:13:15 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339
11:13:15 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
11:13:16 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
11:13:16 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
11:13:17 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
11:13:17 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
11:13:18 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
11:13:18 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
11:13:19 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove explicit 'USE_NEUTRON = True' https://review.opendev.org/685937
11:25:54 lyarwood stephenfin: https://github.com/lyarwood/nova/blob/a51921fe195ba6d8ccf60941b12c07ed304496da/nova/tests/functional/libvirt/base.py#L102-L105 - I don't understand what you're suggesting here
11:26:24 lyarwood stephenfin: AssertionError: 16 not greater than 16 : Host.get_online_cpus is only accounting for 16 CPUs but you're requesting 16; change the mock or your test currently showing up in https://review.opendev.org/#/c/682621/2 as a result
11:27:39 lyarwood stephenfin: https://review.opendev.org/#/c/682621/2/nova/tests/functional/regressions/test_bug_1843639.py@57 - should I be setting some additional things in the HostInfo I'm providing?
11:39:54 lyarwood stephenfin: I don't see why this has to be greater
11:56:40 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM libvirt: extract _start_heterogeneous_computes https://review.opendev.org/682620
11:56:41 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622
11:56:41 openstack bug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,In progress] https://launchpad.net/bugs/1843639 - Assigned to Lee Yarwood (lyarwood)
11:56:41 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1843639 https://review.opendev.org/682621
12:13:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/685949
12:14:57 openstackgerrit Balazs Gibizer proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/685950
12:34:08 stephenfin lyarwood: That should be assertGreaterEqual
12:34:52 stephenfin lyarwood: It exists because of this https://github.com/lyarwood/nova/blob/a51921fe195ba6d8ccf60941b12c07ed304496da/nova/tests/functional/libvirt/base.py#L67-L69
12:35:03 stephenfin That's saying cores 0-15 (so 16 cores) are online
12:35:52 lyarwood stephenfin: yeah understood, couldn't see why it was just greater tbh.
12:35:54 lyarwood stephenfin: thanks
12:43:07 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339
12:43:07 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
12:43:07 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
12:43:08 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
12:43:09 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
12:43:09 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
12:43:09 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
12:43:10 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
12:43:10 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
12:44:35 stephenfin gibi: Could you push this through, please? https://review.opendev.org/#/c/662505/4
12:50:05 gibi stephenfin: donstedone
12:50:25 stephenfin :D
12:50:32 stephenfin thanks
13:42:20 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133
13:42:27 stephenfin bauzas: Can you review that today, pretty please? ^ It keeps going into merge conflict and I'm sick of it \o/
13:43:28 bauzas stephenfin: I can try, rushing to provide a new patch for the audit command
13:43:48 stephenfin bauzas: Nah, if you've something higher priority do that
13:46:10 bauzas customers, customers, customers
13:52:27 mriedem dansmith: for versioned objects tests, you know how we have a local and remote version with a mixin that usually holds the actual tests run by both? if the method being tested isn't remotable but is just some classmethod, is there any value in having it part of the mixin that gets run by the remote test since it's not remotable? seems like duplication for no gain.
13:52:40 mriedem iow, is it fine to just put it in the local test version (not the mixin)?
13:52:49 dansmith mriedem: correct
13:56:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807
14:01:44 bauzas gibi: thanks for your comments on https://review.opendev.org/#/c/670112/5/nova/cmd/manage.py
14:02:10 bauzas gibi: I see you tested on your devstack, cool

Earlier   Later