Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-30
16:03:55 bauzas mriedem: you know what ? can't confirm a resize after stopping/deleting/restarting the original compute
16:04:19 mriedem that's not surprising
16:04:23 bauzas mriedem: after this, I'm stopping to do this, I'll just mock out the allocation delete
16:04:38 bauzas so it'll just leave the orphaned migration allocation
16:05:35 mriedem bauzas: i'm assuming the failure is the same as before? or something new because on restart of the source compute service, we've created a new compute node record with a new uuid and a new resource provider and we can't cleanup the migration-based allocations b/c we're looking for the wrong provider?
16:05:58 bauzas mriedem: a different exception
16:06:11 bauzas mriedem: a conflict because we want to recreate a new RP with the same name
16:06:12 mriedem do you have a paste?
16:06:25 bauzas sure, sec
16:06:39 mriedem nvm that's a known bug
16:07:07 openstack Launchpad bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)
16:07:07 mriedem https://bugs.launchpad.net/nova/+bug/1817833
16:07:11 mriedem called out in https://review.opendev.org/#/c/678100/
16:08:00 bauzas mriedem: http://paste.openstack.org/show/780370/
16:08:13 bauzas mriedem: anyway, like I said, I'll just mock out the allocation delete
16:08:30 bauzas so once we fix the bug, we won't need to modify the functional test
16:08:49 bauzas (or I'll just recreate the migration allocation)
16:09:06 bauzas in order to make sure the nova-manage audit command sees it and then deletes it if asked
16:10:46 openstack bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] https://launchpad.net/bugs/1817833 - Assigned to Matt Riedemann (mriedem)
16:10:46 mriedem i'd make sure to have a note explaining it's due to bug 1817833
16:10:51 mriedem if you're mocking things out in a functional test
16:11:40 bauzas mriedem: I'll write something and rushing to upload it, so you can provide comments
16:12:07 mriedem you're assuming i'm going to review that today...
16:12:24 mriedem but sure :)
16:12:53 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326
16:12:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334
16:12:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333
16:12:54 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332
16:12:55 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335
16:12:56 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337
16:12:56 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336
16:12:57 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341
16:12:57 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340
16:12:58 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343
16:12:58 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342
16:12:59 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
16:12:59 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
16:13:37 bauzas mriedem: nah, it's 6:13pm, my wife is looking at me angrily
16:13:45 bauzas mriedem: so I'll do this tomorrow morning
16:13:47 mriedem i understand
16:14:28 bauzas well, my wife understands more my upstream work than other folks :)
16:19:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
16:21:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Migrate old style volume attachments on nova-compute startup https://review.opendev.org/549130
16:21:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Extract some helper functions from DriverVolumeBlockDevice https://review.opendev.org/685752
16:24:11 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
16:24:12 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345
16:26:52 openstackgerrit Merged openstack/nova-specs master: Fix invalid link index https://review.opendev.org/685664
16:45:50 openstackgerrit Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/684825
16:47:44 openstackgerrit Adam Spiers proposed openstack/nova stable/train: Also enable iommu for virtio controllers in libvirt https://review.opendev.org/685756
17:05:40 efried aspiers: RC2? ^
17:06:07 efried not clear from the bug report what actually breaks
17:11:46 sean-k-mooney efried: im guessing it breaks sev guest when you set the disk bus to scsi and select virt-scsi as the model
17:14:08 efried sean-k-mooney: is that something that happens frequently?
17:14:13 sean-k-mooney yes
17:14:41 efried and by "breaks" -- the guest won't boot? or won't be SEV'd? or...?
17:14:52 sean-k-mooney hw_disk_mode=scsi and hw_scsi_model=virtio-scsi is the recommend mode for ceph
17:15:38 sean-k-mooney im not sure what aspiers is chaning is enabling the iommu integration so i would guest it unencyrped but i dont think tha tis allowd for sev guest so it might just not boot
17:17:00 aspiers efried: I think it probably causes a kernel panic
17:17:12 sean-k-mooney in the guest right
17:17:15 aspiers from the spec: "The iommu attribute is on for all virtio devices. Despite the name, this does not require the guest or host to have an IOMMU device, but merely enables the virtio flag which indicates that virtualized DMA should be used. This ties into the SEV code to handle memory encryption/decryption, and prevents IO buffers being shared between host and guest."
17:17:43 aspiers I've definitely seen kernel panics from incorrectly configured guests, I can't remember if I explicitly tested virtio-scsi without iommu
17:17:48 aspiers but it's required for sure
17:17:54 efried k, would be good to understand all of that to know whether this should be considered critical for RC2. It sounds like it probably is. <== dansmith mriedem
17:18:28 sean-k-mooney well you have to opt into enabling the scsi disk bus
17:18:30 efried aspiers: imo [unencrypted when encrypted was expected] would be worse than [kernel panic] (assuming the latter is only affecting the guest, not the whole host)
17:18:34 sean-k-mooney since that is not the default
17:18:43 aspiers sean-k-mooney: not if config drives or cdroms are used
17:18:52 sean-k-mooney but it would be very common to do so if you are using ceph
17:19:02 efried but either way it's a bug in a new feature and therefore RC potential IIUC
17:19:10 aspiers efried: [unencrypted when encrypted was expected] will not happen
17:19:10 sean-k-mooney aspiers: config drive should now defualt to sata
17:19:18 sean-k-mooney and it used to default to ide
17:19:21 efried well that's good anyway :)
17:19:36 aspiers efried: the <launchSecurity> element will be there regardless of any iommu stuff
17:22:47 dansmith efried: in a sec
17:23:12 dansmith mriedem: do you know if another db_sync --all-cells patch was floated somewhere? The one I was thinking of never merged and was abandoned silently in july
17:23:21 dansmith mriedem: https://review.opendev.org/#/c/519275/
17:23:30 dansmith not sure why, but that probably took it off anyone's radar
17:24:10 dansmith or hmm, maybe we made it hit all cells by default... gosh, all this fell out of my head
17:25:19 dansmith ah, no --local-cell is just skipping cell0, so it still doesn't fan like I thought
17:29:30 dansmith efried: probably depends on what the fix looks like and what impacts it might have, and what the impact of not having it is (like you say expecting safe, but not safe)
17:30:55 sean-k-mooney thats the main part of the fix https://review.opendev.org/#/c/684825/4/nova/virt/libvirt/designer.py
17:33:37 sean-k-mooney aspiers: by the way the only think that stikes me about the fix is that we are testing with a fake xml we cannot generate
17:33:38 mriedem dansmith: i don't remember another, though i thought i had reported a bug at some point about making db sync support all cells but i might just be thinking of the archive command
17:34:05 sean-k-mooney e.g. its not posibel to have two scsi contolers with a different model based on how nova generates the xml
17:34:06 dansmith mriedem: yeah, so code in tree does not fan out (except to cell0) and that other patch got abandoned in July for some reason
17:34:16 sean-k-mooney that said it is vaild in libvirt to do that
17:34:19 mriedem i also remember bringing it up at some summit, i.e. should the nova-manage commands hit all cells? and it was a low priority response - that might have been sydney...
17:34:36 mriedem dansmith: my guess is they abandoned it b/c it sat since july with no replies
17:34:47 dansmith could be
17:34:59 mriedem lincanwei is still around though, he's the watcher ptl
17:39:20 dansmith oh, nm, this was abandoned in Jan, last patch was in july 2018, I see
17:39:27 dansmith hmm, I thought there was a more recent attempt at this t hen
17:40:32 mriedem i see a duplicate of the archive all-cells patch
17:40:56 mriedem https://review.opendev.org/#/c/599050/ ?
17:41:08 mriedem oh no that's different
17:41:13 dansmith no
17:41:14 dansmith yeah
17:41:22 dansmith anyway, not a big deal
17:41:51 gmann mriedem: dansmith : seems like sec groups are added for down cell response for detail GET API case only (it is not included in Show API case)

Earlier   Later