| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-19 | |||
| 01:44:07 | openstackgerrit | Fan Zhang proposed openstack/nova master: Fix exception translation when creating volume https://review.opendev.org/678991 | |
| 01:51:48 | KeithMnemonic1 | melwitt quick question, if some of those conflicts are from other patches that cherry pick clean to pike, is the the proper process? | |
| 01:52:41 | KeithMnemonic1 | isnt it better to pull in cleanly any dependencies instead of me trying to shove some stuff in his review? | |
| 01:53:41 | KeithMnemonic1 | and then rebase that patch once they are merged? | |
| 01:54:09 | melwitt | KeithMnemonic1: we don't pull in dependencies that are unrelated to the backport, it can get pretty unwieldy that way. by resolving the conflict you're just making the patch fit within the env of the older release, which shouldn't result in adding a bunch of stuff | |
| 01:54:57 | melwitt | from what I saw when I glanced, the conflicts didn't look too big and mriedem documented all of them in the commit message already. just need to be smoothed out in the .py files | |
| 02:29:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Move Destination object tests to their own test class https://review.opendev.org/683017 | |
| 03:21:28 | openstackgerrit | Merged openstack/nova master: Temporarily skip TestNovaMigrationsMySQL https://review.opendev.org/683009 | |
| 03:21:36 | openstackgerrit | Merged openstack/nova stable/stein: Fix race in _test_live_migration_force_complete https://review.opendev.org/681744 | |
| 03:21:45 | openstackgerrit | Merged openstack/nova stable/stein: Fix a misuse of assertGreaterEqual https://review.opendev.org/682168 | |
| 05:45:09 | openstackgerrit | garyk proposed openstack/nova master: Deconstruct the mother of all locks https://review.opendev.org/682242 | |
| 06:45:45 | openstackgerrit | hulina proposed openstack/nova master: Nova raise exceptions when extending volume fails https://review.opendev.org/680648 | |
| 07:41:56 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043 | |
| 07:42:17 | gibi | sean-k-mooney: thanks for the work on https://review.opendev.org/#/c/669738/ I +Ad it | |
| 07:47:42 | bauzas | gibi: sean-k-mooney: I just left some comments (and I concurrently +Wd, my bad) that honestly I feel we could have defined this test module as a plain top-level function testsuite for configdrivers | |
| 07:47:48 | bauzas | configdrives* | |
| 07:49:03 | gibi | bauzas: ack. I think the reorg for a top level test module can be done separately | |
| 07:49:13 | bauzas | gibi: oh yeah totally | |
| 07:49:24 | gibi | bauzas: and I'm supportive :) | |
| 07:49:26 | bauzas | gibi: just saying this regression testclass is way more than a single check :) | |
| 07:49:34 | gibi | yeah | |
| 07:51:33 | gibi | bauzas: here is a nova-manage heal allocation test addition if you have some review time https://review.opendev.org/#/c/669879/11 | |
| 07:56:57 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | |
| 07:56:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pull up compute node queries to init_host https://review.opendev.org/682680 | |
| 07:57:39 | openstackgerrit | hulina proposed openstack/nova master: Nova raise exceptions when extending volume fails https://review.opendev.org/680648 | |
| 08:05:55 | kashyap | mnaser: Hi, reading the scroll. | |
| 08:16:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix unit of hw_rng:rate_period https://review.opendev.org/683051 | |
| 08:16:56 | kashyap | mnaser: There's a lot scrollback; let's discuss today when you're around. :-) | |
| 08:22:46 | bauzas | gibi: congrats for your visa, I got mine too yesterday by postal service | |
| 08:22:58 | gibi | bauzas: congrats for you too then | |
| 08:23:00 | bauzas | (and I understand why they asked me my passport) | |
| 08:24:53 | bauzas | I have a powerful passport, it was the first time I asked for this but I was a bit afraid my visa application could be not supported because I had some coffee stains | |
| 08:25:03 | bauzas | (on my passport) | |
| 08:25:57 | kashyap | mnaser: But a couple of things to get out of the way: | |
| 08:26:15 | kashyap | mnaser: * When you use 'host-model', you won't actually see 'host-model' in the *live* guest XML; libvirt expands it (see next point) | |
| 08:26:26 | kashyap | mnaser: * To refresh your memory, 'host-model' means: (a) get maximum possible CPU features from the host; (b) make the guest live-migratable; and (c) auto-add critical CPU flags -- provided you have the right underlying bits for microcode, kernel, etc. | |
| 08:26:50 | kashyap | mnaser: * The "IvyBridge-IBRS" model does *not* contain 'vmx'; you have to explicitly add it. (You can `grep` the 'cpu_map.xml'; or if you're running new enough libvirt `grep vmx /usr/share/libvirt/cpu_map/x86_IvyBridge-IBRS.xml`) | |
| 08:30:33 | kashyap | mnaser: And lastly, since you're in the nested setup: make sure that your level-1 guest explicitly has 'vmx' flag set, even if you're using 'host-model'. | |
| 09:01:20 | bauzas | grraaah, got swamped by internal escalation | |
| 09:04:37 | openstackgerrit | Arthur Dayne proposed openstack/nova master: Fix block disk attachment failure https://review.opendev.org/682772 | |
| 09:31:35 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/621646 | |
| 10:22:22 | openstackgerrit | Luyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests https://review.opendev.org/680300 | |
| 11:07:44 | sean-k-mooney | bauzas: ya i coudl do that. i am only testing the regression cases so i would have to add more test that are not based on the conf option to make it a propper config-drive test suite | |
| 11:09:11 | sean-k-mooney | bauzas: i originaly had the tests in the test_server.py module and mriedem suggested making it a regression so i coudl avoid the old legacy code and use teh integrated helpers but since then i have added alot more tests | |
| 11:11:03 | sean-k-mooney | bauzas: so ya it definetrly worth considering factoring it into its own module and addign the remiaing tests to validate other config drive behavior e.g. passing the flage to server create and i think there is an image property you can set. so if i added 2 or 3 more tests it would fully cover the behavior | |
| 11:21:12 | mnaser | kashyap: yeah it seems we've pretty much came to the same conclusion with sean-k-mooney regarding vmx yesterday. I appreciate you actually validating our theories | |
| 11:21:25 | mnaser | Knowing libvirt expands it is good to knwo | |
| 11:21:36 | kashyap | mnaser: Yes, that's something the casual user might miss: | |
| 11:21:47 | kashyap | mnaser: "I specified 'host-model' on guest boot, why don't I see it in live?" | |
| 11:21:55 | sean-k-mooney | might miss. consider a bug... | |
| 11:21:58 | kashyap | mnaser: ... not realizing that libvirt expands it at run-time | |
| 11:22:22 | sean-k-mooney | that said i know why it does it | |
| 11:22:29 | kashyap | sean-k-mooney: Guess I broke your long sentence, sorry | |
| 11:22:48 | sean-k-mooney | not really | |
| 11:22:56 | kashyap | Ah! | |
| 11:23:09 | kashyap | You actually were commemting at my remark. (I already forgot I said "might miss") | |
| 11:23:14 | sean-k-mooney | i was just making the point that while i know why it expands it some might consier some of the expantion a bug | |
| 11:23:15 | kashyap | sean-k-mooney: Why bug? | |
| 11:23:25 | kashyap | sean-k-mooney: Ah, yeah, I see what you mean, though | |
| 11:23:31 | sean-k-mooney | because in this case its not additive | |
| 11:23:36 | kashyap | sean-k-mooney: It needs to documented clearly. | |
| 11:23:46 | kashyap | But I agree with what you imply | |
| 11:23:53 | sean-k-mooney | it replace the requested model with what was equvalent on that host | |
| 11:24:04 | kashyap | Yes | |
| 11:24:12 | sean-k-mooney | it would be require to do the current expantion if it move the vm to another host | |
| 11:24:34 | kashyap | I can't parse your second q. | |
| 11:24:47 | kashyap | s/q./comment/ | |
| 11:25:07 | sean-k-mooney | if you were to live migrate it could not rely on the models being the same | |
| 11:25:28 | sean-k-mooney | it can check but it simpler to expand the flags for a migration | |
| 11:25:46 | sean-k-mooney | so rather then specail case that they made it the default behavior | |
| 11:26:32 | sean-k-mooney | fortunetly however you added the extra_flags config | |
| 11:26:34 | kashyap | sean-k-mooney: Ah, yes; thanks for expanding your comment | |
| 11:26:54 | sean-k-mooney | so you can just add vmx or whatever you thing is missing | |
| 11:26:55 | kashyap | Yeah. sean-k-mooney -- But I haven't had the chance to thoroughly test the multiple CPU models thing we merged | |
| 11:27:03 | kashyap | Yeah | |
| 11:27:12 | sean-k-mooney | well mnaser is still on stien | |
| 11:27:22 | sean-k-mooney | at least until train is actully released | |
| 11:27:54 | sean-k-mooney | mnaser: im expecting to hear vexxhost is fully in production with train in about a week or two right :P | |
| 11:32:11 | kashyap | sean-k-mooney: If you addressed to me something after "at least until train ..." please re-post; I got dropped briefly | |
| 11:32:44 | kashyap | I just said that I realize mnaser is on Stein; but I was just talking from the POV of functional testing in Train | |
| 11:33:24 | sean-k-mooney | kashyap: no i was just admireing/makeing fun of the fact that vexxhost/osa has good ci/cd and unlike most operators actully runs a recent openstack release | |
| 11:33:46 | kashyap | Ah, nod :-) | |
| 11:33:49 | openstackgerrit | Merged openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | |
| 11:34:10 | mnaser | Train on release day would be cool, we're seeing.. | |
| 11:35:40 | sean-k-mooney | osa at least in the passed did not aim to have upgrade support day 1 corret. so that will be one of the requirements pre upgrading | |
| 11:36:15 | sean-k-mooney | although you mentioned in teh project in denver that ye were tyring to get upgrade testing in the gate to run on each patch | |
| 11:36:22 | sean-k-mooney | so maybe that has changed? | |
| 11:37:24 | mnaser | We have upgrade jobs now that upgrade from Stein to master | |
| 11:37:43 | mnaser | Which afaik included placement reshuffle | |
| 11:39:02 | openstackgerrit | Merged openstack/nova master: objects: Add 'InstanceNUMATopology.cpu_pinning' property https://review.opendev.org/680106 | |
| 11:39:44 | sean-k-mooney | mnaser: cool i hope the placement work is finished in tripleo by now | |
| 12:05:15 | bauzas | mmm, super weirdo : http://paste.openstack.org/show/777697/ | |
| 12:05:29 | bauzas | but https://docs.openstack.org/api-ref/compute/?expanded=evacuate-server-evacuate-action-detail,update-forced-down-detail#update-forced-down tells me it's right | |
| 12:05:46 | bauzas | gibi: any ideas ? ^ | |
| 12:05:53 | bauzas | or sean-k-mooney: ^ | |
| 12:06:53 | bauzas | 'host' and 'binary' are correct arguments for force-down (at least for 2.77 microversion) | |
| 12:07:30 | bauzas | I don't see why I'm getting a HTTP400 | |
| 12:08:07 | gibi | looking | |
| 12:08:32 | bauzas | thanks | |
| 12:08:58 | gibi | Starting with microversion 2.53 this API is superseded by PUT /os-services/{service_id}. | |