| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-18 | |||
| 14:48:06 | efried | sean-k-mooney, mriedem: merging https://review.opendev.org/#/c/669738/ (config drive fix) | |
| 14:49:19 | mriedem | lyarwood: yup thanks | |
| 14:49:44 | sean-k-mooney | efried: cool, im not sure if mdbooth replied but i dont think the follow up patch is needed so we might want to abandon it? i did not rebase it because i dont know what value it adds. | |
| 14:50:18 | efried | oh, that one's been around for a whiiile. | |
| 14:50:24 | efried | I haven't looked at it recently. | |
| 14:50:43 | mriedem | with the size and breadth of that change the commit message would need a hell of a lot more detail | |
| 15:01:17 | melwitt | dansmith: guh, yeah I had intended to but it keeps getting left on the backburner | |
| 15:01:30 | dansmith | melwitt: okay, seems worth finishing | |
| 15:01:49 | melwitt | yeah, agreed :( | |
| 15:02:01 | melwitt | if anyone else wants to update it, of course feel free too | |
| 15:02:09 | melwitt | I'll try to do it after my calls today | |
| 15:04:24 | gibi | sean-k-mooney: I think I found possible race in the test in https://review.opendev.org/#/c/669738/ | |
| 15:07:11 | sean-k-mooney | i think the state does change but ill check | |
| 15:07:22 | sean-k-mooney | maybe its the task sate | |
| 15:07:47 | gibi | sean-k-mooney: task_state changes but I think the status doesn't | |
| 15:08:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pull up compute node queries to init_host https://review.opendev.org/682680 | |
| 15:08:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | |
| 15:08:37 | gibi | sean-k-mooney: even if status changes during the reboot if it start from ACTIVE and ends in ACTIVE then you cannot be sure why the wait returned | |
| 15:08:44 | sean-k-mooney | looking at https://docs.openstack.org/nova/latest/reference/vm-states.html you seam to be correct | |
| 15:09:18 | gibi | mriedem: fixed your comments in https://review.opendev.org/#/c/666857 | |
| 15:10:32 | sean-k-mooney | gibi: efried so we should stop https://review.opendev.org/#/c/669738/7 merging and i should fix that | |
| 15:10:48 | gibi | sean-k-mooney: a rebase would pull it out from the gate | |
| 15:11:10 | sean-k-mooney | i just set workflow -1 will that work? | |
| 15:11:33 | sean-k-mooney | i just removed erric +w | |
| 15:11:35 | gibi | I don't know what is stronger the W+ or the W- | |
| 15:11:46 | gibi | sean-k-mooney: ohh you can do that? | |
| 15:11:53 | sean-k-mooney | if you are the patch owner | |
| 15:11:58 | sean-k-mooney | or a core | |
| 15:12:00 | efried | whoah | |
| 15:12:02 | efried | I didn't know that | |
| 15:12:24 | sean-k-mooney | ya we block remove -* i think | |
| 15:12:28 | efried | anyway, that's not going to pull it out of the check queue, which is where it's sitting right now. But it should prevent it going into the gate. | |
| 15:12:36 | efried | if it was already in the gate you would have to rebase to pull it. | |
| 15:12:42 | bauzas | mriedem: I'm pretty done with my audit command (just needing to work on unittests) but I'd like to provide a functional test about some migration error | |
| 15:12:59 | efried | If you care to save on gate resources you could rebase to pull it out of check | |
| 15:13:05 | bauzas | mriedem: just to make it clear, there are cases where the migration goes into ERROR and then we have orphaned allocations, right? | |
| 15:13:06 | efried | if the patch itself needs changes. | |
| 15:13:22 | sean-k-mooney | efried: taht will kick off new jobs | |
| 15:13:32 | efried | yes, but at the back of the queue :) | |
| 15:13:32 | sean-k-mooney | ill just try to fix it before it starts running | |
| 15:13:33 | bauzas | mriedem: I'd like to mimic some behaviour | |
| 15:13:41 | sean-k-mooney | ok | |
| 15:13:44 | sean-k-mooney | ill do that | |
| 15:13:46 | efried | I think actually you might be able to pull it completely by abandoning and restoring | |
| 15:14:00 | efried | um, restore might start it again | |
| 15:14:11 | efried | so you could abandon until you're ready to push new ps | |
| 15:16:46 | kashyap | sfinucan: Before the GA, this should go in, yeah? The typo-that-matters in driver.py: https://review.opendev.org/#/c/682267/3/nova/virt/libvirt/driver.py | |
| 15:17:08 | mriedem | gibi: sean-k-mooney: commenting on sean's patch | |
| 15:19:08 | mriedem | commented | |
| 15:19:11 | mriedem | seems the only issue is reboot | |
| 15:19:57 | mriedem | sorry i was looking at unshelve | |
| 15:21:33 | openstackgerrit | Shilpa Devharakar proposed openstack/nova-specs master: Update spec: filtering of alloc candidates by forbidden aggregates https://review.opendev.org/675384 | |
| 15:21:35 | mriedem | i think in either case waiting for task_state to be None is sufficient, but waiting on notifications also works | |
| 15:22:28 | gibi | mriedem: replied | |
| 15:26:03 | mriedem | bauzas: for that audit command i would have started with functional tests months ago | |
| 15:26:09 | mriedem | unit tests don't mean much for stuff like this | |
| 15:26:20 | mriedem | in fact, i don't like unit tests really for any of these types of operational commands | |
| 15:26:22 | bauzas | mriedem: I can send you a new revision now, FWIW | |
| 15:26:36 | bauzas | mriedem: but I just wonder what to test from a migration usecase | |
| 15:26:54 | bauzas | but I think I'll just mock a failing migration that leaves an allocation record | |
| 15:26:57 | mriedem | there are notes about migration in the bug report aren't there? | |
| 15:27:18 | bauzas | correct, there are examples where we found orphaned allocations | |
| 15:27:23 | mriedem | i don't think mocking is really good here, i'm pretty sure we have known ways to hit stuff like that, with evacuate | |
| 15:28:02 | mriedem | https://review.opendev.org/#/c/678100/ has a couple of related bugs where we orphan allocations/providers | |
| 15:28:06 | bauzas | what I basically do is to compare whether I can find an active migration against an existing allocation | |
| 15:28:22 | bauzas | will look at the change ^ | |
| 15:28:38 | bauzas | and you know what ? I'll release the change now so people can voice against it | |
| 15:29:07 | mriedem | kashyap: i've tagged the bug with train-rc-potential | |
| 15:29:30 | kashyap | mriedem: Ah, thank you. Didn't think of it | |
| 15:29:53 | kashyap | IIRC, stephenfin wanted to hold off on it until the 'cpu-resources' merges | |
| 15:30:10 | mriedem | so like the day of RC1 | |
| 15:30:12 | mriedem | got it | |
| 15:30:13 | kashyap | (Due to conflicts, etc.) | |
| 15:30:38 | kashyap | mriedem: :D I mentioned it exactly for that -- in case it doesn't merge, that typo shouldn't fall through the cracks | |
| 15:30:49 | kashyap | (And you've helpfully fixed it, by the tag) | |
| 15:30:55 | mriedem | i sure hope everyone rechecking the vpmem and pcpu series is actually looking at every failure to make sure we're not recheck grinding in some regression | |
| 15:31:33 | stephenfin | I am. We're seeing mirror issues, InnoDB issues, and something with devstack_gate and null bytes | |
| 15:31:38 | mriedem | kashyap: i don't see you or aspiers as +1 on that bug fix | |
| 15:31:40 | stephenfin | None of which I know how to fix :( | |
| 15:32:00 | kashyap | mriedem: Damn, I have it sit in a tab, let me do that | |
| 15:36:15 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a placement audit command https://review.opendev.org/670112 | |
| 15:41:29 | shilpasd | dansmith: i have addressed your minor nit isolated aggregate spec on https://review.opendev.org/#/c/675384/ | |
| 15:44:44 | mriedem | i guess that wasn't related to aspiers so ignore the ping | |
| 15:47:22 | dansmith | shilpasd: you only changed it in that one place | |
| 15:47:36 | dansmith | shilpasd: it should be changed elsewhere too, except maybe in work items.. | |
| 15:47:49 | shilpasd | dansmith: okay, will do that | |
| 15:53:27 | mloza | Hello, I'm getting tons of 'Unexpected exception in API method: MigrationNotFound:' in nova-api. Here is the full log http://paste.openstack.org/show/777427/ | |
| 15:54:35 | mloza | I don't see pending migrations in `nova migration-list` | |
| 15:54:59 | mloza | I'm using stable/stein branch | |
| 15:55:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: Get the CPU model, not 'arch' from get_capabilities() https://review.opendev.org/682267 | |
| 15:58:24 | openstackgerrit | sean mooney proposed openstack/nova master: make config drives sticky bug 1835822 https://review.opendev.org/669738 | |
| 15:58:25 | openstack | bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to Matt Riedemann (mriedem) | |
| 15:58:36 | sean-k-mooney | rebase to kick it down the queue | |
| 15:58:39 | kashyap | mriedem: Thanks for updating | |
| 16:00:19 | openstackgerrit | Merged openstack/nova master: Remove an unused file and a related description https://review.opendev.org/681955 | |
| 16:01:59 | openstackgerrit | Shilpa Devharakar proposed openstack/nova-specs master: Update spec: filtering of alloc candidates by forbidden aggregates https://review.opendev.org/675384 | |
| 16:02:09 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add func test for 'required' PCI NUMA policy https://review.opendev.org/682941 | |
| 16:02:45 | artom | sean-k-mooney, stephenfin ^^ Dunno if it's that useful given that we test the 'legacy' policy which essentially does the same, but since I noticed it was missing while doing downstream reviews... | |
| 16:03:24 | sean-k-mooney | the legacy policy works differently if you have no device numa info on the host | |
| 16:03:44 | mriedem | artom: is that from you investigating that numa live migration testing thread in the ML? | |