| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-18 | |||
| 12:35:29 | openstackgerrit | sean mooney proposed openstack/nova master: conf: Deprecate 'devname' field of '[pci] passthrough_whitelist' https://review.opendev.org/670585 | |
| 12:45:45 | efried | ++ thanks aspiers! | |
| 12:47:32 | efried | stephenfin, alex_xu: thanks for splitting out the series. In retrospect (hindsight 20/20 and all that) we should have done it long ago, but I didn't want to lose all the +Vs we already had up the series since the gate was so slow. | |
| 12:48:28 | openstackgerrit | Tao Yang proposed openstack/nova master: Add missing parameter https://review.opendev.org/682886 | |
| 12:56:15 | openstackgerrit | sean mooney proposed openstack/nova master: make config drives sticky bug 1835822 https://review.opendev.org/669738 | |
| 12:56:16 | openstack | bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney) | |
| 12:59:26 | mriedem | dansmith: if you're looking for an easy way to get back into things and be productive we need stable reviews https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/stein | |
| 13:06:37 | shilpasd | dansmith: hi, want your review on spec for isolate aggregate https://review.opendev.org/#/c/675384/ | |
| 13:11:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: make config drives sticky bug 1835822 https://review.opendev.org/669738 | |
| 13:11:43 | openstack | bug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney) | |
| 13:12:31 | mriedem | need another core on https://review.opendev.org/#/c/669738/ since it fixes a regression introduced in train | |
| 13:14:12 | sean-k-mooney | mriedem: thanks i though the api comment was for the flavor no the images i would have used the api otherwise | |
| 13:14:43 | sean-k-mooney | and ya i forgot to chagne the vm name | |
| 13:15:49 | sean-k-mooney | mdbooth: do we actully need the followup patch https://review.opendev.org/#/c/485930/10 i dont think we do as the orginal bug is actully already fixed but i think you wanted to refactor how this was done in general | |
| 13:16:40 | sean-k-mooney | i.e. once https://review.opendev.org/#/c/669738/ is merged i think we can just abandon the follow up patch unless we just want to do it for refactoring reasons | |
| 13:19:39 | sean-k-mooney | bauzas: gibi if ye are around care to review https://review.opendev.org/#/c/669738/ | |
| 13:33:47 | dansmith | mriedem: cool, thanks.. I love being spoon fed | |
| 13:33:53 | dansmith | shilpasd: ack | |
| 13:34:14 | efried | dansmith: you got that one, then? I can stop reading? | |
| 13:34:18 | mriedem | dansmith: i'll burp and change your dipee for $2 | |
| 13:34:25 | mriedem | *dipey? | |
| 13:34:32 | efried | I'm gonna go with dipey. | |
| 13:34:49 | dansmith | efried: what one? You're already +2 on the spec revision | |
| 13:35:41 | efried | dansmith: The config drive regression | |
| 13:36:04 | dansmith | efried: I was responding to mriedem asking me to hit the stable queue | |
| 13:37:38 | efried | okay, I was referring to 8:12:31 AM - mriedem: need another core on https://review.opendev.org/#/c/669738/ since it fixes a regression introduced in train | |
| 13:37:42 | efried | I'll keep reading | |
| 13:40:00 | dansmith | so, it looks like some of the stuff we +Wd before FF still haven't merged.. ISTR efried saying we'd reassess if things haven't merged by monday, and now it's wednesday | |
| 13:40:07 | dansmith | assume we're backing off from the recheck grind? | |
| 13:40:32 | efried | no, I hadn't planned to. | |
| 13:40:44 | bauzas | I think it's okay | |
| 13:40:53 | bauzas | at least until next Thursday... :D | |
| 13:40:59 | dansmith | how close to freeze are we going to keep doing that? | |
| 13:41:23 | efried | Ask me again on Monday | |
| 13:52:17 | mriedem | gibi: need to deal with some ironic-isms in https://review.opendev.org/#/c/666857/ | |
| 13:52:26 | gibi | mriedem: ack, looking | |
| 13:52:28 | mriedem | gibi: also noted that we'll get a warning on every comptue fresh start up | |
| 13:53:52 | gibi | mriedem: is it OK to start up the nova-compute with ironic setup if the ironic-api is not available? | |
| 13:54:51 | mriedem | gibi: that's what we've always had since ironic in devstack is a plugin and comes after nova | |
| 13:55:03 | mriedem | but i think in general it's good for the nova code to be resilient to when the hypervisor isn't available, | |
| 13:55:13 | gibi | mriedem: I see. Then I will log on that error but otherwise ignore it | |
| 13:55:16 | mriedem | e.g. in the libvirt driver case it auto-disables the service record so you can't schedule to that node | |
| 13:55:41 | mriedem | gibi: yeah i think log and return from the method is what i'd expect | |
| 13:55:49 | gibi | mriedem: ok | |
| 14:03:28 | shilpasd | dansmith: thanks for ack | |
| 14:06:58 | efried | "There is no script for 398 version" <== I thought this means I need to rebuild my testenv, but that didn't fix it. | |
| 14:08:58 | dansmith | efried: clean your directory of pyc files | |
| 14:09:04 | efried | thanks dansmith | |
| 14:33:01 | dansmith | melwitt: were you going to update this? https://review.opendev.org/#/c/662095 | |
| 14:33:25 | mriedem | alex_xu: is anyone working on renaming "Intel_Zuul" so it shows up as 3rd party CI? | |
| 14:33:38 | mriedem | i.e. comments in patches will be hidden by default | |
| 14:36:28 | sean-k-mooney | https://docs.openstack.org/infra/system-config/third_party.html#creating-a-service-account covers how to configure it but they jsut need to chage teh account full name to have CI in it | |
| 14:38:59 | efried | dtroyer: ^^ Would you be able to (poke someone to) make a PR to make that adjustment? | |
| 14:39:29 | sean-k-mooney | its why everyone ignores my "Sean Mooney CI" account | |
| 14:39:50 | efried | I never know which one to use when adding you to a change. Is your RH email the right one? | |
| 14:40:14 | sean-k-mooney | use the non ci one | |
| 14:40:19 | sean-k-mooney | but yes the redhat one | |
| 14:41:21 | sean-k-mooney | the ci one was for testing ci jobs locally when i was planning to run my own thridparty ci | |
| 14:42:51 | sean-k-mooney | i might someday set that up again but it was burning like 100-200 euro a month in power someing like that anyway | |
| 14:43:06 | mriedem | lyarwood: can we drop these backports? https://review.opendev.org/#/q/I15a7c13edf78884ec223fd531a78a341106b41b8+status:open | |
| 14:43:14 | mriedem | we have no recreate and it's a very latent thing | |
| 14:44:07 | dtroyer | efried: will do | |
| 14:44:13 | efried | thank you dtroyer | |
| 14:45:08 | lyarwood | mriedem: ack sure | |
| 14:46:55 | lyarwood | mriedem: I'll do the same for https://review.opendev.org/#/q/topic:bug/1834048+(status:open+OR+status:merged) - iirc the downstream reporter never got back to us about this. | |
| 14:48:06 | efried | sean-k-mooney, mriedem: merging https://review.opendev.org/#/c/669738/ (config drive fix) | |
| 14:49:19 | mriedem | lyarwood: yup thanks | |
| 14:49:44 | sean-k-mooney | efried: cool, im not sure if mdbooth replied but i dont think the follow up patch is needed so we might want to abandon it? i did not rebase it because i dont know what value it adds. | |
| 14:50:18 | efried | oh, that one's been around for a whiiile. | |
| 14:50:24 | efried | I haven't looked at it recently. | |
| 14:50:43 | mriedem | with the size and breadth of that change the commit message would need a hell of a lot more detail | |
| 15:01:17 | melwitt | dansmith: guh, yeah I had intended to but it keeps getting left on the backburner | |
| 15:01:30 | dansmith | melwitt: okay, seems worth finishing | |
| 15:01:49 | melwitt | yeah, agreed :( | |
| 15:02:01 | melwitt | if anyone else wants to update it, of course feel free too | |
| 15:02:09 | melwitt | I'll try to do it after my calls today | |
| 15:04:24 | gibi | sean-k-mooney: I think I found possible race in the test in https://review.opendev.org/#/c/669738/ | |
| 15:07:11 | sean-k-mooney | i think the state does change but ill check | |
| 15:07:22 | sean-k-mooney | maybe its the task sate | |
| 15:07:47 | gibi | sean-k-mooney: task_state changes but I think the status doesn't | |
| 15:08:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pull up compute node queries to init_host https://review.opendev.org/682680 | |
| 15:08:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | |
| 15:08:37 | gibi | sean-k-mooney: even if status changes during the reboot if it start from ACTIVE and ends in ACTIVE then you cannot be sure why the wait returned | |
| 15:08:44 | sean-k-mooney | looking at https://docs.openstack.org/nova/latest/reference/vm-states.html you seam to be correct | |
| 15:09:18 | gibi | mriedem: fixed your comments in https://review.opendev.org/#/c/666857 | |
| 15:10:32 | sean-k-mooney | gibi: efried so we should stop https://review.opendev.org/#/c/669738/7 merging and i should fix that | |
| 15:10:48 | gibi | sean-k-mooney: a rebase would pull it out from the gate | |
| 15:11:10 | sean-k-mooney | i just set workflow -1 will that work? | |
| 15:11:33 | sean-k-mooney | i just removed erric +w | |
| 15:11:35 | gibi | I don't know what is stronger the W+ or the W- | |
| 15:11:46 | gibi | sean-k-mooney: ohh you can do that? | |
| 15:11:53 | sean-k-mooney | if you are the patch owner | |
| 15:11:58 | sean-k-mooney | or a core | |
| 15:12:00 | efried | whoah | |
| 15:12:02 | efried | I didn't know that | |
| 15:12:24 | sean-k-mooney | ya we block remove -* i think | |
| 15:12:28 | efried | anyway, that's not going to pull it out of the check queue, which is where it's sitting right now. But it should prevent it going into the gate. | |
| 15:12:36 | efried | if it was already in the gate you would have to rebase to pull it. | |
| 15:12:42 | bauzas | mriedem: I'm pretty done with my audit command (just needing to work on unittests) but I'd like to provide a functional test about some migration error | |
| 15:12:59 | efried | If you care to save on gate resources you could rebase to pull it out of check | |