Posted	Nick	Remark
#openstack-nova - 2019-09-13
21:18:30	mriedem	i was rushing
21:18:54	mriedem	it's up to me if you want to approve it or let it sit, it's not the big blow up like the libvirt host capabilities one
21:20:02	mriedem	i think both your alternative and artom's are equally gross
21:20:04	sean-k-mooney	ya that one does not actully casuse the test to fail and the log mesage is like 20 lines vs 100s
21:20:18	efried	how many times do we actually need to raise?
21:21:09	sean-k-mooney	well once really. the stub raises if its called more then once
21:21:20	sean-k-mooney	i doubt we will call it again if we raise
21:22:25	sean-k-mooney	i +1'd it because a.) it works and b.) while it was surpising at first glance i understand how it works after looking at it for 30 seconds
21:22:54	mriedem	you can't use wraps because we need to side effect the error in the 2nd call,
21:23:08	sean-k-mooney	ya you cant
21:23:10	sean-k-mooney	i tried
21:23:12	mriedem	and we can't just mock it because the test fails if you don't actually call the original method on the first pass
21:23:27	sean-k-mooney	yep
21:23:40	mriedem	and that was the bug i uncovered
21:24:35	sean-k-mooney	out of interest why do you dislike moveing the stub function inside the mock context manager
21:25:14	sean-k-mooney	functionally its identiacla to what you wrote but im just wondering out of interest
21:28:50	efried	I approved it.
21:29:40	mriedem	sean-k-mooney: but it's late on a friday and i don't feel like updating the patch :)
21:29:46	mriedem	and i'm trying to do some education stuff
21:29:51	mriedem	*b/c
21:30:07	sean-k-mooney	that totally fair
21:30:28	sean-k-mooney	i was just wondering if you had a technical reason i missed
21:31:10	sean-k-mooney	as i said i +1 because i was ok with what you wrote and didnt think it was really worth a respin
21:32:36	efried	okay, unless there's something else I can do here, I'm going to bugger back off and just monitor the gate
21:32:50	efried	looks like we're back up to a 12h delay \o/
21:48:07	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: Fix a misuse of assertGreaterEqual https://review.opendev.org/682168
22:24:33	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: neutron: refactor nw info cache refresh out of associate_floating_ip https://review.opendev.org/682181
22:24:34	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: Find instance in another cell during floating IP re-association https://review.opendev.org/682183
22:24:34	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: Trap and log errors from _update_inst_info_cache_for_disassociated_fip https://review.opendev.org/682182
22:28:18	mriedem	gibi: just so you're aware we're trying to get https://review.opendev.org/#/c/682133/ and https://review.opendev.org/#/c/682025/ through the gate since things keep failing on those bugs
#openstack-nova - 2019-09-14
00:09:40	openstackgerrit	Merged openstack/nova master: libvirt: stub logging of host capabilities https://review.opendev.org/682133
00:09:49	openstackgerrit	Merged openstack/nova master: Fix a misuse of assertGreaterEqual https://review.opendev.org/682025
00:43:54	mriedem_afk	let the rechecks begin
00:44:09	sean-k-mooney	i was just about to saw the same
00:44:21	sean-k-mooney	*say
00:45:24	sean-k-mooney	if it was any it would be somewhere in the mid atlantic i think
00:45:31	tbachman	lol
00:45:51	tbachman	No matter which TZ I’m in, I see you online
00:45:58	tbachman	#botcheck sean-k-mooney
00:46:19	sean-k-mooney	also im currently watching youtube and playing eve online. i just hapen to have irc open on my laptop
00:46:24	tbachman	heh
01:15:25	sean-k-mooney	efried_afk: gibi by the way mriedem has rechecked the numa series. we need to recheck the vpmem series and cpu serise but we proably should wait a while to see if the fixes above help things merge in the gate
01:15:59	sean-k-mooney	i have not checked gibi series but i assume there are patces pending for bandwith migration also
01:17:10	sean-k-mooney	actully looks like gibi's bandwith serise is currenly in gate :)
05:09:19	openstackgerrit	Merged openstack/nova master: Make SRIOV computes non symmetric in func test https://review.opendev.org/681667
05:09:57	openstackgerrit	Merged openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
05:10:06	openstackgerrit	Merged openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
05:10:16	openstackgerrit	Merged openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019
05:10:25	openstackgerrit	Merged openstack/nova master: Extract pf$N literals as constants from func test https://review.opendev.org/680991
05:10:35	openstackgerrit	Merged openstack/nova master: Improve dest service level func tests https://review.opendev.org/680998
05:27:15	openstackgerrit	Merged openstack/nova master: Follow up for Ib50b6b02208f5bd2972de8a6f8f685c19745514c https://review.opendev.org/681490
05:27:23	openstackgerrit	Merged openstack/nova master: Skip querying resource request in revert_resize if no qos port https://review.opendev.org/681513
05:27:37	openstackgerrit	Merged openstack/nova master: Follow up for I220fa02ee916728e241503084b14984bab4b0c3b https://review.opendev.org/680810
07:05:21	openstackgerrit	Brin Zhang proposed openstack/nova master: Fix legacy issues in Filter migrations by user_id/project_id https://review.opendev.org/682198
07:25:17	brinzhang_	The failure rate of Zuul in these two days is low
07:25:30	brinzhang_	so many ptach were failed
13:40:44	openstackgerrit	Matt Riedemann proposed openstack/nova stable/stein: libvirt: stub logging of host capabilities https://review.opendev.org/682210
15:37:42	donnyd	is there a method in nova to tell it to boot an instance when the hypervisor comes up? So for instance if I needed to do maintenance, but wanted specific instances to come up automatically
15:37:50	donnyd	Is there a way to do that in Nova
16:37:58	openstackgerrit	Merged openstack/nova master: PDF documentation build https://review.opendev.org/676730
17:29:28	openstackgerrit	Merged openstack/nova master: Use SpawnIsSynchronousFixture in reschedule functional tests https://review.opendev.org/682140
22:43:57	sean-k-mooney	donnyd: i dont know if you found it our not but you can use https://docs.openstack.org/nova/rocky/configuration/config.html#DEFAULT.resume_guests_state_on_host_boot
#openstack-nova - 2019-09-15
01:34:30	openstackgerrit	Merged openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074
02:57:30	openstackgerrit	Merged openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
02:57:48	openstackgerrit	Merged openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229
05:34:15	openstackgerrit	Merged openstack/nova master: Note about Destination.forbidden_aggregates https://review.opendev.org/680945
05:36:49	openstackgerrit	Merged openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075
06:12:43	openstackgerrit	Merged openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447
06:33:08	openstackgerrit	Merged openstack/nova master: object: Introduce Resource and ResourceList objs https://review.opendev.org/678448
06:33:16	openstackgerrit	Merged openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
06:33:43	openstackgerrit	Merged openstack/nova master: Set user_id/project_id from context when creating a Migration https://review.opendev.org/679413
06:33:53	openstackgerrit	Merged openstack/nova master: Retrieve the allocations early https://review.opendev.org/678450
09:20:05	openstackgerrit	Merged openstack/nova master: Docs for isolated aggregates request filter https://review.opendev.org/667952
11:12:30	openstackgerrit	Merged openstack/nova master: NUMA live migration support https://review.opendev.org/634606
11:23:00	openstackgerrit	garyk proposed openstack/nova master: Deconstruct the mother of all locks https://review.opendev.org/682242
14:48:54	MarkMielke	oslo_utils doesn't seem to have unit tests, but nova does... if oslo_utils needs a fix, is there any special downstream nova process that should be followed to pick it up, and test with it?
14:49:42	MarkMielke	specifically, I'm talking about https://review.opendev.org/682247 which I just submitted
15:05:29	sean-k-mooney	oh your fixing that issue
15:05:36	sean-k-mooney	that is on my todo list
15:05:46	sean-k-mooney	i personally would add tests to oslo utils
15:07:02	sean-k-mooney	thats breaking fedora with the virt preview repo enabeld currently
15:07:20	sean-k-mooney	alshtough im not sure it affct any distros default packages yet?
15:07:46	MarkMielke	right
15:08:25	MarkMielke	qemu 4.1 provides important nVMX patches
15:08:51	MarkMielke	so not necessarily in distro
15:09:00	MarkMielke	can use qemu 4.1 on RHEL 7 if need be
15:09:40	MarkMielke	all of the tests for outputs seem to be in nova
15:09:50	MarkMielke	seems like unit test confusion :-)
15:09:52	sean-k-mooney	non of them shoudl be in nova
15:10:02	sean-k-mooney	they should all be in oslo_untils
15:10:18	sean-k-mooney	but i think that code was original ported from nova
15:10:25	sean-k-mooney	so i guess they did not mvoe the tests
15:11:15	MarkMielke	I want to add a test, but I'm not familiar with setting it up from scratch, and I don't want to take on doing it all :-)
15:11:16	sean-k-mooney	nova really should not be asserting the parseing behavior of oslo code so i sustpect the nova tests are just legacy test we did not remove
15:11:46	MarkMielke	two character fix :-( hehe
15:11:49	sean-k-mooney	you could add more test in nova but personally i think those are techdebt
15:12:11	MarkMielke	i agree from observing
15:12:23	sean-k-mooney	well you could file a bug for the lack of test in oslo_utils
15:12:44	MarkMielke	good idea
15:12:47	sean-k-mooney	and submit the ptach without tests. you would have to use a depend on to test the feature in nova

Earlier   Later