Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-13
19:13:50 sean-k-mooney it refers to the mock you are creating in the with statemnet but you are using it in the stub fill provider mapping funciton
19:14:00 mriedem python magic
19:14:14 mriedem it's used in the function which isn't used until after the mock is setup
19:14:38 mriedem anyway, as for https://review.opendev.org/#/c/682133/ i'm going to do a full py26,func-py36,pep8 locally and if that's good clark is going to promote to the gate
19:14:47 sean-k-mooney right so its parsing the function signiture but not the body untill its used
19:14:53 mriedem yar
19:14:59 sean-k-mooney and by the time its use its inscope
19:14:59 mriedem that's something that always trips me up with python
19:15:17 sean-k-mooney that is slightly terrifying but ok
19:15:42 artom Wait, what?
19:16:07 artom The function can refer to its own mock?
19:16:11 sean-k-mooney dont look too closely https://review.opendev.org/#/c/682140/1/nova/tests/functional/test_servers.py@6808
19:16:21 sean-k-mooney you might go insane
19:16:23 artom Too late, I clicked
19:16:42 sean-k-mooney but ya i get how it could work
19:16:43 artom There's gotta be a less funky clever way of doing that
19:17:11 sean-k-mooney i think there is a mock.wraps that does something similar
19:17:20 artom Yeah
19:17:26 artom Or even with side_effect
19:17:56 artom Something like side_effect=[original_fill] + itertools.repeat(raise)
19:17:59 sean-k-mooney it is a side effect
19:18:07 sean-k-mooney that is how the fuction is used
19:18:20 sean-k-mooney *stub_fuction
19:18:36 artom Right, I meant... we don't need the weirdly scoped function introspecting itself thing
19:18:38 sean-k-mooney with all that said what mriedem worte appeares to work
19:18:46 artom Not that it's not clever
19:18:59 artom It'll just cause headaches to whoever has to work with it next
19:26:16 artom o/ see ya Monday
19:27:44 sean-k-mooney oh i see what its doing its filling the provider mapping if tis not filled
19:28:25 sean-k-mooney and raise an exception if called again
20:51:31 mriedem sean-k-mooney: heh, of course now the libvirt logging patch failed in the gate b/c of the functional notifications patch
20:54:24 sean-k-mooney nothing else would do sure :) i has to keep up the tradtion of the rest
20:56:58 mriedem corvus is going to promote both
20:59:03 sean-k-mooney if they fail again we might need to squash them. the failures are not determisitic so we should be able to merge them on there own but we might not want to retry them that much
21:09:43 efried o/
21:09:45 efried checking in
21:09:57 efried I assume we're holding rechecks until we can merge some of those gate fixes mriedem?
21:10:09 efried I've got eight or so lined up.
21:10:15 efried rechecks, not fixes
21:11:26 mriedem efried: yeah
21:11:31 mriedem corvus just promoted to top of gate
21:12:06 efried nice of him
21:12:37 mriedem i think i just bring out the best in people
21:12:39 mriedem you know?
21:12:50 efried threats of violence will do that
21:12:53 mriedem ha
21:13:34 efried do you want me to merge https://review.opendev.org/#/c/682140/ ?
21:13:43 efried despite artom hatin on it
21:14:04 efried even though you spelled stacktrace wrong
21:17:26 sean-k-mooney he did. unsurpisingly i did not notice
21:18:28 mriedem i got it correct in one spot
21:18:30 mriedem i was rushing
21:18:54 mriedem it's up to me if you want to approve it or let it sit, it's not the big blow up like the libvirt host capabilities one
21:20:02 mriedem i think both your alternative and artom's are equally gross
21:20:04 sean-k-mooney ya that one does not actully casuse the test to fail and the log mesage is like 20 lines vs 100s
21:20:18 efried how many times do we actually need to raise?
21:21:09 sean-k-mooney well once really. the stub raises if its called more then once
21:21:20 sean-k-mooney i doubt we will call it again if we raise
21:22:25 sean-k-mooney i +1'd it because a.) it works and b.) while it was surpising at first glance i understand how it works after looking at it for 30 seconds
21:22:54 mriedem you can't use wraps because we need to side effect the error in the 2nd call,
21:23:08 sean-k-mooney ya you cant
21:23:10 sean-k-mooney i tried
21:23:12 mriedem and we can't just mock it because the test fails if you don't actually call the original method on the first pass
21:23:27 sean-k-mooney yep
21:23:40 mriedem and that was the bug i uncovered
21:24:35 sean-k-mooney out of interest why do you dislike moveing the stub function inside the mock context manager
21:25:14 sean-k-mooney functionally its identiacla to what you wrote but im just wondering out of interest
21:28:50 efried I approved it.
21:29:40 mriedem sean-k-mooney: but it's late on a friday and i don't feel like updating the patch :)
21:29:46 mriedem and i'm trying to do some education stuff
21:29:51 mriedem *b/c
21:30:07 sean-k-mooney that totally fair
21:30:28 sean-k-mooney i was just wondering if you had a technical reason i missed
21:31:10 sean-k-mooney as i said i +1 because i was ok with what you wrote and didnt think it was really worth a respin
21:32:36 efried okay, unless there's something else I can do here, I'm going to bugger back off and just monitor the gate
21:32:50 efried looks like we're back up to a 12h delay \o/
21:48:07 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Fix a misuse of assertGreaterEqual https://review.opendev.org/682168
22:24:33 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: neutron: refactor nw info cache refresh out of associate_floating_ip https://review.opendev.org/682181
22:24:34 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Find instance in another cell during floating IP re-association https://review.opendev.org/682183
22:24:34 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Trap and log errors from _update_inst_info_cache_for_disassociated_fip https://review.opendev.org/682182
22:28:18 mriedem gibi: just so you're aware we're trying to get https://review.opendev.org/#/c/682133/ and https://review.opendev.org/#/c/682025/ through the gate since things keep failing on those bugs
#openstack-nova - 2019-09-14
00:09:40 openstackgerrit Merged openstack/nova master: libvirt: stub logging of host capabilities https://review.opendev.org/682133
00:09:49 openstackgerrit Merged openstack/nova master: Fix a misuse of assertGreaterEqual https://review.opendev.org/682025
00:43:54 mriedem_afk let the rechecks begin
00:44:09 sean-k-mooney i was just about to saw the same
00:44:21 sean-k-mooney *say
00:45:24 sean-k-mooney if it was any it would be somewhere in the mid atlantic i think
00:45:31 tbachman lol
00:45:51 tbachman No matter which TZ I’m in, I see you online
00:45:58 tbachman #botcheck sean-k-mooney
00:46:19 sean-k-mooney also im currently watching youtube and playing eve online. i just hapen to have irc open on my laptop
00:46:24 tbachman heh
01:15:25 sean-k-mooney efried_afk: gibi by the way mriedem has rechecked the numa series. we need to recheck the vpmem series and cpu serise but we proably should wait a while to see if the fixes above help things merge in the gate
01:15:59 sean-k-mooney i have not checked gibi series but i assume there are patces pending for bandwith migration also
01:17:10 sean-k-mooney actully looks like gibi's bandwith serise is currenly in gate :)
05:09:19 openstackgerrit Merged openstack/nova master: Make SRIOV computes non symmetric in func test https://review.opendev.org/681667
05:09:57 openstackgerrit Merged openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
05:10:06 openstackgerrit Merged openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
05:10:16 openstackgerrit Merged openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019
05:10:25 openstackgerrit Merged openstack/nova master: Extract pf$N literals as constants from func test https://review.opendev.org/680991

Earlier   Later