| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-12 | |||
| 15:23:02 | bauzas | gibi: you could technically use another helper method | |
| 15:23:17 | bauzas | but this one is convenient, I don't disagree | |
| 15:25:56 | gibi | bauzas: ack, I made a TODO for myself about RPC bump for Ussuri but I'm sure I will need help doing that properly | |
| 15:29:09 | dansmith | gibi: we have a doc about how to do it actually | |
| 15:29:10 | dansmith | it's been a while | |
| 15:30:03 | dansmith | gibi: https://wiki.openstack.org/wiki/RpcMajorVersionUpdates | |
| 15:31:11 | dansmith | not sure we've done it since we've had auto version pinning so we'd need to think through that a bit | |
| 15:31:13 | bauzas | gibi: yeah follow dansmith's point, I made it for the scheduler and I can give you a ton of code snippets | |
| 15:31:26 | bauzas | dansmith: oh good point | |
| 15:31:37 | bauzas | it's been a while since I've seen a major bump | |
| 15:31:56 | bauzas | (but it's been a while since I followed changes like I was before) | |
| 15:32:10 | gibi | dansmith: thanks. I've annotated my TODO with the wiki link | |
| 15:33:50 | sean-k-mooney | whats the the synatax for resouce request again "resouces:PCPU=2" | |
| 15:34:39 | sean-k-mooney | that is correct yes? | |
| 15:34:50 | sean-k-mooney | in the flavor | |
| 15:35:11 | dansmith | sean-k-mooney: with proper spelling, I think so | |
| 15:35:25 | sean-k-mooney | ill copy it form functional test to get it right | |
| 15:35:27 | bauzas | sean-k-mooney: yeah, if you don't want more | |
| 15:36:10 | gibi | mriedem: thanks for fixing the race and fixing up the series and the reviews! | |
| 15:36:45 | bauzas | sean-k-mooney: example for VGPU : https://docs.openstack.org/nova/latest/admin/virtual-gpu.html#configure-a-flavor-controller | |
| 15:36:58 | sean-k-mooney | ya i found an example | |
| 15:37:05 | mriedem | gibi: np | |
| 15:37:07 | bauzas | FWIW, pidgin makes it a joke | |
| 15:37:19 | bauzas | or a smiley rather | |
| 15:38:43 | mriedem | dansmith: i think you did the last compute rpc api bump to 5.0 in queens | |
| 15:39:00 | mriedem | which i'm pretty sure was after the auto stuff | |
| 15:39:15 | dansmith | yeah I was looking.. I think so too | |
| 15:40:21 | mriedem | sean-k-mooney: i said this the other day, but i'd think you'd want a flavor with PCPU=1 (i guess if you test resize you need an alternate flavor, but that could also be PCPU=1 and a different ram/disk) and you'll want to tell tempest to run the tests in serial or at least --concurrency=2 | |
| 15:40:45 | mriedem | i think, because otherwise i'd expect novalidhost errors while concurrent tests are consuming all the PCPU inventory on the single node | |
| 15:41:17 | bauzas | gibi: just a nit with +Wd https://review.opendev.org/#/c/679019/14/releasenotes/notes/support-cold-migrating-neutron-ports-with-resource-request-6d23be654a253625.yaml | |
| 15:41:19 | mriedem | i'd probably also just restrict tempest to tempest.api.compute tests to start | |
| 15:42:16 | donnyd | sean-k-mooney: You should be good to go now | |
| 15:45:13 | gibi | bauzas: ack, thanks | |
| 15:47:30 | bauzas | gibi: mriedem: efried_afk: I'm glad we can say support-move-ops-with-qos-ports as approved | |
| 15:47:43 | bauzas | let's now wait for the gate to claim it as implemented | |
| 15:47:55 | mriedem | cool, thanks for hitting those | |
| 15:48:13 | bauzas | mriedem: you did the most | |
| 15:48:59 | bauzas | efried_afk: sean-k-mooney: what's the status with vpmem ? | |
| 15:49:03 | bauzas | can i help ? | |
| 15:49:38 | bauzas | stephenfin: FWIW, reviewing back https://review.opendev.org/#/c/671801/48 | |
| 15:50:31 | stephenfin | bauzas: I'm going through vPMEM while my local hosts are deploying for manual upgrade testing of PCPU | |
| 15:50:40 | stephenfin | So it _should_ be fine | |
| 15:50:51 | stephenfin | We're going to need to rebase this whole thing into one giant chain once it's one though | |
| 15:51:20 | stephenfin | because vPMEM, VCPU and NUMA-aware LM series all conflict with each other | |
| 15:51:30 | bauzas | \o/ | |
| 15:51:39 | stephenfin | so much fun :) | |
| 15:51:45 | stephenfin | I can do that once everything is approved, I guess | |
| 15:52:05 | stephenfin | hopefully the conflicts are trivial (I suspect they will be) | |
| 15:52:47 | gibi | dddf | |
| 15:54:09 | gibi | sorry | |
| 15:54:23 | gibi | bauzas: thanks! | |
| 15:55:09 | gibi | bauzas: to be precise the cold migrate and resize part of support-move-ops-with-qos-ports is now approved. I have to continue working on evacuate, live migrate, and unshelve in Ussuri | |
| 15:55:23 | bauzas | oh correct of course | |
| 15:55:28 | bauzas | I was short in explanation :) | |
| 15:55:34 | gibi | :) | |
| 15:55:40 | bauzas | but we stick with the plan you wrote | |
| 15:55:53 | gibi | bauzas: yeah, there was no way to fitt everything | |
| 15:55:54 | bauzas | FWIW, I wish I could have had time for this with VGPU support... | |
| 15:56:06 | gibi | bauzas: let's try that again in U | |
| 15:56:17 | stephenfin | melwitt: ta for https://review.opendev.org/681374 (y) | |
| 15:56:20 | bauzas | every cycle, I make myself a promise | |
| 15:56:29 | bauzas | I stopped doing it | |
| 15:57:36 | luyao | stephenfin: reminder for vpmems series. :) | |
| 15:57:51 | stephenfin | luyao: https://review.opendev.org/#/c/678452/32 :) | |
| 15:58:04 | bauzas | stephenfin: I'm balancing in my head the need for defaulting disable_fallback_pcpu_query to True as default | |
| 15:58:28 | melwitt | stephenfin: np, good call on keeping the quota tests with it and moving the other unrelated func test to the next patch | |
| 15:58:29 | stephenfin | bauzas: It's the same discussion we had with the previous manual configuration option | |
| 15:58:45 | bauzas | yeah I now | |
| 15:58:47 | bauzas | know* | |
| 15:59:02 | stephenfin | melwitt: Yeah, thank mriedem for that (he complained (fairly) that the next one was way too big) | |
| 15:59:33 | luyao | stephenfin: thanks, not noticed that.:) | |
| 15:59:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up for Ib50b6b02208f5bd2972de8a6f8f685c19745514c https://review.opendev.org/681490 | |
| 16:01:59 | gibi | bauzas, mriedem: could you re-apply your love there? ^^ | |
| 16:02:19 | bauzas | gibi: a safe love but yeah | |
| 16:02:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Skip querying resource request in revert_resize if no qos port https://review.opendev.org/681513 | |
| 16:02:48 | gibi | bauzas: :) | |
| 16:03:55 | mriedem | consider my love applied | |
| 16:04:12 | gibi | mriedem: thanks | |
| 16:04:52 | artom | Eww | |
| 16:05:08 | mriedem | hey, | |
| 16:05:17 | mriedem | nothing eww about a grown man loving up on some patches | |
| 16:06:34 | bauzas | stephenfin: https://review.opendev.org/#/c/671801/48/releasenotes/notes/cpu-resources-d4e6a0c12681fa87.yaml@35 worth considering a nova-status upgrade check that would verify before you upgrade to Ussuri that you no longer require the workaround | |
| 16:06:46 | melwitt | mnaser: fyi os-vif 1.15.2 has been released https://review.opendev.org/681358 | |
| 16:07:19 | bauzas | anyway, dropping now, but I'll be back later (doing a bit of trail running) | |
| 16:07:29 | stephenfin | bauzas: Yup, good call. That's what we did for the consoleauth workaround | |
| 16:08:02 | stephenfin | dansmith: Can we squash migrations in the future? | |
| 16:08:20 | dansmith | stephenfin: what migrations? | |
| 16:08:38 | stephenfin | i.e. "INFO migrate.versioning.api [-] 254 -> 255..." | |
| 16:08:48 | stephenfin | our DB migrations | |
| 16:09:17 | dansmith | we've compacted them before, but not in a long time, as you know | |
| 16:09:20 | dansmith | so.. yes? | |
| 16:09:26 | stephenfin | I did not know that | |
| 16:09:30 | stephenfin | or rather, I'd forgotten it | |
| 16:12:21 | mriedem | stephenfin: my recollection with that is sdague heard from a bunch of operators at one point that they actually didn't like the compacting because it f'ed up things like FFUs | |
| 16:12:29 | mriedem | this was long before FFU was even a term | |
| 16:12:34 | mriedem | so "skip level upgrades" at the time | |
| 16:12:54 | dansmith | yeah it's a giant pain | |
| 16:12:55 | mriedem | so we stopped doing it, | |
| 16:12:57 | mriedem | and, | |
| 16:12:58 | stephenfin | understandable. That's why I was thinking Queens | |